[clang-tools-extra] [NFC] Use a move instead of a copy to optimize performance. (PR #118699)

2024-12-05 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/118699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Complete proper copying and resource cleanup in classes. (PR #118655)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/118655 >From 3b93252fa52c4055e8c294784056697e92299b9b Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 4 Dec 2024 07:24:20 -0800 Subject: [PATCH 1/2] [NFC] Complete proper copying and resource cleanup in

[clang-tools-extra] [NFC] Complete proper copying and resource cleanup in classes. (PR #118655)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/118655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/118664 None >From 35f795549d25ec1358b54ebd3f2176cf8e49aeff Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 4 Dec 2024 08:23:12 -0800 Subject: [PATCH] [NFC] Avoid data race condition. --- clang-tools-e

[clang-tools-extra] [NFC] Complete proper copying and resource cleanup in classes. (PR #118655)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/118655 None >From 3b93252fa52c4055e8c294784056697e92299b9b Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 4 Dec 2024 07:24:20 -0800 Subject: [PATCH] [NFC] Complete proper copying and resource cleanup i

[clang-tools-extra] [NFC] Complete proper copying and resource cleanup in classes. (PR #118655)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/118655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix uninitialized scalar field in constructor. (PR #118324)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @HighCommander4 Is that good as a change? Do you still want an issue to be opened? @tahonermann can you please review? Thanks. https://github.com/llvm/llvm-project/pull/118324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang-tools-extra] [NFC] Fix potential underflow constant. (PR #118528)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/118528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix potential underflow constant. (PR #118528)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > _ No description provided. _ https://github.com/llvm/llvm-project/pull/118528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix potential underflow constant. (PR #118528)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
@@ -58,10 +58,10 @@ getDerivedParameter(const ClassTemplateSpecializationDecl *CRTP, Arg.getAsType()->getAsCXXRecordDecl() == Derived; }); - return AnyOf ? CRTP->getSpecializedTemplate() - ->getTemplateParameters() -

[clang-tools-extra] [NFC] Fix potential underflow constant. (PR #118528)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
@@ -58,10 +58,10 @@ getDerivedParameter(const ClassTemplateSpecializationDecl *CRTP, Arg.getAsType()->getAsCXXRecordDecl() == Derived; }); - return AnyOf ? CRTP->getSpecializedTemplate() - ->getTemplateParameters() -

[clang-tools-extra] [NFC] Use a move instead of a copy to optimize performance. (PR #118699)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/118699 None >From 440554df79ebc7c8971c4af928f623b13c95c6ee Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 4 Dec 2024 12:54:41 -0800 Subject: [PATCH] [NFC] Use a move instead of a copy to optimize perfo

[clang-tools-extra] [NFC] Use a move instead of a copy to optimize performance. (PR #118699)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/118699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-04 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/118664 >From 35f795549d25ec1358b54ebd3f2176cf8e49aeff Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 4 Dec 2024 08:23:12 -0800 Subject: [PATCH 1/2] [NFC] Avoid data race condition. --- clang-tools-ext

[clang-tools-extra] [NFC] Use a move instead of a copy to optimize performance. (PR #118699)

2024-12-06 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/118699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-02-04 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: ping? @Meinersbur https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-02-10 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @alexey-bataev I haven't gotten any response from @Meinersbur , can I merge this in? Thanks. https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang] Assert the enum FPOpts and LangOpts fit into the storage (PR #126166)

2025-02-10 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > @zahiraam the default of the `ComplexRange`, `CX_None` does overflow the `2` > storage bits. That means we were probably still using `CX_Full` (4 should > overflow to `0`) even after #78330 (I am not sure why why that changed the > default in the first place). Also it's impos

[clang] [clang] Assert the enum FPOpts and LangOpts fit into the storage (PR #126166)

2025-02-10 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > > > @zahiraam the default of the `ComplexRange`, `CX_None` does overflow the > > > `2` storage bits. That means we were probably still using `CX_Full` (4 > > > should overflow to `0`) even after #78330 (I am not sure why why that > > > changed the default in the first place).

[clang] [clang] Assert the enum FPOpts and LangOpts fit into the storage (PR #126166)

2025-02-10 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > > > > Not sure I understand your question? Which assertion? `clang.exe t.c` > > > > is triggering an assertion? > > > > > > > > > I don't understand why you say > > > > The value `CX_None` is the defaut value given to the `Range` when no > > > > `fcomplex-arithmetic` is used

[clang] [clang] Assert the enum FPOpts and LangOpts fit into the storage (PR #126166)

2025-02-10 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > > Not sure I understand your question? Which assertion? `clang.exe t.c` is > > triggering an assertion? > > I don't understand why you say > > > The value `CX_None` is the defaut value given to the `Range` when no > > `fcomplex-arithmetic` is used on the command lin > > but

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-02-12 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > @zahiraam I've reverted your PR. I'm happy to test your revised version > though my build environment is no secret -- `-DLLVM_ENABLE_WERROR=On` along > with clang as the host compiler. Sorry about that! I will fix the error and merge it back. https://github.com/llvm/llvm-pro

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #126927)

2025-02-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/126927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-29 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-30 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @Meinersbur Would love to check this off. Can you please take another look? Thanks. https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-10 Thread Zahira Ammarguellat via cfe-commits
@@ -501,6 +501,7 @@ class PreambleThread { } { +std::unique_lock Lock(Mutex); WithContext Guard(std::move(CurrentReq->Ctx)); zahiraam wrote: Thanks @tahonermann. I had forgotten about it. Closing it. https://github.com/llvm/llvm-

[clang-tools-extra] [NFC] Avoid data race condition. (PR #118664)

2024-12-10 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/118664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-17 Thread Zahira Ammarguellat via cfe-commits
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> { let association = AS_Loop; let category = CA_Executable; } +def OMP_Stripe : Directive<"stripe"> { + let allowedOnceClauses = [ +VersionedClause, zahiraam wrote: I have set it to `51` but I thi

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-17 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Copy to move (PR #119741)

2024-12-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/119741 None >From 440554df79ebc7c8971c4af928f623b13c95c6ee Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 4 Dec 2024 12:54:41 -0800 Subject: [PATCH 1/2] [NFC] Use a move instead of a copy to optimize

[clang-tools-extra] Copy to move (PR #119741)

2024-12-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/119741 >From 440554df79ebc7c8971c4af928f623b13c95c6ee Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 4 Dec 2024 12:54:41 -0800 Subject: [PATCH 1/3] [NFC] Use a move instead of a copy to optimize perfor

[clang-tools-extra] [NFC] Fixes for issues found by static analysis tool. (PR #119741)

2024-12-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/119741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-13 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-13 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fixes for issues found by static analysis tool. (PR #119741)

2024-12-13 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/119741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix uninitialized pointer field. (PR #117173)

2024-11-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/117173 None >From 27925c327d9f3164e3ba966ffaed5715681480fd Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 21 Nov 2024 07:03:46 -0800 Subject: [PATCH] [NFC] Fix uninitialized pointer field. --- clang-

[clang-tools-extra] [NFC] Fix uninitialized pointer field. (PR #117173)

2024-11-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/117173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix uninitialized pointer field. (PR #117173)

2024-11-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/117173 >From 27925c327d9f3164e3ba966ffaed5715681480fd Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 21 Nov 2024 07:03:46 -0800 Subject: [PATCH 1/2] [NFC] Fix uninitialized pointer field. --- clang-to

[clang-tools-extra] [NFC] Fix uninitialized pointer field. (PR #117173)

2024-11-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/117173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Covrt issue (PR #117331)

2024-11-22 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/117331 None >From 27925c327d9f3164e3ba966ffaed5715681480fd Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 21 Nov 2024 07:03:46 -0800 Subject: [PATCH 1/2] [NFC] Fix uninitialized pointer field. --- cl

[clang-tools-extra] Covrt issue (PR #117331)

2024-11-22 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/117331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix potential underflow constant. (PR #118528)

2024-12-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/118528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix potential underflow constant. (PR #118528)

2024-12-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/118528 None >From 59904d85cece9758dbb449ae4180ee5f917d0263 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 3 Dec 2024 10:53:22 -0800 Subject: [PATCH] [NFC] Fix potential underflow constant. --- .../bu

[clang-tools-extra] [NFC] Fix potential underflow constant. (PR #118528)

2024-12-03 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/118528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Complete proper copying and resource cleanup in classes. (PR #118655)

2024-12-05 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/118655 >From 3b93252fa52c4055e8c294784056697e92299b9b Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Wed, 4 Dec 2024 07:24:20 -0800 Subject: [PATCH 1/3] [NFC] Complete proper copying and resource cleanup in

[clang] [OpenMP] Change default version to OMP6.0. (PR #122108)

2025-01-08 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Change default version to OMP6.0. (PR #122108)

2025-01-08 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam converted_to_draft https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-08 Thread Zahira Ammarguellat via cfe-commits
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> { let association = AS_Loop; let category = CA_Executable; } +def OMP_Stripe : Directive<"stripe"> { + let allowedOnceClauses = [ +VersionedClause, zahiraam wrote: @alexey-bataev draft PR for thi

[clang] [OpenMP] Change default version to OMP6.0. (PR #122108)

2025-01-08 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Not sure this level of support is enough to make 6.0 the default version. > We're missing support for some 5.2 features still That's what I thought! So the macro should continue being set to `202011? https://github.com/llvm/llvm-project/pull/122108 ___

[clang] [OpenMP] Change default version to OMP6.0. (PR #122108)

2025-01-08 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @alexey-bataev Can you please take a look at this draft PR? I think there are still some LIT tests failing but I want to make sure the changes I am proposing are correct before making further changes. I am not sure if the macro `_OPENMP` should be set to `202411` or if it shoul

[clang] [OpenMP] Change default version to OMP6.0. (PR #122108)

2025-01-08 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Change default version to OMP6.0. (PR #122108)

2025-01-08 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-21 Thread Zahira Ammarguellat via cfe-commits
@@ -14477,6 +14485,268 @@ StmtResult SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses, buildPreInits(Context, PreInits)); } +StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef Clauses, +

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-21 Thread Zahira Ammarguellat via cfe-commits
@@ -14477,6 +14484,279 @@ StmtResult SemaOpenMP::ActOnOpenMPTileDirective(ArrayRef Clauses, buildPreInits(Context, PreInits)); } +StmtResult SemaOpenMP::ActOnOpenMPStripeDirective(ArrayRef Clauses, +

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-21 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > I don't think it is necessary to test each value of `-fopenmp-version=` > separately, but don't mind either as long it doesn't affect maintanability. > > * Instead of repeating each clang diagnositic, consider passing multiple > values to `-verify`, e.g. `-verify=omp51,omp60`

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-22 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Yes, I think that would be helpful. Also, avoid duplicating lines with > multiple `-verify=` prefixes. I have made an attempt to edit the 2 LIT tests. I had a hard time finding good names for the `verify` prefixes. Please don't hesitate to suggest better ones. We could also u

[clang] [Clang] Fix warning for non std functions with name `infinity` (PR #123417)

2025-01-20 Thread Zahira Ammarguellat via cfe-commits
@@ -8454,26 +8454,43 @@ static bool IsInfOrNanFunction(StringRef calleeName, MathCheck Check) { llvm_unreachable("unknown MathCheck"); } +static bool IsInfinityFunction(const FunctionDecl *FDecl) { + if (FDecl->getName() != "infinity") +return false; + + if (const CXX

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-20 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Thanks for revising the PR. I have added some comments. > > To unblock #119891, wouldn't it be sufficient that `-fopenmp-version=60` > becomes a valid value? Do we need to modify all these tests to test only this > flag? Yes it's sufficient and that's what's done in #119891.

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-20 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Please address @saiislam's questions. I also think that the title and > description of the PR should reflect that this PR not only introduces the 6.0 > flag, but also moves several of the tests to test against 5.1 and 6.0. I responded to the question. The changes in the tests

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-20 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix warning for non std functions with name `infinity` (PR #123417)

2025-01-20 Thread Zahira Ammarguellat via cfe-commits
@@ -8454,26 +8454,43 @@ static bool IsInfOrNanFunction(StringRef calleeName, MathCheck Check) { llvm_unreachable("unknown MathCheck"); } +static bool IsInfinityFunction(const FunctionDecl *FDecl) { + if (FDecl->getName() != "infinity") +return false; + + if (const CXX

[clang] [Clang] Fix warning for non std functions with name `infinity` (PR #123417)

2025-01-20 Thread Zahira Ammarguellat via cfe-commits
@@ -8454,26 +8454,43 @@ static bool IsInfOrNanFunction(StringRef calleeName, MathCheck Check) { llvm_unreachable("unknown MathCheck"); } +static bool IsInfinityFunction(const FunctionDecl *FDecl) { + if (FDecl->getName() != "infinity") +return false; + + if (const CXX

[clang] [Clang] Fix warning for non std functions with name `infinity` (PR #123417)

2025-01-20 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/123417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-27 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: ping @Meinersbur and @alexey-bataev https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-27 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: ping @mjklemm. https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-28 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: Please let me know if there are any issues that I haven't addressed. Thanks. https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-28 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @mjklemm @Meinersbur any more things to add? thanks. https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Zahira Ammarguellat via cfe-commits
@@ -68,15 +70,15 @@ int fun(int arg) { {} #pragma omp target map(mapper(aa :vv) // expected-error {{use of undeclared identifier 'aa'}} expected-error {{expected ')'}} expected-error {{call to undeclared function 'mapper'}} expected-note

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-13 Thread Zahira Ammarguellat via cfe-commits
@@ -68,15 +70,15 @@ int fun(int arg) { {} #pragma omp target map(mapper(aa :vv) // expected-error {{use of undeclared identifier 'aa'}} expected-error {{expected ')'}} expected-error {{call to undeclared function 'mapper'}} expected-note

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Zahira Ammarguellat via cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public OMPLoopTransformationDirective { } }; +class OMPStripeDirective final : public OMPLoopTransformationDirective { + friend class ASTStmtReader; + friend class OMPExecutableDirective; + + /// Default list of offse

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Zahira Ammarguellat via cfe-commits
@@ -1179,6 +1179,13 @@ def OMP_Tile : Directive<"tile"> { let association = AS_Loop; let category = CA_Executable; } +def OMP_Stripe : Directive<"stripe"> { + let allowedOnceClauses = [ +VersionedClause, zahiraam wrote: I see. In this case I think it

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2024-12-24 Thread Zahira Ammarguellat via cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public OMPLoopTransformationDirective { } }; +class OMPStripeDirective final : public OMPLoopTransformationDirective { + friend class ASTStmtReader; + friend class OMPExecutableDirective; + + /// Default list of offse

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-16 Thread Zahira Ammarguellat via cfe-commits
@@ -19,6 +19,8 @@ typedef void *omp_depend_t; void foo() {} void tmainc(){ omp_depend_t obj; + int omp_all_memory; zahiraam wrote: Removed. https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits maili

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-10 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @mjklemm and @saiislam would you mind taking a look at this please? Thanks. https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-09 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Initialize value. (PR #122339)

2025-01-10 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/122339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-17 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Please resolve open feedback items before the next round of reviews. Thanks. Sorry I might have been ahead of myself! I think this time I might have gotten it. https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-17 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > Aldo, update OpenMPSupport page Question about this. I see that the table for `OpenMP 6.0 Implementation Details` chapter has an entry for `Loop transformation constructs`. Should the `#pragma omp stripe` be listed here as a bullet item? Do you have a preference of how this

[clang-tools-extra] Initialize value. (PR #122339)

2025-01-09 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/122339 None >From d8268afeafb61f95f1fa917ab26214e84372eba3 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 9 Jan 2025 10:58:29 -0800 Subject: [PATCH] Initialize value. --- .../clang-tidy/modernize/Use

[clang-tools-extra] Initialize value. (PR #122339)

2025-01-09 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/122339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-14 Thread Zahira Ammarguellat via cfe-commits
@@ -5621,6 +5623,81 @@ class OMPTileDirective final : public OMPLoopTransformationDirective { } }; +class OMPStripeDirective final : public OMPLoopTransformationDirective { + friend class ASTStmtReader; + friend class OMPExecutableDirective; + + /// Default list of offse

[clang] [OpenMP] Allow OMP6.0 features. (PR #122108)

2025-01-15 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @mjklemm, @saiislam can you please review this? Thanks. https://github.com/llvm/llvm-project/pull/122108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-01-15 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: @alexey-bataev, @kparzysz can you please review this? Thanks. https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #126927)

2025-02-13 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/126927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #126927)

2025-02-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/126927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Missing implicit otherwise clause in metadirective. (PR #127113)

2025-02-13 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/127113 None >From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 13 Feb 2025 11:24:32 -0800 Subject: [PATCH] [OpenMP] Missing implicit otherwise clause in metad

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-02-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang] [OpenMP] Add support for '#pragma omp stripe'. (PR #119891)

2025-02-11 Thread Zahira Ammarguellat via cfe-commits
zahiraam wrote: > > @alexey-bataev I haven't gotten any response from @Meinersbur , can I merge > > this in? Thanks. > > Go ahead Thanks. https://github.com/llvm/llvm-project/pull/119891 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [llvm] [OpenMP] Missing implicit otherwise clause in metadirective. (PR #127113)

2025-02-13 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/127113 >From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 13 Feb 2025 11:24:32 -0800 Subject: [PATCH 1/2] [OpenMP] Missing implicit otherwise clause in metadi

[clang] [llvm] [OpenMP] Missing implicit otherwise clause in metadirective. (PR #127113)

2025-02-13 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/127113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Missing implicit otherwise clause in metadirective. (PR #127113)

2025-02-14 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/127113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG-CL] Remove the 'static' declaration specifier for _FUNCTION_ in (PR #128184)

2025-02-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/128184 MSVC mode. >From bcf2a4708c3f9ae88f5fddafe02c95533601c887 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 21 Feb 2025 07:14:02 -0800 Subject: [PATCH] [CLANG-CL] Remove the 'static' declaration sp

[clang] [CLANG-CL] Remove the 'static' specifier for _FUNCTION_ in MSVC mode. (PR #128184)

2025-02-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/128184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG-CL] Remove the 'static' specifier for _FUNCTION_ in MSVC mode. (PR #128184)

2025-02-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/128184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG-CL] Remove the 'static' specifier for _FUNCTION_ in MSVC mode. (PR #128184)

2025-02-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/128184 >From bcf2a4708c3f9ae88f5fddafe02c95533601c887 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 21 Feb 2025 07:14:02 -0800 Subject: [PATCH 1/2] [CLANG-CL] Remove the 'static' declaration specifier

[clang] [CLANG-CL] Remove the 'static' specifier for _FUNCTION_ in MSVC mode. (PR #128184)

2025-02-21 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/128184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Missing implicit otherwise clause in metadirective. (PR #127113)

2025-02-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/127113 >From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 13 Feb 2025 11:24:32 -0800 Subject: [PATCH 1/4] [OpenMP] Missing implicit otherwise clause in metadi

[clang] [llvm] [OpenMP] Missing implicit otherwise clause in metadirective. (PR #127113)

2025-02-17 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/127113 >From 1995b54afcc9fab93e7e80d3993d3396f193b31d Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 13 Feb 2025 11:24:32 -0800 Subject: [PATCH 1/3] [OpenMP] Missing implicit otherwise clause in metadi

[clang] [llvm] [OpenMP] Missing implicit otherwise clause in metadirective. (PR #127113)

2025-02-17 Thread Zahira Ammarguellat via cfe-commits
@@ -2882,6 +2882,12 @@ StmtResult Parser::ParseOpenMPDeclarativeOrExecutableDirective( /*ReadDirectiveWithinMetadirective=*/true); break; } +// If no match is found and no otherwise clause is present, skip +// OMP5.2 Chapter 7.4: If no otherwise cla

<    2   3   4   5   6   7   8   >