[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/6] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] [TBAA] Emit int TBAA metadata on FP math libcall expf (PR #96025)

@@ -0,0 +1,43 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// The test may fail as time out on windows +// REQUIRES: system-linux + +// RUN: %clang -S -O3 -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefixes=CHECK,

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/7] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/5] The pragma STDC CX_LIMITED_RANGE ON should have prece

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/8] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/6] The pragma STDC CX_LIMITED_RANGE ON should have prece

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 1/9] [NFC] Add assertion to ensure that FiniteMathOnly toggl

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 01/10] [NFC] Add assertion to ensure that FiniteMathOnly to

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

@@ -3298,7 +3298,18 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } // Handle __FINITE_MATH_ONLY__ similarly. - if (!HonorINFs && !HonorNaNs) + bool InfValues = true; + bool NanValues = true; + auto processArg = [&](const auto *Arg) {

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/97342 >From aea6519809340024226d587303e26c800c1a3756 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 1 Jul 2024 12:56:07 -0700 Subject: [PATCH 01/11] [NFC] Add assertion to ensure that FiniteMathOnly to

[clang] Fix -fno-unsafe-math-optimizations behavior (PR #89473)

zahiraam wrote: LGTM! Thanks. https://github.com/llvm/llvm-project/pull/89473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin and frexp. (PR #88978)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/88978 >From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Apr 2024 13:09:58 -0700 Subject: [PATCH 1/3] Adding C23 constexpr math functions fmin and frexp. -

[clang] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin and frexp. (PR #88978)

@@ -0,0 +1,57 @@ +// RUN: %clang_cc1 -DWIN -verify -std=c++23 -fsyntax-only %s +// RUN: %clang_cc1 -verify -std=c++23 -fsyntax-only %s + +// expected-no-diagnostics + + +#ifdef WIN +#define INFINITY ((float)(1e+300 * 1e+300)) +#define NAN (-(float)(INFINITY * 0.0F)) +#else

[clang] [clang][CodeGen] Propagate pragma set fast-math flags to floating point builtins (PR #90377)

@@ -0,0 +1,55 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -disable-llvm-passes -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -fmath-errno -ffp-contract=on

[clang] [clang][CodeGen] Propagate pragma set fast-math flags to floating point builtins (PR #90377)

@@ -0,0 +1,55 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -disable-llvm-passes -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -fmath-errno -ffp-contract=on

[clang] [clang][CodeGen] Propagate pragma set fast-math flags to floating point builtins (PR #90377)

@@ -0,0 +1,55 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -disable-llvm-passes -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -fmath-errno -ffp-contract=on

[clang] [clang][CodeGen] Propagate pragma set fast-math flags to floating point builtins (PR #90377)

@@ -0,0 +1,76 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s + +// precise mode +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fmath-errno -ffp-contract=on \ +// RUN: -fno-rounding-math -emit-llvm -o - %s | FileCheck \ +// RUN: --check-prefix=CHE

[clang] [clang][CodeGen] Propagate pragma set fast-math flags to floating point builtins (PR #90377)

https://github.com/zahiraam approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/90377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Driver] Clean up RenderFloatingPointOptions() (PR #91017)

https://github.com/zahiraam approved this pull request. LGTM. Thanks. https://github.com/llvm/llvm-project/pull/91017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Driver] Clean up RenderFloatingPointOptions() (PR #91017)

https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/91017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Driver] Clean up RenderFloatingPointOptions() (PR #91017)

@@ -2885,6 +2883,7 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, Range = RangeVal; break; } + zahiraam wrote: nit. no need for this line. https://github.com/llvm/llvm-project/pull/91017 __

[clang] [NFC][Driver] Clean up RenderFloatingPointOptions() (PR #91017)

@@ -3152,6 +3125,12 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, } break; } +// The StrictFPModel local variable is needed to report warnings +// in the wat we intend. If -ffp-model=strict has been used, we ---

[clang] [Driver] Clean up fp-contract handling in clang driver (PR #91271)

@@ -2893,7 +2915,6 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, AssociativeMath = false; ReciprocalMath = false; SignedZeros = true; - FPContract = "on"; zahiraam wrote: Not quite sure why this is remo

[clang] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin and frexp. (PR #88978)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/88978 >From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Apr 2024 13:09:58 -0700 Subject: [PATCH 1/4] Adding C23 constexpr math functions fmin and frexp. -

[clang] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin and frexp. (PR #88978)

@@ -0,0 +1,59 @@ +// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \ +// RUN: -DWIN -emit-llvm -o - %s | FileCheck %s --check-prefixes=WIN + +// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \ +// RUN: -emit-llvm -o - %s | FileCheck %s --check

[clang] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin and frexp. (PR #88978)

@@ -14547,6 +14547,20 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr *E) { default: return false; + case Builtin::BI__builtin_frexp: + case Builtin::BI__builtin_frexpf: + case Builtin::BI__builtin_frexpl: { +LValue Pointer; +if (!EvaluateFloat(E->ge

[clang] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin and frexp. (PR #88978)

zahiraam wrote: @hubert-reinterpretcast Thanks for the reviews/suggestions. Let me know what you think. https://github.com/llvm/llvm-project/pull/88978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin and frexp. (PR #88978)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/88978 >From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Apr 2024 13:09:58 -0700 Subject: [PATCH 1/5] Adding C23 constexpr math functions fmin and frexp. -

[clang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/88978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/88978 >From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Apr 2024 13:09:58 -0700 Subject: [PATCH 1/6] Adding C23 constexpr math functions fmin and frexp. -

[clang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/88978 >From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Apr 2024 13:09:58 -0700 Subject: [PATCH 1/7] Adding C23 constexpr math functions fmin and frexp. -

[clang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

@@ -14574,9 +14574,17 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr *E) { default: return false; + case Builtin::BI__builtin_frexpl: +// AIX library function `frexpl` has 'long double' type and not +// PPCDoubleDouble type. To make sure we generate t

[clang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

@@ -14574,9 +14574,17 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr *E) { default: return false; + case Builtin::BI__builtin_frexpl: +// AIX library function `frexpl` has 'long double' type and not +// PPCDoubleDouble type. To make sure we generate t

[clang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/88978 >From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Apr 2024 13:09:58 -0700 Subject: [PATCH 1/8] Adding C23 constexpr math functions fmin and frexp. -

[clang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/88978 >From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Apr 2024 13:09:58 -0700 Subject: [PATCH 1/8] Adding C23 constexpr math functions fmin and frexp. -

[clang] [NFC][Clang] Clean up VisitUnaryPlus by removing unused FP feature check (PR #101412)

https://github.com/zahiraam approved this pull request. LGTM. This is dead code. Thanks Soumi! https://github.com/llvm/llvm-project/pull/101412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

@@ -14683,6 +14710,23 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr *E) { default: return false; + case Builtin::BI__builtin_frexp: + case Builtin::BI__builtin_frexpf: + case Builtin::BI__builtin_frexpl: { zahiraam wrote: Done. https://g

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

@@ -14674,6 +14676,31 @@ static bool TryEvaluateBuiltinNaN(const ASTContext &Context, return true; } +// Checks that the value x is in the range (-1;-0.5], [0.5; 1) +static bool isInFrexpResultRange(const llvm::APFloat &x) { + llvm::APFloat minusOne(x.getSemantics(), "-1.

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

@@ -253,8 +253,10 @@ def FmodF16F128 : F16F128MathTemplate, Builtin { def FrexpF16F128 : F16F128MathTemplate, Builtin { let Spellings = ["__builtin_frexp"]; - let Attributes = [FunctionWithBuiltinPrefix, NoThrow]; + let Attributes = [FunctionWithBuiltinPrefix, NoThrow, Con

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

@@ -0,0 +1,106 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 + +// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \ +// RUN: -emit-llvm -o - %s | FileCheck %s + +#define NAN (__builtin_nanf("")) +#define

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

@@ -0,0 +1,106 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 + +// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \ +// RUN: -emit-llvm -o - %s | FileCheck %s + +#define NAN (__builtin_nanf("")) +#define

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

@@ -0,0 +1,108 @@ +// RUN: %clang_cc1 -DWIN -verify=nan-not-constant -std=c++23 -fsyntax-only %s +// RUN: %clang_cc1 -verify -std=c++23 -fsyntax-only %s +// RUN: %clang_cc1 -verify=cplusplus20andless -std=c++20 -fsyntax-only %s + +// expected-no-diagnostics + + +#ifdef WIN +#de

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/88978 >From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 16 Apr 2024 13:09:58 -0700 Subject: [PATCH 01/15] Adding C23 constexpr math functions fmin and frexp.

[clang] 8ba9c79 - Add support for sycl_special_class attribute.

Author: Zahira Ammarguellat Date: 2022-01-25T14:17:09-08:00 New Revision: 8ba9c794feb30cd969b9776c39873def10c51bff URL: https://github.com/llvm/llvm-project/commit/8ba9c794feb30cd969b9776c39873def10c51bff DIFF: https://github.com/llvm/llvm-project/commit/8ba9c794feb30cd969b9776c39873def10c51bff

[clang] e692654 - The methods visited for a special class must have an identifier.

Author: Zahira Ammarguellat Date: 2022-02-02T13:12:33-08:00 New Revision: e692654a4dc017b0bddc4366b328dd6d68d2740a URL: https://github.com/llvm/llvm-project/commit/e692654a4dc017b0bddc4366b328dd6d68d2740a DIFF: https://github.com/llvm/llvm-project/commit/e692654a4dc017b0bddc4366b328dd6d68d2740a

[clang] 1592d88 - Add support for floating-point option `ffp-eval-method` and for

Author: Zahira Ammarguellat Date: 2022-02-23T15:00:18-08:00 New Revision: 1592d88aa7bc13c9f53cf09d25b98e7318a57bfb URL: https://github.com/llvm/llvm-project/commit/1592d88aa7bc13c9f53cf09d25b98e7318a57bfb DIFF: https://github.com/llvm/llvm-project/commit/1592d88aa7bc13c9f53cf09d25b98e7318a57bfb

[clang] cec7c2b - Revert "[CLANG][PATCH][FPEnv] Add support for option -ffp-eval-method and extend #pragma float_control similarly"

Author: Zahira Ammarguellat Date: 2021-09-01T04:48:50-07:00 New Revision: cec7c2b32ecfd38151822a6e01ec78afaf98bf9a URL: https://github.com/llvm/llvm-project/commit/cec7c2b32ecfd38151822a6e01ec78afaf98bf9a DIFF: https://github.com/llvm/llvm-project/commit/cec7c2b32ecfd38151822a6e01ec78afaf98bf9a

[clang] Fix bug with -ffp-contract=fast-honor-pragmas (PR #104857)

https://github.com/zahiraam approved this pull request. LGTM. Thanks. I had to double check, but it looks like the LIT test `ffp-contract-fast-honor-pragma-option.cpp` has the same behavior with and without this patch. Right? Aren't there already tests that check the output of the option? ht

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

zahiraam wrote: > Alternatively, we don't need tablegen changes if we leave the encoding of > which language standard a builtin is constexpr since to a helper function. @hubert-reinterpretcast I have implemented what you proposed. Removed the `ConstExprSince` attribute and replaced it with me

[clang] [C23] Add *_NORM_MAX macros to (PR #96643)

@@ -207,6 +211,23 @@ #error "Mandatory macros {FLT,DBL,LDBL}_MAX_10_EXP are invalid." #endif +#if __STDC_VERSION__ >= 202311L || !defined(__STRICT_ANSI__) +#ifndef FLT_NORM_MAX + #error "Mandatory macro FLT_NORM_MAX is missing." +#else + _Static_assert(FLT_NORM_MAX >= 1.

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107397 >From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 5 Sep 2024 05:42:26 -0700 Subject: [PATCH 1/4] [NFC] Move warning from COdeGen to Sema. --- clang/i

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107598 >From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 6 Sep 2024 08:01:25 -0700 Subject: [PATCH 1/4] Don't emit int TBAA metadata on more complex FP math

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

@@ -699,9 +699,20 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, bool ConstWithoutErrnoAndExceptions = Context.BuiltinInfo.isConstWithoutErrnoAndExceptions(BuiltinID); // Restrict to target with errno, for example, MacOS doesn't

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107397 >From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 5 Sep 2024 05:42:26 -0700 Subject: [PATCH 1/5] [NFC] Move warning from COdeGen to Sema. --- clang/i

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107397 >From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 5 Sep 2024 05:42:26 -0700 Subject: [PATCH 1/6] [NFC] Move warning from COdeGen to Sema. --- clang/i

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107598 >From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 6 Sep 2024 08:01:25 -0700 Subject: [PATCH 1/5] Don't emit int TBAA metadata on more complex FP math

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

zahiraam wrote: > double foo(); > double d = 2.0 * foo(); That's correct. Only for division and only `-fcomplex-arithmetic=promoted` and when the higher precision type of a target is the same than the current precision type. https://github.com/llvm/llvm-project/pull/107397 ___

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

@@ -6784,6 +6784,11 @@ def warn_arc_lifetime_result_type : Warning< "ARC %select{unused|__unsafe_unretained|__strong|__weak|__autoreleasing}0 " "lifetime qualifier on return type is ignored">, InGroup; +def warn_excess_precision_not_supported : Warning< + "excess precisi

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

@@ -21,6 +25,7 @@ void a() { EVALF((2. + 3i) + (4. + 5i), 6. + 8i); EVALF((2. + 3i) - (4. + 5i), -2. - 2i); EVALF((2. + 3i) * (4. + 5i), -7. + 22i); + // div-precision-warning@+1 {{excess precision is requested but the target does not support excess precision which may

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

@@ -21,6 +25,7 @@ void a() { EVALF((2. + 3i) + (4. + 5i), 6. + 8i); EVALF((2. + 3i) - (4. + 5i), -2. - 2i); EVALF((2. + 3i) * (4. + 5i), -7. + 22i); + // div-precision-warning@+1 {{excess precision is requested but the target does not support excess precision which may

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107397 >From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 5 Sep 2024 05:42:26 -0700 Subject: [PATCH 1/7] [NFC] Move warning from COdeGen to Sema. --- clang/i

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

zahiraam wrote: Let's see if this is better. https://github.com/llvm/llvm-project/pull/107397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107397 >From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 5 Sep 2024 05:42:26 -0700 Subject: [PATCH 1/8] [NFC] Move warning from COdeGen to Sema. --- clang/i

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

@@ -7964,6 +7964,12 @@ class Sema final : public SemaBase { /// Do an explicit extend of the given block pointer if we're in ARC. void maybeExtendBlockObject(ExprResult &E); + std::vector> + ExcessPrecisionNotSatisfied; + unsigned NumExcessPrecisionNotSatisfied = 0;

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107598 >From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 6 Sep 2024 08:01:25 -0700 Subject: [PATCH 1/6] Don't emit int TBAA metadata on more complex FP math

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

@@ -0,0 +1,31 @@ +// RUN: %clang_cc1 %s -O3 -fmath-errno -emit-llvm -triple x86_64-unknown-unknown -o - %s | FileCheck %s -check-prefixes=CHECK +// RUN: %clang_cc1 %s -O3 -fmath-errno -emit-llvm -triple x86_64-pc-win64 -o - %s | FileCheck %s -check-prefixes=CHECK +// RUN: %clan

[clang] [clang] Allow `pragma float_control(precise, *)` to... (PR #105912)

zahiraam wrote: Not very clear to me what the issue is. Can you please explain this in the description. I think here the `#pragma float_control(precise, on)` should be taking precedence over the `-ffast-math` flag and it's not. Right? https://github.com/llvm/llvm-project/pull/105912 _

[clang] [clang][codegen] Don't mark "int" TBAA on FP libcalls with indirect args (PR #108853)

https://github.com/zahiraam approved this pull request. https://github.com/llvm/llvm-project/pull/108853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][codegen] Don't mark "int" TBAA on FP libcalls with indirect args (PR #108853)

zahiraam wrote: OK. This LGTM. I guess we can adopt this PR instead of https://github.com/llvm/llvm-project/pull/107598 unless other reviewers have more to say. https://github.com/llvm/llvm-project/pull/108853 ___ cfe-commits mailing list cfe-commit

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

zahiraam wrote: This is a duplicate solution of https://github.com/llvm/llvm-project/pull/108853. Closing it if no objection from reviewers. https://github.com/llvm/llvm-project/pull/107598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [clang] Set FPOptions at the beginning of CompoundStmt (PR #111654)

https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/111654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Set FPOptions at the beginning of CompoundStmt (PR #111654)

@@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -ffast-math -ffp-contract=fast -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -ffast-math -ffp-contract=fast -emit-llvm -O2 -o - %s | FileCheck %s zahiraam wrote: It seems to me that this issue exists only at O2, right

[clang] [clang] Set FPOptions at the beginning of CompoundStmt (PR #111654)

@@ -1684,6 +1684,15 @@ class CompoundStmt final return hasStoredFPFeatures() ? getStoredFPFeatures() : FPOptionsOverride(); } + /// Get FPOptions inside this statement. They may differ from the outer + /// options due to pragmas. + /// \param CurFPOptions FPOptions ou

[clang] [clang] Set FPOptions at the beginning of CompoundStmt (PR #111654)

https://github.com/zahiraam commented: You seem to have some fails in the CI. https://github.com/llvm/llvm-project/pull/111654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Covrt issue (PR #117769)

https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/117769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Covrt issue (PR #117769)

https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/117769 None >From 27925c327d9f3164e3ba966ffaed5715681480fd Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 21 Nov 2024 07:03:46 -0800 Subject: [PATCH 1/3] [NFC] Fix uninitialized pointer field. --- cl

[clang-tools-extra] Covrt issue (PR #117769)

https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/117769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107598 >From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 6 Sep 2024 08:01:25 -0700 Subject: [PATCH 1/7] Don't emit int TBAA metadata on more complex FP math

[clang] [clang][codegen] Don't mark "int" TBAA on FP libcalls with indirect args (PR #108853)

zahiraam wrote: > > How does this interact with #107598? > >Though this also changes things to ensure when TBAA data is set, it's always >set on the call. Wasn't already doing that? (setting the TBAA on the call?). https://github.com/llvm/llvm-project/pull/108853 _

[clang] [clang][codegen] Don't mark "int" TBAA on FP libcalls with indirect args (PR #108853)

zahiraam wrote: > > > > How does this interact with #107598? > > > > > > > > > Though this also changes things to ensure when TBAA data is set, it's > > > always set on the call. > > > > > > Wasn't already doing that? (setting the TBAA on the call?). > > It was setting it on `cast(Call.getS

[clang] [clang][codegen] Don't mark "int" TBAA on FP libcalls with indirect args (PR #108853)

zahiraam wrote: > > > > > > How does this interact with #107598? > > > > > > > > > > > > > > > Though this also changes things to ensure when TBAA data is set, it's > > > > > always set on the call. > > > > > > > > > > > > Wasn't already doing that? (setting the TBAA on the call?). > > > >

[clang] [clang][codegen] Don't mark "int" TBAA on FP libcalls with indirect args (PR #108853)

zahiraam wrote: > > Not really! int TBAA in in our downstream compiler is interpreted as > > describing the function arguments (they are not int) and the load/store of > > the argument before the library call are begin eliminated which result in > > unexpected behavior. > > Oh wait, then you

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107397 >From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 5 Sep 2024 05:42:26 -0700 Subject: [PATCH 1/9] [NFC] Move warning from COdeGen to Sema. --- clang/i

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/107397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix uninitialized data member in constructor. (PR #118324)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/118324 >From 4142b5bd36a4f7a554196687e191a09dba9e4dcf Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 2 Dec 2024 09:09:21 -0800 Subject: [PATCH 1/2] [NFC] Fix uninitialized data member in constructor. -

[clang-tools-extra] [NFC] Fix uninitialized data member in constructor. (PR #118324)

https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/118324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix uninitialized scalar field in constructor. (PR #118324)

https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/118324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix uninitialized scalar field in constructor. (PR #118324)

zahiraam wrote: > How did you decide on `IndexContents::All` as the default initialization > value. I would be more inclined towards `IndexContents::None`. > > I think it would be preferred to use a member initializer in the declaration > of `IdxContents`. That will ensure an initialization is

[clang-tools-extra] [NFC] Fix uninitialized data member in constructor. (PR #118324)

https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/118324 None >From 4142b5bd36a4f7a554196687e191a09dba9e4dcf Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 2 Dec 2024 09:09:21 -0800 Subject: [PATCH] [NFC] Fix uninitialized data member in constructor.

[clang-tools-extra] [NFC] Fix uninitialized scalar field in constructor. (PR #118324)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/118324 >From 4142b5bd36a4f7a554196687e191a09dba9e4dcf Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 2 Dec 2024 09:09:21 -0800 Subject: [PATCH 1/3] [NFC] Fix uninitialized data member in constructor. -

[clang-tools-extra] [NFC] Fix uninitialized scalar field in constructor. (PR #118324)

https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/118324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Fix uninitialized scalar field in constructor. (PR #118324)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/118324 >From 4142b5bd36a4f7a554196687e191a09dba9e4dcf Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Mon, 2 Dec 2024 09:09:21 -0800 Subject: [PATCH 1/4] [NFC] Fix uninitialized data member in constructor. -

[clang-tools-extra] [NFC] Fix uninitialized scalar field in constructor. (PR #118324)

zahiraam wrote: > Seems like `MemIndex::IdxContents` has the same issue. > > It's a bit suspicious to me that the other `DexIndex` and `MemIndex` > constructors are not passing in an `IndexContents` value. Either there's a > bug lurking there, or the field is only relevant in certain situation

[clang-tools-extra] [NFC] Fix uninitialized scalar field in constructor. (PR #118324)

zahiraam wrote: > idxcontents is only used when we have a set of file names available. hence > this was only set via relevant constructors and rest of the runtime doesn't > use the field. > > but we don't construct tons of new index instances every second. so it's > totally fine to just initi

[clang-tools-extra] [NFC] Complete proper copying and resource cleanup in classes. (PR #118655)

https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/118655 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [NFC] Complete proper copying and resource cleanup in classes. (PR #118655)

zahiraam wrote: Thanks @AaronBallman . I think it makes more sense to have `=delete` instead of `=default`. I changed them. @HerrCai0907 what do you think of these changes? If you think they are useless we can consider these a false positive from the analyzer and ignore them all together. htt

[clang-tools-extra] [NFC] Fix uninitialized scalar field in constructor. (PR #118324)

https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/118324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   7   8   >