zahiraam wrote:
@rjmccall thanks for the review and clarification. @andykaylor do you have any
other comments about this?
https://github.com/llvm/llvm-project/pull/78330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
zahiraam wrote:
@AaronBallman any comments about this? Thanks.
https://github.com/llvm/llvm-project/pull/78330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2712,9 +2712,22 @@ static void EmitComplexRangeDiag(const Driver &D,
<< EnumComplexRangeToStr(Range1) << EnumComplexRangeToStr(Range2);
}
-static std::string RenderComplexRangeOption(std::string Range) {
+static std::string
+RenderComplexRangeOption(LangOptions::Co
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/78330
>From 8f8917528e30d2ba67f669cfd1a893bc85c21121 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 16 Jan 2024 11:24:03 -0800
Subject: [PATCH 1/5] Fixed a bug in Smith's algorithm and made sure last
option i
@@ -13861,6 +13897,36 @@ Sema::CheckReturnValExpr(Expr *RetValExp, QualType
lhsType,
CheckPPCMMAType(RetValExp->getType(), ReturnLoc);
}
+/// Diagnose comparison to NAN or INFINITY in fast math modes.
+/// The comparison to NaN or INFINITY is always false in
+/// fast mod
zahiraam wrote:
Any other comments from @arsenm and @andykaylor?
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/78330
>From 8f8917528e30d2ba67f669cfd1a893bc85c21121 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 16 Jan 2024 11:24:03 -0800
Subject: [PATCH 1/6] Fixed a bug in Smith's algorithm and made sure last
option i
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/76873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -112,6 +112,85 @@ enum FloatingRank {
Ibm128Rank
};
+constexpr unsigned CXX23FloatRankToIndex(clang::BuiltinType::Kind Kind) {
+ switch (Kind) {
+ case clang::BuiltinType::Float16:
+return 0;
+ case clang::BuiltinType::BFloat16:
+return 1;
+ case clang::Builti
@@ -7007,27 +7090,69 @@ static FloatingRank getFloatingRank(QualType T) {
}
}
+/// C++23 6.8.5 [conv.rank]
/// getFloatingTypeOrder - Compare the rank of the two specified floating
/// point types, ignoring the domain of the type (i.e. 'double' ==
-/// '_Complex double').
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/78330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/78330
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/69963
This reverts commit a3a7d6318027bb86e6614c022e77e0bd81aef6dc.
When compiling with MSVC2022 in C++32 mode this is giving an error.
Compiling this simple test case:
t1.cpp:
with -std=c++23 will give the following
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/69963
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/2] Revert "[clang] Support fixed point types in C++
(#67750)"
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/69963
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/3] Revert "[clang] Support fixed point types in C++
(#67750)"
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/69963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/69963
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/3] Revert "[clang] Support fixed point types in C++
(#67750)"
zahiraam wrote:
@AaronBallman Do I have your thumb up for this? Thanks.
https://github.com/llvm/llvm-project/pull/69963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
@AaronBallman Do I have your thumb up for this? Thanks.
https://github.com/llvm/llvm-project/pull/69963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/69963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/70127
None
>From 707f1625a626faae14b8e24f7e3cf10a2ed621ce Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Sun, 24 Sep 2023 22:38:01 -0400
Subject: [PATCH 1/4] [clang][DFP] Add basic builtin type representation for
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/70127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/68820
>From 91de35737b74233f29da76573b4099bf64e8bdd4 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 10 Oct 2023 08:31:41 -0700
Subject: [PATCH 1/5] Add support for -fcx-limited-range and #pragma
CX_LIMTED_RAN
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/68820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/68820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/70244
None
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/8] Revert "[clang] Support fixed point types in C++
(#677
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/70244
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/9] Revert "[clang] Support fixed point types in C++
(#67750)"
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/70244
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 1/9] Revert "[clang] Support fixed point types in C++
(#67750)"
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/70244
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 01/10] Revert "[clang] Support fixed point types in C++
(#67750)"
zahiraam wrote:
> I'm sure Aaron would appreciate me also saying that these changes would
> require addition to the clang release notes. 😄
Yes :-) Will do that. I just wanted you to have a first run through it.
I am getting a funny fail with the formatting as you can see. I think somehow
my PR
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/70244
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 01/11] Revert "[clang] Support fixed point types in C++
(#67750)"
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/70244
>From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Mon, 23 Oct 2023 12:51:21 -0700
Subject: [PATCH 01/11] Revert "[clang] Support fixed point types in C++
(#67750)"
Author: Zahira Ammarguellat
Date: 2020-12-01T10:33:12-08:00
New Revision: 37340798ccb00b9c3a53e8a5f1b6430e85870338
URL:
https://github.com/llvm/llvm-project/commit/37340798ccb00b9c3a53e8a5f1b6430e85870338
DIFF:
https://github.com/llvm/llvm-project/commit/37340798ccb00b9c3a53e8a5f1b6430e85870338
Author: Zahira Ammarguellat
Date: 2020-12-01T12:34:18-08:00
New Revision: f9eaa4650f5d5948af7050efef9d4098ff7f0ae8
URL:
https://github.com/llvm/llvm-project/commit/f9eaa4650f5d5948af7050efef9d4098ff7f0ae8
DIFF:
https://github.com/llvm/llvm-project/commit/f9eaa4650f5d5948af7050efef9d4098ff7f0ae8
Author: Zahira Ammarguellat
Date: 2020-10-27T05:57:39-07:00
New Revision: e562a40871da14cef6685efef09760bca2718269
URL:
https://github.com/llvm/llvm-project/commit/e562a40871da14cef6685efef09760bca2718269
DIFF:
https://github.com/llvm/llvm-project/commit/e562a40871da14cef6685efef09760bca2718269
Author: Zahira Ammarguellat
Date: 2021-05-26T18:07:31-07:00
New Revision: a4b61c82cf1a45c172af2e0242f5019281de14f8
URL:
https://github.com/llvm/llvm-project/commit/a4b61c82cf1a45c172af2e0242f5019281de14f8
DIFF:
https://github.com/llvm/llvm-project/commit/a4b61c82cf1a45c172af2e0242f5019281de14f8
Author: Zahira Ammarguellat
Date: 2021-06-11T06:56:01-07:00
New Revision: 150f7cedfb2e072804f4a0887d14c97a7fe3f374
URL:
https://github.com/llvm/llvm-project/commit/150f7cedfb2e072804f4a0887d14c97a7fe3f374
DIFF:
https://github.com/llvm/llvm-project/commit/150f7cedfb2e072804f4a0887d14c97a7fe3f374
Author: Zahira Ammarguellat
Date: 2021-08-06T12:01:47-07:00
New Revision: 4389a413e2129d7d55ee779638b649aa852b6f8a
URL:
https://github.com/llvm/llvm-project/commit/4389a413e2129d7d55ee779638b649aa852b6f8a
DIFF:
https://github.com/llvm/llvm-project/commit/4389a413e2129d7d55ee779638b649aa852b6f8a
Author: Zahira Ammarguellat
Date: 2021-10-26T13:58:43-04:00
New Revision: e84c5419e2264375e9fef9b025a0dd8ecb251429
URL:
https://github.com/llvm/llvm-project/commit/e84c5419e2264375e9fef9b025a0dd8ecb251429
DIFF:
https://github.com/llvm/llvm-project/commit/e84c5419e2264375e9fef9b025a0dd8ecb251429
Author: Zahira Ammarguellat
Date: 2021-11-05T15:08:09-07:00
New Revision: 627868263cd4d57c230b61904483a3dad9e1a1da
URL:
https://github.com/llvm/llvm-project/commit/627868263cd4d57c230b61904483a3dad9e1a1da
DIFF:
https://github.com/llvm/llvm-project/commit/627868263cd4d57c230b61904483a3dad9e1a1da
Author: Zahira Ammarguellat
Date: 2021-11-08T07:51:29-05:00
New Revision: 17d9560294eee1eae5e2d3ac1ab84f514318409e
URL:
https://github.com/llvm/llvm-project/commit/17d9560294eee1eae5e2d3ac1ab84f514318409e
DIFF:
https://github.com/llvm/llvm-project/commit/17d9560294eee1eae5e2d3ac1ab84f514318409e
Author: Zahira Ammarguellat
Date: 2021-11-08T08:35:19-05:00
New Revision: 438437cbb61a39ce27b3d6218ac426b8f8a0132e
URL:
https://github.com/llvm/llvm-project/commit/438437cbb61a39ce27b3d6218ac426b8f8a0132e
DIFF:
https://github.com/llvm/llvm-project/commit/438437cbb61a39ce27b3d6218ac426b8f8a0132e
Author: Zahira Ammarguellat
Date: 2021-11-11T07:40:35-05:00
New Revision: f04e387055e495e3e14570087d68e93593cf2918
URL:
https://github.com/llvm/llvm-project/commit/f04e387055e495e3e14570087d68e93593cf2918
DIFF:
https://github.com/llvm/llvm-project/commit/f04e387055e495e3e14570087d68e93593cf2918
Author: Zahira Ammarguellat
Date: 2021-11-15T15:30:10-05:00
New Revision: 95edd7f53e77415ca30abefdcdc5ce723c292ebd
URL:
https://github.com/llvm/llvm-project/commit/95edd7f53e77415ca30abefdcdc5ce723c292ebd
DIFF:
https://github.com/llvm/llvm-project/commit/95edd7f53e77415ca30abefdcdc5ce723c292ebd
Author: Zahira Ammarguellat
Date: 2021-11-19T08:59:50-05:00
New Revision: 6623c02d70c3732dbea59c6d79c69501baf9627b
URL:
https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b
DIFF:
https://github.com/llvm/llvm-project/commit/6623c02d70c3732dbea59c6d79c69501baf9627b
Author: Zahira Ammarguellat
Date: 2021-11-23T08:00:57-05:00
New Revision: fd759d42c9f84d16efa99a59620cbb3e6836fed4
URL:
https://github.com/llvm/llvm-project/commit/fd759d42c9f84d16efa99a59620cbb3e6836fed4
DIFF:
https://github.com/llvm/llvm-project/commit/fd759d42c9f84d16efa99a59620cbb3e6836fed4
Author: Zahira Ammarguellat
Date: 2022-09-16T11:08:41-04:00
New Revision: 1b69ce1208976c71bf7ee3932aa272462c1feb1b
URL:
https://github.com/llvm/llvm-project/commit/1b69ce1208976c71bf7ee3932aa272462c1feb1b
DIFF:
https://github.com/llvm/llvm-project/commit/1b69ce1208976c71bf7ee3932aa272462c1feb1b
Author: Zahira Ammarguellat
Date: 2022-10-14T10:55:29-04:00
New Revision: 84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b
URL:
https://github.com/llvm/llvm-project/commit/84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b
DIFF:
https://github.com/llvm/llvm-project/commit/84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b
Author: Zahira Ammarguellat
Date: 2022-10-17T14:26:17-04:00
New Revision: d0a4741392a3df0fb4083e12bef0cef14af439e1
URL:
https://github.com/llvm/llvm-project/commit/d0a4741392a3df0fb4083e12bef0cef14af439e1
DIFF:
https://github.com/llvm/llvm-project/commit/d0a4741392a3df0fb4083e12bef0cef14af439e1
Author: Zahira Ammarguellat
Date: 2023-01-05T09:35:28-05:00
New Revision: 85d049a089d4a6a4a67145429ea5d8e155651138
URL:
https://github.com/llvm/llvm-project/commit/85d049a089d4a6a4a67145429ea5d8e155651138
DIFF:
https://github.com/llvm/llvm-project/commit/85d049a089d4a6a4a67145429ea5d8e155651138
Author: Zahira Ammarguellat
Date: 2022-11-11T10:24:12-05:00
New Revision: 91628f0616ca5203945afb56b3d8a27522b99808
URL:
https://github.com/llvm/llvm-project/commit/91628f0616ca5203945afb56b3d8a27522b99808
DIFF:
https://github.com/llvm/llvm-project/commit/91628f0616ca5203945afb56b3d8a27522b99808
Author: Zahira Ammarguellat
Date: 2023-01-26T14:18:28-05:00
New Revision: b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2
URL:
https://github.com/llvm/llvm-project/commit/b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2
DIFF:
https://github.com/llvm/llvm-project/commit/b4b06d8ff82647824a658356e1e8f7dc9d1ac7d2
Author: Zahira Ammarguellat
Date: 2023-01-20T11:25:36-05:00
New Revision: 47074683c906f920cb7bba462beeb57ca4b84ab0
URL:
https://github.com/llvm/llvm-project/commit/47074683c906f920cb7bba462beeb57ca4b84ab0
DIFF:
https://github.com/llvm/llvm-project/commit/47074683c906f920cb7bba462beeb57ca4b84ab0
Author: Zahira Ammarguellat
Date: 2023-01-20T16:44:51-05:00
New Revision: f97cdc013fe75e18f74fd7bba7de4913c38875a6
URL:
https://github.com/llvm/llvm-project/commit/f97cdc013fe75e18f74fd7bba7de4913c38875a6
DIFF:
https://github.com/llvm/llvm-project/commit/f97cdc013fe75e18f74fd7bba7de4913c38875a6
Author: Zahira Ammarguellat
Date: 2023-01-23T12:08:07-05:00
New Revision: 3759ef9e56dcea6a5c0b6fdca1d2e3f7d3c7d118
URL:
https://github.com/llvm/llvm-project/commit/3759ef9e56dcea6a5c0b6fdca1d2e3f7d3c7d118
DIFF:
https://github.com/llvm/llvm-project/commit/3759ef9e56dcea6a5c0b6fdca1d2e3f7d3c7d118
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/66381
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/66120
>From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 12 Sep 2023 11:25:19 -0700
Subject: [PATCH 1/3] [clang-cl] Fix for __FUNCTION__ in c++.
---
clang/lib/AST/E
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/66120
>From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 12 Sep 2023 11:25:19 -0700
Subject: [PATCH 1/3] [clang-cl] Fix for __FUNCTION__ in c++.
---
clang/lib/AST/E
zahiraam wrote:
There are still some debug info LIT tests that are failing, but I am not going
to edit them because I am not quite sure that's correct. Probably adding the
"class" keyword shouldn't happen at all times even when the MSVCPolicy is true?
https://github.com/llvm/llvm-project/pull/
zahiraam wrote:
There are still some debug info LIT tests that are failing, but I am not going
to edit them because I am not quite sure that's correct. Probably adding the
"class" keyword shouldn't happen at all times even when the MSVCPolicy is true?
https://github.com/llvm/llvm-project/pull/
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/66120
>From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 12 Sep 2023 11:25:19 -0700
Subject: [PATCH 1/4] [clang-cl] Fix for __FUNCTION__ in c++.
---
clang/lib/AST/E
https://github.com/zahiraam ready_for_review
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/66120
>From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 12 Sep 2023 11:25:19 -0700
Subject: [PATCH 1/8] [clang-cl] Fix for __FUNCTION__ in c++.
---
clang/lib/AST/E
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/66120
>From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 12 Sep 2023 11:25:19 -0700
Subject: [PATCH 1/8] [clang-cl] Fix for __FUNCTION__ in c++.
---
clang/lib/AST/E
zahiraam wrote:
> I wanted to make some minor naming suggestions, and I used the GitHub "edit
> this file" feature for the first time to commit them as new commits to your
> branch. I've never done this before, so I don't really know how it works, but
> clang-format isn't available, so now I'v
zahiraam wrote:
> I wanted to make some minor naming suggestions, and I used the GitHub "edit
> this file" feature for the first time to commit them as new commits to your
> branch. I've never done this before, so I don't really know how it works, but
> clang-format isn't available, so now I'v
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam closed
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zahiraam wrote:
> This implementation has bugs, see [#66114
> (comment)](https://github.com/llvm/llvm-project/issues/66114#issuecomment-1732319259)
@RIscRIpt Thanks. Will look at them.
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits m
zahiraam wrote:
> Hi @zahiraam - can we revert this change until [#66114
> (comment)](https://github.com/llvm/llvm-project/issues/66114#issuecomment-1732319259)
> is resolved? Unfortunately this is impacting our downstream windows-x64
> builder.
I have a fix for it. It should be ready by eod
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/67592
None
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/67592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/2] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/2] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/2] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/3] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/4] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/5] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/5] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/6] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/67592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/67592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/7] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
zahiraam wrote:
> Could you add a description explaining what is currently wrong with the value
> of `__FUNCTION__` is MSVC mode? I think we also need a release note.
Hope the RN is at the right place? Thanks.
https://github.com/llvm/llvm-project/pull/67592
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/7] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/67592
>From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Wed, 27 Sep 2023 11:59:04 -0700
Subject: [PATCH 1/7] Fix value of __FUNCTION__ and __func__ in MSVC mode.
---
cl
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/68106
None
>From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 3 Oct 2023 05:43:48 -0700
Subject: [PATCH 1/2] Testing.
---
clang/lib/AST/Expr.cpp | 2 +-
1 file cha
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/68106
>From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 3 Oct 2023 05:43:48 -0700
Subject: [PATCH 1/3] Testing.
---
clang/lib/AST/Expr.cpp | 2 +-
1 file changed,
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/68106
>From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001
From: Ammarguellat
Date: Tue, 3 Oct 2023 05:43:48 -0700
Subject: [PATCH 1/4] Testing.
---
clang/lib/AST/Expr.cpp | 2 +-
1 file changed,
201 - 300 of 741 matches
Mail list logo