[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:613 +result = EmitUnpromotion(promotionTy, E->getSubExpr()->getType(), result); + return result; +} rjmccall wrote: > You should unpromote only if we're not in a promoted context

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked 3 inline comments as done. zahiraam added a comment. Comment at: clang/test/CodeGen/X86/Float16-complex.c:1184 +// X86-NEXT:store float [[NEG_I]], ptr [[RETVAL_IMAGP]], align 2 +// X86-NEXT:[[TMP0:%.*]] = load <2 x half>, ptr [[RETVAL]], align 2 +// X86

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. This is a reduced test case from the codegen/complex-strictfp.c _Complex double g1, g2; double D; void foo(void) { g1 = g1 + D; } The issue is that we are calling in VisitBinAssign the function EmitUnpromotion (since promotionTy is null). This creates 2 constrain

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3736325 , @rjmccall wrote: > In D113107#3736312 , @zahiraam > wrote: > >> This is a reduced test case from the codegen/complex-strictfp.c >> >> _Complex double g1, g2; >> doub

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:207 +// CHECK-NEXT:[[EXT:%.*]] = fpext half [[TMP0]] to float +// CHECK-NEXT:store float [[EXT]], ptr [[RETVAL]], align 2 +// CHECK-NEXT:

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/test/CodeGen/X86/Float16-arithmetic.c:207 +// CHECK-NEXT:[[EXT:%.*]] = fpext half [[TMP0]] to float +// CHECK-NEXT:store float [[EXT]], ptr [[RETVAL]], align 2 +// CHECK-NEXT:[[TMP1:%.*]] = load half, ptr [[RETVAL]], a

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3743318 , @rjmccall wrote: > Somehow we've taken a huge step back on unpromotion, and I'm worried you're > now doing the exact thing I didn't want us doing and forcing all the > downstream clients to handle the possi

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:615 + ComplexPairTy result = VisitMinus(E, promotionTy); + return result; +} rjmccall wrote: > This is not unpromoting if the original `PromotionType` is null. The idea for this cha

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3747095 , @rjmccall wrote: > Thanks, LGTM Thanks for all the reviews. There is still more work to be done :) I will push it tomorrow as it's the end of day for me and I am afraid there will be some fails that I woul

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a subscriber: bkramer. zahiraam added a comment. Thanks @bkramer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 ___ cfe-commits mailing list cfe

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 465768. zahiraam added reviewers: andrew.w.kaylor, aaron.ballman, rjmccall, efriedma, fhahn, dexonsmith. zahiraam changed the visibility from "Custom Policy" to "Public (No Login Required)". Herald added a subscriber: MaskRay. CHANGES SINCE LAST ACTION ht

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 465790. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 Files: clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGCall.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/fp-options-

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added a comment. In D135097#3840706 , @aaron.ballman wrote: > I'm also okay with this direction. I took a look to see if people seemed to > be using this option in their build scripts (maybe we would need a louder > deprecation period), and it

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 466474. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGCall.cpp clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations, the compiler +options ``-funsafe-math-opti

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam updated this revision to Diff 467749. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135097/new/ https://reviews.llvm.org/D135097 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Driver/Options.td clang/lib/CodeGen/CGCall.cpp clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/docs/ReleaseNotes.rst:410-412 +- The driver option ``-menable-unsafe-fp-math`` has been removed. Passing it, will +result in a hard error. To enable unsafe floating-point optimizations,

[PATCH] D135097: Remove redundant option '-menable-unsafe-fp-math'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. zahiraam marked an inline comment as done. Closed by commit rG84a9ec2ff1ee: Remove redundant option -menable-unsafe-fp-math. (authored by zahiraam). Repository: rG L

[PATCH] D135963: Fix build issue due to https://reviews.llvm.org/rG84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D135963 Files: clang/lib/CodeGen/CGCall.cpp Index:

[PATCH] D135963: Fix build issue due to https://reviews.llvm.org/rG84a9ec2ff1ee97fd7e8ed988f5e7b197aab84a7b

zahiraam added a comment. In D135963#3858638 , @aaron.ballman wrote: > LGTM -- btw, feel free to land fixes to buildbot breaks without code review. thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

zahiraam created this revision. zahiraam added reviewers: jrtc27, saugustine, aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. See details in comment https://reviews.llvm.org/D135097#3859893 and https://reviews.llvm.org/D135097

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

zahiraam added a comment. @saugustine A, @jrtc27. Thanks for your comments. Adding '-target x86_64' is restrictive, but not sure what option to use to express that I want target with zero as default address. @aaron.ballman what do you think? Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

zahiraam added inline comments. Comment at: clang/test/CodeGen/func-attr.c:1 -// RUN: %clang -c -ffast-math -emit-llvm -S -o - %s \ -// RUN: | FileCheck %s +// RUN: %clang -c -O2 -target x86_64 -ffast-math\ +// RUN: -emit-llvm -S -o - %s | FileCheck %s erichkean

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

zahiraam updated this revision to Diff 468236. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136084/new/ https://reviews.llvm.org/D136084 Files: clang/test/CodeGen/func-attr.c Index: clang/test/CodeGen/func-attr.c === --

[PATCH] D136084: Fix LIT CodeGen/Func-attr.c

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0a4741392a3: Fix LIT test func-attr.c added by https://reviews.llvm.org/D135097. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13608

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484006. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484062. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/Co

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4852 + if (!CD->isTrivial() && !D->getTLSKind()) +NeedsGlobalCtor = true; +} efriedma wrote: > I have no idea what this code is supposed to do. I have remove

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4852 + if (!CD->isTrivial() && !D->getTLSKind()) +NeedsGlobalCtor = true; +} efriedma wrote: > zahiraam wrote: > > efriedma wrote: > > > I have no idea wh

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5009 + if (isStaticInit(D, getLangOpts()) && NeedsGlobalCtor && NeedsGlobalDtor) { +EmitCXXCtorInit(D, GV, true, 201, llvm::StringLiteral("ctor"), false

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484258. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { Do you agree this should be done only when one of those flags is on? CHANGES SI

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484278. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/test/CodeGenCXX/PR19955.cpp:20 +// CHECK-64: store ptr @"?var@@3HA", ptr @"?varp@@3PEAHEA" +// CHECK: ret void @rnk was concerned about varp pointing to dllimport var. That does it I think. CHANGES SINCE LAS

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked 3 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > >

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484665. zahiraam marked an inline comment as done. Herald added a subscriber: aheejin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > > efriedma wrote: > > > zahiraam wrote: > > >

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484814. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 484840. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 484882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/docs/UsersManual.rst clang/include/clang/AST/Type.h clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 486274. zahiraam marked 2 inline comments as done. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > > efriedma wrote: > > > zahiraam wrote: > > >

[PATCH] D136176: Implement support for option 'fexcess-precision'.

This revision was automatically updated to reflect the committed changes. Closed by commit rG85d049a089d4: Implement support for option 'fexcess-precision'. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://re

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. The changes in this patch look good to me. I talked to @andrew.w.kaylor offline: I was thinking that it might be necessary to make the two driver changes we talked about, before merging this patch. But if the tests pass then I think it's okay to implement the driver ch

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3897568 , @mstorsjo wrote: > In D137107#3897326 , @rnk wrote: > >> Unless I'm missing something, I think Clang's behavior here is preferable to >> MSVC's. MSVC produces code w

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3906413 , @mstorsjo wrote: > In D137107#3905443 , @zahiraam > wrote: > >> and the same assembly (load __imp_?val) (is that why you made the comment >> above?). And the test c

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. In D136786#3907235 , @michele.scandale wrote: > In D136786#3903646 , @zahiraam > wrote: > >> The changes in this patch look good to me. >> @michele.scandale please make sure not to dro

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 473693. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CodeGenCXX/PR19955.cpp clang/test/CodeGenCXX/dllimport.cpp clang/test/SemaCXX/constant-expressio

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

zahiraam added a comment. In D136786#3909043 , @zahiraam wrote: > In D136786#3907235 , > @michele.scandale wrote: > >> In D136786#3903646 , @zahiraam >> wrote: >> >>> Th

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

zahiraam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2844 FPContract = "fast"; +FPExceptionBehavior = ""; } else if (Val.equals("precise")) { I would expect the same thing should happen with -ffp-model=strict -

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

zahiraam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3034 RoundingFPMath = false; + FPExceptionBehavior = ""; // If fast-math is set then set the fp-contract mode to fast. FPExceptionBehavior should be set here and

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

zahiraam updated this revision to Diff 474515. zahiraam edited the summary of this revision. zahiraam added reviewers: andrew.w.kaylor, michele.scandale. zahiraam set the repository for this revision to rG LLVM Github Monorepo. zahiraam changed the visibility from "Custom Policy" to "All Users". za

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

zahiraam added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3957 - if (Arg *A = Args.getLastArg(OPT_ffp_contract)) { -StringRef Val = A->getValue(); -if (Val == "fast") + if (auto *A = Args.getLastArg(OPT_ffp_contract, OPT_cl_fast_relaxed_mat

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

zahiraam added a comment. In D137578#3918314 , @michele.scandale wrote: > Looks good to me @michele.scandale Now that I opened up the patch to all, it needs another stamp from you. Would you mind reviewing it again please? I will wait for a day before

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3906766 , @rnk wrote: > In D137107#3905443 , @zahiraam > wrote: > >> extern int __declspec(dllimport) next(int n); >> int main () { >> extern int _declspec(dllimport)

[PATCH] D137578: Fix 'unsafe-math-optimizations' flag dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91628f0616ca: The handling of 'funsafe-math-optimizations' doesn't update the 'MathErrno' (authored by zahiraam). Changed prior to commit: https:

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

zahiraam added inline comments. Comment at: clang/test/Driver/fp-model.c:162 +// CHECK-FASTMATH-FPM-STRICT-NOT: "-ffast-math" +// CHECK-FASTMATH-FPM-STRICT-NOT: "-ffinite-math-only" Shouldn't be worth adding a rule for -ffast-math and ffp-model=fast (even if it

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. It would probably be better to make these changes with the appropriate code changes you are making for each semantic mode. And may be keep this patch only for the other changes you are proposing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. In D138117#3930423 , @kawashima-fj wrote: > I don't know it is inteded that `-fno-fast-math` does not imply > `-ftrapping-math` and `-frounding-math`. > `-ffast-math` and `-fno-fast-math` is not symmetric in > RenderFloatingPo

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 475902. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Basic/LangOptions.h clang/includ

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:300 +FPP_Fast, +FPP_None + }; andrew.w.kaylor wrote: > Is FPP_None somehow the same as fexcess-precision=16? If not, what does it > mean? Yes, maybe this is confusing.

[PATCH] D138117: [clang][docs] Correct floating point option explanations

zahiraam added a comment. In D138117#3932688 , @kawashima-fj wrote: > In D138117#3931109 , @zahiraam > wrote: > >> It would probably be better to make these changes with the appropriate code >> changes you are

[PATCH] D138109: [clang] Fix -fp-model={strict|precise} to disable -fapprox-func

zahiraam added a comment. In D138109#3932691 , @kawashima-fj wrote: > Update a test to include the `ffast-math -ffp-model=fast` pattern. Thanks. Looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138109/new/ https://reviews.llvm.

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

zahiraam added a comment. Looks good to me after the additional RUN line mentioned in my comment for Driver/fp-model.c is added. Thanks. Comment at: clang/test/Driver/fp-model.c:77 +// WARN12-NOT: warning: overriding '-ffp-model=strict' option with '-ffp-model=strict' [-Wove

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:300 +FPP_Fast, +FPP_None + }; zahiraam wrote: > andrew.w.kaylor wrote: > > Is FPP_None somehow the same as fexcess-precision=16? If not, what does it > > mean? > Yes, ma

[PATCH] D136176: Implement support for option 'fexcess-precision'.

zahiraam updated this revision to Diff 476161. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136176/new/ https://reviews.llvm.org/D136176 Files: clang/include/clang/Basic/LangOptions.def clang/include/clang/Basic/LangOptions.h clang/include/clang/Driver/Options.td clang/lib/CodeG

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked an inline comment as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5006 +if (NeedsGlobalCtor || NeedsGlobalDtor) + DelayedCXXInitPosition[D] = ~0U; + } else { efriedma wrote: > zahiraam wrote: > >

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam marked an inline comment as done. zahiraam added a comment. Thanks. Please see my comments/questions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 ___ cfe-commits mailing list cfe-commits

[PATCH] D142583: [SPIR-V] Add support for __arithmetic_fence builtin for SYCL targets.

zahiraam created this revision. zahiraam added reviewers: bader, andrew.w.kaylor. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. __arithmetic_fence enforces ordering on expressi

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam updated this revision to Diff 492410. zahiraam marked 3 inline comments as done. zahiraam edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGen/

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam updated this revision to Diff 492483. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 Files: clang/lib/Basic/Targets/SPIR.h clang/test/CodeGen/arithmetic-fence-builtin.c clang/test/Sema/arithmetic-fence-builtin.c Index: clang/te

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam added inline comments. Comment at: clang/test/CodeGen/arithmetic-fence-builtin.c:73 int subit(float a, float b, float *fp) { - // CHECKFAST: define {{.*}}@subit(float noundef %a, float noundef %b{{.*}} + // CHECKPRECISE: define {{.*}}@subit(float noundef %a, float nou

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

zahiraam added a comment. In D142583#4083251 , @bader wrote: > LGTM. Thanks! Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142583/new/ https://reviews.llvm.org/D142583 ___ cfe-commits mailin

[PATCH] D142583: [SPIR] Add support for __arithmetic_fence builtin for SPIR target.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b06d8ff826: __arithmetic_fence enforces ordering on expression evaluation when fast-math (authored by zahiraam). Repository: rG LLVM Github Mono

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 493411. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 493726. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam updated this revision to Diff 494051. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137107/new/ https://reviews.llvm.org/D137107 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGDeclCXX.cpp clang/lib/CodeGen/CGE

[PATCH] D141929: Add support for clang-cl's option /Qfexcess-precision.

zahiraam created this revision. zahiraam added reviewers: andrew.w.kaylor, mdtoguchi. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D141929 Files: clang/include/clang/Driver

[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

zahiraam updated this revision to Diff 489833. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/ https://reviews.llvm.org/D141929 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-options.c Index: clang/test/Driver/cl-options.c ==

[PATCH] D141929: Add support for clang-cl's option /fexcess-precision.

zahiraam updated this revision to Diff 490183. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141929/new/ https://reviews.llvm.org/D141929 Files: clang/include/clang/Driver/Options.td clang/test/Driver/fexcess-precision.c Index: clang/test/

[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47074683c906: Add support for clang-cl's option `-fexcess-precision`. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D141929: Add support for clang-cl's option -fexcess-precision.

zahiraam added a comment. In D141929#4069763 , @thakis wrote: > This breaks tests on macOS: http://45.33.8.238/macm1/53215/step_7.txt > > Please take a look and revert for now if it takes a while to fix. @thakis I reverted it. The fast value of the optio

[PATCH] D142367: Add support for clang-cl's option -fexcess-precision.

zahiraam created this revision. zahiraam added reviewers: mdtoguchi, andrew.w.kaylor. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. This option is useful for clang and clang-cl. Repository: rG LLVM Github Monorepo https://reviews.llvm.

[PATCH] D142367: Add support for clang-cl's option -fexcess-precision.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3759ef9e56dc: Add support for clang-cl's option `-fexcess-precision`. (authored by zahiraam). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D142367: Add support for clang-cl's option -fexcess-precision.

zahiraam added a subscriber: thakis. zahiraam added a comment. @thakis I think this should fix the clang-cl use with the Mac OS compiler. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142367/new/ https://reviews.llvm.org/D142367 __

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 437191. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/X86.cpp

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. @rjmccall I made some progress on the requests above. There are still a few things that need to be nailed down. The comma && ternary cases for EmitPromoted, I am not sure what needs to happen there? I am also not quite sure about the ComplexExpr’s generated IR . I upd

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked 2 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { rjmccall wrote: >

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked 7 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { pengfei wrote: >

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 439020. zahiraam marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Target

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { pengfei wrote: > zahiraam wrote: > > pengfei wrote: > > > rj

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3601873 , @rjmccall wrote: > Supporting the lowering in the backend is sensible in order to support > `-fexcess-precision=16`, because I agree that the most reasonable IR output > in that configuration is to simply g

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 439110. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/X86.cpp

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 439113. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/X86.cpp

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 439128. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/X86.cpp

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 439130. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/X86.cpp

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3603761 , @pengfei wrote: >> Supporting the lowering in the backend is sensible in order to support >> -fexcess-precision=16, because I agree that the most reasonable IR output in >> that configuration is to simply g

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3604048 , @pengfei wrote: > @zahiraam, community requires to enable the `_Float16` support in FE, see > https://discourse.llvm.org/t/how-to-build-compiler-rt-for-new-x86-half-float-abi/63366 > Is there any blocking is

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam updated this revision to Diff 439385. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Basic/TargetInfo.h clang/lib/Basic/Targets/X86.cpp

<    1   2   3   4   5   6   >