Author: ygao
Date: Wed Oct 12 14:33:33 2016
New Revision: 284033
URL: http://llvm.org/viewvc/llvm-project?rev=284033&view=rev
Log:
[NFC] Trial change to remove a redundant blank line.
Modified:
cfe/trunk/lib/Headers/xmmintrin.h
Modified: cfe/trunk/lib/Headers/xmmintrin.h
URL:
http://llvm.or
Author: ygao
Date: Wed Oct 12 18:27:27 2016
New Revision: 284080
URL: http://llvm.org/viewvc/llvm-project?rev=284080&view=rev
Log:
[NFC] Fixing the description for _mm_store_ps and _mm_store_ps1.
It seems that the doxygen description of these two intrinsics were swapped by
mistake.
Modified:
ygao added a subscriber: ygao.
Comment at: lib/Format/FormatTokenLexer.cpp:245
@@ -241,1 +244,3 @@
++Offset; // Skip the escaped character.
+if (Offset + 1 < Lex->getBuffer().end() && *Offset == '$' &&
+*(Offset + 1) == '{') {
What happens if th
Author: ygao
Date: Fri Sep 2 18:16:06 2016
New Revision: 280556
URL: http://llvm.org/viewvc/llvm-project?rev=280556&view=rev
Log:
(clang part) Implement MASM-flavor intel syntax behavior for inline MS asm
block.
Clang tests for verifying the following syntaxes:
1. 0xNN and NNh are accepted as va
Author: ygao
Date: Mon Jul 18 13:44:51 2016
New Revision: 275877
URL: http://llvm.org/viewvc/llvm-project?rev=275877&view=rev
Log:
Support -masm= flag for x86 assembly targets.
For assembly files without .intel_syntax or .att_syntax directives, allow the
-masm= flag to supply a default assembly d
ygao marked an inline comment as done.
Comment at: lib/Driver/Tools.cpp:6379
@@ +6378,3 @@
+void ClangAs::AddX86TargetArgs(const ArgList &Args,
+ArgStringList &CmdArgs) const {
+ if (Arg *A = Args.getLastArg(options::OPT_masm_EQ)) {
---
ygao closed this revision.
ygao marked an inline comment as done.
ygao added a comment.
Closed by https://reviews.llvm.org/rL275877.
https://reviews.llvm.org/D22285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
ygao created this revision.
ygao added reviewers: gribozavr, aaron.ballman.
ygao added a subscriber: cfe-commits.
Hi,
I was preparing our internal release documentation with our tech writers, and
when reviewing the clang manual for the current release, we think the current
documentation of type sa
Author: ygao
Date: Fri Jul 29 13:34:21 2016
New Revision: 277192
URL: http://llvm.org/viewvc/llvm-project?rev=277192&view=rev
Log:
Improve documentation of the type safety attributes.
1. Add description of the arguments to these attributes.
2. Add missing declarations to some of the MPI code examp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277192: Improve documentation of the type safety attributes.
(authored by ygao).
Changed prior to commit:
https://reviews.llvm.org/D22717?vs=65206&id=66155#toc
Repository:
rL LLVM
https://reviews.ll
Author: ygao
Date: Tue Mar 29 17:59:20 2016
New Revision: 264801
URL: http://llvm.org/viewvc/llvm-project?rev=264801&view=rev
Log:
Fixing PR26558: remove the adx target attribute requirement from adc builtins.
The addcarry and subborrow variants of the builtins do not require the adx
target attri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL264801: Fixing PR26558: remove the adx target attribute
requirement from adc builtins. (authored by ygao).
Changed prior to commit:
http://reviews.llvm.org/D18533?vs=51857&id=52000#toc
Repository:
rL
ygao added a comment.
> Yep, only the ADCX instruction needs adx. This LGTM, but please just
> remove "-target-feature +adx" from the run line instead of adding a
> second run line.
Thanks, Justin.
Committed r264801 and updated the test as you suggested.
Repository:
rL LLVM
http://revie
ygao created this revision.
ygao added subscribers: cfe-commits, rsmith.
Hi,
It seems that the module.modulemap file in the lib/Headers directory is missing
the LLVM copyright notice.
This patch adds the copyright notice just like the rest of the files in this
directory.
Could you review that is
ygao added a subscriber: ygao.
Comment at: test/Driver/ps4-misc-defaults.cpp:10
@@ +9,2 @@
+// RUN: %clang -target x86_64-scei-ps4 -E -x c -dM %s | FileCheck
-check-prefix=CHECK-CSTD %s
+// CHECK-CSTD: __STDC_VERSION__ 199901L
It seems to me that this part of the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL265325: Add copyright notice to the modulemap file.
(authored by ygao).
Changed prior to commit:
http://reviews.llvm.org/D18709?vs=52414&id=52590#toc
Repository:
rL LLVM
http://reviews.llvm.org/D187
Author: ygao
Date: Mon Apr 4 13:46:09 2016
New Revision: 265325
URL: http://llvm.org/viewvc/llvm-project?rev=265325&view=rev
Log:
Add copyright notice to the modulemap file.
The module.modulemap file in the lib/Headers directory was missing the LLVM
copyright notice. This patch adds the copyrigh
ygao accepted this revision.
ygao added a reviewer: ygao.
ygao added a comment.
The test LGTM. Thanks!
http://reviews.llvm.org/D18708
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ygao created this revision.
ygao added subscribers: thakis, cfe-commits.
For assembly files without .intel_syntax or .att_syntax directives, allow the
-masm= flag to supply a default assembly dialect. For example,
C:\TMP> type intel.s
.text
mov al,0
C:\TMP> clang -masm=intel -c intel.s
Without
ygao added a subscriber: ygao.
Comment at: lib/Basic/Targets.cpp:2772
@@ -2771,2 +2771,3 @@
setFeatureEnabledImpl(Features, "xsaveopt", true);
+setFeatureEnabledImpl(Features, "xsave", true);
// FALLTHROUGH
Is this line necessary? Line#3027 below in
ygao created this revision.
ygao added subscribers: craig.topper, bogner, cfe-commits.
Hi,
The addcarry and subborrow variants of the builtins do not require the adx
target attribute. Only the addcarryx variants require them.
This patch attempts to remove the target attribute requirements from th
ygao added a comment.
> What I would suggest is:
>
> Check that this test fails at least on windows with your patch
>
> reverted. If so, commit it. BTW, don't you need to drop the "|
> FileCheck" to cause a crash?
Hmm, even with the pipe removed, I still have difficulty reproducing the
ygao added a comment.
In llvm/utils/lit/lit/TestRunner.py line#202 inside function executeShCmd(),
the test is spawned by
subprocess.Popen(command, ..., stdout = subprocess.PIPE, stderr =
subprocess.PIPE, ...)
And the test passes. I can verify with a small python script doing just a
subprocess.
ygao updated this revision to Diff 44351.
http://reviews.llvm.org/D15705
Files:
test/Preprocessor/bigoutput.c
Index: test/Preprocessor/bigoutput.c
===
--- test/Preprocessor/bigoutput.c
+++ test/Preprocessor/bigoutput.c
@@ -0,0 +1,
ygao created this revision.
ygao added a reviewer: rsmith.
ygao added a subscriber: cfe-commits.
Herald added subscribers: dschuff, jfb.
Hi,
I was looking at the list of pre-defined macros by the new LLVM release and
noticed that the __GXX_RTTI macro is being defined for both C and C++, and I
wo
ygao updated this revision to Diff 45784.
http://reviews.llvm.org/D15705
Files:
test/Preprocessor/bigoutput.c
test/lit.cfg
Index: test/lit.cfg
===
--- test/lit.cfg
+++ test/lit.cfg
@@ -491,4 +491,9 @@
if use_gmalloc:
conf
ygao added a comment.
Thanks, Rafael!
I did verify that the test would fail without my fix. But what do I need to do
to make buildbots turn on the new lit parameter?
http://reviews.llvm.org/D15705
___
cfe-commits mailing list
cfe-commits@lists.llvm
ygao added a comment.
A gentle ping.
http://reviews.llvm.org/D16365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ygao
Date: Tue Jan 26 14:15:02 2016
New Revision: 258850
URL: http://llvm.org/viewvc/llvm-project?rev=258850&view=rev
Log:
Do not define GXX_RTTI macro for C.
This is same as GCC behavior (tested with GCC 4.8.2).
Differential Revision: http://reviews.llvm.org/D16365
Modified:
cfe/tr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL258850: Do not define GXX_RTTI macro for C. (authored by
ygao).
Changed prior to commit:
http://reviews.llvm.org/D16365?vs=45416&id=46031#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16365
File
Author: ygao
Date: Tue Jan 26 20:18:28 2016
New Revision: 258902
URL: http://llvm.org/viewvc/llvm-project?rev=258902&view=rev
Log:
Adding a test for PR25717.
The test tries to produce a large preprocessed output to the console, and checks
that we do not see any unexpected fatal errors.
The test
ygao created this revision.
ygao added subscribers: gkistanova, sqlbyme, cfe-commits, llvm-commits.
Hi,
So this patch tries to enable tests that will output to the console. These
tests are otherwise not exercised.
Note that the outputs will stay on the console and will not be saved into the
test
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259248: [llvmlab] Enable clang tests that output to the
console when we are on the… (authored by ygao).
Changed prior to commit:
http://reviews.llvm.org/D16694?vs=46313&id=46431#toc
Repository:
rL LL
ygao closed this revision.
ygao added a comment.
The test is commited in http://reviews.llvm.org/rL258898 and
http://reviews.llvm.org/rL258902, and it is enabled on buildbot in
http://reviews.llvm.org/rL259248.
Thanks!
http://reviews.llvm.org/D15705
_
Author: ygao
Date: Wed Dec 9 19:37:18 2015
New Revision: 255200
URL: http://llvm.org/viewvc/llvm-project?rev=255200&view=rev
Log:
Fix a typo in the clang user manual.
-fmax-unknown-pointer-align => -fmax-type-align
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManua
ygao created this revision.
ygao added subscribers: cfe-commits, rsandifo, majnemer, aaron.ballman.
Hi,
I am trying to add a test for PR25717. The test itself is fairly
straight-forward: it generates a
large .c temporary file on the fly and then runs the preprocessor over the
generated file to
m
ygao added inline comments.
Comment at: test/Preprocessor/bigoutput.py:7
@@ +6,3 @@
+
+f = open("bigoutput.c", "wb")
+for i in range(0, 15000):
For example, it would be nice to use %t as the temporary file name (so lit will
fill in with a generated
name) instead
ygao added a comment.
Hi Rafael,
Yes I can do that, and it works for me. Do you know whether there is a way to
keep the UNIX line ending on the test file upon checkout rather than having svn
or git auto-translate the line endings? The UNIX line ending is necessary to
trigger the original bug,
ygao updated this revision to Diff 43554.
ygao added a comment.
I think what I can do is to run
svn propset svn:eol-style 'LF'
on the new file, and hopefully the subversion or git client will get the hint
and not auto-translate the line endings.
http://reviews.llvm.org/D15705
Files:
test/Pre
ygao added a comment.
If you take a look at
void PrintPreprocessedAction::ExecuteAction() {
...
while (next < end) {
if (*cur == 0x0D) { // CR
if (*next == 0x0A) // CRLF
BinaryMode = false;
...
The value of this BinaryMode reflects whethe
40 matches
Mail list logo
