yamaguchi accepted this revision.
yamaguchi added a comment.
LGTM
https://reviews.llvm.org/D47273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi created this revision.
yamaguchi added reviewers: rsmith, dblaikie, v.g.vassilev.
Clang emits error when implicit modules was relocated from the
first build directory. However this was biting our usecase where we copy
the contents of build directory to another directory in order to
distr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL338503: [Modules] Do not emit relocation error when
-fno-validate-pch is set (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
yamaguchi updated this revision to Diff 102051.
yamaguchi added a comment.
I think we don't need additional testcase, because this is non-functional
change. Driver.cpp will emit error if value was not "thin" nor "full". This
testcase is at clang/test/CodeGen/thinlto-backend-option.ll.
https://
yamaguchi updated this revision to Diff 102551.
yamaguchi added a comment.
Herald added a subscriber: eraman.
Update patch. Add testcase and check if argument is valid or not.
https://reviews.llvm.org/D34055
Files:
clang/lib/Frontend/CompilerInvocation.cpp
clang/test/CodeGen/thinlto-backend
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305392: Be more strict when checking the -flto option value
(authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34055?vs=102551&id=102555#toc
Repository:
rL LLVM
https://revi
yamaguchi closed this revision.
yamaguchi added a comment.
Landed in r305561.
https://reviews.llvm.org/D32341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi updated this revision to Diff 102944.
yamaguchi marked 3 inline comments as done.
yamaguchi added a comment.
Herald added a subscriber: hiraditya.
Update patch and add support for `clang -stdlib=[tab]` case.
In this case we expect to see all possible values.
(Eg. `libc++ libstdc++ platfo
yamaguchi added inline comments.
Comment at: clang/test/Driver/autocomplete.c:7
// NONE: foo
+// RUN: %clang --autocomplete=l,=,-stdlib | FileCheck %s -check-prefix=STDLIB
+// STDLIB: libc++ libstdc++
ruiu wrote:
> Why do you want to pass the arguments in the re
yamaguchi marked 2 inline comments as done.
yamaguchi added inline comments.
Comment at: llvm/lib/Option/OptTable.cpp:198
+ continue;
+std::string S = "-" + std::string(In.Name);
+std::string C = (Command[1] == "=") ?
yamaguchi wrote:
> teemperor wr
yamaguchi updated this revision to Diff 102946.
yamaguchi marked 5 inline comments as done.
yamaguchi added a comment.
Update patch. Rui's comment about the bash part is very reasonable.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/O
yamaguchi updated this revision to Diff 102958.
yamaguchi marked 10 inline comments as done.
yamaguchi added a comment.
Cleaned suggestValueCompletions and bash-autocomplete.sh, and added tests.
We have passed flags and values from bash to clang like `clang
--autocomplete=l,=,-stdlib`, but I've
yamaguchi updated this revision to Diff 102959.
yamaguchi marked an inline comment as done.
yamaguchi added a comment.
Made trivial change.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/Options.td
clang/lib/Driver/Driver.cpp
clang
yamaguchi updated this revision to Diff 102960.
yamaguchi added a comment.
Made trivial bug fix.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/Options.td
clang/lib/Driver/Driver.cpp
clang/lib/Driver/DriverOptions.cpp
clang/test/
yamaguchi updated this revision to Diff 102961.
yamaguchi added a comment.
Made trivial change.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/Options.td
clang/lib/Driver/Driver.cpp
clang/lib/Driver/DriverOptions.cpp
clang/test/D
yamaguchi updated this revision to Diff 102964.
yamaguchi added a comment.
Made a trivial change in optionMatches.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/Options.td
clang/lib/Driver/Driver.cpp
clang/lib/Driver/DriverOptions
yamaguchi updated this revision to Diff 102981.
yamaguchi marked 6 inline comments as done.
yamaguchi added a comment.
Update code comment according to Rui's comment.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/Options.h
clang/include/clang/Driver/Options.td
clang/li
yamaguchi updated this revision to Diff 102982.
yamaguchi added a comment.
Add support and test for
-cl-std=,-fno-sanitize-coverage=,-ffp-contract=,-flto=,-fveclib=,-fshow-overloads=,-fvisibility=,-mfloat-abi=,-mthread-model.
https://reviews.llvm.org/D33383
Files:
clang/include/clang/Driver/
yamaguchi closed this revision.
yamaguchi added a comment.
Landed in https://reviews.llvm.org/rL305805.
https://reviews.llvm.org/D33383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
yamaguchi accepted this revision.
yamaguchi added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks for the patch.
https://reviews.llvm.org/D34557
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
yamaguchi created this revision.
Add check if user's clang version supports --autocomplete or not.
If not, we just autocomplete files.
https://reviews.llvm.org/D34607
Files:
clang/utils/bash-autocomplete.sh
Index: clang/utils/bash-autocomplete.sh
yamaguchi updated this revision to Diff 103884.
yamaguchi added a comment.
Update patch.
https://reviews.llvm.org/D34607
Files:
clang/utils/bash-autocomplete.sh
Index: clang/utils/bash-autocomplete.sh
===
--- clang/utils/bash-a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326684: [Bash-autocompletion] Pass all flags in shell
command-line to Clang (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
yamaguchi created this revision.
yamaguchi added reviewers: teemperor, v.g.vassilev.
--autocomplete flag now handles all the flags passed to shell, and this
implementation breaks backward compatibily before Clang 6.0.
https://reviews.llvm.org/D44191
Files:
clang/docs/ReleaseNotes.rst
Index:
yamaguchi updated this revision to Diff 137352.
yamaguchi added a comment.
Fixed typos
https://reviews.llvm.org/D44191
Files:
clang/docs/ReleaseNotes.rst
Index: clang/docs/ReleaseNotes.rst
===
--- clang/docs/ReleaseNotes.rst
++
This revision was automatically updated to reflect the committed changes.
Closed by commit rL326889: Add Clang ReleaseNotes that --autocomplete breaks
backward compatibily (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.l
yamaguchi created this revision.
yamaguchi added a reviewer: dlj.
Herald added a subscriber: llvm-commits.
Clang compiles and test passes without these includes.
Repository:
rL LLVM
https://reviews.llvm.org/D44508
Files:
clang/lib/Driver/Driver.cpp
Index: clang/lib/Driver/Driver.cpp
yamaguchi updated this revision to Diff 138671.
yamaguchi added a comment.
@marsupial Thanks for the commment, found a bug in my script and fixed. Now
this patch removes only includes which are not used in each TU.
Repository:
rL LLVM
https://reviews.llvm.org/D44508
Files:
clang/lib/Drive
yamaguchi created this revision.
yamaguchi added reviewers: rsmith, aprantl, bruno.
Reproducer and errors:
https://bugs.llvm.org/show_bug.cgi?id=37878
lookupModule was falling back to loadSubdirectoryModuleMaps when it couldn't
find ModuleName in (proper) search paths. This was causing iteration
yamaguchi updated this revision to Diff 152086.
yamaguchi added a comment.
Update commmit message and comment, add ObjC2
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Lex/HeaderSearch.cpp
Index: clang/lib/Lex/HeaderSearch.cpp
yamaguchi updated this revision to Diff 152240.
yamaguchi added a comment.
Add a test case
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Lex/HeaderSearch.cpp
clang/test/Modules/Inputs/autoload-subdirectory/a.h
clang/test/Modules/Inputs/autoload-sub
yamaguchi added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
yamaguchi created this revision.
yamaguchi added reviewers: teemperor, ruiu.
There was a bug that when a flag ends with '=' and no value was suggested,
clang autocompletes the flag itself.
For example, in bash, it looked like this:
$ clang -fmodule-file=[tab]
-> $clang -fmodule-file=-fmodule-
yamaguchi created this revision.
yamaguchi added reviewers: teemperor, ruiu.
Distinguish "--autocomplete=-someflag" and "--autocomplete=-someflag,"
because the latter indicates that the user put space before pushing tab
which should end up in a file completion.
https://reviews.llvm.org/D53639
F
yamaguchi updated this revision to Diff 170849.
yamaguchi added a comment.
Updated HasSpace, added comments, fixed typo in the commit message
https://reviews.llvm.org/D53639
Files:
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345133: [autocompletion] Handle the space before pressing
tab (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53639?vs
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345133: [autocompletion] Handle the space before pressing
tab (authored by yamaguchi, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53639?vs=170849&id=170856#toc
Repository:
rL L
yamaguchi closed this revision.
yamaguchi added a comment.
Landed in https://reviews.llvm.org/rL345121
https://reviews.llvm.org/D53589
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi created this revision.
yamaguchi added a reviewer: rsmith.
ReadASTBlock was allocating extra memory by resizing vector for all
record decls, and half of them stayed nullptr without being loaded. For
us this part was crucial and this patch had large amount of memory
improvement.
About cl
yamaguchi added a comment.
FYI, raw benchmarking data:
https://gist.github.com/yamaguchi1024/4f28406f51b413129cc762365fdd76c8
https://gist.github.com/yamaguchi1024/318b30db03adb10b7b230b706012a14c
https://reviews.llvm.org/D54097
___
cfe-commits mail
yamaguchi created this revision.
yamaguchi added reviewers: rsmith, v.g.vassilev.
This is a follow-up patch of
https://reviews.llvm.org/rL338503: [Modules] Do not emit relocation error when
-fno-validate-pch is set
File modification with modules is also fine for our usecase as we
want to reuse p
yamaguchi created this revision.
https://reviews.llvm.org/D36782 broke lld buildbots, because I've changed
OptionInfo's type
from ArrayRef to std::vector, so it became a copy, not a reference.
In this patch, I changed Table to static, so that it won't be freed
after the return. However, I'm not s
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311971: [Bash-autocompletion] Add support for -std=
(authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36820?vs=111804&id=113009#toc
Repository:
rL LLVM
https://reviews.llvm
yamaguchi abandoned this revision.
yamaguchi added a comment.
https://reviews.llvm.org/D37217 has already landed, so we don't need this
anymore.
https://reviews.llvm.org/D37203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
yamaguchi created this revision.
We wrote many codes in HandleImediateArgs, so I've refactored it into
handleAutocompletions.
https://reviews.llvm.org/D37249
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
Index: clang/lib/Driver/Driver.cpp
==
yamaguchi updated this revision to Diff 113027.
yamaguchi marked an inline comment as done.
yamaguchi added a comment.
Update diff. I agree that this is more generic.
https://reviews.llvm.org/D37249
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
Index: clang/lib/Dri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL312018: [Bash-autocomplete] Refactor autocomplete code into
own function (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D37249?vs=113027&id=113118#toc
Repository:
rL LLVM
yamaguchi accepted this revision.
yamaguchi added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks for the fix!
Repository:
rL LLVM
https://reviews.llvm.org/D37465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
yamaguchi created this revision.
yamaguchi added a reviewer: thakis.
Herald added a subscriber: mgorny.
Generate Checkers.inc also under include/clang/Driver so that we can
include this file from Driver/CC1Options.td without making Driver's
tablegen output depending on StaticAnalyzer/Checker's tab
yamaguchi created this revision.
yamaguchi added reviewers: rsmith, dblaikie.
Previous code was comparing the location of "modulemap which
is currently loaded and gives a definition of current module"
and "the location of the modulemap where the current implicit module was built".
This check was
yamaguchi added a comment.
We have both explicitly and implicitly prebuilt modules, but this patch only
relates to implicit ones. I agree that our usecase is a bit unique where we're
installing and distributing implicitly built pcm, but I also imagine there
might be a usecase where you built im
yamaguchi created this revision.
yamaguchi added reviewers: v.g.vassilev, rsmith, dblaikie, thakis.
We need to know if ASTReader already has a DeserializationListner or
not, and this also helps to create a multiplexing deserialization
listener if there is one already attached.
https://reviews.ll
yamaguchi added a comment.
Do you mean something like `addDeserializationListener` which create a
multiplex listener with an existing listener? I think that'll be good as well!
https://reviews.llvm.org/D45921
___
cfe-commits mailing list
cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330946: Add getDeserializationListener to ASTReader
(authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45921?vs=143441&id
yamaguchi added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
yamaguchi updated this revision to Diff 152664.
yamaguchi added a comment.
use %clang_cc1 instead of %clang
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/ModuleMap.h
clang/lib/Lex/HeaderSearch.cpp
clang/test/Modules/Inputs/autoload-subdirectory/a.h
clang/test/Modules/In
yamaguchi updated this revision to Diff 152875.
yamaguchi added a comment.
Add #import test and add branch AllowExtraModuleMapSearch when ModuleName was
from @import
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/HeaderSearch.h
clang/lib/Frontend/CompilerInstance.cpp
clan
yamaguchi added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
yamaguchi updated this revision to Diff 152876.
yamaguchi added a comment.
Delete a.out)
https://reviews.llvm.org/D48367
Files:
clang/include/clang/Lex/HeaderSearch.h
clang/lib/Frontend/CompilerInstance.cpp
clang/lib/Lex/HeaderSearch.cpp
clang/lib/Serialization/ASTReader.cpp
clang/tes
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336660: [modules] Fix 37878; Autoload subdirectory
modulemaps with specific LangOpts (authored by yamaguchi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://rev
yamaguchi created this revision.
clang/test/Driver/autocomplete.c is a test for --autocomplete, and this
test might break if people add/modify flags or HelpText. So I've add
comment for future developers so that they can fix this file according
to the change they had made.
https://reviews.llvm.o
yamaguchi updated this revision to Diff 109277.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36209
Files:
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
--- clang/test/Driver/a
yamaguchi added a comment.
@ruiu
This test will break for instance, when someone add new value to
mrelocation-model because values has to be shown in row 78- 83 order, or when
someone made a new flags which start with `-Wno-invalid-pp-` because in row 96
only -Wno-invalid-pp-token is expected
yamaguchi updated this revision to Diff 109281.
yamaguchi added a comment.
Modified comment.
https://reviews.llvm.org/D36209
Files:
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
--- clang/test/Dri
yamaguchi updated this revision to Diff 109283.
yamaguchi added a comment.
Fixed typo.
https://reviews.llvm.org/D36209
Files:
clang/test/Driver/autocomplete.c
Index: clang/test/Driver/autocomplete.c
===
--- clang/test/Driver/au
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309794: [Bash-autocompletion] Add comment to test so that it
is easier to fix (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36209?vs=109283&id=109285#toc
Repository:
rL
yamaguchi created this revision.
I thought we should add this information to release notes, because we
added a new flag to clang driver.
https://reviews.llvm.org/D36567
Files:
clang/docs/ReleaseNotes.rst
Index: clang/docs/ReleaseNotes.rst
This revision was automatically updated to reflect the committed changes.
Closed by commit rL310700: [Bash-autocompletion] Add --autocomplete flag to 5.0
release notes (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36567?vs=110518&id=110679#toc
Repository:
rL LLV
yamaguchi created this revision.
Herald added a subscriber: hiraditya.
This is a patch for clang autocomplete feature.
It will collect values which -analyzer-checker takes, which is defined in
clang/StaticAnalyzer/Checkers/Checkers.inc, dynamically.
First, from ValuesCode class in Options.td, Tab
yamaguchi updated this revision to Diff 111318.
yamaguchi marked 7 inline comments as done.
yamaguchi added a comment.
Update diff according to Raphael's comments.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test
yamaguchi updated this revision to Diff 111457.
yamaguchi marked 2 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test/Driver/autocomplete.c
llvm/in
yamaguchi added a comment.
@ruiu
I understand your concern. However by doing this (rather than building
functions for each flag), we will be able to get all information in OptTable
itself. It is true that this is quite fragile, but adding ValuesCode to new
flag is not complicated, so I believe
yamaguchi created this revision.
Add support for autocompleting values of -std= by including
LangStandards.def. This patch relies on https://reviews.llvm.org/D36782, and is
using two-stage
code generation.
https://reviews.llvm.org/D36820
Files:
clang/include/clang/Driver/Options.td
clang/t
yamaguchi updated this revision to Diff 111547.
yamaguchi marked 2 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test/Driver/autocomplete.c
llvm/in
yamaguchi updated this revision to Diff 111548.
yamaguchi added a comment.
const char* Values -> const char *Values
https://reviews.llvm.org/D36782
Files:
clang/include/clang/Driver/CC1Options.td
clang/lib/Driver/DriverOptions.cpp
clang/test/Driver/autocomplete.c
llvm/include/llvm/Optio
yamaguchi updated this revision to Diff 111549.
yamaguchi marked 2 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36820
Files:
clang/include/clang/Driver/Options.td
clang/test/Driver/autocomplete.c
llvm/utils/TableGen/OptParserEmitter.cpp
Inde
yamaguchi added inline comments.
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:314
for (const std::string &Pref : R.getValueAsListOfStrings("Prefixes")) {
-OS << "bool ValuesWereAdded = ";
+OS << "ValuesWereAdded = ";
OS << "Opt.addValues(";
yamaguchi updated this revision to Diff 111611.
yamaguchi marked 3 inline comments as done.
yamaguchi added a comment.
Update diff.
https://reviews.llvm.org/D36820
Files:
clang/include/clang/Driver/Options.td
clang/test/Driver/autocomplete.c
llvm/utils/TableGen/OptParserEmitter.cpp
Inde
yamaguchi added inline comments.
Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:319-320
OS << ", Values);\n";
OS << "(void)ValuesWereAdded;\nassert(ValuesWereAdded &&";
OS << " \"Couldn't add values to OptTable!\");\n";
}
r
yamaguchi updated this revision to Diff 111804.
yamaguchi added a comment.
Update diff. Thank you for your comments!
https://reviews.llvm.org/D36820
Files:
clang/include/clang/Driver/Options.td
clang/test/Driver/autocomplete.c
llvm/utils/TableGen/OptParserEmitter.cpp
Index: llvm/utils/T
yamaguchi added a comment.
@ruiu
I addressed your comments in https://reviews.llvm.org/D36820, so please take a
look at it. Thank you!
https://reviews.llvm.org/D36782
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
This revision was automatically updated to reflect the committed changes.
yamaguchi marked an inline comment as done.
Closed by commit rL311552: [Bash-autocompletion] Add support for static
analyzer flags (authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D36782?vs=11154
yamaguchi created this revision.
Previously, we passed "#" to --autocomplete to indicate to enable cc1
flags. For example, when -cc1 or -Xclang was passed to bash, bash
executed `clang --autocomplete=#-`.
However, this was not a good implementation because it depends -Xclang
and -cc1 parsing to s
yamaguchi added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:1171
+ StringRef TargetFlag = PassedFlags;
+ for (; TargetFlag.find(':') != StringRef::npos;) {
+StringRef CurFlag;
v.g.vassilev wrote:
> Why not a `while` loop?
I didn't have special
yamaguchi updated this revision to Diff 121444.
yamaguchi added a comment.
Herald added a subscriber: hiraditya.
Update diff. Pass all flags just with "," including values.
https://reviews.llvm.org/D39342
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
clang/test/Dr
yamaguchi updated this revision to Diff 121449.
yamaguchi added a comment.
Made a trivial fix in the testcase
https://reviews.llvm.org/D39342
Files:
clang/include/clang/Driver/Driver.h
clang/lib/Driver/Driver.cpp
clang/test/Driver/autocomplete.c
clang/utils/bash-autocomplete.sh
llvm/l
yamaguchi accepted this revision.
yamaguchi added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D40234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
yamaguchi updated this revision to Diff 93860.
yamaguchi added a comment.
Moved comment inside if (ExistingInit).
https://reviews.llvm.org/D31591
Files:
SemaInit.cpp
Index: SemaInit.cpp
===
--- SemaInit.cpp
+++ SemaInit.cpp
@@
yamaguchi updated this revision to Diff 93864.
yamaguchi added a comment.
Made unified diff for the testcase and SemaInit.cpp.
https://reviews.llvm.org/D31591
Files:
SemaInit.cpp
sema-segvcheck.c
Index: sema-segvcheck.c
===
-
yamaguchi updated this revision to Diff 94090.
yamaguchi added a comment.
Add relative path to the file.
https://reviews.llvm.org/D31591
Files:
clang/test/Sema/sema-segvcheck.c
lib/Sema/SemaInit.cpp
Index: clang/test/Sema/sema-segvcheck.c
==
yamaguchi updated this revision to Diff 95064.
yamaguchi added a comment.
I've been trying to minimal the testcase, add comments to describe what it is
testing, and fix styles of the testcase properly.
However, I don't have clear idea what will be the best. I would like to ask for
the advice.
yamaguchi added a comment.
I don't have a commit access. Can you commit?
https://reviews.llvm.org/D31591
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yamaguchi added a comment.
Doxygen couldn't handle @abs_srcsdir@/../ , so I changed it to @abs_arcdir@/..
in Diff 95410, then it worked OK.
Document will now show the path of #include "include/clang/Sema/Sema.h" .
https://reviews.llvm.org/D32113
__
yamaguchi updated this revision to Diff 95434.
yamaguchi added a comment.
It worked, and this code generates #include "Sema/Sema.h".
https://reviews.llvm.org/D32113
Files:
docs/doxygen.cfg.in
Index: docs/doxygen.cfg.in
===
---
yamaguchi added inline comments.
Comment at: docs/doxygen.cfg.in:158
+STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang
+STRIP_FROM_INC_PATH+= @abs_srcdir@/../include/clang-c
v.g.vassilev wrote:
> We should be stripping `@abs_srcdir@/../include` becau
yamaguchi updated this revision to Diff 95436.
yamaguchi added a comment.
This will generate #include "clang/Sema/Sema.h" .
https://reviews.llvm.org/D32113
Files:
docs/doxygen.cfg.in
Index: docs/doxygen.cfg.in
===
--- docs/doxy
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306555: [Bash-autocompletion] Check clang version in Bash
(authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34607?vs=103884&id=104435#toc
Repository:
rL LLVM
https://review
yamaguchi created this revision.
When user build clang and used completion Eg. `build/bin/clang
-fno[tab]`, we want to invoke `build/bin/clang --autocomplete=-fno`,
rather than `clang --autocomplete=-fno`.
https://reviews.llvm.org/D34761
Files:
clang/utils/bash-autocomplete.sh
Index: cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306559: [Bash-autocompletion] Invoke clang where user called
(authored by yamaguchi).
Changed prior to commit:
https://reviews.llvm.org/D34761?vs=104438&id=104439#toc
Repository:
rL LLVM
https://rev
yamaguchi created this revision.
Herald added a subscriber: hiraditya.
We don't want to autocomplete flags whose Flags class has `NoDriverOption` when
argv[1] is not `-cc1`.
Another idea for this implementation is to make --autocomplete a cc1
option and handle it in clang Frontend, by porting --
1 - 100 of 165 matches
Mail list logo
