[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

eopXD added inline comments. Comment at: clang/lib/Driver/Driver.cpp:660 + +if (RVArch == llvm::Triple::riscv64 && +ArchName.startswith_insensitive("rv32")) Do we need to throw error (or warning) when these two (`RVArch` and `ArchName`) don't match?

[PATCH] D126042: [RISCV][NFC] Remove `*=` operator for LMULType

eopXD created this revision. eopXD added reviewers: khchen, kito.cheng. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D126042: [RISCV][NFC] Remove `*=` operator for LMULType

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda201aa4242e: [RISCV][NFC] Remove `*=` operator for LMULType (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D136783: Pre-commit test case

eopXD created this revision. Herald added a project: All. eopXD requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136783 Files: clang/test/Parser/pragma-loop.cpp

[PATCH] D136784: [Clang] Improve diagnotisc message for loop hint pragma

eopXD created this revision. Herald added a project: All. eopXD requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Originally the loop hint is not displayed correctly in the diagnostic. This patch fixes it. Repository: rG LLVM

[PATCH] D136784: [Clang] Improve diagnotisc message for loop hint pragma

eopXD updated this revision to Diff 470913. eopXD added a comment. Trigger upon parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https://reviews.llvm.org/D136784 Files: clang/lib/Parse/ParsePragma.cpp clang/test/Parse

[PATCH] D136783: Pre-commit test case for D136784

eopXD updated this revision to Diff 471047. eopXD added a comment. Update to latest main. (Triggering CI again) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136783/new/ https://reviews.llvm.org/D136783 Files: clang/test/Parser/pragma-loop.cpp

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD updated this revision to Diff 471048. eopXD added a comment. Rebase upon latest main and simplify existing checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https://reviews.llvm.org/D136784 Files: clang/lib/Parse/ParsePragm

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); + if (Str == "loop") +return (llvm::Twine("clang loop ") + Option.getIdentifierInfo()->getName

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD updated this revision to Diff 471057. eopXD marked an inline comment as done. eopXD added a comment. Update code based on suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https://reviews.llvm.org/D136784 Files: clang/l

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); + if (Str == "loop") +return (llvm::Twine("clang loop ") + Option.getIdentifierInfo()->getName

[PATCH] D136783: Pre-commit test case for D136784

This revision was automatically updated to reflect the committed changes. Closed by commit rG97dcbd124d54: Pre-commit test case for D136784 (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136783/new/ https://reviews.llvm.org/D1367

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

eopXD updated this revision to Diff 471344. eopXD added a comment. Update code to handle when IdentifierInfo is null. The .Case syntax seems to evaulate expression in other non-trigger cases. The "loop" case was triggered for test case in loop unroll and jam, resulting in segmentation fault. Anywa

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

This revision was automatically updated to reflect the committed changes. Closed by commit rGbeb997799d82: [Clang] Improve diagnostic message for loop hint pragma (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https:/

[PATCH] D134407: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

eopXD created this revision. Herald added a project: All. eopXD requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. By draft of C23 (https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2912.pdf), the description for isless macro under 7.12.17.3 s

[PATCH] D134407: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10409bf86e58: [FPEnv] Remove inaccurate comments regarding signaling NaN for isless (authored by eopXD). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D134513: [RISCV][Clang] Replace all undef value with poison

eopXD created this revision. eopXD added reviewers: nlopes, khchen, craig.topper. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01,

[PATCH] D134513: [RISCV][Clang] Replace all undef value with poison

This revision was automatically updated to reflect the committed changes. Closed by commit rG75279aeecd1d: [RISCV][Clang] Replace all undef value with poison (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134513/new/ https://revi

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD created this revision. eopXD added reviewers: sdesmalen, paulwalker-arm, fhahn, reames, hfinkel. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabua

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. Please feel free to add appropriate reviewer to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 ___ cfe-commits mailing list

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD updated this revision to Diff 463261. eopXD added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeGen/CGLoopInfo.

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD marked an inline comment as done. eopXD added a comment. After this patch, we can remove setVectorizeWidth(1) and setInterleaveCount(1) when vectorize(disable) and interleave(disable) is specified. For now it is not removed to keep the patch limited and simple enough. Repository: rG LL

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD updated this revision to Diff 463299. eopXD added a comment. Fix grammar error in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 Files: clang/lib/CodeGen/CGLoopInfo.cpp clang/lib/CodeG

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

eopXD added a comment. I see that this revision is reverted along with reversion of D128143 , I see that D128143 is re-commited. The commit message of D128143 says that it depends on this pat

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

eopXD added a comment. Please disregard my previous comment, I missed the latest commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128142/new/ https://reviews.llvm.org/D128142 ___ cfe-commits mailing

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. Gentle ping, thank you ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. @fhahn Thank you very much for the review, backward compatibility is a good point. I will update the revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134745/new/ https://reviews.llvm.org/D134745 _

[PATCH] D134745: [LV][Metadata] Add loop.interleave.enable for loop vectorizer

eopXD added a comment. Hi @fhahn, After a second thought, I think posting a clear RFC [0] to the community that defines the problem and goal this patch tries to achieve so the community is notified of such change is a better approach than directly updating this patch. Please consider to drop b

[PATCH] D135519: [RISCV] Remove some vsetvli intrinsics under Zve32*.

eopXD accepted this revision. eopXD added a comment. This revision is now accepted and ready to land. Looks good to me. I think this should solve https://github.com/riscv/riscv-v-spec/issues/832. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135519

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

eopXD added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:772 + + if ((Exts.count("zvkb") || Exts.count("zvknhb")) && !Exts.count("zve64x")) +return createStringError( With this check, the check for these extensions on top are redundant. =

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

eopXD added inline comments. Comment at: llvm/test/MC/RISCV/rvv/rv64zvksed_invalid.s:1 +# RUN: not llvm-mc -triple=riscv64 --mattr=+zve32x --mattr=+experimental-zvksed -show-encoding %s 2>&1 \ +# RUN:| FileCheck %s --check-prefix=CHECK-ERROR I see simila

[PATCH] D139025: [NFC][RISCV] Extract utility to calculate value through MajorVersion and MinorVersion

This revision was automatically updated to reflect the committed changes. Closed by commit rG1953c7e03b08: [NFC][RISCV] Extract utility to calculate value through MajorVersion and… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D140389: [NFC][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D140389: [NFC][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD added a comment. Just throwing out the question here, I would be happy to rename it to anything else that makes sense rather than the current. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 __

[PATCH] D140389: [NFC][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD updated this revision to Diff 484758. eopXD added a comment. Rebase upon latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 Files: clang/include/clang/Basic/riscv_vector.td clang/inclu

[PATCH] D140661: [NFC][Clang] Reduce for-loop with SmallVectorUtility

eopXD created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb. Herald added a project: All. eopXD r

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, khchen. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer

[PATCH] D140661: [NFC][Clang][RISCV] Reduce for-loop with SmallVector utility

This revision was automatically updated to reflect the committed changes. Closed by commit rG904a79f99153: [NFC][Clang][RISCV] Reduce for-loop with SmallVector utility (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140661/new/ ht

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485270. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140662/new/ https://reviews.llvm.org/D140662 Files: clang/include/clang/Basic/riscv_vector.td Index: clang/i

[PATCH] D140389: [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD updated this revision to Diff 485310. eopXD added a comment. Rebae to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 Files: clang/include/clang/Basic/riscv_vector.td clang/include/

[PATCH] D140389: [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD updated this revision to Diff 485311. eopXD added a comment. Change: Recover mis-deleted lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 Files: clang/include/clang/Basic/riscv_vector.td c

[PATCH] D140389: [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

eopXD updated this revision to Diff 485312. eopXD added a comment. Recover mis-deleted lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140389/new/ https://reviews.llvm.org/D140389 Files: clang/include/clang/Basic/riscv_vector.td clang/inc

[PATCH] D140389: [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs'

This revision was automatically updated to reflect the committed changes. Closed by commit rG1deb6bce8931: [NFC][Clang][RISCV] Rename data member 'DefaultPolicy' to 'PolicyAttrs' (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1403

[PATCH] D140686: [Clang][RISCV] Update operand order for vmerge and vcompress

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD added a comment. This patch is not ready yet since currently we don't have a pull request under rvv-intrinsic-doc to match to this. The pull request will be created in the near future. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vcompress.c:514 // CH

[PATCH] D140687: [Clang][RISCV] Use poison instead of undef

eopXD created this revision. eopXD added reviewers: kito-cheng, nlopes, craig.topper, khchen. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck

[PATCH] D140678: [RISCV][WIP] Use SmallVector::append to replace some for loops in intrinsic creation. NFC

eopXD accepted this revision. eopXD added a comment. This revision is now accepted and ready to land. Thank you for the patch. We can land this and then I have D140662 rebase upon it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD updated this revision to Diff 485363. eopXD added a comment. Update code, recovered ManualCodeGen for vcompress and vmerge. Deleted the `std::rotate` since it is not needed now due to the operand order change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vcompress.c:514 // CHECK-RV64-NEXT: entry: -// CHECK-RV64-NEXT:[[TMP0:%.*]] = call @llvm.riscv.vcompress.nxv1i32.i64( poison, [[SRC:%.*]], [[MASK:%.*]], i64 [[VL:%.*]]) -// CHEC

[PATCH] D140687: [Clang][RISCV] Use poison instead of undef

eopXD updated this revision to Diff 485371. eopXD added a comment. Update leftout test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140687/new/ https://reviews.llvm.org/D140687 Files: clang/test/CodeGen/RISCV/riscv-attr-builtin-alias.c

[PATCH] D140687: [Clang][RISCV] Use poison instead of undef

This revision was automatically updated to reflect the committed changes. Closed by commit rG1972fb23cb36: [Clang][RISCV] Use poison instead of undef (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140687/new/ https://reviews.llvm

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485589. eopXD added a comment. Update code based on landing of D140678 . The motivation of this NFC patch comes from the struggle while I was tracing through them. I think the scattered comments of boilerplates with only some

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485604. eopXD marked 2 inline comments as done. eopXD edited the summary of this revision. eopXD added a comment. Update comment section for segment load. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140662/new/

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485606. eopXD added a comment. Update comment section: remove mis-indented indents. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140662/new/ https://reviews.llvm.org/D140662 Files: clang/include/clang/Basic/r

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2bec8702688: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment… (authored by eopXD). Repository: rG LLVM Github Monor

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD updated this revision to Diff 485961. eopXD added a comment. Update test cases for vfmerge. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140686/new/ https://reviews.llvm.org/D140686 Files: clang/include/clang/Basic/riscv_vector.td clang

[PATCH] D140895: [WIP][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D140936: [WIP][2/6][RISCV][Clang] Remove default tail-undisturbed for vslideup intrinsics

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D140937: [WIP][3/6][Clang][RISCV] Remove default tail-undisturbed for vslidedown intrinsics

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D140937: [WIP][3/6][Clang][RISCV] Remove default tail-undisturbed for vslidedown intrinsics

eopXD updated this revision to Diff 486137. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140937/new/ https://reviews.llvm.org/D140937 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D140941: [WIP][4/6][Clang][RISCV] Remove default tail-undisturbed for multiply-add intrinsics

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D140954: [WIP][7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

eopXD created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sab

[PATCH] D140954: [WIP][7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

eopXD updated this revision to Diff 486170. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140954/new/ https://reviews.llvm.org/D140954 Files: clang/include/clang/Basic/riscv_vector.td clang/include/clang/Support

[PATCH] D140954: [WIP][7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

eopXD updated this revision to Diff 486174. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140954/new/ https://reviews.llvm.org/D140954 Files: clang/include/clang/Basic/riscv_vector.td clang/include/clang/Support

[PATCH] D141032: [Clang][RISCV] Expose vlenb to vread_csr

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, frasercrmck. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edwa

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD added a comment. Upon a second thought, with future extensions of the intrinsics, we will add rounding mode and exception intrinsics. The exposure of vxsat, vxrm, and vcsr in vread_csr and vwrite_csr will confuse user and we should remove them. Furthermore, vstart is pretty much always ke

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD updated this revision to Diff 486486. eopXD edited the summary of this revision. eopXD added a comment. Update code. Add function `vlenb` instead of extending inside the `vread_csr` function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1410

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1559 __asm__ __volatile__ ("csrw\tvcsr, %z0" : : "rJ"(__value) : "memory"); break; } pcwang-thead wrote: > Should we report

[PATCH] D141198: [NFC][Clang][RISCV] Reorganize test case for rvv intrinsics

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, frasercrmck, reames, jrtc27. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, Mar

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD updated this revision to Diff 487094. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https://reviews.llvm.org/D141198 Files: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/no

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD added a comment. The testing time difference is shown below. I personally think 3 more minutes in testing is tolerable when considering `check-all`. The testing time increase comes from full test coverage to the intrinsics. Before this patch, some test cases only includes parts of the {SE

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD added a comment. The patch application failure probably is due to the large amount of changes in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https://reviews.llvm.org/D141198

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD added a comment. I have created a branch under my forked repo. for people to checkout this commit conveniently. https://github.com/eopXD/llvm-project/tree/reorganize-testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https:/

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD updated this revision to Diff 487194. eopXD added a comment. Rebase upon D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140686/new/ https://reviews.llvm.org/D140686 Files: clang/include/clang/Basi

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD updated this revision to Diff 487206. eopXD marked an inline comment as not done. eopXD added a comment. Update code. Apply suggestion from @pcwang-thead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141032/new/ https://reviews.llvm.org/D141

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD marked 2 inline comments as done. eopXD added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1565 + unsigned long __rv = 0; + __asm__ __volatile__ ("csrr\t%0, vlenb" : "=r"(__rv) : : "memory"); + return __rv; pcwang-thead wrote: >

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD updated this revision to Diff 487293. eopXD marked 5 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141032/new/ https://reviews.llvm.org/D141032 Files: clang/inclu

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

eopXD updated this revision to Diff 487302. eopXD added a comment. Update code: Avoid emit clang version in test case. @pcwang-thead Thank you for checking and providing the corresponding resolution. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD updated this revision to Diff 487317. eopXD edited the summary of this revision. eopXD added a comment. Update test cases. Don't add target feature `zfh` and `zvfh` for intrinsics that does not have a floating-point type variant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD updated this revision to Diff 487683. eopXD added a comment. Address comment from Craig. Also separate test case according to their mnemonics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https://reviews.llvm.org/D141198 Files:

[PATCH] D141032: [Clang][RISCV] Expose vlenb to user

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96b52c1eec7b: [Clang][RISCV] Expose vlenb to user (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD updated this revision to Diff 488055. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https://reviews.llvm.org/D141198 Files: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/no

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

eopXD updated this revision to Diff 488061. eopXD added a comment. Recover mis-deleted handcrafted test case for vmulh, vmulhu, and vmulhsu on e8 ~ e64 with zve32x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141198/new/ https://reviews.llvm.org

[PATCH] D141198: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9f75827fedb: [Clang][RISCV][NFC] Reorganize test case for rvv intrinsics (authored by eopXD). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D140686: [WIP][Clang][RISCV] Update operand order for vmerge and vcompress

eopXD updated this revision to Diff 488093. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140686/new/ https://reviews.llvm.org/D140686 Files: clang/in

[PATCH] D140895: [1/7][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

eopXD updated this revision to Diff 488140. eopXD edited the summary of this revision. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140895/new/ https://

[PATCH] D140936: [2/7][Clang][RISCV] Remove default tail-undisturbed for vslideup intrinsics

eopXD updated this revision to Diff 488144. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140936/new/ https://reviews.llvm.org/D140936 Files: clang/in

[PATCH] D140941: [4/7][Clang][RISCV] Remove default tail-undisturbed for multiply-add intrinsics

eopXD updated this revision to Diff 488150. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140941/new/ https://reviews.llvm.org/D140941 Files: clang/in

[PATCH] D140942: [5/7][Clang][RISCV] Remove default tail-undisturbed for vcompress intrinsics

eopXD updated this revision to Diff 488152. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140942/new/ https://reviews.llvm.org/D140942 Files: clang/in

[PATCH] D140947: [6/7][Clang][RISCV] Remove default tail-undisturbed for vmv_s_x and vfmv_s_f intrinsics

eopXD updated this revision to Diff 488156. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140947/new/ https://reviews.llvm.org/D140947 Files: clang/in

[PATCH] D140954: [7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

eopXD updated this revision to Diff 488157. eopXD added a comment. Rebase on top of landing of D141198 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140954/new/ https://reviews.llvm.org/D140954 Files: clang/in

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD created this revision. eopXD added a reviewer: SjoerdMeijer. Herald added a project: All. eopXD requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. This change allows extension of new categories be aware of adding more code h

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD added a comment. Upon additional modification to this code base I am tempt to prefer having a `NumberOfCategories` under the enum and make the sanity check explicit. I understand this is totally a problem of personal taste so definitely feel free to argue with me :) Repository: rG LLV

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD updated this revision to Diff 475043. eopXD marked 3 inline comments as done. eopXD added a comment. Address comments from reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://reviews.llvm.org/D137570 Files: clang/l

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD updated this revision to Diff 475044. eopXD added a comment. Minor update in comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://reviews.llvm.org/D137570 Files: clang/lib/Sema/SemaStmtAttr.cpp Index: clang/lib/Sem

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD added a comment. @mikerice @jyu2 May you accept the revision please if this patch looks good to you? Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://reviews.llvm.org/D137570

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

eopXD updated this revision to Diff 475563. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://reviews.llvm.org/D137570 Files: clang/lib/Sema/SemaStmtAttr.cpp Index: clang/lib/Sema/S

[PATCH] D137570: [Clang][Sema] Refactor category declaration under CheckForIncompatibleAttributes. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6dee23919a36: [Clang][Sema] Refactor category declaration under… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137570/new/ https://revi

[PATCH] D141756: [6/15][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecbf5db88d28: [6/15][Clang][RISCV][NFC] Instructions with a mask destination register is… (authored by eopXD). Changed prior to commit: https://re

[PATCH] D141759: [7/15][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a16e1ff7d27: [7/15][Clang][RISCV][NFC] Correct the default value for Policy to TAMU (authored by eopXD). Changed prior to commit: https://reviews

  1   2   3   4   5   6   >