[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan edited the summary of this revision. zyounan added reviewers: hokein, sammccall, nridge. zyounan published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 493081. zyounan added a comment. Do not format inc file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang-tools-extra/clangd/index/CanonicalIncludes.cpp

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan updated this revision to Diff 493195. zyounan added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142836/new/ https://reviews.llvm.org/D142836 Files: clang-tools-extra/clangd/index/CanonicalIncludes.cpp clang-tools-ex

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. Another question is that file `clang/Tooling/Inclusions/StdSymbolMap.inc` seems to be out-of-date. What's worse, the archive of cppref doesn't always update on time The latest version from official is published in 201

[PATCH] D142836: [clangd] Add symbol mappings for `std::experimental::filesystem`

zyounan added a comment. In D142836#4089721 , @kadircet wrote: > And to follow up, I definitely see the problem you're facing and it's > something we'd like to address as well, just not in the way you proposed. > > This falls under the bucket of "we migh

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan updated this revision to Diff 494815. zyounan added a comment. zyounan updated this revision to Diff 494816. zyounan added reviewers: hokein, sammccall, kadircet, nridge. zyounan publis

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan updated this revision to Diff 494911. zyounan added a comment. Herald added a subscriber: ormris. Update tests && Use Preprocessor.LookupFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files:

[PATCH] D143319: [clangd] Support iwyu pragma: no_include

zyounan updated this revision to Diff 494921. zyounan added a comment. Fix test on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143319/new/ https://reviews.llvm.org/D143319 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan marked 3 inline comments as done. zyounan added a comment. Thank you guys again for the long and meticulous review! :) For a quick note, here are points I've excerpted from Nathan's reviews that need improvements later: 1. Implement a heuristic that works for function template pointers

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 557441. zyounan added a comment. Address nits; discard default template parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang/include/clang/Sema/S

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 557442. zyounan added a comment. Sorry, wrong patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-e

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 557443. zyounan added a comment. Fix the CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/cla

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

This revision was automatically updated to reflect the committed changes. Closed by commit rG23ef8bf9c0f3: [clangd][CodeComplete] Improve FunctionCanBeCall (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://revi

[PATCH] D155370: [CodeComplete] Don't emit parameters when not FunctionCanBeCall

zyounan updated this revision to Diff 543277. zyounan added a comment. Don't change the CCR. Handle these in CreateCodeCompletionString. Emit template arguments if possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155370/new/ https://reviews

[PATCH] D155370: [CodeComplete] Don't emit parameters when not FunctionCanBeCall

zyounan updated this revision to Diff 543280. zyounan added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155370/new/ https://reviews.llvm.org/D155370 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra/clangd/

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Thanks for the insightful suggestions! (Apologies for my late update. Just had a really busy week.) As suggested, I left the CCR intact and handled these functions in `CodeCompletionResult::createCodeCompletionStringForDecl`. I think this preserves the Declaration, righ

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1407 R.FunctionCanBeCall = CurrentClassScope && The current heuristic results in the following: ``` struct Base { void foo(int); }; struct Derived : Base { voi

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan created this revision. zyounan added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is a

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 544252. zyounan added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd/un

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan created this revision. zyounan added reviewers: saar.raz, erichkeane, ilya-biryukov, aaron.ballman. Herald added a subscriber: kadircet. Herald added a project: All. zyounan published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're exp

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 550683. zyounan added a comment. Rebase and format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/include/clang/AST/ExprConcepts.h clang/lib/Sema/Se

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 550713. zyounan added a comment. Adapt to D157554 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/include/clang/AST/

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:9079 +auto *IDC = TC->getImmediatelyDeclaredConstraint(); +assert(IDC && "ImmediatelyDeclaredConstraint can't be null here."); +ExprResult Constraint = SubstExpr(IDC, MLTAL); I'

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 551723. zyounan marked 14 inline comments as done. zyounan added a comment. Address many comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tool

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Thanks for Sam and Nathan's thorough review! I've updated, and please take another look. (Apologize for churning on weekends, but I don't have chunk time during the week.) Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:258 case Co

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 551726. zyounan added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprC

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 551728. zyounan added a comment. Rebase and Remove the stray status Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst clang/inclu

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 551730. zyounan added a comment. Fix the bool expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-t

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 551736. zyounan added a comment. Sorry, forgot to update tests :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan added a comment. Ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan added a comment. Oops, my apologies for bothering you. Thanks again for the explanation and your dedication! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 __

[PATCH] D156605: [CodeComplete] Mark 'Derived().Base::foo()' CanBeCall

zyounan created this revision. zyounan added reviewers: sammccall, nridge, hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan published this revision for review. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. This re

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1407 R.FunctionCanBeCall = CurrentClassScope && zyounan wrote: > The current heuristic results in the following: > > ``` > struct Base { > void foo(int); > }; >

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 545920. zyounan marked 2 inline comments as done. zyounan added a comment. Herald added a project: clang. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 545922. zyounan added a comment. Fix the chaos in the previous update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan added a comment. Sorry, looks like I messed up with the commits before. Fixed it now. Comment at: clang-tools-extra/clangd/InlayHints.cpp:207 + + // This is a bit tricky: we traverse the type structure and find whether or + // not a type in the desugaring process is o

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. In D155370#4545763 , @nridge wrote: > (e.g. maybe you're looking for one with a particular parameter type). I understand the second point that it'd be nice to offer the user a chance to see the arguments in order to help decide

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 546007. zyounan added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd/unittes

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

zyounan updated this revision to Diff 546008. zyounan added a comment. Final update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156300/new/ https://reviews.llvm.org/D156300 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/cla

[PATCH] D156300: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1193c13a5f9: [clangd] Avoid unexpected desugaring in isSugaredTemplateParameter (authored by zyounan). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan planned changes to this revision. zyounan added a comment. In D155370#4552967 , @nridge wrote: > I was thinking of functions with different names (with a common prefix) and > different signatures, where the signature could be a useful piece of >

[PATCH] D156605: [CodeComplete] Mark 'Derived().Base::foo()' CanBeCall

zyounan updated this revision to Diff 547566. zyounan added a comment. Merge changes with function templates from D155370 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

zyounan abandoned this revision. zyounan added a comment. Closing this in favor of D156605 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155370/new/ https://reviews.llvm.org/D155370 _

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 547569. zyounan added a comment. Trigger the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-ex

[PATCH] D158926: [clangd] Show parameter hints for operator()

zyounan marked 2 inline comments as done. zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:626 + Method && Method->isInstance()) +Args = Args.drop_front(1); +processCall(Callee, Args); nridge wrote: > Huh, th

[PATCH] D158926: [clangd] Show parameter hints for operator()

zyounan updated this revision to Diff 556358. zyounan marked an inline comment as done. zyounan added a comment. Address a nit comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158926/new/ https://reviews.llvm.org/D158926 Files: clang-tools-

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3577 // containing all of the arguments up to the first deducible argument. + // Or, if this isn't a call, emit all the template arguments + // to disambiguate the (potential) overload

[PATCH] D158926: [clangd] Show parameter hints for operator()

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbd6ac6165e6: [clangd] Show parameter hints for operator() (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158926/new/ https://reviews.

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan updated this revision to Diff 556909. zyounan marked 2 inline comments as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 Files: clang-tools-extra

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Thank you Nathan for your constructive opinions! I've updated this patch again, hopefully this becomes better. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1387 - // When completing a non-static member function (and not via - // dot/arrow member

[PATCH] D155370: [CodeComplete] Don't emit parameters when not FunctionCanBeCall

zyounan created this revision. zyounan added reviewers: nridge, tom-anders, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan added a comment. zyounan updated this revision to Diff 540687. zyounan published this revision for review. Herald added projects:

[PATCH] D158926: [clangd] Show parameter hints for operator()

zyounan created this revision. zyounan added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Closes ht

[PATCH] D156605: [clangd][CodeComplete] Improve FunctionCanBeCall

zyounan added a comment. Gently ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156605/new/ https://reviews.llvm.org/D156605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added a comment. Gently ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan created this revision. zyounan added reviewers: sammccall, nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a comment. > `clang::ParseAST` or `ASTFrontendAction::ExecuteAction` look like good > candidates to me. We had already placed the initialization in ASTFrontendAction::ExecuteAction

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a subscriber: rsmith. zyounan added a comment. Thanks for the reply. And I understand (and agree with) the point that it's better to solve this problem once and for all. > Currently the code in CompilerInstance::ExecuteAction seems to acknowledge > that there should be a fallback.

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan added a comment. > According to documentation of noteBottomOfStack, those should be tied to > thread creation, i.e. main and AsyncTaskRunner are two most common entry > points for threads that do parsing. Yeah, I was about to put this call there. But they both boil down to the single `

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan updated this revision to Diff 554279. zyounan added a comment. Herald added a project: clang. Adopt the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files: clang-tools-extra/clangd/

[PATCH] D158967: [clangd] Record the stack bottom before building AST

zyounan updated this revision to Diff 554283. zyounan added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd/support/

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan added a comment. @ilya-biryukov I've updated the patch following your suggestion. PTAL, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 ___ cfe-

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 554285. zyounan added a comment. Oops, something went wrong accidently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files: clang-tools-extra/clangd/support/Thre

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 554674. zyounan marked an inline comment as done. zyounan added a comment. Address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files: clang-tools-extra/

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan added a comment. Thanks again for Richard and Sam's comments! (I didn't add another lit test for asynchronous case since it essentially works the same as the synchronous one. Hope this isn't harmful.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 554914. zyounan marked an inline comment as done. zyounan added a comment. Expand diagnostics in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: cl

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan added a comment. Thanks for the review! Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:26 +// Consume remaining notes/errors. +// expected-note@* 0+{{}} +// expected-error@* 0+{{}} erichkeane wrote: > Please don't do this, actually write

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 554919. zyounan added a comment. Rebase to main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprCon

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan updated this revision to Diff 555277. zyounan marked an inline comment as done. zyounan added a comment. Address one last nit comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158061/new/ https://reviews.llvm.org/D158061 Files: clan

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

zyounan marked an inline comment as done. zyounan added a comment. Thanks again for the review! Comment at: clang/test/SemaCXX/concept-crash-on-diagnostic.cpp:28 + +// expected-error@#1 {{no member named 'value' in 'is_convertible'}} + erichkeane wrote: > So I

[PATCH] D158061: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fd01d75a863: [clang] Construct ExprRequirement with SubstitutionDiagnostic on SubstFailure (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 555356. zyounan added a comment. Herald added a subscriber: javed.absar. Disperse the call over clangd tasks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files:

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan added a comment. Thanks! I hope I'm getting things right. Specifically, 1. `UpdateIndexCallbacks::indexStdlib()::Task` in `ClangdServer.cpp` 2. `PreambleThread::run()`, `ASTWorker::run()` and `TUScheduler::runWithPreamble()::Task` in `TUScheduler.cpp` 3. The lambda of `runAsync` in `Back

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

zyounan updated this revision to Diff 77. zyounan marked an inline comment as done. zyounan added a comment. Remove the stray header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158967/new/ https://reviews.llvm.org/D158967 Files: clang-tool

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe257c0a91906: [clang][clangd] Ensure the stack bottom before building AST (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 505420. zyounan marked 3 inline comments as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 Files: clang-tools-extra

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added a comment. Updated now. Thank you again for your patient review. :) Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:213 ++SnippetArg; - if (SnippetArg == CursorSnippetArg) { + if (ShouldPatchPlaceholder0 && SnippetArg == CursorSnipp

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 506001. zyounan marked an inline comment as done. zyounan added a comment. Add description to shouldPatchPlaceholder0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:60 +bool shouldPatchPlaceholder0(CodeCompletionResult::ResultKind ResultKind, + CXCursorKind CursorKind) { nridge wrote: > nit: let's add a

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

This revision was automatically updated to reflect the committed changes. Closed by commit rG138adb098032: [clangd] Refine logic on $0 in completion snippets (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://re

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This patch adapts to D140059

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan updated this revision to Diff 508316. zyounan added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146874/new/ https://reviews.llvm.org/D146874 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/un

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan marked 2 inline comments as done. zyounan added a comment. Thank you! Comment at: clang-tools-extra/clangd/Hover.cpp:396 // -2=> 0xfffe -// -2^32 => 0xfffe +// -2^32 => 0x static llvm::FormattedNumber printHex(const llvm::APSInt &V)

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

zyounan updated this revision to Diff 508401. zyounan marked an inline comment as done. zyounan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146874/new/ https://reviews.llvm.org/D146874 Files: clang-tools-extra

[PATCH] D146874: [clangd] Fix a hover crash on unsigned 64bit value

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b103edf5b2c: [clangd] Fix a hover crash on unsigned 64bit value (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146874/new/ https://re

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan updated this revision to Diff 500387. zyounan marked an inline comment as done. zyounan added a comment. Address the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144074/new/ https://reviews.llvm.org/D144074 Files: clang-tools-e

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan added inline comments. Comment at: clang-tools-extra/clangd/InlayHints.cpp:520 auto ExprStartLoc = SM.getTopMacroCallerLoc(E->getBeginLoc()); -auto Decomposed = SM.getDecomposedLoc(ExprStartLoc); +auto Decomposed = SM.getDecomposedExpansionLoc(ExprStartLoc);

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

zyounan updated this revision to Diff 500388. zyounan added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144074/new/ https://reviews.llvm.org/D144074 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd/un

[PATCH] D144074: [clangd] Hide inlay hints when using a macro as a calling argument that with a param comment

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb2d04d41e47: [clangd] Hide inlay hints when using a macro as a calling argument that with a… (authored by zyounan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan added reviewers: nridge, kadircet. zyounan published this revision for review. zyounan added inline comments. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 504947. zyounan marked 3 inline comments as done. zyounan added a comment. Address the comments. Revise parameters of `getSignature` to avoid passing CCR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:441 getSignature(*SemaCCS, &S.Signature, &S.SnippetSuffix, - &Completion.RequiredQualifier, IsPattern); + &Completion.RequiredQualifier, IsPattern, C.Se

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan updated this revision to Diff 504950. zyounan added a comment. Update doxygen comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145319/new/ https://reviews.llvm.org/D145319 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-to

[PATCH] D145319: [clangd] Refine logic on $0 in completion snippets

zyounan added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.h:45 /// /// When \p CompletingPattern is true, the last placeholder will be of the form /// ${0:…}, indicating the cursor should stay there. Sorry, I forget to revise th

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan created this revision. zyounan added reviewers: royjacobson, aaron.ballman, erichkeane, shafik. Herald added a project: All. zyounan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a follow-up patch to D126194

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan added inline comments. Comment at: clang/docs/ReleaseNotes.rst:524 crash when we encounter a unresolved TypoExpr during diagnostic emission. - (`#50244 _`). + (`#50244

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534359. zyounan added a comment. And this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp clan

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534362. zyounan added a comment. Typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp clang/te

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534386. zyounan added a comment. Simplify test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.

[PATCH] D153724: [clang] Fix a crash on invalid destructor

zyounan updated this revision to Diff 534387. zyounan added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153724/new/ https://reviews.llvm.org/D153724 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaDeclCXX.cpp clang/test/

  1   2   >