yaxunl added a comment.
We need to discuss the layout of the header file.
For the builtin functions, I plan to follow the order of the spec and extension
spec. If there are difference in 1.2 and 2.0, use condition macro.
For functions with double or half arguments, we have two options:
1. keep
Author: yaxunl
Date: Tue Apr 12 10:46:24 2016
New Revision: 266083
URL: http://llvm.org/viewvc/llvm-project?rev=266083&view=rev
Log:
Verify commit right by adding a blank line to
test/CodeGenOpenCL/address-spaces-conversions.cl.
Modified:
cfe/trunk/test/CodeGenOpenCL/address-spaces-conversio
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266107: [OpenCL] Handle AddressSpaceConversion when target
address space does not… (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D18713?vs=52800&id=53439#toc
Repository:
rL L
Author: yaxunl
Date: Tue Apr 12 14:03:49 2016
New Revision: 266107
URL: http://llvm.org/viewvc/llvm-project?rev=266107&view=rev
Log:
[OpenCL] Handle AddressSpaceConversion when target address space does not
change.
In codegen different address spaces may be mapped to the same address
space for a
Author: yaxunl
Date: Tue Apr 12 14:43:36 2016
New Revision: 266111
URL: http://llvm.org/viewvc/llvm-project?rev=266111&view=rev
Log:
PR19957: [OpenCL] Incorrectly accepts implicit address space conversion with
ternary operator.
Generates addrspacecast instead of bitcast for ternary operator when
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rL266111: PR19957: [OpenCL] Incorrectly accepts implicit
address space conversion with… (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D174
Author: yaxunl
Date: Tue Apr 12 15:22:32 2016
New Revision: 266117
URL: http://llvm.org/viewvc/llvm-project?rev=266117&view=rev
Log:
Pass -backend-option to LLVM when there is no target machine.
Clang should pass -backend-option to LLVM even though there is no target
machine, since LLVM passes a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266117: Pass -backend-option to LLVM when there is no target
machine. (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D17552?vs=51326&id=53449#toc
Repository:
rL LLVM
http://r
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader, pxli168.
yaxunl added subscribers: tstellarAMD, cfe-commits.
OpenCL spec 1.2/2.0 requires `__OPENCL_C_VERSION__` to be defined based on
-cl-std option. This patch implements that.
OpenCL spec 1.0/1.1 does not have a predefin
yaxunl added inline comments.
Comment at: lib/Frontend/InitPreprocessor.cpp:421
@@ +420,3 @@
+switch (LangOpts.OpenCLVersion) {
+case 0:
+case 100:
pxli168 wrote:
> What is 0 stand for as OpenCLVersion, it seems the default OpenCLVersion if
> we did n
yaxunl marked 4 inline comments as done.
Comment at: lib/Headers/opencl.h:13721-13726
@@ +13720,8 @@
+
+/**
+ * Queue a memory fence to ensure correct ordering of memory
+ * operations between work-items of a work-group to
+ * image memory.
+ */
+#define CLK_IMAGE_MEM_FENCE 0x04
yaxunl marked 8 inline comments as done.
Comment at: lib/Headers/opencl.h:11-13
@@ +10,5 @@
+
+#if !defined(__SPIR32__) && !defined(__SPIR64__)
+#error "This header file should be used with SPIR target only."
+#endif
+
tstellarAMD wrote:
> This should be removed s
yaxunl marked 4 inline comments as done.
Comment at: lib/Headers/opencl.h:15636-15637
@@ +15635,4 @@
+#if defined(__OPENCL_C_VERSION__) && __OPENCL_C_VERSION__ >= 200
+#define PIPE_RESERVE_ID_VALID_BIT (1U << 30)
+#define CLK_NULL_RESERVE_ID
(__builtin_astype(((void*)(~PIPE_RESER
yaxunl marked 6 inline comments as done.
Comment at: lib/Frontend/InitPreprocessor.cpp:426
@@ +425,3 @@
+case 110:
+ Builder.defineMacro("__CLANG_OPENCL_C_VERSION__", "110");
+ break;
Anastasia wrote:
> So why we can't use unified __OPENCL_C_VERSION_
yaxunl marked 7 inline comments as done.
Comment at: lib/Frontend/InitPreprocessor.cpp:421
@@ +420,3 @@
+switch (LangOpts.OpenCLVersion) {
+case 0:
+case 100:
yaxunl wrote:
> pxli168 wrote:
> > What is 0 stand for as OpenCLVersion, it seems the default
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 54243.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Added __OPENCL_C_VERSION__ and CL_VERSION_X_Y for all OpenCL versions.
Also fixed the test using -std=c99 for OpenCL and limit allowed languag
yaxunl updated this revision to Diff 54404.
yaxunl added a comment.
Fix test/preprocessor/predefined_macros.c.
Merge test/frontend/std.cl into langstd.c since they are similar.
http://reviews.llvm.org/D19071
Files:
lib/Frontend/CompilerInvocation.cpp
lib/Frontend/InitPreprocessor.cpp
tes
yaxunl updated this revision to Diff 54552.
yaxunl added a comment.
Revised as Anastasia suggested.
http://reviews.llvm.org/D19071
Files:
lib/Frontend/CompilerInvocation.cpp
lib/Frontend/InitPreprocessor.cpp
test/Frontend/std.cl
test/Frontend/stdlang.c
test/Preprocessor/predefined-mac
yaxunl added a comment.
In http://reviews.llvm.org/D18369#408773, @bader wrote:
> BTW, there is a comment on GitHub that opencl.h might be a bad name for that
> header, since Khronos group provides the header with the same name, but it
> defines host API. So if some developer is using clang to
yaxunl added a comment.
LGTM
http://reviews.llvm.org/D19478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader.
yaxunl added subscribers: cfe-commits, pxli168, tstellarAMD.
Add supported OpenCL extensions to target info. It serves as default values to
save the users of the burden setting each supported extensions and optional
core fea
yaxunl marked 12 inline comments as done.
yaxunl added a comment.
Changed file name to opencl-c.h and updated comments.
Addressed Anastasia's early comments.
I am thinking we may need several more patches to address remaining issues to
keep the changes manageable.
Comment at:
yaxunl updated this revision to Diff 55016.
yaxunl marked 4 inline comments as done.
yaxunl added a comment.
Add CHECK-NOT for `__FAST_RELAXED_MATH__`.
http://reviews.llvm.org/D19071
Files:
lib/Frontend/CompilerInvocation.cpp
lib/Frontend/InitPreprocessor.cpp
test/Frontend/std.cl
test/F
yaxunl updated this revision to Diff 58297.
yaxunl added a comment.
Fix regressions in unit test due to ConstructJob disables builtin include path.
http://reviews.llvm.org/D20444
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
include/clang/Frontend/CompilerI
yaxunl added inline comments.
Comment at: lib/Headers/opencl-c.h:143
@@ +142,3 @@
+#if __OPENCL_C_VERSION__ >= CL_VERSION_2_0
+#define NULL ((void*)0)
+#endif
Anastasia wrote:
> indentation seems wrong!
fixed.
Comment
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
yaxunl added subscribers: pxli168, bader, tstellarAMD, cfe-commits.
Fix a regression which forbids using -std=CL|CL1.1|CL1.2|CL2.0 in driver.
Changed -std=cl to -std=CL to match -cl-std=CL.
http://reviews.llvm.org/D20630
Files:
yaxunl updated this revision to Diff 58471.
yaxunl added a comment.
Revised as Richard suggested.
http://reviews.llvm.org/D20630
Files:
lib/Frontend/CompilerInvocation.cpp
test/Driver/opencl.cl
test/Frontend/stdlang.c
Index: test/Frontend/stdlang.c
===
yaxunl added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:1587-1589
@@ -1579,3 +1586,4 @@
+.Case("cl", LangStandard::lang_opencl)
.Case("CL1.1", LangStandard::lang_opencl11)
.Case("CL1.2", LangStandard::lang_opencl12)
.Case("CL2.0", LangStand
yaxunl created this revision.
yaxunl added reviewers: rsmith, Anastasia.
yaxunl added subscribers: cfe-commits, tstellarAMD.
Sometimes a backend needs to apply certain target-specific passes before
linking. This patch attempts to add that.
It depends on a new virtual member function addPreLinkPa
yaxunl added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:11
@@ +10,3 @@
+#endif
+#pragma OPENCL EXTENSION cl_clang_storage_class_specifiers: enable
+
Anastasia wrote:
> jvesely wrote:
> > Anastasia wrote:
> > > jvesely wrote:
> > > > Anastasi
yaxunl retitled this revision from "[OpenCL] Include opencl-c.h by default as a
module" to "[OpenCL] Include opencl-c.h by default as a clang module".
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 58830.
yaxunl added a comment.
Revised as Anastasia suggested.
yaxunl marked an inline comment as done.
Comment at: include/clang/Basic/LangOptions.def:220
@@ -219,3 +219,3 @@
ENUM_LANGOPT(AddressSpaceMapMangling , AddrSpaceMapMangling, 2, ASMM_Target,
"OpenCL address space map mangling mode")
-
+LANGOPT(IncludeDefaultHeader, 1, 0, "Include
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D20744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: yaxunl
Date: Mon May 30 01:42:48 2016
New Revision: 271198
URL: http://llvm.org/viewvc/llvm-project?rev=271198&view=rev
Log:
[OpenCL] Remove tests without triple from test/Headers/opencl-c-header.cl.
This test requires triples with Itanium C++ ABI whereas triples with MSVC
environment us
yaxunl updated this revision to Diff 58978.
yaxunl added a comment.
Revised as Richard suggested.
http://reviews.llvm.org/D20630
Files:
include/clang/Frontend/LangStandards.def
lib/Frontend/CompilerInvocation.cpp
test/Driver/opencl.cl
test/Frontend/stdlang.c
Index: test/Frontend/stdlan
yaxunl marked 7 inline comments as done.
Comment at: lib/CodeGen/CGExprScalar.cpp:3420
@@ -3407,35 +3419,3 @@
llvm::Type *SrcTy = Src->getType();
- if (isa(DstTy) && isa(SrcTy)) {
-unsigned numElementsDst = cast(DstTy)->getNumElements();
-unsigned numElementsSrc = cast
yaxunl updated this revision to Diff 58991.
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Fix variable capitalization and indentation.
http://reviews.llvm.org/D20133
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGenOpenCL/as_type.cl
Index: test/CodeGenOpenCL/as_type.cl
==
yaxunl updated this revision to Diff 59398.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Add a test for -fblocks as Anastasia suggested.
http://reviews.llvm.org/D20444
Files:
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
include/clang/Frontend/
yaxunl added inline comments.
Comment at: test/Headers/opencl-c-header.cl:53-54
@@ +52,4 @@
+
+// ===
+// Compile for OpenCL 2.0 for the first time. The module should change.
+// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o -
-cl-std=CL2.0 -finclude-default-hea
yaxunl updated this revision to Diff 59431.
yaxunl added a comment.
Improve diag msg for fblocks.
http://reviews.llvm.org/D20444
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
include/clang/Frontend/CompilerInvoca
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader, pxli168.
yaxunl added subscribers: cfe-commits, tstellarAMD.
This patch attempts to use target-dependent function attribute to represent
reqd_work_group_size, work_group_size_hint and vector_type_hint kernel
attributes and u
yaxunl updated this revision to Diff 59630.
yaxunl marked 10 inline comments as done.
yaxunl added a comment.
Add a sema test for mismatched type size. Fix codegen test.
http://reviews.llvm.org/D20133
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGenOpenCL/as_type.cl
test/SemaOpenCL/as_typ
yaxunl added inline comments.
Comment at: lib/CodeGen/CGExprScalar.cpp:3394
@@ +3393,3 @@
+ if (NumElementsDst == 4)
+Args.push_back(llvm::UndefValue::get(CGF.Int32Ty));
+ llvm::Constant *Mask = llvm::ConstantVector::get(Args);
Anastasia wrote:
> should this
yaxunl added inline comments.
Comment at: test/Headers/opencl-c-header.cl:50
@@ +49,3 @@
+// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash %s | FileCheck %
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 59733.
yaxunl marked 8 inline comments as done.
yaxunl added a comment.
Update the diagnositic msg for fblocks.
http://reviews.llvm.org/D20444
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/B
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Ping
Xiuli, could you please take a look? Thanks.
http://reviews.llvm.org/D20133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
yaxunl marked 4 inline comments as done.
Comment at: test/Headers/opencl-c-header.cl:50
@@ +49,3 @@
+// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash %s |
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
In http://reviews.llvm.org/D20681#448443, @Anastasia wrote:
> Do you think we could add any test for this change?
We have prelinking passes in amdgpu backend but it requires the llvm change to
be committed first. We can add a tes
Author: yaxunl
Date: Wed Jun 8 10:11:21 2016
New Revision: 272153
URL: http://llvm.org/viewvc/llvm-project?rev=272153&view=rev
Log:
[OpenCL] Fix __builtin_astype for vec3 types.
__builtin_astype does not generate correct LLVM IR for vec3 types. This patch
inserts bitcasts to/from vec4 when nece
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272153: [OpenCL] Fix __builtin_astype for vec3 types.
(authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D20133?vs=59630&id=60043#toc
Repository:
rL LLVM
http://reviews.llvm.org/
yaxunl updated this revision to Diff 60078.
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
Modified the test for module as Anastasia suggested.
http://reviews.llvm.org/D20444
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/LangOptions.def
include/cl
yaxunl marked 5 inline comments as done.
Comment at: test/Headers/opencl-c-header.cl:50
@@ +49,3 @@
+
+// ===
+// Compile for OpenCL 1.0 for the second time. The module should not be
re-created.
I changed the module to read only. If Clang tries to create a new mo
yaxunl added a comment.
In http://reviews.llvm.org/D20979#452463, @Anastasia wrote:
> Looking good generally, I am just not sure about mixing two different
> representations.
If we choose only one form of representation, would you suggest to use function
metadata or function attribute?
http
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
> > We have prelinking passes in amdgpu backend but it requires the llvm change
> > to be committed first. We can add a test for this after that.
>
>
> Sure. Could you subscribe me to the relevant backend reviews if possible
>
yaxunl updated this revision to Diff 60105.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Refactor to eliminate lambda function argument.
http://reviews.llvm.org/D20681
Files:
include/clang/CodeGen/BackendUtil.h
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CodeGenAction.cpp
yaxunl marked 2 inline comments as done.
Comment at: test/Headers/opencl-c-header.cl:70
@@ +69,3 @@
+// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t %s | FileCheck %s
+// RUN: %clan
yaxunl added inline comments.
Comment at: test/Headers/opencl-c-header.cl:53-54
@@ +52,4 @@
+// RUN: %clang_cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash -ftime-report %s 2
yaxunl added a comment.
In http://reviews.llvm.org/D20979#453632, @Anastasia wrote:
> In http://reviews.llvm.org/D20979#452616, @yaxunl wrote:
>
> > In http://reviews.llvm.org/D20979#452463, @Anastasia wrote:
> >
> > > Looking good generally, I am just not sure about mixing two different
> > > r
yaxunl marked 4 inline comments as done.
yaxunl added a comment.
Ping!
Richard, are you OK with this? Thanks.
http://reviews.llvm.org/D20630
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
yaxunl retitled this revision from "[OpenCL] Use function attribute/metadata to
represent kernel attributes" to "[OpenCL] Use function metadata to represent
kernel attributes".
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 60545.
http://reviews.llvm.org/D2097
yaxunl added a comment.
I updated the patch to use function metadata only. Please review. Thanks.
http://reviews.llvm.org/D20979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated this revision to Diff 60568.
yaxunl added a comment.
Update the test as Anastasia suggested.
http://reviews.llvm.org/D20444
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/LangOptions.def
include/clang/Driver/CC1Options.td
include/clang/Frontend/Comp
yaxunl added a comment.
In http://reviews.llvm.org/D20444#457588, @Anastasia wrote:
> LGTM, I think it would be nice if the block related code goes in a separate
> commit.
>
> Thanks!
Will do. Thanks.
http://reviews.llvm.org/D20444
___
cfe-commi
Author: yaxunl
Date: Tue Jun 14 16:43:01 2016
New Revision: 272720
URL: http://llvm.org/viewvc/llvm-project?rev=272720&view=rev
Log:
[OpenCL] Enable -fblocks by default for OpenCL 2.0 and above.
Reviewed as part of http://reviews.llvm.org/D20444
Added:
cfe/trunk/test/Frontend/opencl-blocks.c
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: yaxunl
Date: Fri Jun 17 12:19:28 2016
New Revision: 273015
URL: http://llvm.org/viewvc/llvm-project?rev=273015&view=rev
Log:
[OpenCL] Allow -std={cl|CL}{|1.1|1.2|2.0} in driver
Fix a regression which forbids using -std=cl|CL1.1|CL1.2|CL2.0 in driver.
Allow -std and -cl-std={cl|CL}{|1.1|1
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273015: [OpenCL] Allow -std={cl|CL}{|1.1|1.2|2.0} in driver
(authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D20630?vs=58978&id=61109#toc
Repository:
rL LLVM
http://reviews.llv
yaxunl added a comment.
Ping!
Alexey/Xiuli, are you OK with this change? Thanks.
http://reviews.llvm.org/D20979
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/kernel-attributes.cl:9
@@ -8,3 +10,1 @@
-// CHECK: opencl.kernels = !{[[MDNODE0:![0-9]+]], [[MDNODE3:![0-9]+]]}
-
bader wrote:
> AFAIK, this named metadata node were also useful for kernel functions
>
Author: yaxunl
Date: Mon Jun 20 14:26:00 2016
New Revision: 273191
URL: http://llvm.org/viewvc/llvm-project?rev=273191&view=rev
Log:
[OpenCL] Include opencl-c.h by default as a clang module
Include opencl-c.h by default as a module to utilize the automatic AST caching
mechanism of clang modules.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273191: [OpenCL] Include opencl-c.h by default as a clang
module (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D20444?vs=60568&id=61290#toc
Repository:
rL LLVM
http://review
yaxunl created this revision.
yaxunl added reviewers: Anastasia, bader, pxli168.
yaxunl added subscribers: cfe-commits, tstellarAMD.
Currently Clang use int32 to represent sampler_t, which have been a source of
issue for some backends, because in some backends sampler_t cannot be
represented by
yaxunl updated this revision to Diff 61443.
yaxunl added a comment.
Add test deleted by accident.
http://reviews.llvm.org/D21567
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/AST/OperationKinds.def
include/clang/AST/Type.h
include/clang/Basic/D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL273425: [OpenCL] Use function metadata to represent kernel
attributes (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D20979?vs=60545&id=61555#toc
Repository:
rL LLVM
http://r
Author: yaxunl
Date: Wed Jun 22 09:56:35 2016
New Revision: 273425
URL: http://llvm.org/viewvc/llvm-project?rev=273425&view=rev
Log:
[OpenCL] Use function metadata to represent kernel attributes
This patch uses function metadata to represent reqd_work_group_size,
work_group_size_hint and vector_
yaxunl added a comment.
In http://reviews.llvm.org/D19932#465781, @jvesely wrote:
> In http://reviews.llvm.org/D19932#465763, @cfe-commits wrote:
>
> > The returned pointer should point to the same pointee type as the argument.
> > Header file cannot guarantee that.
> >
> > Sam
>
>
> how come? i
yaxunl added a comment.
> this is not true. as I pointed out earlier, take a look at libclc headers. a
> lot functions are defined for multiple types while maintaining type safety.
> there is no problem having TYPE * to_global(TYPE *), for every permissible
> CLC type, declared in headers with
yaxunl added inline comments.
Comment at: include/clang/AST/BuiltinTypes.def:164
@@ +163,3 @@
+// Internal OpenCL sampler initializer type.
+BUILTIN_TYPE(OCLSamplerInit, OCLSamplerInitTy)
+
Anastasia wrote:
> I can't get why is this necessary to represent initiali
yaxunl created this revision.
yaxunl added a reviewer: Anastasia.
yaxunl added subscribers: cfe-commits, bader, pxli168, tstellarAMD.
Allow user to use pragma to add supported extensions:
#pragma OPENCL EXTENSION the_new_extension_name : register
After that, users can use
#pragma OPENCL EXT
yaxunl added a comment.
I am wondering what's the difference between this calling convention and
spir_kernel.
http://reviews.llvm.org/D21367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
yaxunl added a comment.
In http://reviews.llvm.org/D21367#467982, @nhaustov wrote:
> In http://reviews.llvm.org/D21367#467894, @yaxunl wrote:
>
> > I am wondering what's the difference between this calling convention and
> > spir_kernel.
>
>
> spir_kernel has only effect and was created only for
Author: yaxunl
Date: Mon Jun 27 16:43:00 2016
New Revision: 273948
URL: http://llvm.org/viewvc/llvm-project?rev=273948&view=rev
Log:
Attempting to fix lit test test/Headers/opencl-c-header.cl on cygwin.
"chmod u-x *" does not work for lit on cygwin.
Modified:
cfe/trunk/test/Headers/opencl-c-
yaxunl added a comment.
> Maybe we can use the fact that calling conventions are separate in AST and in
> LLVM IR. So in AST maybe we can have opencl_kernel and in LLVM it can map to
> spir_kernel for SPIR and amdgpu_kernel for AMDGPU.
This approach looks good to me. Thanks.
http://reviews
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D21367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274150: [OpenCL] Allow -cl-std and other standard -cl-
options in driver (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D21031?vs=61574&id=62267#toc
Repository:
rL LLVM
http:
Author: yaxunl
Date: Wed Jun 29 14:39:32 2016
New Revision: 274150
URL: http://llvm.org/viewvc/llvm-project?rev=274150&view=rev
Log:
[OpenCL] Allow -cl-std and other standard -cl- options in driver
Allow -cl-std and other standard -cl- options from cc1 to driver.
Added a test for the options mov
yaxunl added a comment.
Can we add tests for returning sampler, image and pipe type? Thanks.
http://reviews.llvm.org/D21989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl closed this revision.
yaxunl added a comment.
This patch was superseded by http://reviews.llvm.org/D20389
http://reviews.llvm.org/D20373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
yaxunl added inline comments.
Comment at: include/clang/AST/BuiltinTypes.def:164
@@ +163,3 @@
+// Internal OpenCL sampler initializer type.
+BUILTIN_TYPE(OCLSamplerInit, OCLSamplerInitTy)
+
Anastasia wrote:
> yaxunl wrote:
> > Anastasia wrote:
> > > I can't get wh
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks!
http://reviews.llvm.org/D21989
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl added a comment.
I think you also need to set Opts.NoSignedZeros in CompilerInvocation.cpp.
Repository:
rL LLVM
http://reviews.llvm.org/D22067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
yaxunl updated this revision to Diff 62966.
yaxunl added a comment.
Removed the old representation of sampler type by i32.
http://reviews.llvm.org/D21567
Files:
include/clang/AST/ASTContext.h
include/clang/AST/BuiltinTypes.def
include/clang/AST/OperationKinds.def
include/clang/AST/Type.
yaxunl added a comment.
LGTM. Thanks.
http://reviews.llvm.org/D22067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 63286.
yaxunl added a comment.
Drop the sampler initializer structure as Anastasia suggested. Now
`__translate_sampler_initializer` accepts an integer parameter.
http://reviews.llvm.org/D21567
Files:
include/c
Author: yaxunl
Date: Fri Jul 8 15:28:29 2016
New Revision: 274923
URL: http://llvm.org/viewvc/llvm-project?rev=274923&view=rev
Log:
[OpenCL] Add missing -cl-no-signed-zeros option into driver
Add OCL option -cl-no-signed-zeros to driver options.
Also added to opencl.cl testcases.
Patch by Aaro
This revision was automatically updated to reflect the committed changes.
Closed by commit rL274923: [OpenCL] Add missing -cl-no-signed-zeros option into
driver (authored by yaxunl).
Changed prior to commit:
http://reviews.llvm.org/D22067?vs=63143&id=63308#toc
Repository:
rL LLVM
http://rev
yaxunl added inline comments.
Comment at: test/Frontend/opencl-blocks.cl:9
@@ -8,1 +8,3 @@
// RUN: %clang_cc1 %s -triple amdgcn--amdhsa -x c -std=c99 -verify
-fsyntax-only
+// RUN: %clang_cc1 -cl-std=CL1.1 -cl-strict-aliasing %s 2>&1 | FileCheck
--check-prefix=CHECK-INVALID-OPE
yaxunl added inline comments.
Comment at: test/Frontend/opencl-blocks.cl:9
@@ -8,1 +8,3 @@
// RUN: %clang_cc1 %s -triple amdgcn--amdhsa -x c -std=c99 -verify
-fsyntax-only
+// RUN: %clang_cc1 -cl-std=CL1.1 -cl-strict-aliasing %s 2>&1 | FileCheck
--check-prefix=CHECK-INVALID-OPE
yaxunl added inline comments.
Comment at: test/Frontend/opencl-blocks.cl:9
@@ -8,1 +8,3 @@
// RUN: %clang_cc1 %s -triple amdgcn--amdhsa -x c -std=c99 -verify
-fsyntax-only
+// RUN: %clang_cc1 -cl-std=CL1.1 -cl-strict-aliasing %s 2>&1 | FileCheck
--check-prefix=CHECK-INVALID-OPE
yaxunl marked 20 inline comments as done.
Comment at: lib/CodeGen/CGExprConstant.cpp:694
@@ +693,3 @@
+case CK_IntToOCLSampler:
+ llvm_unreachable("global sampler variables are not generated");
+
Anastasia wrote:
> Does this only apply to global variable
1001 - 1100 of 1680 matches
Mail list logo
