Author: yrnkrn
Date: Thu Aug 6 02:28:36 2015
New Revision: 244196
URL: http://llvm.org/viewvc/llvm-project?rev=244196&view=rev
Log:
Plug a memory leak in NeonEmitter: Intrinsics allocated were never released.
Modified:
cfe/trunk/utils/TableGen/NeonEmitter.cpp
Modified: cfe/trunk/utils/Tabl
Author: yrnkrn
Date: Fri Aug 7 05:15:15 2015
New Revision: 244312
URL: http://llvm.org/viewvc/llvm-project?rev=244312&view=rev
Log:
Silence tools/clang/lib/Tooling/CompilationDatabase.cpp:328:12: warning:
‘clang::tooling::JSONAnchorDest’ defined but not used [-Wunused-variable]
from gcc 5.1.
Mo
Author: yrnkrn
Date: Fri Aug 7 11:37:34 2015
New Revision: 244329
URL: http://llvm.org/viewvc/llvm-project?rev=244329&view=rev
Log:
Silence gcc 5.1 unused variable warnings using LLVM_ATTRIBUTE_UNUSED.
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
Modified: clang-tool
This issue is surfacing regulary. In cases where clang prints the escaped
path we have to use {{/} which is not very readable, for example in
mingw driver case:
// CHECK_MINGW_ORG_TREE:
"{{.*}}/Inputs/mingw_mingw_org_tree/mingw{{/|}}lib{{/|}}gcc{{/|}}mingw32{{/|}}4.8.1{{/|}
Author: yrnkrn
Date: Thu Jul 21 02:44:41 2016
New Revision: 276252
URL: http://llvm.org/viewvc/llvm-project?rev=276252&view=rev
Log:
Provide __GLIBCXX_TYPE_INT_N_0 and __GLIBCXX_BITSIZE_INT_N_0 when in C++ gnu
language extensions.
These are used by libstdc++ for is_integral<__int128>.
Addresses
Author: yrnkrn
Date: Mon Aug 1 05:14:54 2016
New Revision: 277334
URL: http://llvm.org/viewvc/llvm-project?rev=277334&view=rev
Log:
Allow .exe extension to ld to fix test with mingw.
Modified:
cfe/trunk/test/Driver/offloading-interoperability.c
Modified: cfe/trunk/test/Driver/offloading-in
Author: yrnkrn
Date: Sun Feb 7 06:44:35 2016
New Revision: 260028
URL: http://llvm.org/viewvc/llvm-project?rev=260028&view=rev
Log:
Use CodeGenModule::addReplacement() instead of directly accessing
Replacements[].
This helps when trying to debug who inserted into Replacements.
Modified:
cf
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
We have tried to keep one copy of http://reviews.llvm.org/D11103
Can it share the Module->getDataLayout() ?
http://reviews.llvm.org/D17183
___
cfe-commits mailing list
cfe-com
yaron.keren added a comment.
It certainly makes sense to redirect the module request to its owner instead of
duplicating it in a local copy.
There may be a change in behaviour here, pre-patch
CodeGenAction::EndSourceFileAction() would take the BackendConsumer Module,
keeping CodeGen Module int
yaron.keren accepted this revision.
yaron.keren added a reviewer: yaron.keren.
yaron.keren added a comment.
This revision is now accepted and ready to land.
Would be nice to have CodeGenAction::TheModule redirect to CodeGeneratorImpl::M
if possible, but that's for another patch. LGTM.
http://re
Hi Nico,
In other tests, {{/|}} or {{/|\\}} are used match the forward or
backward slash(es). clang escapes \ so we get two of them in output and
four in the LIT test.
It would be nice to have more elegant construct for this general problem,
to avoid tests like:
"{{.*}}/Inputs/mingw_mingw_or
Author: yrnkrn
Date: Fri May 13 09:53:19 2016
New Revision: 269423
URL: http://llvm.org/viewvc/llvm-project?rev=269423&view=rev
Log:
Prune four superfluous ExternalSemaSource.h includes and one forward
declaration in Sema.h
where ExternalSemaSource.h was already included due to ExternalSemaSource
yaron.keren added a subscriber: yaron.keren.
yaron.keren accepted this revision.
yaron.keren added a reviewer: yaron.keren.
yaron.keren added a comment.
This revision is now accepted and ready to land.
result of r269402, LGTM
http://reviews.llvm.org/D20240
___
Author: yrnkrn
Date: Tue May 17 14:01:16 2016
New Revision: 269801
URL: http://llvm.org/viewvc/llvm-project?rev=269801&view=rev
Log:
Teach clang to look for libcxx in /usr/local/include/c++ on Linux
As The default CMAKE install prefix is /usr/local (
https://cmake.org/cmake/help/v3.0/variable/CM
+1, if possible. There is a if (getLangOpts().ObjC1) block just before this.
2016-04-03 14:21 GMT+03:00 Vassil Vassilev via cfe-commits <
cfe-commits@lists.llvm.org>:
> On 04/02/16 01:55, Ben Langmuir via cfe-commits wrote:
>
>> Author: benlangmuir
>> Date: Wed Feb 3 18:55:24 2016
>> New Revisio
I look at many AST dumps for small reduced code so it's mostly weird to see
this in the AST (and takes a bit of screen real estate) as it's not
something that originated in the code.
By now I'm used to ignoring it but would expect NSConstantString would
baffle new clang programmers. It would be nic
If used only for Darwin, could this depend
on Target.getTriple().isOSDarwin() ?
2016-04-11 17:18 GMT+03:00 Ben Langmuir :
>
> On Apr 3, 2016, at 10:57 AM, Yaron Keren wrote:
>
> I look at many AST dumps for small reduced code so it's mostly weird to
> see this in the AST (and takes a bit of scr
Author: yrnkrn
Date: Wed Jun 1 08:47:26 2016
New Revision: 271392
URL: http://llvm.org/viewvc/llvm-project?rev=271392&view=rev
Log:
Fix the CLANG_ENABLE_STATIC_ANALYZER=OFF build.
tools/clang/tools/CMakeLists.txt does not create the
clang-check target when CLANG_ENABLE_STATIC_ANALYZER=OFF.
Mod
Thanks! I've just noticed this today locally. It happens with unoptimized
builds only so the bots are not catching it.
2016-06-01 18:17 GMT+03:00 Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org>:
> Author: aaronballman
> Date: Wed Jun 1 10:17:54 2016
> New Revision: 271399
>
> URL:
yaron.keren added a subscriber: yaron.keren.
yaron.keren accepted this revision.
yaron.keren added a reviewer: yaron.keren.
yaron.keren added a comment.
This revision is now accepted and ready to land.
You mean
Some target platforms do not support -fsanitize=address.
http://reviews.llvm.org/D21
Author: yrnkrn
Date: Wed Jun 29 13:55:53 2016
New Revision: 274149
URL: http://llvm.org/viewvc/llvm-project?rev=274149&view=rev
Log:
Add CapturedDecl::parameters() ArrayRef accessors following r273647.
Modified:
cfe/trunk/include/clang/AST/Decl.h
Modified: cfe/trunk/include/clang/AST/Decl.h
Seems this commit broke a builder,
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26133
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26134
TEST 'Clang-Unit ::
ASTMatchers/ASTMatchersTests/Declaratio
Author: yrnkrn
Date: Wed Jul 13 14:04:51 2016
New Revision: 275303
URL: http://llvm.org/viewvc/llvm-project?rev=275303&view=rev
Log:
Implement FunctionDecl::getDefinition() to be consistent with
VarDecl, TagDecl, EnumDecl, RecordDecl, CXXRecordDecl.
Use getDefinition in two locations to make the
Author: yrnkrn
Date: Wed Mar 16 07:14:43 2016
New Revision: 263635
URL: http://llvm.org/viewvc/llvm-project?rev=263635&view=rev
Log:
Directly get the canonical Type instead of going around through a CanQualType
temporary, NFC.
Modified:
cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp
Modified: cfe
Author: yrnkrn
Date: Fri Jan 22 13:03:27 2016
New Revision: 258524
URL: http://llvm.org/viewvc/llvm-project?rev=258524&view=rev
Log:
Merge templated static member variables, fixes http://llvm.org/pr26179.
Patch by Vassil Vassilev!
Reviewed by Richard Smith.
Added:
cfe/trunk/test/Modules/Inp
Committed revision 258524.
2016-01-21 19:33 GMT+02:00 Vassil Vassilev via cfe-commits <
cfe-commits@lists.llvm.org>:
> ping... (perhaps someone else with commit rights can check it it...)
> --Vassil
>
> On 18/01/16 22:07, Vassil Vassilev wrote:
>
> Thanks! Could you check it in?
> -- Vassil
> On
The instantiated does get a new collection of ParmVarDecls while getting
the pattern Type which points to the pattern ParmVarDecls. So the
ParmVarDecls pointed in the instantiated are not the same as those pointed
by its Type.
Traversing by Type or by the Decl finds a different set of ParmVarDecls
Author: yrnkrn
Date: Fri Jan 29 07:46:15 2016
New Revision: 259192
URL: http://llvm.org/viewvc/llvm-project?rev=259192&view=rev
Log:
Implement TemplateArgument::dump() method for debugging, patterned after
TemplateName::dump().
Modified:
cfe/trunk/include/clang/AST/TemplateBase.h
cfe/tr
ot;Yaron Keren via cfe-commits" <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Author: yrnkrn
> > Date: Fri Jan 29 07:46:15 2016
> > New Revision: 259192
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=259192&view=rev
> > Log:
> >
Author: yrnkrn
Date: Fri Jan 29 13:38:18 2016
New Revision: 259232
URL: http://llvm.org/viewvc/llvm-project?rev=259232&view=rev
Log:
Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192
post commit comment.
Modified:
cfe/trunk/lib/AST/APValue.cpp
cfe/trunk/lib
), ASTReader::dump(),
> > ModuleMap::dump(), MacroInfo::dump(), ...
> >
> > Annotate all dump() methods LLVM_DUMP_METHOD ?
>
> SGTM
>
> > 2016-01-29 19:37 GMT+02:00 Richard Smith :
> >>
> >> On 29 Jan 2016 5:50 a.m., "Yaron Keren via cfe-commits"
Author: yrnkrn
Date: Fri Nov 13 09:39:39 2015
New Revision: 253046
URL: http://llvm.org/viewvc/llvm-project?rev=253046&view=rev
Log:
Deduplicate three identical copies of isExplicitInstantiationOrSpecialization,
NFC.
Modified:
cfe/trunk/include/clang/AST/DeclTemplate.h
cfe/trunk/include
Author: yrnkrn
Date: Fri Nov 13 13:46:02 2015
New Revision: 253066
URL: http://llvm.org/viewvc/llvm-project?rev=253066&view=rev
Log:
Add test case for mingw -fuse-ld= support introduced in r242121.
Added:
cfe/trunk/test/Driver/mingw-useld.c
Added: cfe/trunk/test/Driver/mingw-useld.c
URL:
h
Author: yrnkrn
Date: Fri Nov 13 14:02:08 2015
New Revision: 253069
URL: http://llvm.org/viewvc/llvm-project?rev=253069&view=rev
Log:
Relax mingw-useld test to fix bot failures.
Modified:
cfe/trunk/test/Driver/mingw-useld.c
Modified: cfe/trunk/test/Driver/mingw-useld.c
URL:
http://llvm.org/
Sure, r253066.
2015-11-13 19:40 GMT+02:00 Rafael Espíndola :
> This needs a testcase. Nothing is checking the linker invocation.
>
> On 14 July 2015 at 01:23, Yaron Keren wrote:
> > Author: yrnkrn
> > Date: Tue Jul 14 00:23:34 2015
> > New Revision: 242121
> >
> > URL: http://llvm.org/viewvc/ll
Filipe: with mingw targetting Windows/COFF files I think only ld and lld
makes sense as gold creates ELF files. I included Microsoft link.exe in the
mingw-useld test but rethinking, no one really uses that configuration, see
attached patch. Is that what you mean?
Rafael: running under Windows whic
Author: yrnkrn
Date: Sun Nov 15 02:06:27 2015
New Revision: 253161
URL: http://llvm.org/viewvc/llvm-project?rev=253161&view=rev
Log:
Make the mingw toolchain accept 'ld' and 'lld' only as values to -fuse-ld.
Post-commit suggestion by Filipe Cabecinhas.
Modified:
cfe/trunk/lib/Driver/Tools.cp
r253161
2015-11-14 22:45 GMT+02:00 Martell Malone :
> The reason why I didn't use -fuse-ld=lld2 was because on Windows we don't
> have symlinks.
> I figured passing flavor gets over this hurdle and the installation takes
> up less space.
> If you want to change it I have no objections we will jus
Author: yrnkrn
Date: Mon Nov 23 13:28:42 2015
New Revision: 253904
URL: http://llvm.org/viewvc/llvm-project?rev=253904&view=rev
Log:
Replace loop with std::any_of, NFC.
Inspired by similar commits from Craig Topper.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/lib/Sema/Se
Searching for gcc on Linux is not a good idea, you'll find the system one
not the mingw one. Searching for i686-w64-mingw32-gcc or
x86_64-w64-mingw32-gcc should work better, that is searching for:
getTriple().getArchName()) + "-w64-mingw32-gcc"
Moreover, this should work on Windows as well, min
yaron.keren added a comment.
This always searches for something-gcc and then discards the result if sysroot
was provided, which is a waste.
Move the searching to a helper function and then it can be done only if sysroot
was not provided, as it is now.
The break is needed to avoid looking for mi
yaron.keren added a comment.
findGccDir() can return llvm::ErrorOr and then all Base
assignments happen at the same if-elseif-else:
if (getDriver().SysRoot.size())
Base = getDriver().SysRoot;
else if (llvm::ErrorOr GPPName = findGccDir())
Base = llvm::sys::path::parent_path(
Author: yrnkrn
Date: Tue Dec 1 02:14:39 2015
New Revision: 254392
URL: http://llvm.org/viewvc/llvm-project?rev=254392&view=rev
Log:
Remove superfluous StringRef casts, NFC.
Modified:
cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
URL:
http://
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
There is another copy of getEffectiveDeclContext in MicrosoftMangle.cpp which
pre-commit was identical to this one.
Should it get this commit as well to keep both identical?
If so, could both copies of getEffectiveDeclConte
MSVC 2013 Update 5 accepts for (bool SkipUnwritten : {false, true}).
Possibly changed in one of the Updates?
2015-12-14 23:35 GMT+02:00 Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org>:
> aaron.ballman added a subscriber: aaron.ballman.
>
>
> Comment at: lib/ASTMatcher
That's odd. I'm using the same update 5 exactly, added " for (bool
SkipUnwritten : {false, true});" inside a LLVM source file and re-compiled.
MSVC complained about the unused SkipUnwritten but was therwise OK with the
code.
2015-12-14 23:43 GMT+02:00 Aaron Ballman :
> On Mon, Dec 14, 2015 at 4
yaron.keren added inline comments.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:322
@@ +321,3 @@
+ for (bool SkipUnwritten : SkipUnwrittenCases) {
+llvm::SmallString<128> NodeName = StringRef("::");
+llvm::raw_svector_ostream OS(NodeName);
StringRe
yaron.keren added a comment.
http://bb.pgr.jp/grid
http://reviews.llvm.org/D15579
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren accepted this revision.
yaron.keren added a comment.
This revision is now accepted and ready to land.
LGTM with some tests cases.
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: yrnkrn
Date: Fri Dec 18 04:30:12 2015
New Revision: 255993
URL: http://llvm.org/viewvc/llvm-project?rev=255993&view=rev
Log:
Replace SM.getFileEntryForID(Lexer->getFileID()) with Lexer->getFileEntry().
Modified:
cfe/trunk/lib/Lex/PPDirectives.cpp
cfe/trunk/lib/Lex/PPLexerChange.c
Author: yrnkrn
Date: Wed Dec 23 14:38:13 2015
New Revision: 256349
URL: http://llvm.org/viewvc/llvm-project?rev=256349&view=rev
Log:
Replace isa+cast with dyn_cast and obey the no else after return rule.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL
Author: yrnkrn
Date: Sun Dec 27 08:34:22 2015
New Revision: 256472
URL: http://llvm.org/viewvc/llvm-project?rev=256472&view=rev
Log:
Constify NestedNameSpecifier::dump and add a no-argument dump function suitable
for calling from a debugger.
Modified:
cfe/trunk/include/clang/AST/NestedNameS
Author: Yaron Keren
Date: 2021-08-31T18:57:47+03:00
New Revision: 10d78a06baa217b8a4b853eff962e9ae719a8a45
URL:
https://github.com/llvm/llvm-project/commit/10d78a06baa217b8a4b853eff962e9ae719a8a45
DIFF:
https://github.com/llvm/llvm-project/commit/10d78a06baa217b8a4b853eff962e9ae719a8a45.diff
L
101 - 153 of 153 matches
Mail list logo
