Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

Hi Richard, This broke the tests on the Windows bot: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/5266 1. FAIL: Clang::preprocess-nested.cpp

r304411 - Increase the limit for the number of DiagnosticLexKinds.td diags.

Author: yrnkrn Date: Thu Jun 1 07:46:59 2017 New Revision: 304411 URL: http://llvm.org/viewvc/llvm-project?rev=304411&view=rev Log: Increase the limit for the number of DiagnosticLexKinds.td diags. 300 was reached in r304190, 400 should be enough for a while. Modified: cfe/trunk/include/cla

r305213 - Add regression test for r305179.

Author: yrnkrn Date: Mon Jun 12 13:05:13 2017 New Revision: 305213 URL: http://llvm.org/viewvc/llvm-project?rev=305213&view=rev Log: Add regression test for r305179. Added: cfe/trunk/test/Misc/pr32207.c Added: cfe/trunk/test/Misc/pr32207.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk

r305215 - Address David Blaikie comment by replacing grep with FileCheck.

Author: yrnkrn Date: Mon Jun 12 13:29:37 2017 New Revision: 305215 URL: http://llvm.org/viewvc/llvm-project?rev=305215&view=rev Log: Address David Blaikie comment by replacing grep with FileCheck. Modified: cfe/trunk/test/Misc/pr32207.c Modified: cfe/trunk/test/Misc/pr32207.c URL: http://l

Re: r305213 - Add regression test for r305179.

Sure, r305215. ‫בתאריך יום ב׳, 12 ביוני 2017 ב-21:21 מאת ‪David Blaikie‬‏ <‪ dblai...@gmail.com‬‏>:‬ > Prefer FileCheck over grep, generally? > > On Mon, Jun 12, 2017 at 11:05 AM Yaron Keren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: yr

Re: r305213 - Add regression test for r305179.

12 ביוני 2017 ב-21:21 מאת ‪David Blaikie‬‏ <‪ > dblai...@gmail.com‬‏>:‬ > >> Prefer FileCheck over grep, generally? >> >> On Mon, Jun 12, 2017 at 11:05 AM Yaron Keren via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: yrnkrn

r336047 - Add expected fail triple x86_64-pc-windows-gnu to test as x86_64-w64-mingw32 is already there

Author: yrnkrn Date: Sat Jun 30 04:18:44 2018 New Revision: 336047 URL: http://llvm.org/viewvc/llvm-project?rev=336047&view=rev Log: Add expected fail triple x86_64-pc-windows-gnu to test as x86_64-w64-mingw32 is already there Modified: cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. also, gcc warns if order of field initializators is different than the order of fields. Repository: rL LLVM https://reviews.llvm.org/D24754 ___ cfe-commits mailing list cf

Re: r283063 - Alias must point to a definition

The mangling is different when targeting MSVC ABI, see failure at http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/29889/steps/test_all/logs/Clang%20%3A%3A%20CodeGenCXX__alias-available-externally.cpp maybe -triple x86_64-pc-linux ? 2016-10-02 6:06 GMT+03:00 Aditya Kumar via cfe-com

Re: r283063 - Alias must point to a definition

yes, it works, thanks! 2016-10-03 18:19 GMT+03:00 Aditya K : > Thanks for poining that out. I have updated the test case, please see if > that works. > > > http://llvm.org/viewvc/llvm-project?view=revision&revision=283085 > > > > -Aditya > > > -- > *From:* Yaron Keren

r283657 - Un-tabify source files, NFC.

Author: yrnkrn Date: Sat Oct 8 01:45:10 2016 New Revision: 283657 URL: http://llvm.org/viewvc/llvm-project?rev=283657&view=rev Log: Un-tabify source files, NFC. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/AST/NestedNameSpecifier.cpp

[clang] 5aa0f9c - Use installed llvm-lit.py instead of lit.py PR-51072

Author: Yaron Keren Date: 2021-08-18T09:06:06+03:00 New Revision: 5aa0f9cc9ab267803ad7bcfd14c8fd8bbffd82cb URL: https://github.com/llvm/llvm-project/commit/5aa0f9cc9ab267803ad7bcfd14c8fd8bbffd82cb DIFF: https://github.com/llvm/llvm-project/commit/5aa0f9cc9ab267803ad7bcfd14c8fd8bbffd82cb.diff L

r328447 - Remove reference to stale (2009) python version.

Author: yrnkrn Date: Sun Mar 25 06:12:05 2018 New Revision: 328447 URL: http://llvm.org/viewvc/llvm-project?rev=328447&view=rev Log: Remove reference to stale (2009) python version. Modified: cfe/trunk/www/hacking.html Modified: cfe/trunk/www/hacking.html URL: http://llvm.org/viewvc/llvm-p

r290495 - Deduplicate several GD.getDecl() calls into Decl * local variable.

Author: yrnkrn Date: Sat Dec 24 09:32:39 2016 New Revision: 290495 URL: http://llvm.org/viewvc/llvm-project?rev=290495&view=rev Log: Deduplicate several GD.getDecl() calls into Decl * local variable. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenMo

r291230 - Constify UsingPackDecl::getInstantiatedFromUsingDecl(), NFC.

Author: yrnkrn Date: Fri Jan 6 05:15:57 2017 New Revision: 291230 URL: http://llvm.org/viewvc/llvm-project?rev=291230&view=rev Log: Constify UsingPackDecl::getInstantiatedFromUsingDecl(), NFC. Modified: cfe/trunk/include/clang/AST/DeclCXX.h Modified: cfe/trunk/include/clang/AST/DeclCXX.h U

Re: r278984 - Add test missed from r278983.

I see the same stack overflow asan error in a local buildbot. 2016-08-22 20:30 GMT+03:00 Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org>: > Hi Richard, > > This test has been failing since it was committed. > > http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2277/

Re: r278984 - Add test missed from r278983.

Thanks! 2016-08-25 0:39 GMT+03:00 Richard Smith : > As of r279668, we shouldn't run this test for ASan builds any more. > Perhaps we should increase Clang's minimum stack allocation when built with > ASan to compensate for it making stack frames larger. > On Wed, Aug 24, 2016 at 12:33 AM, Yaron

Re: r299079 - Move NumRegParameters Module Flag. NFCI.

Thanks! If you like, might make sense now to move all these addModuleFlag() into a new helper function, addModuleFlags(). ‫בתאריך יום ה׳, 30 במרץ 2017 ב-16:54 מאת ‪Nirav Dave via cfe-commits‬‏ <‪ cfe-commits@lists.llvm.org‬‏>:‬ > Author: niravd > Date: Thu Mar 30 08:41:44 2017 > New Revision: 29

r300036 - Remove Sema::addOverloadedOperatorToUnresolvedSet declaration. Its definition was removed in r206436.

Author: yrnkrn Date: Wed Apr 12 03:17:44 2017 New Revision: 300036 URL: http://llvm.org/viewvc/llvm-project?rev=300036&view=rev Log: Remove Sema::addOverloadedOperatorToUnresolvedSet declaration. Its definition was removed in r206436. Modified: cfe/trunk/include/clang/Sema/Sema.h Modified:

r300043 - Rangify for loop, NFC.

Author: yrnkrn Date: Wed Apr 12 05:05:48 2017 New Revision: 300043 URL: http://llvm.org/viewvc/llvm-project?rev=300043&view=rev Log: Rangify for loop, NFC. Modified: cfe/trunk/lib/Sema/SemaLookup.cpp Modified: cfe/trunk/lib/Sema/SemaLookup.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tr

r300423 - Use setUsedForHeaderGuard() accessor function instead of direcly accessing UsedForHeaderGuard.

Author: yrnkrn Date: Sun Apr 16 10:53:19 2017 New Revision: 300423 URL: http://llvm.org/viewvc/llvm-project?rev=300423&view=rev Log: Use setUsedForHeaderGuard() accessor function instead of direcly accessing UsedForHeaderGuard. Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified: cfe/tru

r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions are

Author: yrnkrn Date: Mon Apr 17 03:51:20 2017 New Revision: 300443 URL: http://llvm.org/viewvc/llvm-project?rev=300443&view=rev Log: Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice

Re: r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions

3:32: note: previous definition is here > template inline void f() {} > > > I reverted this change in r300497. > > On Mon, Apr 17, 2017 at 10:51 AM, Yaron Keren via cfe-commits > wrote: > > Author: yrnkrn > > Date: Mon Apr 17 03:51:20 2017 > > New Revision

r292032 - Fix PR31644 introduced by r287138 and add a regression test.

Author: yrnkrn Date: Sat Jan 14 15:12:08 2017 New Revision: 292032 URL: http://llvm.org/viewvc/llvm-project?rev=292032&view=rev Log: Fix PR31644 introduced by r287138 and add a regression test. Thanks Dimitry Andric for the report and fix! Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp

r295839 - Remove superfluous initializer.

Author: yrnkrn Date: Wed Feb 22 08:32:39 2017 New Revision: 295839 URL: http://llvm.org/viewvc/llvm-project?rev=295839&view=rev Log: Remove superfluous initializer. The following fully-covered switch either sets value to External or exits the function. Modified: cfe/trunk/lib/AST/ASTContex

r287102 - Rangify for loop, NFC.

Author: yrnkrn Date: Wed Nov 16 07:45:34 2016 New Revision: 287102 URL: http://llvm.org/viewvc/llvm-project?rev=287102&view=rev Log: Rangify for loop, NFC. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp URL: http://llvm.org/viewvc/llvm-project/c

r287138 - Rangify for loops, NFC.

Author: yrnkrn Date: Wed Nov 16 13:24:10 2016 New Revision: 287138 URL: http://llvm.org/viewvc/llvm-project?rev=287138&view=rev Log: Rangify for loops, NFC. Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp URL: http://llvm.org/viewvc/l

Re: r287343 - [OpenCL] Introduce ReadPipeType and WritePipeType.

Hi Joey, In order for ReadPipeType and WritePipeType to work with LLVM type system (isa, dyn_cast), you need to modify the existing TypeClass::Pipe kind into TypeClass::ReadPipe and TypeClass::WritePipe, have Pipe::classof recognize both kinds and have ReadPipe::classof and WritePipe::classof rec

r288124 - Correct comment: we are creating a canonicla decltypetype.

Author: yrnkrn Date: Tue Nov 29 04:08:20 2016 New Revision: 288124 URL: http://llvm.org/viewvc/llvm-project?rev=288124&view=rev Log: Correct comment: we are creating a canonicla decltypetype. Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL: http://

r289328 - Simplify parseShowColorsArgs logic, NFC.

Author: yrnkrn Date: Sat Dec 10 08:55:14 2016 New Revision: 289328 URL: http://llvm.org/viewvc/llvm-project?rev=289328&view=rev Log: Simplify parseShowColorsArgs logic, NFC. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp URL:

r301526 - Constify SourceManager input to MacroInfo::getDefinitionLengthSlow, NFC.

Author: yrnkrn Date: Thu Apr 27 04:56:39 2017 New Revision: 301526 URL: http://llvm.org/viewvc/llvm-project?rev=301526&view=rev Log: Constify SourceManager input to MacroInfo::getDefinitionLengthSlow, NFC. Modified: cfe/trunk/include/clang/Lex/MacroInfo.h cfe/trunk/lib/Lex/MacroInfo.cpp

Re: r301815 - Adapt to LLVM's rename of WeakVH to WeakTrackingVH; NFC

out-of-tree code that uses WeakVH will continue to compile OK but may not perform OK with WeakVH not tracking anymore. May be better not to reuse WeakVH yet so such code will fail compilation. ‫בתאריך יום ב׳, 1 במאי 2017 ב-20:21 מאת ‪Sanjoy Das via cfe-commits‬‏ <‪ cfe-commits@lists.llvm.org‬‏>:‬

Re: r285258 - Refactor call emission to package the function pointer together with

Hi John, clang warns on this: /llvm/tools/zapccs/../clang/include/../lib/CodeGen/CGCall.h:79:7: warning: anonymous types declared in an anonymous union are an extension [-Wnested-anon-types] struct { ^ /llvm/tools/zapccs/../clang/include/../lib/CodeGen/CGCall.h:83:7: warning: anonymou

r247410 - This test requires UTF-8 output to print the UT-8 characters.

Author: yrnkrn Date: Fri Sep 11 08:29:12 2015 New Revision: 247410 URL: http://llvm.org/viewvc/llvm-project?rev=247410&view=rev Log: This test requires UTF-8 output to print the UT-8 characters. Modified: cfe/trunk/test/Frontend/source-col-map.c Modified: cfe/trunk/test/Frontend/source-col-

Re: r247410 - This test requires UTF-8 output to print the UT-8 characters.

to fix it was. > :-) > > ~Aaron > > On Fri, Sep 11, 2015 at 9:29 AM, Yaron Keren via cfe-commits > wrote: > > Author: yrnkrn > > Date: Fri Sep 11 08:29:12 2015 > > New Revision: 247410 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=247410&view=rev > >

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

Thanks, I have replied there. 2015-09-19 13:33 GMT+03:00 Hal Finkel : > FYI: https://llvm.org/bugs/show_bug.cgi?id=24398 was just reopened > pointing to a lack of resolution here. > > -Hal > > - Original Message - > > From: "Yaron Keren via cfe-commits"

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

>>> pointing to a lack of resolution here. >>> >>> -Hal >>> >>> - Original Message - >>> > From: "Yaron Keren via cfe-commits" >>> > To: "Martell Malone" >>> > Cc: "Richard Smith" ,

Re: [libcxxabi] r248129 - Let cxa_demangle.cpp compile with gcc/libstdc++ 4.8 and clang-cl/MSVC2013's STL.

Visual C++ 2013 update 5 (latest) does not appear to compile this, mainly due to missing support for constexpr. https://msdn.microsoft.com/en-us/library/vstudio/hh567368.aspx Visual C++ 2013 CTP has constexpr, but MS did not further update this branch since Nov 2013. The "regular" branch of 201

Re: [PATCH] D13128: Fix backend crash on multiple close of stdout.

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. When stdout goes elsewhere the console, the shell creates the the output file (pipe) and will close it when clang terminates so so why clang should close it at all ? it did not open it. Practically, we have been running

Re: [PATCH] D13128: Fix backend crash on multiple close of stdout.

yaron.keren added a subscriber: sunfish. yaron.keren added a comment. The original commit http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20100816/106268.html by Dan Ghoman says: "Make raw_fd_ostream consider itself the owner of STDOUT_FILENO when constructed with an output filename of

Re: [libcxxabi] r248129 - Let cxa_demangle.cpp compile with gcc/libstdc++ 4.8 and clang-cl/MSVC2013's STL.

Ah, OK. Maybe it would compile with VC 2013 by using LLVM_CONSTEXPR instead of constexpr. It's not available now in libcxx but the definition from Compiler.h is trivial. 2015-09-24 19:28 GMT+03:00 Nico Weber : > On Thu, Sep 24, 2015 at 4:20 AM, Yaron Keren via cfe-commits < &g

Re: broken testing caused by r248546

Here too: http://bb.pgr.jp/builders/ninja-clang-i686-msc18-R/builds/3285 http://bb.pgr.jp/builders/ninja-clang-i686-msc18-R/builds/3285/steps/test-clang/logs/Clang%20%3A%3A%20Driver__ps4-linker-win.c 2015-09-25 2:10 GMT+03:00 Romanova, Katya via cfe-commits < cfe-commits@lists.llvm.org>: > Hi,

r248626 - Relax test to allow for __attribute__((thiscall)). Under Win32 c-index-test output is

Author: yrnkrn Date: Fri Sep 25 17:09:07 2015 New Revision: 248626 URL: http://llvm.org/viewvc/llvm-project?rev=248626&view=rev Log: Relax test to allow for __attribute__((thiscall)). Under Win32 c-index-test output is CXXMethod=foo:4:7 (unavailable) [type=int () __attribute__((thiscall))] [typ

Re: [PATCH] D13128: Fix backend crash on multiple close of stdout.

yaron.keren added a comment. Hi Dan, it makes sense that output streams should not usually be mixed together, especially if one is binary as you write. This may or may not be a problem depending on what the user really wants. He may want to mix the outputs for whatever purposes or it may usually

r248807 - Fix typo.

Author: yrnkrn Date: Tue Sep 29 11:51:08 2015 New Revision: 248807 URL: http://llvm.org/viewvc/llvm-project?rev=248807&view=rev Log: Fix typo. Modified: cfe/trunk/lib/Lex/Preprocessor.cpp Modified: cfe/trunk/lib/Lex/Preprocessor.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Le

r249001 - C++11 rangify for loops, NFC.

Author: yrnkrn Date: Thu Oct 1 06:19:28 2015 New Revision: 249001 URL: http://llvm.org/viewvc/llvm-project?rev=249001&view=rev Log: C++11 rangify for loops, NFC. Modified: cfe/trunk/lib/Frontend/InitHeaderSearch.cpp Modified: cfe/trunk/lib/Frontend/InitHeaderSearch.cpp URL: http://llvm.or

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. clang can't generate Visual C++ debug info except line numbers yet, so building with VC is essential to development on Windows. While most people and our bots are still using VC 2013 going forward supporting VC 2015 (even

r249152 - constify ClassTemplatePartialSpecializationDecl::getInstantiatedFromMember and VarTemplatePartialSpecializationDecl::getInstantiatedFromMember.

Author: yrnkrn Date: Fri Oct 2 11:40:48 2015 New Revision: 249152 URL: http://llvm.org/viewvc/llvm-project?rev=249152&view=rev Log: constify ClassTemplatePartialSpecializationDecl::getInstantiatedFromMember and VarTemplatePartialSpecializationDecl::getInstantiatedFromMember. Modified: cfe/

Re: r249141 - Revert "Add support for the new mips-mti-linux toolchain."

The regular expression should match match clang.exe on Windows. 2015-10-02 18:00 GMT+03:00 Vasileios Kalintiris via cfe-commits < cfe-commits@lists.llvm.org>: > Author: vkalintiris > Date: Fri Oct 2 10:00:55 2015 > New Revision: 249141 > > URL: http://llvm.org/viewvc/llvm-project?rev=249141&vi

r249159 - constify four getInstantiatedFromMemberTemplate() in DeclTemplate.h.

Author: yrnkrn Date: Fri Oct 2 12:38:57 2015 New Revision: 249159 URL: http://llvm.org/viewvc/llvm-project?rev=249159&view=rev Log: constify four getInstantiatedFromMemberTemplate() in DeclTemplate.h. Modified: cfe/trunk/include/clang/AST/DeclTemplate.h Modified: cfe/trunk/include/clang/AS

r249228 - Replace double-negated !SourceLocation.isInvalid() with SourceLocation.isValid().

Author: yrnkrn Date: Sat Oct 3 00:15:57 2015 New Revision: 249228 URL: http://llvm.org/viewvc/llvm-project?rev=249228&view=rev Log: Replace double-negated !SourceLocation.isInvalid() with SourceLocation.isValid(). Modified: cfe/trunk/lib/ARCMigrate/ObjCMT.cpp cfe/trunk/lib/AST/TypeLoc.

[clang-tools-extra] r249235 - Replace double negation of !FileID.isInvalid() with FileID.isValid().

Author: yrnkrn Date: Sat Oct 3 05:46:20 2015 New Revision: 249235 URL: http://llvm.org/viewvc/llvm-project?rev=249235&view=rev Log: Replace double negation of !FileID.isInvalid() with FileID.isValid(). +couple more of double-negated !SourceLocation.isInvalid() unfixed in r249228. Modified:

r249235 - Replace double negation of !FileID.isInvalid() with FileID.isValid().

Author: yrnkrn Date: Sat Oct 3 05:46:20 2015 New Revision: 249235 URL: http://llvm.org/viewvc/llvm-project?rev=249235&view=rev Log: Replace double negation of !FileID.isInvalid() with FileID.isValid(). +couple more of double-negated !SourceLocation.isInvalid() unfixed in r249228. Modified:

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. There is also the case insensitivity issue, see https://llvm.org/bugs/show_bug.cgi?id=17993 http://reviews.llvm.org/D11944 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D11808: Driver: Fix include and lib dirs when not using gcc under mingw

yaron.keren added a comment. Yes, go ahead. http://reviews.llvm.org/D11808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r244869 - Disable failing check in bots from r244867.

Author: yrnkrn Date: Thu Aug 13 01:12:49 2015 New Revision: 244869 URL: http://llvm.org/viewvc/llvm-project?rev=244869&view=rev Log: Disable failing check in bots from r244867. Modified: cfe/trunk/test/Frontend/dependency-gen.c Modified: cfe/trunk/test/Frontend/dependency-gen.c URL: http:/

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

Hi Ivan, CHECK-EIGHT is failing bots, see http://lab.llvm.org:8011/builders/clang-x86_64-ubuntu-gdb-75/builds/24306/steps/check-all/logs/FAIL%3A%20Clang%3A%3Adependency-gen.c I disabled it in r244869. Yaron 2015-08-13 7:04 GMT+03:00 Ivan Krasin via cfe-commits < cfe-commits@lists.llvm.org>:

r244871 - Remove superfluous private:, TypeCache is private by default.

Author: yrnkrn Date: Thu Aug 13 02:12:03 2015 New Revision: 244871 URL: http://llvm.org/viewvc/llvm-project?rev=244871&view=rev Log: Remove superfluous private:, TypeCache is private by default. Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.h Modified: cfe/trunk/lib/CodeGen/CodeGenTypes.h UR

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

yaron.keren added inline comments. Comment at: lib/Basic/FileManager.cpp:221-222 @@ -220,1 +220,4 @@ + SmallString<1024> NativeFilename; + llvm::sys::path::native(Filename, NativeFilename); + rsmith wrote: > I have two concerns with this: > > 1) It's needless

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

yaron.keren added a comment. I think she wishes your second option. Note that windows API actually do accept slash as seperator and need no conversion. https://en.wikipedia.org/wiki/Path_(computing)#MS-DOS.2FMicrosoft_Windows_style The issues are with apps that interpret slash as switch, ma

r244888 - Remove raw_svector_ostream::resync and users. It's no-op after r244870.

Author: yrnkrn Date: Thu Aug 13 07:42:25 2015 New Revision: 244888 URL: http://llvm.org/viewvc/llvm-project?rev=244888&view=rev Log: Remove raw_svector_ostream::resync and users. It's no-op after r244870. Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp Modified: cfe/trunk/lib/CodeGen/TargetI

Re: r244867 - Add sanitizer blacklists to the rules generated with -M/-MM/-MD/-MMD.

assed locally and I didn't > think about all the variety of the supported configs. :( > > Does LLVM have try bots, so that I can run the tests with my patch before > committing it? > > krasin > On Thu, Aug 13, 2015 at 3:40 AM, Renato Golin wrote: > On 13 August 201

r244928 - Remove and forbid raw_svector_ostream::flush() calls.

Author: yrnkrn Date: Thu Aug 13 13:12:56 2015 New Revision: 244928 URL: http://llvm.org/viewvc/llvm-project?rev=244928&view=rev Log: Remove and forbid raw_svector_ostream::flush() calls. After r244870 flush() will only compare two null pointers and return, doing nothing but wasting run time. The c

r245184 - Enable passing test on Windows + MSYS.

Author: yrnkrn Date: Sun Aug 16 14:02:49 2015 New Revision: 245184 URL: http://llvm.org/viewvc/llvm-project?rev=245184&view=rev Log: Enable passing test on Windows + MSYS. Modified: cfe/trunk/test/Preprocessor/macro-multiline.c Modified: cfe/trunk/test/Preprocessor/macro-multiline.c URL: h

r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

Author: yrnkrn Date: Wed Aug 19 12:02:32 2015 New Revision: 245459 URL: http://llvm.org/viewvc/llvm-project?rev=245459&view=rev Log: According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes. See https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/i386-and-x86-64-Options.html Added: cf

r245462 - Add REQUIRES: x86-registered-target to test since it's required.

Author: yrnkrn Date: Wed Aug 19 12:18:32 2015 New Revision: 245462 URL: http://llvm.org/viewvc/llvm-project?rev=245462&view=rev Log: Add REQUIRES: x86-registered-target to test since it's required. Modified: cfe/trunk/test/CodeGen/mingw-long-double-size.c Modified: cfe/trunk/test/CodeGen/mi

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

Sorry to notice late (just diagnosed the issue from a failing boost::math test), according to i686 ABI, long double size on x86 is 12 bytes (the memory allocated, not the underlying 80 bits register), see https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/i386-and-x86-64-Options.html -m128bit-long-double

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

ddress-aware' Thread model: posix gcc version 5.1.0 (i686-posix-dwarf-rev0, Built by MinGW-W64 project) sh-4.3$ g++ a.cpp sh-4.3$ ./a.exe 12 Without the patch clang outputs 16 and seg faults on a boost::math example. 2015-08-19 21:29 GMT+03:00 Richard Smith : > On Wed, Aug 19, 2015 at

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

Yes, worth merging with Richard approval. 2015-08-19 23:16 GMT+03:00 Hans Wennborg : > I assume this is a merge request? > > Richard: what do you think about r245459+r245462? > > > > On Wed, Aug 19, 2015 at 10:22 AM, Yaron Keren > wrote: > > Sorry to notice late (just diagnosed the issue from a

r245607 - Fix test on Windows to accept both gcc and gcc.exe.

Author: yrnkrn Date: Thu Aug 20 15:37:58 2015 New Revision: 245607 URL: http://llvm.org/viewvc/llvm-project?rev=245607&view=rev Log: Fix test on Windows to accept both gcc and gcc.exe. Modified: cfe/trunk/test/Driver/biarch.c Modified: cfe/trunk/test/Driver/biarch.c URL: http://llvm.org/vi

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

> gcc version 5.1.0 (i686-posix-dwarf-rev0, Built by MinGW-W64 project) >> >> sh-4.3$ g++ a.cpp >> sh-4.3$ ./a.exe >> 12 >> >> Without the patch clang outputs 16 and seg faults on a boost::math >> example. >> > > None of that answers m

r245618 - Revert the 32bit part of r245084; mingw values were correct before it.

Author: yrnkrn Date: Thu Aug 20 16:36:14 2015 New Revision: 245618 URL: http://llvm.org/viewvc/llvm-project?rev=245618&view=rev Log: Revert the 32bit part of r245084; mingw values were correct before it. Modified: cfe/trunk/lib/Basic/Targets.cpp Modified: cfe/trunk/lib/Basic/Targets.cpp URL

r245620 - Revert the 64bit part of r245084; long double values were not changed by

Author: yrnkrn Date: Thu Aug 20 16:51:46 2015 New Revision: 245620 URL: http://llvm.org/viewvc/llvm-project?rev=245620&view=rev Log: Revert the 64bit part of r245084; long double values were not changed by it as they are already set correctly by X86_64TargetInfo and X86TargetInfo. Modified:

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

-rev0/mingw32/opt/include >>>> -I/c/mingw510/prerequisites/i686-zlib-static/include >>>> -I/c/mingw510/prerequisites/i686-w64-mingw32-static/include' CXXFLAGS='-O2 >>>> -pipe -I/c/mingw510/i686-510-posix-dwarf-rt_v4-rev0/mingw32/opt/include >>>&

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

t;> --disable-sjlj-exceptions --with-dwarf2 --disable-isl-version-check >>>>>> --disable-libstdcxx-pch --disable-libstdcxx-debug --enable-bootstrap >>>>>> --disable-rpath --disable-win32-registry --disable-nls --disable-werror >>>>>> --disable-symve

r245679 - Expand mingw-long-double.c to test for long double alignment.

Author: yrnkrn Date: Fri Aug 21 03:26:31 2015 New Revision: 245679 URL: http://llvm.org/viewvc/llvm-project?rev=245679&view=rev Log: Expand mingw-long-double.c to test for long double alignment. Added: cfe/trunk/test/CodeGen/mingw-long-double.c Removed: cfe/trunk/test/CodeGen/mingw-long-

[clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

Author: yrnkrn Date: Fri Aug 21 04:27:24 2015 New Revision: 245683 URL: http://llvm.org/viewvc/llvm-project?rev=245683&view=rev Log: Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput. Modified: clang-tools-extra/trunk/clang-tidy/tool/clang-tidy-diff.py Modified: clang-tool

[clang-tools-extra] r245688 - Make test EOL tolerant by moving the symbol ot the first line

Author: yrnkrn Date: Fri Aug 21 05:46:46 2015 New Revision: 245688 URL: http://llvm.org/viewvc/llvm-project?rev=245688&view=rev Log: Make test EOL tolerant by moving the symbol ot the first line before any EOL changes the byte offset count and enable it on Windows. Modified: clang-tools-extr

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

21, 2015 at 11:27 AM, Yaron Keren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: yrnkrn >> Date: Fri Aug 21 04:27:24 2015 >> New Revision: 245683 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=245683&view=rev >> Log: >>

r246026 - Make FileManager::getFileSystemOptions consistent with CompilerInstance::getFileSystemOpts

Author: yrnkrn Date: Wed Aug 26 03:10:22 2015 New Revision: 246026 URL: http://llvm.org/viewvc/llvm-project?rev=246026&view=rev Log: Make FileManager::getFileSystemOptions consistent with CompilerInstance::getFileSystemOpts and CompilerInvocation::getFileSystemOpts by renaming it to getFileSystem

Re: [PATCH] D12466: Fix empty -L Path on OSX hosts

yaron.keren added a comment. I have never used OSX, Try to add one of the Apple clang developers as reviewers, they know more than me about OSX. My guess there should not be empty paths in in TC.getFilePaths(). That patch seems only to sidestep the issue which will probably surface in other pl

r246385 - Make test resistant to false matches of numbered (unnamed) labels inside other numbers.

Author: yrnkrn Date: Sun Aug 30 10:24:46 2015 New Revision: 246385 URL: http://llvm.org/viewvc/llvm-project?rev=246385&view=rev Log: Make test resistant to false matches of numbered (unnamed) labels inside other numbers. In release builds labels are numbers. Matching just the number may result i

r246391 - Fix test for Release builds, the label form is :14, not 14.

Author: yrnkrn Date: Sun Aug 30 12:46:43 2015 New Revision: 246391 URL: http://llvm.org/viewvc/llvm-project?rev=246391&view=rev Log: Fix test for Release builds, the label form is :14, not 14. Modified: cfe/trunk/test/CodeGen/sanitize-trap.c Modified: cfe/trunk/test/CodeGen/sanitize-trap.c

r246520 - Fix path seperator for Windows.

Author: yrnkrn Date: Mon Aug 31 20:29:13 2015 New Revision: 246520 URL: http://llvm.org/viewvc/llvm-project?rev=246520&view=rev Log: Fix path seperator for Windows. Modified: cfe/trunk/test/Driver/solaris-ld.c Modified: cfe/trunk/test/Driver/solaris-ld.c URL: http://llvm.org/viewvc/llvm-pr

Re: r246534 - [modules] When emitting line tables, only emit filenames that are actually referenced by the entries that we emit.

Hi Richard, Since yesterday I see several clang test failures which *may* be related to the series of patches of modules you comitted. These are: Clang :: Modules/cxx-templates.cpp Clang :: Modules/submodules-merge-defs.cpp Clang :: PCH/cxx-key-functions.cpp

Re: [clang-tools-extra] r245683 - Tweak clang-tidy-diff.py to recognize "filename" in the diff ourput.

On Linux: >> ~$ diff -U0 ./a.cpp b\ b.cpp >> --- ./a.cpp 2015-08-14 00:27:03.569276652 +0300 >> +++ "b b.cpp" 2015-08-21 13:54:26.787896719 +0300 >> >> filename with space will break current clang-tidy-diff.py on all platforms, the regular expression do

[clang-tools-extra] r246575 - Add \n to the regex in clang-tidy-diff.py in order to fix http://llvm.org/PR24637,

Author: yrnkrn Date: Tue Sep 1 14:08:17 2015 New Revision: 246575 URL: http://llvm.org/viewvc/llvm-project?rev=246575&view=rev Log: Add \n to the regex in clang-tidy-diff.py in order to fix http://llvm.org/PR24637, git usecase for multiple files diff. Modified: clang-tools-extra/trunk/clan

Re: r246546 - Reverting r246497 (which requires also reverting r246524 and r246521 to avoid merge conflicts). It broke the build on MSVC 2015. It also broke an MSVC 2013 bot with testing issues.

Thanks! 2015-09-01 16:24 GMT+03:00 Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org>: > Author: aaronballman > Date: Tue Sep 1 08:24:39 2015 > New Revision: 246546 > > URL: http://llvm.org/viewvc/llvm-project?rev=246546&view=rev > Log: > Reverting r246497 (which requires also revertin

Move createEliminateAvailableExternallyPass earlier

Following the discussion on cfe-dev, this moves createEliminateAvailableExternallyPass earlier in the pass pipeline to save running many ModulePasses on available external functions that are thrown away anyhow. Index: lib/Transforms/IPO/PassManagerBuilder.cpp ===

Re: Move createEliminateAvailableExternallyPass earlier

t; > On Tue, Sep 1, 2015 at 1:32 PM, Yaron Keren via cfe-commits > wrote: > > Following the discussion on cfe-dev, this moves > > createEliminateAvailableExternallyPass earlier in the pass pipeline to > save > > running many M

Re: [PATCH] D12087: always_inline codegen rewrite

yaron.keren added a comment. In CGCXX.cpp, may be fixable after this commit: // FIXME: An extern template instantiation will create functions with // linkage "AvailableExternally". In libc++, some classes also define // members with attribute "AlwaysInline" and expect no reference to // b

Patch for PR23472

http://llvm.org/pr23472 As suggested by Reid, OK to commit? Index: tools/clang/lib/CodeGen/ItaniumCXXABI.cpp === --- tools/clang/lib/CodeGen/ItaniumCXXABI.cpp (revision 246575) +++ tools/clang/lib/CodeGen/ItaniumCXXABI.cpp (workin

Re: Patch for PR23472

r246803, thanks! 2015-09-03 23:16 GMT+03:00 Reid Kleckner : > LGTM, but I would expand on the comment a bit: > // The ABI says: "It is suggested that it be emitted in the same > COMDAT group > // as the associated data object." In practice, this doesn't work for > non-ELF object format

r250921 - Rename clang config.h include guard from CONFIG_H to CLANG_CONFIG_H

Author: yrnkrn Date: Wed Oct 21 13:16:01 2015 New Revision: 250921 URL: http://llvm.org/viewvc/llvm-project?rev=250921&view=rev Log: Rename clang config.h include guard from CONFIG_H to CLANG_CONFIG_H to make it different from LLVM config.h include guard. Modified: cfe/trunk/include/clang/Co

Re: r251567 - Fix the calling convention of Mingw64 long double values

Thanks! 2015-10-29 0:29 GMT+02:00 Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org>: > Author: rnk > Date: Wed Oct 28 17:29:52 2015 > New Revision: 251567 > > URL: http://llvm.org/viewvc/llvm-project?rev=251567&view=rev > Log: > Fix the calling convention of Mingw64 long double values

Re: [PATCH] D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target

yaron.keren added a subscriber: cfe-commits. yaron.keren added a comment. We did not have cfe-commits as subscriber so I'm adding it now (this is a clang commit), see if someone would like to further comment. http://reviews.llvm.org/D14164 ___ cfe

Re: [PATCH] D14164: Driver: fallback to parent directory of clang if no sysroot for mingw-w64 target

yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. The formatting is wrong, aligned to the right, clang-format the new code. Can we control getInstalledDir() when running under LIT so this co

r252404 - Remove spaces at start of line, NFC.

Author: yrnkrn Date: Sat Nov 7 10:24:52 2015 New Revision: 252404 URL: http://llvm.org/viewvc/llvm-project?rev=252404&view=rev Log: Remove spaces at start of line, NFC. Modified: cfe/trunk/include/clang/Frontend/CompilerInvocation.h Modified: cfe/trunk/include/clang/Frontend/CompilerInvoca

r252405 - Remove spaces in empty line, NFC.

Author: yrnkrn Date: Sat Nov 7 10:35:07 2015 New Revision: 252405 URL: http://llvm.org/viewvc/llvm-project?rev=252405&view=rev Log: Remove spaces in empty line, NFC. Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp URL: http://llvm.org/viewvc/llv

r252426 - Replace tab with 8 spaces, NFC.

Author: yrnkrn Date: Sun Nov 8 16:01:45 2015 New Revision: 252426 URL: http://llvm.org/viewvc/llvm-project?rev=252426&view=rev Log: Replace tab with 8 spaces, NFC. Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL: http://llvm.org/viewvc/llvm-projec

  1   2   >