Author: yrnkrn
Date: Sun Nov 8 16:01:45 2015
New Revision: 252426
URL: http://llvm.org/viewvc/llvm-project?rev=252426&view=rev
Log:
Replace tab with 8 spaces, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL:
http://llvm.org/viewvc/llvm-projec
Author: yrnkrn
Date: Thu Aug 6 02:28:36 2015
New Revision: 244196
URL: http://llvm.org/viewvc/llvm-project?rev=244196&view=rev
Log:
Plug a memory leak in NeonEmitter: Intrinsics allocated were never released.
Modified:
cfe/trunk/utils/TableGen/NeonEmitter.cpp
Modified: cfe/trunk/utils/Tabl
Author: yrnkrn
Date: Fri Aug 7 05:15:15 2015
New Revision: 244312
URL: http://llvm.org/viewvc/llvm-project?rev=244312&view=rev
Log:
Silence tools/clang/lib/Tooling/CompilationDatabase.cpp:328:12: warning:
‘clang::tooling::JSONAnchorDest’ defined but not used [-Wunused-variable]
from gcc 5.1.
Mo
Author: yrnkrn
Date: Fri Aug 7 11:37:34 2015
New Revision: 244329
URL: http://llvm.org/viewvc/llvm-project?rev=244329&view=rev
Log:
Silence gcc 5.1 unused variable warnings using LLVM_ATTRIBUTE_UNUSED.
Modified:
clang-tools-extra/trunk/clang-tidy/tool/ClangTidyMain.cpp
Modified: clang-tool
This issue is surfacing regulary. In cases where clang prints the escaped
path we have to use {{/} which is not very readable, for example in
mingw driver case:
// CHECK_MINGW_ORG_TREE:
"{{.*}}/Inputs/mingw_mingw_org_tree/mingw{{/|}}lib{{/|}}gcc{{/|}}mingw32{{/|}}4.8.1{{/|}
Author: yrnkrn
Date: Thu Jul 21 02:44:41 2016
New Revision: 276252
URL: http://llvm.org/viewvc/llvm-project?rev=276252&view=rev
Log:
Provide __GLIBCXX_TYPE_INT_N_0 and __GLIBCXX_BITSIZE_INT_N_0 when in C++ gnu
language extensions.
These are used by libstdc++ for is_integral<__int128>.
Addresses
Author: yrnkrn
Date: Mon Aug 1 05:14:54 2016
New Revision: 277334
URL: http://llvm.org/viewvc/llvm-project?rev=277334&view=rev
Log:
Allow .exe extension to ld to fix test with mingw.
Modified:
cfe/trunk/test/Driver/offloading-interoperability.c
Modified: cfe/trunk/test/Driver/offloading-in
Author: yrnkrn
Date: Sun Feb 7 06:44:35 2016
New Revision: 260028
URL: http://llvm.org/viewvc/llvm-project?rev=260028&view=rev
Log:
Use CodeGenModule::addReplacement() instead of directly accessing
Replacements[].
This helps when trying to debug who inserted into Replacements.
Modified:
cf
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
We have tried to keep one copy of http://reviews.llvm.org/D11103
Can it share the Module->getDataLayout() ?
http://reviews.llvm.org/D17183
___
cfe-commits mailing list
cfe-com
yaron.keren added a comment.
It certainly makes sense to redirect the module request to its owner instead of
duplicating it in a local copy.
There may be a change in behaviour here, pre-patch
CodeGenAction::EndSourceFileAction() would take the BackendConsumer Module,
keeping CodeGen Module int
yaron.keren accepted this revision.
yaron.keren added a reviewer: yaron.keren.
yaron.keren added a comment.
This revision is now accepted and ready to land.
Would be nice to have CodeGenAction::TheModule redirect to CodeGeneratorImpl::M
if possible, but that's for another patch. LGTM.
http://re
Hi Nico,
In other tests, {{/|}} or {{/|\\}} are used match the forward or
backward slash(es). clang escapes \ so we get two of them in output and
four in the LIT test.
It would be nice to have more elegant construct for this general problem,
to avoid tests like:
"{{.*}}/Inputs/mingw_mingw_or
Author: yrnkrn
Date: Fri May 13 09:53:19 2016
New Revision: 269423
URL: http://llvm.org/viewvc/llvm-project?rev=269423&view=rev
Log:
Prune four superfluous ExternalSemaSource.h includes and one forward
declaration in Sema.h
where ExternalSemaSource.h was already included due to ExternalSemaSource
yaron.keren added a subscriber: yaron.keren.
yaron.keren accepted this revision.
yaron.keren added a reviewer: yaron.keren.
yaron.keren added a comment.
This revision is now accepted and ready to land.
result of r269402, LGTM
http://reviews.llvm.org/D20240
___
Author: yrnkrn
Date: Tue May 17 14:01:16 2016
New Revision: 269801
URL: http://llvm.org/viewvc/llvm-project?rev=269801&view=rev
Log:
Teach clang to look for libcxx in /usr/local/include/c++ on Linux
As The default CMAKE install prefix is /usr/local (
https://cmake.org/cmake/help/v3.0/variable/CM
+1, if possible. There is a if (getLangOpts().ObjC1) block just before this.
2016-04-03 14:21 GMT+03:00 Vassil Vassilev via cfe-commits <
cfe-commits@lists.llvm.org>:
> On 04/02/16 01:55, Ben Langmuir via cfe-commits wrote:
>
>> Author: benlangmuir
>> Date: Wed Feb 3 18:55:24 2016
>> New Revisio
> “weird” to see it in the AST?
>
> On Apr 3, 2016, at 5:21 AM, Yaron Keren wrote:
>
> +1, if possible. There is a if (getLangOpts().ObjC1) block just before
> this.
>
> 2016-04-03 14:21 GMT+03:00 Vassil Vassilev via cfe-commits <
> cfe-commits@lists.llvm.org>:
If used only for Darwin, could this depend
on Target.getTriple().isOSDarwin() ?
2016-04-11 17:18 GMT+03:00 Ben Langmuir :
>
> On Apr 3, 2016, at 10:57 AM, Yaron Keren wrote:
>
> I look at many AST dumps for small reduced code so it's mostly weird to
> see this in the AST
Author: yrnkrn
Date: Wed Jun 1 08:47:26 2016
New Revision: 271392
URL: http://llvm.org/viewvc/llvm-project?rev=271392&view=rev
Log:
Fix the CLANG_ENABLE_STATIC_ANALYZER=OFF build.
tools/clang/tools/CMakeLists.txt does not create the
clang-check target when CLANG_ENABLE_STATIC_ANALYZER=OFF.
Mod
Thanks! I've just noticed this today locally. It happens with unoptimized
builds only so the bots are not catching it.
2016-06-01 18:17 GMT+03:00 Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org>:
> Author: aaronballman
> Date: Wed Jun 1 10:17:54 2016
> New Revision: 271399
>
> URL:
yaron.keren added a subscriber: yaron.keren.
yaron.keren accepted this revision.
yaron.keren added a reviewer: yaron.keren.
yaron.keren added a comment.
This revision is now accepted and ready to land.
You mean
Some target platforms do not support -fsanitize=address.
http://reviews.llvm.org/D21
Author: yrnkrn
Date: Wed Jun 29 13:55:53 2016
New Revision: 274149
URL: http://llvm.org/viewvc/llvm-project?rev=274149&view=rev
Log:
Add CapturedDecl::parameters() ArrayRef accessors following r273647.
Modified:
cfe/trunk/include/clang/AST/Decl.h
Modified: cfe/trunk/include/clang/AST/Decl.h
Seems this commit broke a builder,
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26133
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26134
TEST 'Clang-Unit ::
ASTMatchers/ASTMatchersTests/Declaratio
Author: yrnkrn
Date: Wed Jul 13 14:04:51 2016
New Revision: 275303
URL: http://llvm.org/viewvc/llvm-project?rev=275303&view=rev
Log:
Implement FunctionDecl::getDefinition() to be consistent with
VarDecl, TagDecl, EnumDecl, RecordDecl, CXXRecordDecl.
Use getDefinition in two locations to make the
Author: yrnkrn
Date: Wed Mar 16 07:14:43 2016
New Revision: 263635
URL: http://llvm.org/viewvc/llvm-project?rev=263635&view=rev
Log:
Directly get the canonical Type instead of going around through a CanQualType
temporary, NFC.
Modified:
cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp
Modified: cfe
Author: yrnkrn
Date: Fri Jan 22 13:03:27 2016
New Revision: 258524
URL: http://llvm.org/viewvc/llvm-project?rev=258524&view=rev
Log:
Merge templated static member variables, fixes http://llvm.org/pr26179.
Patch by Vassil Vassilev!
Reviewed by Richard Smith.
Added:
cfe/trunk/test/Modules/Inp
Committed revision 258524.
2016-01-21 19:33 GMT+02:00 Vassil Vassilev via cfe-commits <
cfe-commits@lists.llvm.org>:
> ping... (perhaps someone else with commit rights can check it it...)
> --Vassil
>
> On 18/01/16 22:07, Vassil Vassilev wrote:
>
> Thanks! Could you check it in?
> -- Vassil
> On
The instantiated does get a new collection of ParmVarDecls while getting
the pattern Type which points to the pattern ParmVarDecls. So the
ParmVarDecls pointed in the instantiated are not the same as those pointed
by its Type.
Traversing by Type or by the Decl finds a different set of ParmVarDecls
Author: yrnkrn
Date: Fri Jan 29 07:46:15 2016
New Revision: 259192
URL: http://llvm.org/viewvc/llvm-project?rev=259192&view=rev
Log:
Implement TemplateArgument::dump() method for debugging, patterned after
TemplateName::dump().
Modified:
cfe/trunk/include/clang/AST/TemplateBase.h
cfe/tr
OK. There are more un-annotated dump() methods such
as TemplateName::dump(),
NestedNameSpecifier::dump(), ASTReader::dump(), ModuleMap::dump(),
MacroInfo::dump(),
...
Annotate all dump() methods LLVM_DUMP_METHOD ?
2016-01-29 19:37 GMT+02:00 Richard Smith :
> On 29 Jan 2016 5:50 a.m., &qu
Author: yrnkrn
Date: Fri Jan 29 13:38:18 2016
New Revision: 259232
URL: http://llvm.org/viewvc/llvm-project?rev=259232&view=rev
Log:
Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192
post commit comment.
Modified:
cfe/trunk/lib/AST/APValue.cpp
cfe/trunk/lib
Committed clang part in r259232, LLVM part in r259240.
2016-01-29 21:22 GMT+02:00 Richard Smith :
> On Fri, Jan 29, 2016 at 11:13 AM, Yaron Keren
> wrote:
> > OK. There are more un-annotated dump() methods such as
> > TemplateName::dump(), NestedNameSpecifier::dump(
Author: yrnkrn
Date: Fri Nov 13 09:39:39 2015
New Revision: 253046
URL: http://llvm.org/viewvc/llvm-project?rev=253046&view=rev
Log:
Deduplicate three identical copies of isExplicitInstantiationOrSpecialization,
NFC.
Modified:
cfe/trunk/include/clang/AST/DeclTemplate.h
cfe/trunk/include
Author: yrnkrn
Date: Fri Nov 13 13:46:02 2015
New Revision: 253066
URL: http://llvm.org/viewvc/llvm-project?rev=253066&view=rev
Log:
Add test case for mingw -fuse-ld= support introduced in r242121.
Added:
cfe/trunk/test/Driver/mingw-useld.c
Added: cfe/trunk/test/Driver/mingw-useld.c
URL:
h
Author: yrnkrn
Date: Fri Nov 13 14:02:08 2015
New Revision: 253069
URL: http://llvm.org/viewvc/llvm-project?rev=253069&view=rev
Log:
Relax mingw-useld test to fix bot failures.
Modified:
cfe/trunk/test/Driver/mingw-useld.c
Modified: cfe/trunk/test/Driver/mingw-useld.c
URL:
http://llvm.org/
Sure, r253066.
2015-11-13 19:40 GMT+02:00 Rafael Espíndola :
> This needs a testcase. Nothing is checking the linker invocation.
>
> On 14 July 2015 at 01:23, Yaron Keren wrote:
> > Author: yrnkrn
> > Date: Tue Jul 14 00:23:34 2015
> > New Revision: 242121
> >
Filipe: with mingw targetting Windows/COFF files I think only ld and lld
makes sense as gold creates ELF files. I included Microsoft link.exe in the
mingw-useld test but rethinking, no one really uses that configuration, see
attached patch. Is that what you mean?
Rafael: running under Windows whic
Author: yrnkrn
Date: Sun Nov 15 02:06:27 2015
New Revision: 253161
URL: http://llvm.org/viewvc/llvm-project?rev=253161&view=rev
Log:
Make the mingw toolchain accept 'ld' and 'lld' only as values to -fuse-ld.
Post-commit suggestion by Filipe Cabecinhas.
Modified:
cfe/trunk/lib/Driver/Tools.cp
ave no objections we will just have to look at
> having lld's cmake to ensure it is created on Windows like we do for clang++
>
> The idea of forcing either lld or ld LGTM yaron.
> I don't think using MSVC link.exe makes any sense to mingw users.
>
> On Saturday, November
Author: yrnkrn
Date: Mon Nov 23 13:28:42 2015
New Revision: 253904
URL: http://llvm.org/viewvc/llvm-project?rev=253904&view=rev
Log:
Replace loop with std::any_of, NFC.
Inspired by similar commits from Craig Topper.
Modified:
cfe/trunk/lib/Sema/SemaLookup.cpp
Modified: cfe/trunk/lib/Sema/Se
Searching for gcc on Linux is not a good idea, you'll find the system one
not the mingw one. Searching for i686-w64-mingw32-gcc or
x86_64-w64-mingw32-gcc should work better, that is searching for:
getTriple().getArchName()) + "-w64-mingw32-gcc"
Moreover, this should work on Windows as well, min
yaron.keren added a comment.
This always searches for something-gcc and then discards the result if sysroot
was provided, which is a waste.
Move the searching to a helper function and then it can be done only if sysroot
was not provided, as it is now.
The break is needed to avoid looking for mi
yaron.keren added a comment.
findGccDir() can return llvm::ErrorOr and then all Base
assignments happen at the same if-elseif-else:
if (getDriver().SysRoot.size())
Base = getDriver().SysRoot;
else if (llvm::ErrorOr GPPName = findGccDir())
Base = llvm::sys::path::parent_path(
Author: yrnkrn
Date: Tue Dec 1 02:14:39 2015
New Revision: 254392
URL: http://llvm.org/viewvc/llvm-project?rev=254392&view=rev
Log:
Remove superfluous StringRef casts, NFC.
Modified:
cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp
URL:
http://
yaron.keren added a subscriber: yaron.keren.
yaron.keren added a comment.
There is another copy of getEffectiveDeclContext in MicrosoftMangle.cpp which
pre-commit was identical to this one.
Should it get this commit as well to keep both identical?
If so, could both copies of getEffectiveDeclConte
MSVC 2013 Update 5 accepts for (bool SkipUnwritten : {false, true}).
Possibly changed in one of the Updates?
2015-12-14 23:35 GMT+02:00 Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org>:
> aaron.ballman added a subscriber: aaron.ballman.
>
>
> Comment at: lib/ASTMatcher
On Mon, Dec 14, 2015 at 4:39 PM, Yaron Keren
> wrote:
> > MSVC 2013 Update 5 accepts for (bool SkipUnwritten : {false, true}).
> > Possibly changed in one of the Updates?
>
> I tested using MSVC 2013 Update 5.
>
> Microsoft Visual Studio Ultimate 2013
> Version 12.0.4
yaron.keren added inline comments.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:322
@@ +321,3 @@
+ for (bool SkipUnwritten : SkipUnwrittenCases) {
+llvm::SmallString<128> NodeName = StringRef("::");
+llvm::raw_svector_ostream OS(NodeName);
StringRe
yaron.keren added a comment.
http://bb.pgr.jp/grid
http://reviews.llvm.org/D15579
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren accepted this revision.
yaron.keren added a comment.
This revision is now accepted and ready to land.
LGTM with some tests cases.
http://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
Author: yrnkrn
Date: Fri Dec 18 04:30:12 2015
New Revision: 255993
URL: http://llvm.org/viewvc/llvm-project?rev=255993&view=rev
Log:
Replace SM.getFileEntryForID(Lexer->getFileID()) with Lexer->getFileEntry().
Modified:
cfe/trunk/lib/Lex/PPDirectives.cpp
cfe/trunk/lib/Lex/PPLexerChange.c
Author: yrnkrn
Date: Wed Dec 23 14:38:13 2015
New Revision: 256349
URL: http://llvm.org/viewvc/llvm-project?rev=256349&view=rev
Log:
Replace isa+cast with dyn_cast and obey the no else after return rule.
Modified:
cfe/trunk/lib/Sema/SemaExpr.cpp
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp
URL
Author: yrnkrn
Date: Sun Dec 27 08:34:22 2015
New Revision: 256472
URL: http://llvm.org/viewvc/llvm-project?rev=256472&view=rev
Log:
Constify NestedNameSpecifier::dump and add a no-argument dump function suitable
for calling from a debugger.
Modified:
cfe/trunk/include/clang/AST/NestedNameS
Author: Yaron Keren
Date: 2021-08-31T18:57:47+03:00
New Revision: 10d78a06baa217b8a4b853eff962e9ae719a8a45
URL:
https://github.com/llvm/llvm-project/commit/10d78a06baa217b8a4b853eff962e9ae719a8a45
DIFF:
https://github.com/llvm/llvm-project/commit/10d78a06baa217b8a4b853eff962e9ae719a8a45.diff
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG27e2ff964fc3: Address http://bugs.llvm.org/pr30994 so that a
non-friend can properly replace… (authored by yaron.keren).
H
yaron.keren created this revision.
yaron.keren added reviewers: Orlando, probinson, tstellar.
yaron.keren requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Three tests fail when building and testing LLVM from the Visual C++ environment
since
yaron.keren added a comment.
looking into Linux failures
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108085/new/
https://reviews.llvm.org/D108085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yaron.keren updated this revision to Diff 366515.
yaron.keren added a comment.
Support both Windows llvm-lit.py and Linux llvm-lit command name
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108085/new/
https://reviews.llvm.org/D108085
Files:
cla
yaron.keren created this revision.
yaron.keren requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D108218
Files:
clang/test/utils/update_cc_test_checks/lit.local.cfg
Index: c
yaron.keren abandoned this revision.
yaron.keren added a comment.
opened by mistake
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108218/new/
https://reviews.llvm.org/D108218
___
cfe-commits mailing list
yaron.keren updated this revision to Diff 366941.
yaron.keren added a comment.
Switched to Linux repo
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108085/new/
https://reviews.llvm.org/D108085
Files:
clang/test/utils/update_cc_test_checks/lit.lo
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5aa0f9cc9ab2: Use installed llvm-lit.py instead of lit.py
PR-51072 (authored by yaron.keren).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108085/new/
http
yaron.keren added inline comments.
Comment at: clang/lib/Serialization/ASTReader.cpp:4268
// Read the AST block.
if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities))
+ return Failure;
Result is unused now.
Comment
yaron.keren added inline comments.
Comment at: clang/lib/Serialization/ASTReader.cpp:4268
// Read the AST block.
if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities))
+ return Failure;
vsapsai wrote:
> yaron.keren wrote:
> > Result is
yaron.keren added inline comments.
Comment at: lib/Basic/FileManager.cpp:218
+#ifdef LLVM_ON_WIN32
+ SmallString<128> NormalizedPath(Filename.str());
+ llvm::sys::path::native(NormalizedPath);
I'd use a larger SmallString<256>, with large projects 128 bytes are
yaron.keren added a comment.
While at it, llvm.org/pr30994
Repository:
rL LLVM
https://reviews.llvm.org/D28399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren added a comment.
Could use dumpDeclContext() to test?
https://reviews.llvm.org/D31187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren created this revision.
Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace
a friend, and a visible friend can properly replace an invisible friend but not
vice verse. This also fixes two FIXME in SemaTemplate/friend-template.cpp.
Repository:
rL LLVM
ht
yaron.keren added inline comments.
Comment at: cmake/modules/HandleLLVMOptions.cmake:562
add_flag_if_supported("-Wstring-conversion" STRING_CONVERSION_FLAG)
+else()
+ append("-w" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
note this is an else to
if (LLVM_ENABLE_WARNINGS
yaron.keren added a comment.
Thanks, I'll make a test.
Repository:
rL LLVM
https://reviews.llvm.org/D31540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren updated this revision to Diff 94961.
yaron.keren added a comment.
Added attribute test.
https://reviews.llvm.org/D31540
Files:
tools/clang/include/clang/AST/DeclBase.h
tools/clang/lib/AST/Decl.cpp
tools/clang/lib/AST/DeclBase.cpp
tools/clang/test/SemaTemplate/friend-template
yaron.keren added reviewers: mati865, rnk.
yaron.keren added a comment.
Adding Mateusz and Reid.
Repository:
rL LLVM
https://reviews.llvm.org/D15006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
yaron.keren reopened this revision.
yaron.keren added a comment.
reverted in r300497
Repository:
rL LLVM
https://reviews.llvm.org/D31540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
yaron.keren added a comment.
In https://reviews.llvm.org/D28399#642458, @v.g.vassilev wrote:
> @yaron.keren, it seems that http://llvm.org/pr30994 concerns friend function
> declarations. My current patch focuses on friend class templates. Perhaps we
> should open another review item for a fix
yaron.keren accepted this revision.
yaron.keren added a comment.
This revision is now accepted and ready to land.
LGTM, matches the code in libstdc++ stdarg,h.
You can remove the 'hack' comment in line 46, __GNUC_VA_LIST is just a standard
include guard for the typedef.
https://reviews.llvm.or
yaron.keren added a comment.
This code is actually used with Windows as well as Linux (with the exception of
line 218), see the comment blocks above for detailed include dirs from all
platforms from which it was derived.
Please make sure include dirs between gcc and clang match after the patch
yaron.keren added a comment.
Hiding these two include dirs removes many headers. Most has clang equivalents
but not all of them.
For example quadmath.h is only there, and without the include path programs
using it will fail to compile.
The reason mingw limits.h isn't used in your example is tha
yaron.keren added a comment.
The gcc include dirs in mingw contains headers not available esewhere and thus
can't be removed.
Notable examples,
omp.h - OpenMP functions
openacc.h - OpenACC functions
quadmath.h - QUADMATH functions
https://reviews.llvm.org/D29464
__
yaron.keren added a comment.
What about omp.h and openacc.h ? many programs are using OpenMP.
You raised real issues which should certainly be solved with clang mingw
support.
Removing the gcc dirs from include path will break any program that currently
uses or depends in any way on any header
yaron.keren added a comment.
These directories are "mostly" equivalent, with some headers existing is mings
gcc dir but missing in clang resource dir and thus will break compilation.
For example, the most popular (37089 download this week)
https://sourceforge.net/projects/mingw-w64 distribuion f
yaron.keren added a comment.
If something is broken now we don't break it even more.
__float128 remain be fixed to be compatible, not only some poor developer would
have to fix the missing headers bug one day, he will have to re-fix limits.h
the right way and undo this "fix".
There is a problems
yaron.keren added a comment.
OK.
https://reviews.llvm.org/D29464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren added inline comments.
Comment at: lib/AST/ASTContext.cpp:8258
return RHS;
-return isa(LHS) ? getReadPipeType(ResultType)
- : getWritePipeType(ResultType);
+const PipeType *PT = LHS->getAs();
+return PT->isReadOnly()
yaron.keren accepted this revision.
yaron.keren added a comment.
This revision is now accepted and ready to land.
LGTM after fixing the inline comment
Comment at: lib/Serialization/ASTReader.cpp:5804
QualType ElementType = readType(*Loc.F, Record, Idx);
-return Context
yaron.keren added a comment.
Please move the =new out of the PP.AddPragmaHandler calls.
While at it, this code still (as the original) leaks the PragmaHandlers. These
should be deleted after RemovePragmaHandler or instead, simply use
std::unique_ptr.
https://reviews.llvm.org/D32486
yaron.keren accepted this revision.
yaron.keren added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
yaron.keren added a comment.
Raphael , do you have commit access? should I commit this?
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren added a comment.
OK
https://reviews.llvm.org/D32486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaron.keren created this revision.
yaron.keren added a reviewer: tstellar.
yaron.keren requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D109000
Files:
clang/test/utils/update
yaron.keren marked an inline comment as done.
yaron.keren added inline comments.
Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24
+# Windows: llvm-lit.py, Linux: llvm-lit
+llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0]
+lit = config.l
yaron.keren added a comment.
Addressing comment in https://reviews.llvm.org/D108085
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109000/new/
https://reviews.llvm.org/D109000
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rG10d78a06baa2: [llvm-lit] unbreak clang-only builds by not
assuming llvm-lit in build dir (authored by yaron.keren).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
101 - 192 of 192 matches
Mail list logo
