[PATCH] D40058: add check to avoid throwing objc exception according to Google Objective-C guide

Wizard updated this revision to Diff 123089. Wizard marked 2 inline comments as done. Wizard added a comment. address comments https://reviews.llvm.org/D40058 Files: clang-tidy/google/AvoidThrowingObjcExceptionCheck.cpp clang-tidy/google/AvoidThrowingObjcExceptionCheck.h clang-tidy/google

[PATCH] D40058: add check to avoid throwing objc exception according to Google Objective-C guide

Wizard updated this revision to Diff 123090. Wizard marked 6 inline comments as done. Wizard added a comment. rename file https://reviews.llvm.org/D40058 Files: clang-tidy/google/AvoidThrowingObjC2ExceptionCheck.cpp clang-tidy/google/AvoidThrowingObjC2ExceptionCheck.h clang-tidy/google/CM

[PATCH] D40058: add check to avoid throwing objc exception according to Google Objective-C guide

Wizard updated this revision to Diff 123091. Wizard marked an inline comment as done. Wizard added a comment. rename again https://reviews.llvm.org/D40058 Files: clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp clang-tidy/google/AvoidThrowingObjCExceptionCheck.h clang-tidy/google/CMa

[PATCH] D40058: add check to avoid throwing objc exception according to Google Objective-C guide

Wizard updated this revision to Diff 123093. Wizard added a comment. nit fix https://reviews.llvm.org/D40058 Files: clang-tidy/google/AvoidThrowingObjCExceptionCheck.cpp clang-tidy/google/AvoidThrowingObjCExceptionCheck.h clang-tidy/google/CMakeLists.txt clang-tidy/google/GoogleTidyModu

[PATCH] D40058: add check to avoid throwing objc exception according to Google Objective-C guide

This revision was automatically updated to reflect the committed changes. Closed by commit rL318366: add check to avoid throwing objc exception according to Google Objective-C guide (authored by Wizard). Repository: rL LLVM https://reviews.llvm.org/D40058 Files: clang-tools-extra/trunk/clan

[PATCH] D40325: add new check to find OSSpinlock usage

Wizard updated this revision to Diff 123860. Wizard added a comment. add doc to header file https://reviews.llvm.org/D40325 Files: clang-tidy/objc/AvoidSpinlockCheck.cpp clang-tidy/objc/AvoidSpinlockCheck.h clang-tidy/objc/CMakeLists.txt clang-tidy/objc/ObjCTidyModule.cpp docs/Release

[PATCH] D42143: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Wizard retitled this revision from "add ID as a special acronym to objc property declaration check for property names like bundleID. allow using acronyms as suffix." to "add ID as a special acronym to objc property decla

[PATCH] D42143: add ID as a special acronym to objc property declaration check for property names like bundleID.allow using acronyms as suffix.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322602: add ID as a special acronym to objc property declaration check for property… (authored by Wizard, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.ll

[PATCH] D42253: [clang-tidy objc-property-declaration] Expand list of ObjC acronyms

Wizard added a comment. Can you update the doc btw since the acronyms are not only for prefix anymore? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clang-tidy/objc-property-declarati

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:102 +bool hasCategoryPropertyPrefix(const llvm::StringRef &PropertyName) { + for (size_t i = 0; i < PropertyName.size() - 1; ++i) { +if (PropertyName[i] == '_') { benhamil

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131368. Wizard marked an inline comment as done. Wizard added a comment. check for class extentsion Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-prop

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard marked 7 inline comments as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:120 + auto RegexExp = llvm::Regex( + llvm::StringRef(validPropertyNameRegex(Acronyms).replace(0, 2, "^"))); + return RegexExp.match(llvm::StringR

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:93 + [](const std::string &s) { return llvm::Regex::escape(s); }); // Allow any of these names: // foo hokein wrote: > Does the comment still make sense?

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131511. Wizard marked 8 inline comments as done. Wizard added a comment. update some documents and comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/o

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard marked 3 inline comments as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:115 + +bool prefixedPropertyNameMatches(const llvm::StringRef &PropertyName, + const std::vector &Acronyms) { --

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131741. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clang-tidy/objc-propert

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131869. Wizard added a comment. resolve comments and fix some logic Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst test/clan

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131877. Wizard marked 2 inline comments as done. Wizard added a comment. add more tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declara

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard marked 3 inline comments as done. Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:151 + hasCategoryPropertyPrefix(MatchedDecl->getName())) { +const auto *CategoryDecl = (const ObjCCategoryDecl *)(DeclContext); +if (!prefi

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

Wizard updated this revision to Diff 131904. Wizard added a comment. merge changes and add EscapedAcronyms to store the actual acronyms during runtime. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42464 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp clang-tidy/objc/

[PATCH] D42464: add prefix with '_' support for property name. Corresponding apple dev doc: https://developer.apple.com/library/content/qa/qa1908/_index.html

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE323722: add prefix with '_' support for property name. Corresponding apple dev doc… (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D42464?vs=131904&id=131907#to

<    1   2