[PATCH] D128569: Start support for HLSL `RWBuffer`

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1703 LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_pointer, "v*", "i", HLSL_LANG) +LANGBUILTIN(__builtin_hlsl_get_resource_status, "Ui", "i",

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae updated this revision to Diff 431812. python3kgae added a comment. Treat entry functions as in extern C scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124752/new/ https://reviews.llvm.org/D124752 Files: clang/lib/AST/Decl.cpp

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae added a comment. In D124751#3529652 , @MaskRay wrote: > In D124751#3513513 , @python3kgae > wrote: > >> In D124751#3513283 , @MaskRay >> wrote: >> >>> Is the

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae added inline comments. Comment at: clang/lib/Basic/LangOptions.cpp:122 + if (Opts.HLSL) +Includes.push_back("hlsl.h"); Anastasia wrote: > Is this header expected to be large? You might want to flag up in the > description of the review and the

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 432023. python3kgae added a comment. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/lib/Driver/ToolChains/HLSL.cpp clang/test/C

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae updated this revision to Diff 432051. python3kgae added a comment. Herald added a subscriber: MaskRay. Add hlsl-no-stdinc to not include the hlsl header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae updated this revision to Diff 432346. python3kgae added a comment. Update comment for finclude_default_header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052 Files: clang/include/clang/Driv

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae updated this revision to Diff 432355. python3kgae added a comment. Herald added a reviewer: aaron.ballman. Add library to HLSLShaderAttr to help convert ShaderType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://revie

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/entry.hlsl:1 +// RUN: %clang --driver-mode=dxc -Tcs_6_1 -Efoo -fcgl -Fo - %s | FileCheck %s + Anastasia wrote: > Is this test here accidental? This

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae updated this revision to Diff 432393. python3kgae added a comment. Move addHLSLFunctionAttributes to ConstructAttributeList. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124752/new/ https://reviews.llvm.org/D124752 Files: clang/lib/

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 432429. python3kgae added a comment. Add test for main is not entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/lib/Driver/ToolChains/HLSL.cpp

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae updated this revision to Diff 432563. python3kgae added a comment. Add hlsl-entry for cc1 option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 Files: clang/include/clang/Basic/Attr.td c

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae marked 3 inline comments as done. python3kgae added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:11721 + Diag(FD->getLocation(), diag::err_hlsl_missing_numthreads) << "Compute"; + FD->setInvalidDecl(); +} bruno wrote: > Since

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae updated this revision to Diff 432574. python3kgae added a comment. Add newline at end of file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052 Files: clang/include/clang/Driver/Options.td c

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 432606. python3kgae marked 2 inline comments as done. python3kgae added a comment. Use default value of MarshallingInfoString. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe576280380d3: [HLSL] Enable vector types for hlsl. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D124752: [HLSL] clang codeGen for HLSLShaderAttr.

python3kgae updated this revision to Diff 432947. python3kgae marked an inline comment as done. python3kgae added a comment. Code cleanup to match comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124752/new/ https://reviews.llvm.org/D124752

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae added a comment. In D125052#3546205 , @thakis wrote: > Reverted in c4eb8035ed6647e58d4c5161f393e9220f7402cf > for now. Hi thakis, The issue could be fixed by https://revie

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae added a comment. In D124753#3545779 , @Anastasia wrote: > From the current change it seems to me that what you need to be testing is a > just that the frontend options are being passed correctly? This should then > be a driver test with `-##

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 433006. python3kgae added a comment. Add new line at end of file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Driver/Options.td

[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

python3kgae updated this revision to Diff 433143. python3kgae added a comment. Add check for no -T option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125585/new/ https://reviews.llvm.org/D125585 Files: clang/include/clang/Basic/DiagnosticDriv

[PATCH] D125585: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfde240c9c328: [HLSL][clang][Driver] Parse target profile early to update Driver::TargetTriple. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae reopened this revision. python3kgae added a comment. This revision is now accepted and ready to land. Reopen for the Mac/arm test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

python3kgae updated this revision to Diff 433179. python3kgae added a comment. Recover after fix Mac/arm test issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125052/new/ https://reviews.llvm.org/D125052 Files: clang/include/clang/Driver/Opt

[PATCH] D125052: [HLSL] Enable vector types for hlsl.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG13e1a653278b: [HLSL] Enable vector types for hlsl. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae reopened this revision. python3kgae added a comment. This revision is now accepted and ready to land. Reopen to recover the change after fix Mac/arm test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.ll

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae updated this revision to Diff 433227. python3kgae added a comment. Recover after fixed Mac/arm test fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm.org/D125338 Files: clang/include/clang/Driver/Op

[PATCH] D125338: [HLSL] add -D option for dxc mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd3e4727907e5: [HLSL] add -D option for dxc mode. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125338/new/ https://reviews.llvm.o

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 433301. python3kgae added a comment. Cleanup test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Driver/Options.td clang/test/Cod

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae added a comment. In D124753#3550337 , @Anastasia wrote: > In D124753#3546608 , @python3kgae > wrote: > >> In D124753#3545779 , @Anastasia >> wrote: >> >>> Fr

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae created this revision. python3kgae added reviewers: Anastasia, svenvh, jdoerfert, azabaznov, beanz, tra, yaxunl, pow2clk. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One clang builti

[PATCH] D126892: [NFC] Fix issue on CMake Xcode build configuration.

python3kgae created this revision. python3kgae added a reviewer: rastogishubham. Herald added subscribers: Anastasia, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. add missing dependency fo

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae added a comment. In D126857#3554070 , @Anastasia wrote: > ok, so the reason you are adding this to clang is that it needs to be mapped > into a target intrinsic? Yes. The plan is to create a target intrinsic for WaveActiveCountBits which map

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae updated this revision to Diff 433835. python3kgae marked 2 inline comments as done. python3kgae added a comment. Change to verify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126857/new/ https://reviews.llvm.org/D126857 Files:

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + Anastasia wrote: > FYI we most of time try to add a builtin name using a reserved identifier > which i

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae updated this revision to Diff 433841. python3kgae added a comment. Simplify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126857/new/ https://reviews.llvm.org/D126857 Files: clang/include/clang/Basic/Builtins.def clang/includ

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

python3kgae marked 2 inline comments as done. python3kgae added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1697 +// HLSL +LANGBUILTIN(WaveActiveCountBits, "Uib", "nc", HLSL_LANG) + Anastasia wrote: > python3kgae wrote: > > Anastasia wrote

[PATCH] D126857: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. python3kgae marked an inline comment as done. Closed by commit rG6bea9ff91378: [HLSL] Add WaveActiveCountBits as Langugage builtin function for HLSL (authored by python

[PATCH] D126892: [NFC] Fix issue on CMake Xcode build configuration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG436fef21efe3: [NFC] Fix issue on CMake Xcode build configuration. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126892/new/ https

[PATCH] D124751: [HLSL] Support -E option for HLSL.

python3kgae updated this revision to Diff 434615. python3kgae added a comment. Fix test fail after rebased on llvm/main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124751/new/ https://reviews.llvm.org/D124751 Files: clang/include/clang/Basic/

[PATCH] D155729: [OptTable] Make explicitly included options override excluded ones

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. This is much cleaner. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155729/new/ https://reviews.llvm.org/D155729

[PATCH] D156933: [HLSL] Add reversebits library function

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/bitreverse.hlsl:32 +// CHECK: call <4 x i16> @llvm.bitreverse.v4i16 +// NO_HALF: define noundef <4 x i16> @"?test_bitreverse_short4@@YAT?$__vector@F$03@__clang@@T12@@Z"( +// NO_HALF: call <4 x i16> @l

[PATCH] D156933: [HLSL] Add reversebits library function

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. Don't need -fnative-half-type in the RUN line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156933/new/ https://reviews.llvm.org/D156

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae created this revision. python3kgae added reviewers: rjmccall, Quuxplusone, riccibruno. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes 42469 https://github.com/llvm/llvm-project/iss

[PATCH] D144802: clang: Add __builtin_elementwise_round

python3kgae added inline comments. Comment at: clang/docs/LanguageExtensions.rst:646 direction. + T __builtin_elementwise_round(T x) round x to the nearest integer value in floating point format, floating point types +

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added a comment. max/min does work on integers in HLSL. And __builtin_elementwise_max/min support both integers and floats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144309/new/ https://reviews.llvm.org/D144309

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added a comment. In D144309#4156971 , @bob80905 wrote: > add int support for max/min. Sorry didn't check more :(. Now i16/u16/i32/u32/i64/u64/f16/f32/f64 are all supported for min/max in hlsl. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added a comment. In D144309#4159431 , @bob80905 wrote: > - ushort is now unsigned Use uint16_t/int16_t/uint64_t/int64_t for 16/64 bit integers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144

[PATCH] D144309: [HLSL] add max/min library functions

python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/builtins/max.hlsl:12 +// NO_HALF: call i16 @llvm.smax.i16( +int16_t test_max_short ( int16_t p0, int16_t p1 ) { + return max ( p0, p1 ); Just guard 16bit integer tests with #ifdef __HLSL_ENABL

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15656 case BO_XorAssign: -DiagnoseSelfAssignment(S, LHS, RHS, OpLoc, false); CheckIdentityFieldAssignment(LHS, RHS, OpLoc, S); break; rsmith wrote: > This is the same thin

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae updated this revision to Diff 510976. python3kgae added a comment. skip warning on field for compound assignment when isImplicitCXXThis matches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897

[PATCH] D147657: [Sema] Fix reporting of invalid shader attribute on HLSL entry function

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. Thanks for fix the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147657/new/ https://reviews.llvm.org/D147657

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae updated this revision to Diff 511697. python3kgae added a comment. Revert change for self-assign-field which deserve its own pull request. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897 Files

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae updated this revision to Diff 511795. python3kgae added a comment. Update the comment done by rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897 Files: clang/lib/Sema/SemaExpr.cpp c

[PATCH] D144120: [HLSL] add log library functions

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. LGTM. Just fix the newline at end of file for the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144120/new/ https://reviews.llv

[PATCH] D139742: [HLSL] Add acos library function

python3kgae added a comment. The PR title is acos but trunc is added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139742/new/ https://reviews.llvm.org/D139742 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D139742: [HLSL] Add trunc library function

python3kgae accepted this revision. python3kgae added a comment. This revision is now accepted and ready to land. LGTM. Remember to double check the commit message updated to trunc too. Just noticed we don't have double trunc(double) for hlsl now (hlsl 2021). Need make sure to generate float ove

[PATCH] D136913: [HLSL] support RWByteAddressBuffer.

python3kgae updated this revision to Diff 481858. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136913/new/ https://reviews.llvm.org/D136913 Files: clang/include/clang/Sema/HLSLExternalSemaSource.h clang/lib

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae updated this revision to Diff 481861. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136743/new/ https://reviews.llvm.org/D136743 Files: clang/lib/Sema/HLSLExternalSemaSource.cpp clang/test/AST/HL

[PATCH] D139935: [NFC] [Doc] Fix example for AnnotateTypeDocs

python3kgae created this revision. python3kgae added reviewers: mboehme, aaron.ballman, erichkeane. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Change clang::annotate into clang::annotate_type.

[PATCH] D136031: [DirectX backend] support ConstantBuffer to DXILResource.h

python3kgae updated this revision to Diff 482620. python3kgae added a comment. Rebase and remove the counter in resource metadata to match clang change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136031/new/ https://reviews.llvm.org/D136031 Fil

[PATCH] D136743: [HLSL] support ConstantBuffer

python3kgae updated this revision to Diff 483171. python3kgae added a comment. Herald added a reviewer: aaron.ballman. Change CBV implementation to template using ConstantBuffer = T; Added new internal attribute HLSLConstantBufferView to mark CBV with AttributedType. Repository: rG LLVM Gith

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae updated this revision to Diff 377323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/CodeGen/annotations-global.c clang/test/CodeGenC

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae added a comment. Updated summary. Tried to debug the linux fail with Hyper-V VM, cannot repro. Restarted Buildkite build to see if it still happens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D11

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae added a comment. Thanks for the review, the PR is committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09 ___ cfe-commits mailing list cfe-commit

<    1   2   3   4   5