[clang] df08b34 - [NFC] Cleanup miscellaneous header items

Author: Warren Ristow Date: 2022-04-26T14:36:49-07:00 New Revision: df08b3493869540bad5d4b040dae814e078b411d URL: https://github.com/llvm/llvm-project/commit/df08b3493869540bad5d4b040dae814e078b411d DIFF: https://github.com/llvm/llvm-project/commit/df08b3493869540bad5d4b040dae814e078b411d.diff

[clang] 35e7b4f - [NFC] Fix argument types in doxygen comment

Author: Warren Ristow Date: 2022-04-26T16:30:55-07:00 New Revision: 35e7b4f82cfabc28ebc23558917440aece3f489f URL: https://github.com/llvm/llvm-project/commit/35e7b4f82cfabc28ebc23558917440aece3f489f DIFF: https://github.com/llvm/llvm-project/commit/35e7b4f82cfabc28ebc23558917440aece3f489f.diff

[clang] bcae3a7 - [PS4] Predefine the __SCE__ macro for the x86_64-scei-ps4 triple

Author: Warren Ristow Date: 2019-12-12T11:00:09-08:00 New Revision: bcae3a77afd171604d117393d8cb92dfca2da8bb URL: https://github.com/llvm/llvm-project/commit/bcae3a77afd171604d117393d8cb92dfca2da8bb DIFF: https://github.com/llvm/llvm-project/commit/bcae3a77afd171604d117393d8cb92dfca2da8bb.diff

[clang] 7fcd9e3 - [X86] Mark various pointer arguments in builtins as const

Author: Warren Ristow Date: 2019-12-19T11:42:11-08:00 New Revision: 7fcd9e3f70830a9c4bf631a602c2764180b5c3a8 URL: https://github.com/llvm/llvm-project/commit/7fcd9e3f70830a9c4bf631a602c2764180b5c3a8 DIFF: https://github.com/llvm/llvm-project/commit/7fcd9e3f70830a9c4bf631a602c2764180b5c3a8.diff

r293911 - Prevent ICE in dllexport class with _Atomic data member

Author: wristow Date: Thu Feb 2 11:53:34 2017 New Revision: 293911 URL: http://llvm.org/viewvc/llvm-project?rev=293911&view=rev Log: Prevent ICE in dllexport class with _Atomic data member Guard against a null pointer dereference that caused Clang to crash when processing a class containing an _

[PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow created this revision. wristow added reviewers: aaron.ballman, ygao, alexr, silvas, compnerd, cfe-commits. In versions of clang prior to r238238, __declspec was recognized as a keyword in all modes. It was then changed to only be enabled when Microsoft or Borland extensions were enabled

Re: [PATCH] D11207: Enable recognition of __declspec for PS4

wristow abandoned this revision. wristow added a comment. This has been superseded by http://reviews.llvm.org/D13322. http://reviews.llvm.org/D11207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow added inline comments. Comment at: include/clang/Basic/LangOptions.def:93 @@ -92,2 +92,3 @@ LANGOPT(WChar , 1, CPlusPlus, "wchar_t keyword") +LANGOPT(DeclSpecKeyword , 1, 0, "Microsoft __declspec keyword support") BENIGN_LANGOPT(DollarIdents , 1, 1, "'$'

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow updated this revision to Diff 36307. wristow added a comment. Updated patch to change the Group of the diagnostic from f_Group to f_clang_Group, and to change the string associated with the LANGOPT definition of the flag. Also fixed a minor typo in a comment. http://reviews.llvm.org/D

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow updated this revision to Diff 36373. wristow added a comment. Added 4 new tests, the verify the last -fdeclspec/-fno-declspec wins, both in the context of -fms-extensions and without -fms-extensions. http://reviews.llvm.org/D13322 Files: include/clang/Basic/LangOptions.def include/

Re: [PATCH] D13322: Add -f[no-]declspec to control recognition of __declspec as a keyword

wristow added inline comments. Comment at: lib/Driver/Tools.cpp:4663 @@ +4662,3 @@ + else if (Args.hasArg(options::OPT_fno_declspec)) +CmdArgs.push_back("-fno-declspec"); // Explicitly disabling __declspec. + But in the '-fno-declspec -fdeclspec' case, the 'i

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow added a comment. > @wristow, if this still patches cleanly against trunk (I see that this has > been around a while) and test still pass, think this can be committed > soon-ish? It does still apply cleanly, and testing still looks good. Given that the test was adjusted as suggested by

[PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow created this revision. wristow added a reviewer: rsmith. wristow added a subscriber: cfe-commits. The '#pragma once' directive was erroneously ignored when encountered in the header-file specified in generate-PCH-mode. This resulted in compile-time errors in some cases with legal code, an

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow added a comment. To check for whether we're in "generate a PCH file mode", I added a new flag (`GeneratePCHMode`) to `PreprocessorOptions`. If the `CompilerInstance` had been visible in lexical analysis, it would have been easy to do this without adding a new flag. Is there a better w

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow updated this revision to Diff 55936. wristow added a comment. Moved "test/PCH/pragma-once.h" to the "test/PCH/Inputs" directory (and changed "pragma-once.c" appropriately). http://reviews.llvm.org/D19815 Files: include/clang/Lex/PreprocessorOptions.h lib/Frontend/InitPreprocessor.c

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow added a comment. Ping http://reviews.llvm.org/D19815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow added a comment. In http://reviews.llvm.org/D19815#428705, @rsmith wrote: > Rather than threading through a new flag, can you test the existing `TUKind` > field? Yes, that does seem to do the trick. I'll do some testing on it, but with that approach, it should be a simple one-line ch

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow updated this revision to Diff 57320. wristow added a comment. Simplified he implementation, by using the existing `TUKind` field. http://reviews.llvm.org/D19815 Files: llvm/tools/clang/lib/Lex/Pragma.cpp llvm/tools/clang/test/PCH/Inputs/pragma-once.h llvm/tools/clang/test/PCH/prag

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

wristow added a comment. In http://reviews.llvm.org/D20243#433615, @thakis wrote: > Did you see http://reviews.llvm.org/D19815 ? Does that help? Warren might > have opinions on this. Yes, these are definitely related. Fixing that other problem does //not //also fix the issue here, however th

Re: [PATCH] D18708: Set C99 as default C Standard for PS4 target

wristow added a subscriber: wristow. wristow added a comment. In http://reviews.llvm.org/D18708#390183, @dyung wrote: > In http://reviews.llvm.org/D18708#390166, @rsmith wrote: > > > In http://reviews.llvm.org/D18708#390150, @dyung wrote: > > > > > From my understanding, there are 2 issues that b

Re: [PATCH] D19815: Support '#pragma once' in headers when using PCH

wristow added a comment. ping http://reviews.llvm.org/D19815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17775: Add a few dllimport/dllexport tests. NFC

wristow created this revision. wristow added reviewers: cfe-commits, rnk, majnemer. This change just adds tests for some corner cases of dllimport/dllexport, primarily for some static methods. We plan to enable dllimport/dllexport support for the PS4, and these additional tests are for points we

Re: [PATCH] D17775: Add a few dllimport/dllexport tests. NFC

wristow added a comment. In http://reviews.llvm.org/D17775#365611, @silvas wrote: > Random question: > > > We plan to enable dllimport/dllexport support for the PS4 > > > How are you planning on codegenning them? The same way as we do in our > private branch? Yes, that's the intention. http: