[PATCH] D37881: [Sema] Prevent InstantiateClass from checking unrelated exception specs.

vsapsai added a comment. Thanks for review. In https://reviews.llvm.org/D37881#875574, @rsmith wrote: > I think we need to clearly identify what state we're saving here and why. > It's the state that is pending from a class that we're currently in the > middle of parsing, so how about somethin

[PATCH] D37089: [Sema] Error out early for tags defined inside an enumeration.

vsapsai added a comment. Thanks for following up, Alberto. I haven't expected such a use case. It is possible to achieve the same with `LSA_SIZEOF_SA = sizeof(((len_and_sockaddr *)0)->u)` but I don't like it and don't want to force developers using such approach. For solving this problem I thi

[PATCH] D37881: [Sema] Prevent InstantiateClass from checking unrelated exception specs.

vsapsai updated this revision to Diff 116056. vsapsai added a comment. - Rename SavePendingDelayedStateRAII to SavePendingParsedClassStateRAII. https://reviews.llvm.org/D37881 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaTemplateInstantiate.cpp clang/test/SemaTemplate/crash-u

[PATCH] D38109: [fixup][Sema] Allow in C to define tags inside enumerations.

vsapsai created this revision. Fix for too aggressive error err_type_defined_in_enum introduced in r313386. Defining tags inside enumerations is prohibited in C++ but allowed in C. https://reviews.llvm.org/D38109 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Sema/enum.c Index: clang/test/

[PATCH] D37089: [Sema] Error out early for tags defined inside an enumeration.

vsapsai added a comment. Submitted for review https://reviews.llvm.org/D38109 - [fixup][Sema] Allow in C to define tags inside enumerations. Repository: rL LLVM https://reviews.llvm.org/D37089 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D38109: [fixup][Sema] Allow in C to define tags inside enumerations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313894: [fixup][Sema] Allow in C to define tags inside enumerations. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D38109?vs=116110&id=116219#toc Repository: rL LLVM https

[PATCH] D38009: [Sema] Fix using old initializer during switch statement transformation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313896: [Sema] Fix using old initializer during switch statement transformation. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D38009?vs=115754&id=116226#toc Repository: rL

[PATCH] D37881: [Sema] Prevent InstantiateClass from checking unrelated exception specs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL313906: [Sema] Prevent InstantiateClass from checking unrelated exception specs. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D37881?vs=116056&id=116250#toc Repository: rL

[PATCH] D63508: make -frewrite-includes handle __has_include wrapped in a macro

vsapsai added a comment. Luboš, can you please clarify what is wrong with the current Clang behavior? I'm just thinking about what should we do with nested macros. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63508/new/ https://reviews.llvm.org/D63508 __

[PATCH] D64799: [Sema] Emit diagnostics for uncorrected delayed typos at the end of TU

vsapsai added inline comments. Comment at: clang/test/SemaObjC/typo-correction-subscript.m:1 // RUN: %clang_cc1 -triple i386-apple-macosx10.10 -fobjc-arc -fsyntax-only -Wno-objc-root-class %s -verify -disable-free I think you can even remove `-disable-free` i

[PATCH] D65545: Handle some fs::remove failures

vsapsai added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:647-649 + if (std::error_code EC = llvm::sys::fs::remove(OF.TempFilename)) +getDiagnostics().Report(diag::err_fe_error_removing) + << OF.TempFilename << EC.message

[PATCH] D65545: Handle some fs::remove failures

vsapsai added inline comments. Comment at: clang/lib/Frontend/ASTUnit.cpp:2315-2316 if (Out.has_error()) { Out.clear_error(); -return true; +return llvm::createStringError(Out.error(), "AST serialization failed"); } Will `Out.error()` still wor

[PATCH] D65545: Handle some fs::remove failures

vsapsai added a comment. I have no other comments but for the fatal error in `FileRemover` I'd like to loop in Jonas as he was touching module cache in LLDB fairly recently. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1444-1445 // Remove the file. - llvm::s

[PATCH] D65545: Handle some fs::remove failures

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Looks good to me. If in some situations abort on error turns out to be too aggressive, we can change it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.

vsapsai created this revision. vsapsai added a reviewer: rtrieu. Herald added subscribers: dexonsmith, jkorous. Because `Selector::getIdentifierInfoForSlot` returns NULL if a slot has no corresponding identifier, use `Selector::getNameForSlot` instead. rdar://problem/51615164 https://reviews.ll

[PATCH] D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.

vsapsai added inline comments. Comment at: clang/lib/AST/ODRHash.cpp:73 AddBoolean(S.isUnarySelector()); unsigned NumArgs = S.getNumArgs(); for (unsigned i = 0; i < NumArgs; ++i) { rtrieu wrote: > There's actually a second bug here as well. When p

[PATCH] D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.

vsapsai updated this revision to Diff 206992. vsapsai added a comment. Herald added a project: clang. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63789/new/ https://reviews.llvm.org/D63789 Files: clang/lib/AST/ODRHas

[PATCH] D63789: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364664: [ODRHash] Fix null pointer dereference for ObjC selectors with empty slots. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61619/new/ https://reviews.llvm.org/D61619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

vsapsai added a comment. Thanks for the review, Aaron. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61619/new/ https://reviews.llvm.org/D61619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D61619: Make language option `GNUAsm` discoverable with `__has_extension` macro.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360625: Make language option `GNUAsm` discoverable with `__has_extension` macro. (authored by vsapsai, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D6

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

vsapsai added a comment. In D61621#1497027 , @rnk wrote: > lgtm, thanks! > > In D61621#1496978 , @vsapsai wrote: > > > Didn't use `-fms-compatibility` in the test and it seems to be working fine. > > Don't know if

[PATCH] D61621: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360630: [X86] Make `x86intrin.h`, `immintrin.h` includable with `-fno-gnu-inline-asm`. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: clang/lib/Lex/HeaderSearch.cpp:821 CurDir = nullptr; + bool HasBeenMapped = false; arphaman wrote: > NIT: It looks like `HasBeenMapped` should be always set when > `CacheL

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai updated this revision to Diff 200864. vsapsai added a comment. - Address review comments: don't introduce `HasBeenMapped` and rely on `CacheLookup.MappedName`. Changes are rebased, so diff between diffs can be noisy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ htt

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361779: [Preprocessor] Fix crash emitting note with framework location for "file not… (authored by vsapsai, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.o

[PATCH] D61707: [Preprocessor] Fix crash emitting note with framework location for "file not found" error.

vsapsai added a comment. Thanks for the review, Alex. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61707/new/ https://reviews.llvm.org/D61707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai updated this revision to Diff 177803. vsapsai added a comment. - Update `__has_construct`, `__has_destroy` according to review comments. - Tighten tests: custom allocators aren't mandated by C++03 but libc++ has the support. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48753/ne

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai marked 3 inline comments as done. vsapsai added a comment. Regarding the tests. I've moved most of new tests for custom allocators to test/libcxx/*. And in destroy.pass.cpp I'm just checking `_LIBCPP_VERSION` to avoid copying the test to a different file. Comment at:

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai marked an inline comment as done. vsapsai added a comment. In D48753#1323248 , @ldionne wrote: > 2. Also, before this patch, the allocator's `construct` and `destroy` were > NEVER called in C++03, but were called when available in C++11. After thi

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai added a comment. In D55543#1328025 , @rjmccall wrote: > Nice catch. This also fixes problems where there might be cleanups entered > by `EmitParmDecl`, e.g. in ObjC++ with a parameter of type `struct A { > __strong id x; }`; could you please add

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai added a comment. In D55543#1328034 , @smeenai wrote: > I'd tried this exact same patch back in https://reviews.llvm.org/D44619, but > I was running into a bunch of check-clang failures with it, and I was never > able to figure them out. It looks

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai added a comment. In D55543#1329288 , @vsapsai wrote: > In D55543#1328025 , @rjmccall wrote: > > > Nice catch. This also fixes problems where there might be cleanups entered > > by `EmitParmDecl`, e.g. in O

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai updated this revision to Diff 178563. vsapsai added a comment. - Test order of destroying parameters to inlined inherited constructor. - [ObjC++] Add test using struct with `__strong` field as a parameter for inlined inherited constructor. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai updated this revision to Diff 178746. vsapsai added a comment. - [ObjC++] Pass struct with `__strong` field as a value, not as a reference. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55543/new/ https://reviews.llvm.org/D55543 Files: clang/lib/CodeGen/CGClass.cpp clang/te

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai updated this revision to Diff 178921. vsapsai added a comment. - [ObjC++] Verify there are no unexpected calls. `--implicit-check-not` seems reasonable approach in this case. It causes adding `Inheritor` destructors but gives higher confidence there are no unexpected calls in unexpected p

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48753/new/ https://reviews.llvm.org/D48753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349676: [libcxx] Use custom allocator's `construct` in C++03 when available. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

This revision was automatically updated to reflect the committed changes. Closed by commit rC349848: [CodeGen] Fix assertion on emitting cleanup for object with inlined inherited… (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D55543?vs=178921&id=179165#

[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

vsapsai added a comment. Thanks for the review, John. Committed the change and will watch the buildbots on non-Darwin platform. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55543/new/ https://reviews.llvm.org/D55543 __

[PATCH] D47757: [Sema] Produce diagnostics when unavailable aligned allocation/deallocation functions are called

vsapsai accepted this revision. vsapsai added a comment. The change itself looks correct. Cannot really tell if you need to make changes in other places. For that I rely on Richard's opinion. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47757/new/ https://revie

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai updated this revision to Diff 180316. vsapsai added a comment. - Tweak the test. - Use for `__construct_range_forward` approach recommended by @ldionne (it works with C++03). - Use `__is_default_allocator` for `__construct_forward` and `__construct_backward`. Didn't introduce `remove_co

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added inline comments. Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:196 test_ctor_under_alloc(); + test_ctor_with_different_value_type(); } Quuxplusone wrote: > I suggest that interesting test case

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai updated this revision to Diff 180556. vsapsai added a comment. - Test initializing vector of `unsigned int` with array of `int`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48342/new/ https://reviews.llvm.org/D48342 Files: libcxx/include/memory libcxx/test/std/containers

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added inline comments. Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:196 test_ctor_under_alloc(); + test_ctor_with_different_value_type(); } Quuxplusone wrote: > vsapsai wrote: > > Quuxplusone wrote

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added inline comments. Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:161 + { +// Though types are different, initialization can be done with `memcpy`. +int32_t array[1] = {-1}; Quuxplusone wrote

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai updated this revision to Diff 180577. vsapsai added a comment. - Test initializing vector of pointers with array of pointers of convertible type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48342/new/ https://reviews.llvm.org/D48342 Files: libcxx/include/memory libcxx/t

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL350583: [libcxx] Optimize vectors construction of trivial types from an iterator range… (authored by vsapsai, committed by

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added inline comments. Comment at: libcxx/test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:161 + { +// Though types are different, initialization can be done with `memcpy`. +int32_t array[1] = {-1}; Quuxplusone wrote

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

vsapsai created this revision. vsapsai added reviewers: arphaman, erik.pilkington. Herald added subscribers: dexonsmith, jkorous. When a framework with the same name is available at multiple framework search paths, we use the first matching location. If a framework at this location doesn't have al

[PATCH] D56561: [Preprocessor] For missing file in framework add note about framework location.

vsapsai marked an inline comment as done. vsapsai added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:573-574 if (!File) { Diag(SourceLocation(), diag::err_pp_through_header_not_found) << PPOpts->PCHThroughHeader; return; --

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

vsapsai marked 2 inline comments as done. vsapsai added a comment. Thanks for the review. Comment at: clang/lib/Lex/HeaderSearch.cpp:892-902 +IsInHeaderMap, MappedName); +if (!MappedName.empty()) { + assert(IsInHeaderMap && "MappedName should come from a header

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371655: Fix -Wnonportable-include-path suppression for header maps with absolute paths. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai added a comment. In D66696#1663856 , @erik.pilkington wrote: > I'm a bit curious about clients that use `getCanonicalType()` to get a full > desugaring, instead of doing a single step. It seems like they'd still get > the out of date type parame

[PATCH] D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

vsapsai created this revision. vsapsai added reviewers: thegameg, george.karpenkov. Herald added subscribers: ributzka, dexonsmith, jkorous, aprantl. Starting from r324788 timer groups aren't cleared automatically when printed out. As a result some timer groups were printed one more time. For exam

[PATCH] D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372191: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D67683: [Timers] Fix printing some `-ftime-report` sections twice. Fixes PR40328.

vsapsai added a comment. Thanks for the fast review. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67683/new/ https://reviews.llvm.org/D67683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D66696: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai added a comment. Found a use case where `getCanonicalType()` causes problems: @interface NSObject @end @protocol SomeProtocol @end @interface NSString : NSObject @end @interface NSNumber : NSObject @end @interface Container @end @interface Container (exte

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

vsapsai created this revision. vsapsai added reviewers: dsanders, bogner, rtereshin. Herald added subscribers: ributzka, dexonsmith, jkorous, hiraditya. Herald added a project: LLVM. The intended usage is to measure relatively expensive operations. So the cost of the statistic is negligible compar

[PATCH] D68252: [Stats] Add ALWAYS_ENABLED_STATISTIC enabled regardless of LLVM_ENABLE_STATS.

vsapsai added a comment. On release build with assertions disabled and LLVM_ENABLE_STATS being 0 the impact on the compile time is the following Metric: compile_time Programoutput0jM4H6 output_KEgWj diff test-suite...tTests/2003-05-07-VarArgs.

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

vsapsai added a comment. Another approach is `__has_feature` but I don't think it is applicable in this case. Is there a way right now to detect that aligned allocation is supported by clang, regardless of link time? Asking to make sure we are consistent. Repository: rC Clang https://revie

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

vsapsai created this revision. vsapsai added a reviewer: bkramer. Herald added a subscriber: jkorous-apple. `__has_include_next` requires correct DirectoryLookup for being evaluated correctly. We were using Preprocessor::GetCurDirLookup() but we were calling it after the preprocessor finished its

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

vsapsai added a comment. To simplify reviewing additions to the test, here is the corresponding output # 23 "/Users/vsapsai/Projects/llvm/llvm-project/clang/test/Frontend/rewrite-includes.c" 2 #if 0 /* expanded by -frewrite-includes */ #include "rewrite-includes9.h" #endif /* expanded b

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC330041: Fix evaluation of `__has_include_next` during -frewrite-includes. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D45603?vs=142299&id=142438#toc Reposito

[PATCH] D45603: Fix evaluation of `__has_include_next` during -frewrite-includes.

vsapsai added a comment. Thanks for the prompt review. Repository: rC Clang https://reviews.llvm.org/D45603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

vsapsai added a comment. Ping. https://reviews.llvm.org/D34331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45015: [Preprocessor] Allow libc++ to detect when aligned allocation is unavailable.

vsapsai added a comment. In https://reviews.llvm.org/D45015#1064930, @EricWF wrote: > In https://reviews.llvm.org/D45015#1064922, @vsapsai wrote: > > > Another approach is `__has_feature` but I don't think it is applicable in > > this case. > > > > Is there a way right now to detect that aligned

[PATCH] D45470: Emit an error when mixing and

vsapsai added a comment. Herald added a subscriber: jkorous. Ping. https://reviews.llvm.org/D45470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

vsapsai added a comment. Herald added a subscriber: jkorous. Ping. https://reviews.llvm.org/D34331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

vsapsai added a comment. For the record, DR154: Anonymous unions in unnamed namespaces is relevant here. Comment at: Sema/SemaDecl.cpp:4654-4656 + while (OwnerScope->getDeclKind() == Decl::LinkageSpec) { +

[PATCH] D45470: Emit an error when mixing and

vsapsai planned changes to this revision. vsapsai added inline comments. Comment at: clang/test/Headers/stdatomic.cpp:4 + +#include + mclow.lists wrote: > Is there a reason we want to test this twice - once in clang and once in > libc++? > We can use `expected-

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

vsapsai updated this revision to Diff 143797. vsapsai added a comment. - Move tests to test/std. https://reviews.llvm.org/D34331 Files: libcxx/include/__functional_03 libcxx/include/functional libcxx/test/std/utilities/function.objects/func.wrap/func.wrap.func/func.wrap.func.con/move_ree

[PATCH] D45470: Emit an error when mixing and

vsapsai updated this revision to Diff 143817. vsapsai added a comment. - Tighten up a test with expected-error per review comment. https://reviews.llvm.org/D45470 Files: clang/lib/Headers/stdatomic.h clang/test/Headers/stdatomic.cpp libcxx/include/atomic libcxx/test/libcxx/atomics/c_com

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rCXX330885: [libcxx] func.wrap.func.con: Unset function before destroying anything (authored by vsapsai, committed by ). Ch

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

vsapsai accepted this revision. vsapsai added inline comments. This revision is now accepted and ready to land. Comment at: Sema/SemaDecl.cpp:4651-4653 + + DeclContext *OwnerScope = Owner->getRedeclContext(); + I think the code style favours avoiding excessi

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

vsapsai added a comment. It is agreed that it is untenable to support reentrancy for `std::function` assignment operators and I'm not trying to achieve that. Here we restrict reentrancy only to `std::function::operator=(nullptr_t)`. @mclow.lists where should the tests go if the standard specifi

[PATCH] D30881: Track skipped files in dependency scanning

vsapsai added a comment. I plan to look into cleaning this up and addressing the review comments. Need to check if `DepCollectorPPCallbacks` has to be updated too. Comment at: lib/Frontend/DependencyFile.cpp:302 + SrcMgr::CharacteristicKind FileType) { + AddFi

[PATCH] D30881: Track skipped files in dependency scanning

vsapsai updated this revision to Diff 144802. vsapsai added a comment. - Fix FileSkipped adding system headers when it shouldn't. https://reviews.llvm.org/D30881 Files: clang/lib/Frontend/DependencyFile.cpp clang/test/Frontend/Inputs/SystemHeaderPrefix/with-header-guard.h clang/test/Front

[PATCH] D30881: Track skipped files in dependency scanning

vsapsai marked 2 inline comments as done. vsapsai added inline comments. Comment at: lib/Frontend/DependencyFile.cpp:191 + const Token &FilenameTok, + SrcMgr::CharacteristicKind FileType) override; + bruno wrote: > Is there any

[PATCH] D45884: [Sema] Fix parsing of anonymous union in language linkage specification

vsapsai added a comment. In https://reviews.llvm.org/D45884#1084060, @jkorous wrote: > Volodymyr, could you please confirm that the non-anonymous vs non-inline > logic makes sense to you? Looks correct to me that we are checking non-anonymous namespaces. Inline namespaces are somewhat similar

[PATCH] D30881: Track skipped files in dependency scanning

This revision was automatically updated to reflect the committed changes. vsapsai marked an inline comment as done. Closed by commit rL331319: Track skipped files in dependency scanning. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D45470: Emit an error when mixing and

This revision was automatically updated to reflect the committed changes. Closed by commit rC331378: Emit an error when mixing and (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D45470?vs=143817&id=144903#toc Repository: rC Clan

[PATCH] D45470: Emit an error when mixing and

vsapsai added a comment. Thanks for the review, Marshall. In the end I removed `XFAIL: with_system_cxx_lib` from libc++ test as the change is header-only at compile time. Library behaviour at runtime shouldn't be affected. Repository: rC Clang https://reviews.llvm.org/D45470 ___

[PATCH] D46363: Follow-up to r331378. Update tests to allow to use C atomics in C++.

vsapsai created this revision. vsapsai added a reviewer: kubamracek. https://reviews.llvm.org/D46363 Files: compiler-rt/test/tsan/Darwin/gcd-groups-destructor.mm compiler-rt/test/tsan/Darwin/libcxx-shared-ptr-stress.mm compiler-rt/test/tsan/Darwin/xpc-race.mm Index: compiler-rt/test/tsan/

[PATCH] D46363: Follow-up to r331378. Update tests to allow to use C atomics in C++.

vsapsai added a comment. Link to corresponding review that introduced the change is https://reviews.llvm.org/D45470 Another option is to use `` and `std::atomic` but that will be functionality change. I'd rather avoid that. https://reviews.llvm.org/D46363 __

[PATCH] D46363: Follow-up to r331378. Update tests to allow to use C atomics in C++.

This revision was automatically updated to reflect the committed changes. Closed by commit rL331484: Follow-up to r331378. Update tests to allow to use C atomics in C++. (authored by vsapsai, committed by ). Herald added subscribers: llvm-commits, delcypher. Changed prior to commit: https://rev

[PATCH] D46363: Follow-up to r331378. Update tests to allow to use C atomics in C++.

vsapsai added a comment. Thanks for the quick review. Repository: rL LLVM https://reviews.llvm.org/D46363 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45470: Emit an error when mixing and

vsapsai added a comment. In https://reviews.llvm.org/D45470#1087026, @jfb wrote: > This isn't bad, so I'd go with it, but separately I imagine that we could > implement the suggestion in http://wg21.link/p0943 and expose it even before > C++20? Not sure we do this much, but I'd argue that befor

[PATCH] D46446: [c++17] Fix assertion on synthesizing deduction guides after a fatal error.

vsapsai created this revision. vsapsai added a reviewer: rsmith. After a fatal error Sema::InstantiatingTemplate doesn't allow further instantiation and doesn't push a CodeSynthesisContext. When we tried to synthesize implicit deduction guides from constructors we hit the assertion > Assertion fa

[PATCH] D47341: [Sema] Fix infinite typo correction loop.

vsapsai added a comment. Ping. https://reviews.llvm.org/D47341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added a comment. Ping. https://reviews.llvm.org/D48342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47341: [Sema] Fix infinite typo correction loop.

This revision was automatically updated to reflect the committed changes. Closed by commit rC335638: [Sema] Fix infinite typo correction loop. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D47341?vs=148841&id=152924#toc Repository: rC Clang https://

[PATCH] D47341: [Sema] Fix infinite typo correction loop.

vsapsai added a comment. Thanks for the review, Richard. Repository: rC Clang https://reviews.llvm.org/D47341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai planned changes to this revision. vsapsai added inline comments. Comment at: libcxx/include/memory:1479 +struct __has_construct_missing +: false_type +{ erik.pilkington wrote: > Shouldn't this be true_type? I see this is confusing and I'm still strugg

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai updated this revision to Diff 152990. vsapsai added a comment. - Don't use memcpy specialization with custom allocators. Not entirely satisfied with comparing allocator to non-const and const, don't know if there is a more elegant way to do the same. https://reviews.llvm.org/D48342 Fil

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai added inline comments. Comment at: libcxx/include/memory:1479 +struct __has_construct_missing +: false_type +{ erik.pilkington wrote: > vsapsai wrote: > > erik.pilkington wrote: > > > Shouldn't this be true_type? > > I see this is confusing and I'm st

[PATCH] D48753: [libcxx] Use custom allocator's `construct` in C++03 when available.

vsapsai created this revision. vsapsai added reviewers: mclow.lists, EricWF, erik.pilkington. Herald added a subscriber: dexonsmith. Can use `decltype` in C++03 because `include/__config` defines a macro when `decltype` is not available. https://reviews.llvm.org/D48753 Files: libcxx/include/m

[PATCH] D48342: [libcxx] Optimize vectors construction of trivial types from an iterator range with const-ness mismatch.

vsapsai updated this revision to Diff 153430. vsapsai added a comment. Herald added a subscriber: dexonsmith. - Don't check `!__has_construct` for `__construct_range_forward`. Incompatible types will cause a lack of `construct` but it doesn't mean we should use memcpy instead. And missing `_Alloc

<    1   2   3   4   5   6   7   8   9   10   >