voskresensky.vladimir added a comment.
Hello Argyrios,
This is a good addition to simplify reuse of preprocessor in IDEs. Thanks for
doing this.
From our experience of integrating clang PP into NetBeans, the following change
gives more flexibility:
- introduce method in PPCallbacks and consult
voskresensky.vladimir added a comment.
In https://reviews.llvm.org/D34263#782391, @akyrtzi wrote:
> Hey Vladimir, what you are proposing is orthogonal to this patch. You are
> proposing for "the client to provide the value for an undefined identifier",
> and the patch is about the client not kn
voskresensky.vladimir added a comment.
> Here's an example to clarify the difference:
Thanks for the example. You are right, I missed this difference in patch.
https://reviews.llvm.org/D34263
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
voskresensky.vladimir added a comment.
I have some experience with PTH implementation, because had to fix it for
Java-port of Clang (https://github.com/java-port/clank).
It was sometime ago, but making it completely workable was not hard.
As I remember the key fix was just to have PTH be EMITTED
voskresensky.vladimir added a comment.
In https://reviews.llvm.org/D54547#1301359, @erichkeane wrote:
> > I thought clang-d service is using it to speed up indexing.
>
> Presumably, I could also just make PTH use another bit or two for the TokenID
> and it would work fine. However, when I menti
voskresensky.vladimir added a comment.
In https://reviews.llvm.org/D34766#795087, @arphaman wrote:
> LGTM, Thanks! Do you have commit access?
No. Could you commit, please. Thanks!
https://reviews.llvm.org/D34766
___
cfe-commits mailing list
cfe-c
