vitalybuka wrote:
I assume you are going to change fronted to avoid compiler abusing these UBs?
https://github.com/llvm/llvm-project/pull/100272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
@@ -312,6 +312,38 @@ This attribute may not be
supported by other compilers, so consider using it together with
``#if defined(__clang__)``.
+Disabling instrumentation of common overflow idioms
+=
+
+There are certain overflow
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/100272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> I assume you are going to change fronted to avoid compiler abusing these UBs?
Actually stuff like unsigned overflows are not UB.
Maybe instead of `-fno-sanitize-overflow-idioms` we convert into
`unsigned-integer-overflow` into ` check group` so user can
-fno-sanitize=-uns
vitalybuka wrote:
> Right, unsigned overflow is well-defined. This isn't about the semantics of
> "undefined-ness". We want the unsigned sanitizer ON but some of the things it
> reports are noisy -- that's what this PR is about
"Idiom" seems to vague to me. kernel has own opinion on what is i
vitalybuka wrote:
> > ThreadSanitizer is missing
>
> Have added the flag for tsan-module, But not sure about tsan, which is
> function pass. How do we make that idempotent?
We merged Module and function passes for other sanitizers, and we should do for
tsan as well.
So implementing for module
https://github.com/vitalybuka approved this pull request.
LGTM, but please git some time others to respond
https://github.com/llvm/llvm-project/pull/99439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
vitalybuka wrote:
> In the worse case we need this, I'd hope that this is target-specific.
What does this mean?
https://github.com/llvm/llvm-project/pull/99439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
vitalybuka wrote:
> > @MaskRay can you talk more about your concerns? This won't affect compile
> > time, and instrumenting a shadow load will cause an immediate crash of the
> > application at runtime. This patch seems much more robust than counting on
> > toolchains to always arrange to avoi
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/101105
>From 0cc4d622752005ff3c615d0d4eafe1c35d9c Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Mon, 29 Jul 2024 17:06:32 -0700
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/101105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8,11 +8,18 @@ MemorySanitizer
Introduction
-MemorySanitizer is a detector of uninitialized reads. It consists of a
+MemorySanitizer is a detector of uninitialized memory use. It consists of a
compiler instrumentation module and a run-time library.
Typical
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/101105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/101105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/99360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3742,6 +3751,124 @@ struct MemorySanitizerVisitor : public
InstVisitor {
setOriginForNaryOp(I);
}
+ // Given two shadows ..., ..., return the interleaved value
+ // ABABABAB ...
+ //
+ // Width == number of elements in A == number of elements in B
+ Val
@@ -2483,13 +2484,21 @@ struct MemorySanitizerVisitor : public
InstVisitor {
using OriginCombiner = Combiner;
/// Propagate origin for arbitrary operation.
- void setOriginForNaryOp(Instruction &I) {
+ ///
+ /// Optionally skips n trailing operands.
+ void setOriginFo
@@ -2483,13 +2484,21 @@ struct MemorySanitizerVisitor : public
InstVisitor {
using OriginCombiner = Combiner;
/// Propagate origin for arbitrary operation.
- void setOriginForNaryOp(Instruction &I) {
+ ///
+ /// Optionally skips n trailing operands.
+ void setOriginFo
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/99360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3742,6 +3751,124 @@ struct MemorySanitizerVisitor : public
InstVisitor {
setOriginForNaryOp(I);
}
+ // Given two shadows ..., ..., return the interleaved value
+ // ABABABAB ...
+ //
+ // Width == number of elements in A == number of elements in B
+ Val
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/99360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3742,6 +3751,124 @@ struct MemorySanitizerVisitor : public
InstVisitor {
setOriginForNaryOp(I);
}
+ // Given two shadows ..., ..., return the interleaved value
+ // ABABABAB ...
+ //
+ // Width == number of elements in A == number of elements in B
+ Val
@@ -0,0 +1,1515 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
UTC_ARGS: --version 2
+; Test memory sanitizer instrumentation for Arm NEON VST instructions.
+;
+; RUN: opt < %s -passes=msan -S | FileCheck %s
+;
+; Forked from llvm/test/CodeGen/AArch
https://github.com/vitalybuka approved this pull request.
Please use args instead of undefs
https://github.com/llvm/llvm-project/pull/98247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
@@ -0,0 +1,1515 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
UTC_ARGS: --version 2
+; Test memory sanitizer instrumentation for Arm NEON VST instructions.
+;
+; RUN: opt < %s -passes=msan -S | FileCheck %s
+;
+; Forked from llvm/test/CodeGen/AArch
@@ -3865,6 +3866,125 @@ struct MemorySanitizerVisitor : public
InstVisitor {
setOriginForNaryOp(I);
}
+ // Given two shadows ..., ..., return the interleaved value
+ // ABABABAB ...
+ //
+ // Width == number of elements in A == number of elements in B
+ Val
@@ -3865,6 +3866,42 @@ struct MemorySanitizerVisitor : public
InstVisitor {
setOriginForNaryOp(I);
}
+ /// Handle Arm NEON vector store intrinsics (vst{2,3,4}).
+ ///
+ /// Arm NEON vector store intrinsics have the output address (pointer) as the
+ /// last argument
@@ -3865,6 +3866,42 @@ struct MemorySanitizerVisitor : public
InstVisitor {
setOriginForNaryOp(I);
}
+ /// Handle Arm NEON vector store intrinsics (vst{2,3,4}).
+ ///
+ /// Arm NEON vector store intrinsics have the output address (pointer) as the
+ /// last argument
@@ -3865,6 +3866,42 @@ struct MemorySanitizerVisitor : public
InstVisitor {
setOriginForNaryOp(I);
}
+ /// Handle Arm NEON vector store intrinsics (vst{2,3,4}).
+ ///
+ /// Arm NEON vector store intrinsics have the output address (pointer) as the
+ /// last argument
@@ -2498,6 +2499,15 @@ struct MemorySanitizerVisitor : public
InstVisitor {
MSV->setOrigin(I, Origin);
}
}
+
+/// Store the current combined value at the specified origin
+/// location.
+void DoneAndStoreOrigin(TypeSize TS, Value *OriginPtr) {
+
@@ -2498,6 +2499,15 @@ struct MemorySanitizerVisitor : public
InstVisitor {
MSV->setOrigin(I, Origin);
}
}
+
+/// Store the current combined value at the specified origin
+/// location.
+void DoneAndStoreOrigin(TypeSize TS, Value *OriginPtr) {
+
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/99360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/99360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> Gentle ping.
Oh, you should click "re-request review", so it's popup in github review query.
Looking.
https://github.com/llvm/llvm-project/pull/97164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/vitalybuka approved this pull request.
LGTM, but probably someone who contribute these components more should take a
look.
https://github.com/llvm/llvm-project/pull/97164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
https://github.com/vitalybuka unassigned
https://github.com/llvm/llvm-project/pull/97766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
It introduces another issue:
https://lab.llvm.org/buildbot/#/builders/164/builds/1246/steps/14/logs/stdio
https://github.com/llvm/llvm-project/pull/99545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
vitalybuka wrote:
This is causing new/delete mismatch
https://lab.llvm.org/buildbot/#/builders/168/builds/20063
```
=
==2164144==ERROR: AddressSanitizer: new-delete-type-mismatch on 0x503035b0
in thread T0:
object passed to
vitalybuka wrote:
@ldionne looks like a bug in std::string
```
--- a/libcxx/include/string
+++ b/libcxx/include/string
@@ -1123,7 +1123,7 @@ public:
inline _LIBCPP_CONSTEXPR_SINCE_CXX20 ~basic_string() {
__annotate_delete();
if (__is_long())
- __alloc_traits::deallocate(__alloc
vitalybuka wrote:
Delete uses __get_long_cap()
```
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void
__set_long_cap(size_type __s) _NOEXCEPT {
__r_.first().__l.__cap_ = __s / __endian_factor;
__r_.first().__l.__is_long_ = true;
}
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_S
@@ -35,6 +35,9 @@
// RUN: %p/../../../../lib/sanitizer_common/sanitizer_coverage_interface.inc
\
// RUN: | grep -e "INTERFACE_\(WEAK_\)\?FUNCTION"
\
// RUN: | grep -v "__sanitizer_weak_hook"
\
+// R
vitalybuka wrote:
It's LGTM, but it's going to be annoying to merge.
I bet this patch has several reasons to be reverted, and will be reverted
multiple times.
It would be nice to try to split into smaller parts.
https://github.com/llvm/llvm-project/pull/81677
__
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/90299
https://lab.llvm.org/buildbot/#/builders/168/builds/20063
This reverts commit cf5a8b489464d09dfdd7a48ce7c8b41d3c9bf819.
>From b4c0a3f4835a686a15a3ed90a4058f353f844f26 Mon Sep 17 00:00:00 2001
From: Vitaly Bu
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Lets revert #90299 to recover bots before the weekend.
https://github.com/llvm/llvm-project/pull/83774
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka milestoned
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka demilestoned
https://github.com/llvm/llvm-project/pull/90299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> Thanks a lot, that was quick! There is another AddressSanitizer issue that
> may possibly be fixed by #90292. cc @vitalybuka
Yes, please wait for #90292.
https://github.com/llvm/llvm-project/pull/90373
___
cfe-commits mailing lis
vitalybuka wrote:
This patch breaks:
https://lab.llvm.org/buildbot/#/builders/25/builds/1952
https://lab.llvm.org/buildbot/#/builders/52/builds/1775
https://github.com/llvm/llvm-project/pull/105496
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
vitalybuka wrote:
Please let me know if you have a fix for that.
I'll land revert in the morning by PDT.
https://github.com/llvm/llvm-project/pull/106343
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
vitalybuka wrote:
> > This patch breaks: https://lab.llvm.org/buildbot/#/builders/25/builds/1952
> > https://lab.llvm.org/buildbot/#/builders/52/builds/1775
>
> From the buildbot run I can see 12 or 13 changes in the build that failed.
> Just out of curiosity how did you find out it was this p
vitalybuka wrote:
Maybe the patch introduced some miscompile?
The patch affects only clang, but failing tests are LLVM, but tools compiled
with patched clang with UBSAN enabled.
Also there are branches checking sanitizers.
https://github.com/llvm/llvm-project/pull/105496
__
vitalybuka wrote:
> > Please let me know if you have a fix for that. I'll land revert in the
> > morning by PDT.
>
> Thank you for flagging this up and opening this @vitalybuka - I'm taking a
> look now to see if there's an easy enough fix to save reverting.
Thanks. Please merge the revert if
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/106649
None
>From 46f3fb6634138f2d9ce8f301b05d09d16da9f3ea Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Thu, 29 Aug 2024 17:43:18 -0700
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia
https://github.com/vitalybuka converted_to_draft
https://github.com/llvm/llvm-project/pull/106649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> Can you explain what changes were made to address the various issues which
> caused the earlier revert? I've tried diffing the PRs to see what the changes
> are, but my git-fu is insufficient to the task. :-D
Just for convenience I extracted update diff into
https://github
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/92460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/92460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/92460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,516 @@
+//===--- rtsan_test_interceptors.cpp - Realtime Sanitizer ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
vitalybuka wrote:
I can reproduce and will debug in an hour.
https://github.com/llvm/llvm-project/pull/92460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka requested changes to this pull request.
Discussed offline, it should be IR tests
https://github.com/llvm/llvm-project/pull/98247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
vitalybuka wrote:
They look quite independent.
Would be possible to split independent fixed into a separate patches?
https://github.com/llvm/llvm-project/pull/98001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/98194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/98415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
@eugenis There is a inconsistency now with
https://github.com/llvm/llvm-project/pull/98194/files
https://github.com/llvm/llvm-project/pull/98415
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
vitalybuka wrote:
@budimirarandjelovicsyrmia Any updates? Should we revert the patch?
https://github.com/llvm/llvm-project/pull/70024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Thank you!
Sorry, I should search for reverts before complaining.
https://github.com/llvm/llvm-project/pull/70024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Also https://lab.llvm.org/buildbot/#/builders/66/builds/1427/steps/13/logs/stdio
```
[20/21] Running compiler_rt regression tests
llvm-lit:
/b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:60:
warning: Path reported by clang does not exist:
"/b
vitalybuka wrote:
> Also
> https://lab.llvm.org/buildbot/#/builders/66/builds/1427/steps/13/logs/stdio
>
> ```
> [20/21] Running compiler_rt regression tests
> llvm-lit:
> /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/lit.common.cfg.py:60:
> warning: Path reported by clang doe
vitalybuka wrote:
Breaks https://lab.llvm.org/buildbot/#/builders/5/builds/43086
https://github.com/llvm/llvm-project/pull/90499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/90885
Breaks
https://lab.llvm.org/buildbot/#/builders/5/builds/43086/steps/9/logs/stdio
Reverts llvm/llvm-project#90499
>From a6ca95f5e2991fb7f857f70436148a6abdecec00 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Da
vitalybuka wrote:
I am not sure what should be a correct fix, so I'll revert?
https://github.com/llvm/llvm-project/pull/90499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> I already has patch in #90800 waiting for test to finish.
Fix forward is good for something < 1H, but looks like you started 19H ago.
Such cases must be reverted and then fixed.
How long do you need?
https://github.com/llvm/llvm-project/pull/90885
__
vitalybuka wrote:
> How long do you need?
Looks like it's landed.
Thanks!
https://github.com/llvm/llvm-project/pull/90885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Oh, it's not landed. I looked at wrong PR. Lets revert if it can't be landed
soon.
https://github.com/llvm/llvm-project/pull/90885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
vitalybuka wrote:
> BTW, Hi @vitalybuka, do you know how to reproduce the problem with sanitizer
> build? Thanks.
There is a basic instruction, should work with Linux
https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild
I guess this issue should be detectable with appropriate `
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/90885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Please include this fix into re-land.
https://github.com/llvm/llvm-project/pull/90800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka requested changes to this pull request.
Looks broken
https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/9/logs/stdio
https://github.com/llvm/llvm-project/pull/90935
___
cfe-commits mailing list
cfe-commits@list
vitalybuka wrote:
> Looks broken
> https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/9/logs/stdio
This is special build from this PR see `git status` here
https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/6/logs/stdio
https://github.com/llvm/llvm-project/pull/90935
vitalybuka wrote:
> 7c28408
good point, maybe not, I scheduled it as with, without rebase.
Let's try again.
https://github.com/llvm/llvm-project/pull/90935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/90935
>From 8468a10bf34e4c432b181d40c370043ad21b5801 Mon Sep 17 00:00:00 2001
From: jyu2-git
Date: Thu, 2 May 2024 20:55:18 -0700
Subject: [PATCH] Revert "Revert "[OpenMP][TR12] change property of map-type
modifier
vitalybuka wrote:
> > BTW, Hi @vitalybuka, do you know how to reproduce the problem with
> > sanitizer build? Thanks.
>
> There is a basic instruction, should work with Linux
> https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild I guess
> this issue should be detectable with
vitalybuka wrote:
> > 7c28408
>
> good point, maybe not, I scheduled it as with, without rebase. Let's try
> again.
Still fails after rebase https://lab.llvm.org/buildbot/#/builders/5/builds/43115
https://github.com/llvm/llvm-project/pull/90935
___
vitalybuka wrote:
```
diff --git a/clang/lib/Parse/ParseOpenMP.cpp b/clang/lib/Parse/ParseOpenMP.cpp
index 53d89ce2fa3e..1a4442f38f6d 100644
--- a/clang/lib/Parse/ParseOpenMP.cpp
+++ b/clang/lib/Parse/ParseOpenMP.cpp
@@ -4326,6 +4326,7 @@ static OpenMPMapClauseKind isMapType(Parser &P) {
OpenM
vitalybuka wrote:
Yes, its there
but it's too late
we can't cast to enum invalid values
it should be like:
```
unsigned MapType = getOpenMPSimpleClauseType(
OMPC_map, PP.getSpelling(Tok), P.getLangOpts());
if (MapType == OMPC_MAP_to || MapType == OMPC_MAP_from ||
MapType ==
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/91141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/91141
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> Greetings and hello from the UK!
>
> it looks as though this commit caused a test failure on the following build
> bot, is anyone able to take a look see?
>
> https://lab.llvm.org/buildbot/#/builders/139/builds/65066
>
> Will give it an hour for a reply before looking at a
https://github.com/vitalybuka commented:
LGTM
https://github.com/llvm/llvm-project/pull/91032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vitaly Buka
Date: 2024-05-19T05:44:40-07:00
New Revision: ed9007d0d219726db01f211e9c9ab72fbfe4ecb1
URL:
https://github.com/llvm/llvm-project/commit/ed9007d0d219726db01f211e9c9ab72fbfe4ecb1
DIFF:
https://github.com/llvm/llvm-project/commit/ed9007d0d219726db01f211e9c9ab72fbfe4ecb1.diff
L
Author: Vitaly Buka
Date: 2024-05-19T05:44:40-07:00
New Revision: 6447abe067c8088a5cc093fe872719374e174068
URL:
https://github.com/llvm/llvm-project/commit/6447abe067c8088a5cc093fe872719374e174068
DIFF:
https://github.com/llvm/llvm-project/commit/6447abe067c8088a5cc093fe872719374e174068.diff
L
Author: Vitaly Buka
Date: 2024-05-19T06:21:40-07:00
New Revision: c587483da0b50efa04146fde205da1d16731e12e
URL:
https://github.com/llvm/llvm-project/commit/c587483da0b50efa04146fde205da1d16731e12e
DIFF:
https://github.com/llvm/llvm-project/commit/c587483da0b50efa04146fde205da1d16731e12e.diff
L
vitalybuka wrote:
This one is broken https://lab.llvm.org/buildbot/#/builders/168/builds/20461
https://github.com/llvm/llvm-project/pull/90373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
vitalybuka wrote:
> Based on my rough understanding, this is expected?
What do you mean?
Isn't this test needs to be updated or disabled?
https://github.com/llvm/llvm-project/pull/90373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
vitalybuka wrote:
> > > Based on my rough understanding, this is expected?
> >
> >
> > What do you mean?
> > Isn't this test needs to be updated or disabled?
>
> I think this ASAN failure is not caused by this PR because these memorys are
> allocated/deallocated by
100% sure by this PR
https
vitalybuka wrote:
Internally ::allocate uses sided new:
```
void*
allocate(size_t __bytes, size_t __alignment = _S_max_align)
__attribute__((__returns_nonnull__,__alloc_size__(2),__alloc_align__(3)))
{ return ::operator new(__bytes, do_allocate(__bytes, __alignment)); }
```
https:
Author: Vitaly Buka
Date: 2022-01-27T21:16:53-08:00
New Revision: f750c3d95a0c8bf1d21380ae753fce12010a7561
URL:
https://github.com/llvm/llvm-project/commit/f750c3d95a0c8bf1d21380ae753fce12010a7561
DIFF:
https://github.com/llvm/llvm-project/commit/f750c3d95a0c8bf1d21380ae753fce12010a7561.diff
L
701 - 800 of 1471 matches
Mail list logo
