[clang] e8cd046 - [AST] Initialize local counter

2023-05-18 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2023-05-18T01:19:11-07:00 New Revision: e8cd04624e503ae063e925eb5609281a88716d83 URL: https://github.com/llvm/llvm-project/commit/e8cd04624e503ae063e925eb5609281a88716d83 DIFF: https://github.com/llvm/llvm-project/commit/e8cd04624e503ae063e925eb5609281a88716d83.diff L

[clang] b96d063 - [NFC][AST] Align one line

2023-05-18 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2023-05-18T01:19:48-07:00 New Revision: b96d0635f0c65de2fbbcf67fac7e70f9cce35171 URL: https://github.com/llvm/llvm-project/commit/b96d0635f0c65de2fbbcf67fac7e70f9cce35171 DIFF: https://github.com/llvm/llvm-project/commit/b96d0635f0c65de2fbbcf67fac7e70f9cce35171.diff L

[clang] 11fe931 - [AST] Initialized AutoTypeLocInfo::FoundDecl

2023-05-18 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2023-05-18T01:21:29-07:00 New Revision: 11fe9310b9146ee7dfd7cf01662e8fc0a7cd508c URL: https://github.com/llvm/llvm-project/commit/11fe9310b9146ee7dfd7cf01662e8fc0a7cd508c DIFF: https://github.com/llvm/llvm-project/commit/11fe9310b9146ee7dfd7cf01662e8fc0a7cd508c.diff L

[clang] 9e270c6 - [test][clang-repl] Disable test incompatible with msan

2023-05-18 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2023-05-18T01:24:03-07:00 New Revision: 9e270c64a7319929da2b92920a91136fd9e2df43 URL: https://github.com/llvm/llvm-project/commit/9e270c64a7319929da2b92920a91136fd9e2df43 DIFF: https://github.com/llvm/llvm-project/commit/9e270c64a7319929da2b92920a91136fd9e2df43.diff L

[clang] da89ed9 - [cmake] Explicitly disable download step

2023-04-19 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2023-04-19T12:57:12-07:00 New Revision: da89ed99a16920e5986b14853d297322ccf7109e URL: https://github.com/llvm/llvm-project/commit/da89ed99a16920e5986b14853d297322ccf7109e DIFF: https://github.com/llvm/llvm-project/commit/da89ed99a16920e5986b14853d297322ccf7109e.diff L

[clang] b03abbb - [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses

2023-06-09 Thread Vitaly Buka via cfe-commits
Author: Wang Date: 2023-06-09T11:28:14-07:00 New Revision: b03abbb537e5403ab32f97e2ffcebafe4a92720d URL: https://github.com/llvm/llvm-project/commit/b03abbb537e5403ab32f97e2ffcebafe4a92720d DIFF: https://github.com/llvm/llvm-project/commit/b03abbb537e5403ab32f97e2ffcebafe4a92720d.diff LOG: [cl

[clang-tools-extra] 0e8384a - [clangd] Initialize local variable

2023-06-13 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2023-06-13T08:58:46-07:00 New Revision: 0e8384a0fe4f03d60cd92aba1cae074512481ca2 URL: https://github.com/llvm/llvm-project/commit/0e8384a0fe4f03d60cd92aba1cae074512481ca2 DIFF: https://github.com/llvm/llvm-project/commit/0e8384a0fe4f03d60cd92aba1cae074512481ca2.diff L

[clang] a3b48e0 - [NFC][CodeGen] Extract HasStrictReturn

2022-12-04 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-12-04T19:10:17-08:00 New Revision: a3b48e094525ebbce95e7a9da77612adf04ae314 URL: https://github.com/llvm/llvm-project/commit/a3b48e094525ebbce95e7a9da77612adf04ae314 DIFF: https://github.com/llvm/llvm-project/commit/a3b48e094525ebbce95e7a9da77612adf04ae314.diff L

[clang] 262d6d4 - [test][CodeGen] Check noundef for return value

2022-12-04 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-12-04T19:10:17-08:00 New Revision: 262d6d495c692678c100fc4565a519b4ed070f28 URL: https://github.com/llvm/llvm-project/commit/262d6d495c692678c100fc4565a519b4ed070f28 DIFF: https://github.com/llvm/llvm-project/commit/262d6d495c692678c100fc4565a519b4ed070f28.diff L

[clang] 487edfa - [NFC][CodeGen] Add const to a method

2022-12-04 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-12-04T19:10:17-08:00 New Revision: 487edfa4327446d884709263006d3b9108181fce URL: https://github.com/llvm/llvm-project/commit/487edfa4327446d884709263006d3b9108181fce DIFF: https://github.com/llvm/llvm-project/commit/487edfa4327446d884709263006d3b9108181fce.diff L

[clang] 9e87878 - [test][CodeGen] Check noundef for omited return

2022-12-04 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-12-04T19:10:17-08:00 New Revision: 9e8787821f62bc7856d9a4cdf439aadbaf43ed64 URL: https://github.com/llvm/llvm-project/commit/9e8787821f62bc7856d9a4cdf439aadbaf43ed64 DIFF: https://github.com/llvm/llvm-project/commit/9e8787821f62bc7856d9a4cdf439aadbaf43ed64.diff L

[clang] e92fe7a - [test][msan] Update for noundef on retval

2022-12-04 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-12-04T22:47:56-08:00 New Revision: e92fe7af3f9d7a660e026912852c8ce401331c03 URL: https://github.com/llvm/llvm-project/commit/e92fe7af3f9d7a660e026912852c8ce401331c03 DIFF: https://github.com/llvm/llvm-project/commit/e92fe7af3f9d7a660e026912852c8ce401331c03.diff L

[clang] 166c8cc - [msan][CodeGen] Set noundef for C return value

2022-12-05 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2022-12-05T22:58:29-08:00 New Revision: 166c8cccde010ea01fdc20945a2a25fa1971cb73 URL: https://github.com/llvm/llvm-project/commit/166c8cccde010ea01fdc20945a2a25fa1971cb73 DIFF: https://github.com/llvm/llvm-project/commit/166c8cccde010ea01fdc20945a2a25fa1971cb73.diff L

Re: r290533 - Driver: warn on -fPIC/-fpic/-fPIE/-fpie on Windows

2016-12-26 Thread Vitaly Buka via cfe-commits
This fails here http://lab.llvm.org:8011/builders/sanitizer-windows/builds/3537/steps/run%20tests/logs/stdio On Sun, Dec 25, 2016 at 7:45 PM Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Sun Dec 25 21:35:24 2016 > New Revision: 290533 > > URL:

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

2016-12-27 Thread Vitaly Buka via cfe-commits
Both work: #define DECLARE_ASM_REP_MOVS(Type, Movs) \ template <> void asm_rep_movs(Type * dst, Type * src, size_t size) { \ __asm__("rep " Movs " \n\t" \ : "+D"(dst), "+S"(src), "+c"(size) \ : \ : "memory"); \ }

Re: r279351 - [NFC] Add a class ObjCProtocolQualifiers to wrap APIs for ObjC protocol list.

2016-08-19 Thread Vitaly Buka via cfe-commits
Windows build is broken http://lab.llvm.org:8011/builders/sanitizer-windows/builds/27686/steps/run%20tests/logs/stdio On Fri, Aug 19, 2016 at 5:12 PM Manman Ren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: mren > Date: Fri Aug 19 19:04:21 2016 > New Revision: 279351 > > URL: htt

Re: r279374 - [Sema] Don't crash on scanf on forward-declared enums.

2016-08-20 Thread Vitaly Buka via cfe-commits
msan is not happy about this change http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/15681/steps/check-llvm%20msan/logs/stdio On Sat, Aug 20, 2016 at 9:59 AM Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Sat Aug 20 11:51:33 2016 > N

Re: r279374 - [Sema] Don't crash on scanf on forward-declared enums.

2016-08-21 Thread Vitaly Buka via cfe-commits
flake On Sat, Aug 20, 2016 at 11:30 AM Benjamin Kramer wrote: > It cycled back to green. flake? > > On Sat, Aug 20, 2016 at 7:27 PM, Vitaly Buka > wrote: > > msan is not happy about this change > > > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/15681/steps/check-llvm%20m

r279722 - Fix memory leaks in clang-offload-bundler

2016-08-25 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Thu Aug 25 02:21:34 2016 New Revision: 279722 URL: http://llvm.org/viewvc/llvm-project?rev=279722&view=rev Log: Fix memory leaks in clang-offload-bundler Summary: 1. Pair removed from StringMap was not destroyed 2. ObjectFile had no owner Reviewers: sfantao Subscribers:

Re: r279653 - Fix offload bundler tests so that diagnostic can start with caps.

2016-08-25 Thread Vitaly Buka via cfe-commits
It still fails on Windows on another line, \0A vs \0D\0A C:\buildbot\slave-config\clang-x86-win2008-selfhost\llvm\tools\clang\test\Driver\clang-offload-bundler.c:233:16: error: expected string not found in input // CK-OBJ-CMD: private constant [25 x i8] c"Content of device file 1\0A", section "__

Re: [PATCH] D23961: Avoid embedded preprocessor directives in __tree

2016-08-27 Thread Vitaly Buka via cfe-commits
vitalybuka added a subscriber: vitalybuka. vitalybuka added a comment. PPC bots are broken by this patch http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/3547 http://lab.llvm.org:8011/builders/sanitizer-ppc64le-linux/builds/2353 Repository: rL LLVM https://reviews.llvm.org/D2

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

2016-09-06 Thread Vitaly Buka via cfe-commits
vitalybuka resigned from this revision. vitalybuka removed a reviewer: vitalybuka. vitalybuka added a comment. I have no strong opinion on that. There is already exception for startfiles, so maybe sanitizes are OK as well. https://reviews.llvm.org/D24048 _

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-16 Thread Vitaly Buka via cfe-commits
vitalybuka created this revision. vitalybuka added a reviewer: eugenis. vitalybuka added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. Current generation of lifetime intrinsics does not handle cases like: { char x; l1: bar(&x, 1); } goto l1; Intrinsics were b

[PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

2016-09-16 Thread Vitaly Buka via cfe-commits
vitalybuka created this revision. vitalybuka added a reviewer: eugenis. vitalybuka added a subscriber: cfe-commits. D24693 will need access to it from other places https://reviews.llvm.org/D24695 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h

Re: [PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-09-16 Thread Vitaly Buka via cfe-commits
vitalybuka updated this revision to Diff 71721. vitalybuka added a comment. Rebase on https://reviews.llvm.org/D24695 https://reviews.llvm.org/D24693 Files: lib/CodeGen/CGDecl.cpp lib/CodeGen/CMakeLists.txt lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h lib/CodeGen/VarB

Re: r298392 - [index/AST] Determine if a typedef shares a name and spelling location with its underlying tag type

2017-03-21 Thread Vitaly Buka via cfe-commits
Could you please take a look at these leaks http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/3606/steps/check-clang%20asan/logs/stdio = ==32547==ERROR: LeakSanitizer: detected memory leaks Direct leak of 24 byte

Re: [libcxx] r294707 - Split exception.cpp and new.cpp implementation into different files for different runtimes.

2017-02-09 Thread Vitaly Buka via cfe-commits
Thanks. looking... On Thu, Feb 9, 2017 at 9:51 PM Eric Fiselier wrote: > To all those who wander here from the sanitizer autoconf buildbot failures > . > > Yes, this commit is responsible for that breakage. The buildbot in questi

Re: [libcxx] r294707 - Split exception.cpp and new.cpp implementation into different files for different runtimes.

2017-02-09 Thread Vitaly Buka via cfe-commits
As I understand it's not the builder but cmake files of compiler-rt need to be fixed, somewhere near add_custom_libcxx in tsan and msan. Something just like this should work, but it's broken after the patch. cmake -GNinja -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ ../../llvm && ninja che

[PATCH] D26695: Revert "[OPENMP] Fixed codegen for 'omp cancel' construct."

2016-11-15 Thread Vitaly Buka via cfe-commits
vitalybuka created this revision. vitalybuka added a reviewer: ABataev. vitalybuka added a subscriber: cfe-commits. It introduced stack-use-after-return detected by ASAN. Here: ''' auto &&CodeGen = [ELoc](CodeGenFunction &CGF) { CGF.CGM.getOpenMPRuntime().emitForStaticFinish(CGF, ELoc);

[PATCH] D26522: Improve handling of __FUNCTION__ and other predefined expression for Objective-C Blocks

2016-11-15 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. This is probably caused by this patch http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/649/steps/check-clang%20msan/logs/stdio Repository: rL LLVM https://reviews.llvm.org/D26522 ___ cfe-commits mai

Re: r287025 - [OPENMP] Fix stack use after delete, NFC.

2016-11-15 Thread Vitaly Buka via cfe-commits
With this patch it's "after-scope" instead of return but still there: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/650/steps/check-clang%20asan/logs/stdio On Tue, Nov 15, 2016 at 1:07 PM Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: abataev >

[PATCH] D26720: Revert "[OPENMP] Fixed codegen for 'omp cancel' construct."

2016-11-15 Thread Vitaly Buka via cfe-commits
vitalybuka created this revision. vitalybuka added a reviewer: ABataev. vitalybuka added a subscriber: cfe-commits. r286944 introduced bugs detected by ASAN as use-after-return. r287025 have not fixed them completely. This reverts commit r286944 and r287025. https://reviews.llvm.org/D26720 Fil

r287069 - Revert "[OPENMP] Fixed codegen for 'omp cancel' construct."

2016-11-15 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Nov 15 19:01:22 2016 New Revision: 287069 URL: http://llvm.org/viewvc/llvm-project?rev=287069&view=rev Log: Revert "[OPENMP] Fixed codegen for 'omp cancel' construct." Summary: r286944 introduced bugs detected by ASAN as use-after-return. r287025 have not fixed them c

[PATCH] D26720: Revert "[OPENMP] Fixed codegen for 'omp cancel' construct."

2016-11-15 Thread Vitaly Buka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287069: Revert "[OPENMP] Fixed codegen for 'omp cancel' construct." (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D26720?vs=78107&id=78109#toc Repository: rL LLVM https

Re: r287025 - [OPENMP] Fix stack use after delete, NFC.

2016-11-15 Thread Vitaly Buka via cfe-commits
I've reverted them both to fix bots: https://reviews.llvm.org/D26720 On Tue, Nov 15, 2016 at 3:40 PM Vitaly Buka wrote: > With this patch it's "after-scope" instead of return but still there: > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/650/steps/check-clang%20asan/logs

r288685 - Fix stack-use-after-scope in EvaluateImplicitExceptionSpec

2016-12-05 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon Dec 5 12:30:22 2016 New Revision: 288685 URL: http://llvm.org/viewvc/llvm-project?rev=288685&view=rev Log: Fix stack-use-after-scope in EvaluateImplicitExceptionSpec Summary: getExceptionSpec returns structure with pointers to temporarily object created by computeImp

r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

2016-12-05 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon Dec 5 13:25:00 2016 New Revision: 288689 URL: http://llvm.org/viewvc/llvm-project?rev=288689&view=rev Log: Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec Summary: Similar to r288685. getExceptionSpec returned structure with pointers to tempo

Re: r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

2016-12-06 Thread Vitaly Buka via cfe-commits
e policy, but I assumed that was a reasonable approach. So what is the process for after commit review? Alex On 5 December 2016 at 19:25, Vitaly Buka via cfe-commits < cfe-commits@lists.llvm.org> wrote: Author: vitalybuka Date: Mon Dec 5 13:25:00 2016 New Revision: 288689 URL: http://llvm.or

Re: r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

2017-05-01 Thread Vitaly Buka via cfe-commits
crash-vfs-ivfsoverlay.m does not work http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1322/steps/check-clang%20asan/logs/stdio On Fri, Apr 28, 2017 at 6:51 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Apr 28 20:38:29

Re: r301732 - Remove some apparently-unnecessary 'REQUIRES: system-darwin' from tests.

2017-05-01 Thread Vitaly Buka via cfe-commits
We should file a bug and disable the test. Red bots are inconvenient for build cop. I have not notice this on non-asan builds, but I didn't look. On Mon, May 1, 2017 at 12:14 PM Richard Smith wrote: > Looks like this test has found a bug in the compiler. I've not repro'd it > yet but my guess is

r303121 - [Sema] Use CK_NoOp instead CK_Invalid in tryGCCVectorConvertAndSplat

2017-05-15 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Mon May 15 17:04:03 2017 New Revision: 303121 URL: http://llvm.org/viewvc/llvm-project?rev=303121&view=rev Log: [Sema] Use CK_NoOp instead CK_Invalid in tryGCCVectorConvertAndSplat This fix UBSAN bots after r302935. Storing non-defined values in enum is undefined behavior

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-16 Thread Vitaly Buka via cfe-commits
The patch breaks this test http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1349/steps/check-clang%20msan/logs/stdio Script: -- /mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm_build_msan/./bin/clang -cc1 -internal-isystem /mnt/b/sanitizer-buildbot2/s

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-17 Thread Vitaly Buka via cfe-commits
On Tue, May 16, 2017 at 12:19 PM Richard Smith wrote: > On 16 May 2017 at 11:54, Vitaly Buka wrote: > >> The patch breaks this test >> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1349/steps/check-clang%20msan/logs/stdio >> > > Given the nature of this change, that's

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-17 Thread Vitaly Buka via cfe-commits
And looks like "-w" is needed to trigger this. On Wed, May 17, 2017 at 1:43 PM Vitaly Buka wrote: > On Tue, May 16, 2017 at 12:19 PM Richard Smith > wrote: > >> On 16 May 2017 at 11:54, Vitaly Buka wrote: >> >>> The patch breaks this test >>> http://lab.llvm.org:8011/builders/sanitizer-x86_64-

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-17 Thread Vitaly Buka via cfe-commits
Actually it was not "-w" but -DCMAKE_BUILD_TYPE=Release Also now I am not sure that it was r302966. Looking. On Wed, May 17, 2017 at 2:15 PM Vitaly Buka wrote: > And looks like "-w" is needed to trigger this. > > On Wed, May 17, 2017 at 1:43 PM Vitaly Buka wrote: > >> On Tue, May 16, 2017 at 12

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-17 Thread Vitaly Buka via cfe-commits
+Dehao Chen it started from r302938 On Wed, May 17, 2017 at 8:09 PM Jordan Rose via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Thanks, this is helpful! > > > On May 16, 2017, at 12:26, Richard Smith wrote: > > On 15 May 2017 at 10:28, Jordan Rose via cfe-commits < > cfe-commits@lists.ll

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-18 Thread Vitaly Buka via cfe-commits
Local build: r302937 no issue, r302938 has issue. On Thu, May 18, 2017 at 7:23 AM Dehao Chen wrote: > Could you give some context on how r302938 is related to this? > > Thanks, > Dehao > > On Wed, May 17, 2017 at 11:14 PM, Vitaly Buka > wrote: > >> +Dehao Chen >> it started from r302938 >> >>

Re: r302966 - Remove unused tracking of owning module for MacroInfo objects.

2017-05-18 Thread Vitaly Buka via cfe-commits
Clang produces some confusing macro errors. According to Richard it's miscompilation: https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg57270.html On Thu, May 18, 2017 at 1:14 PM Dehao Chen wrote: > What's the issue? Build breaking? Performance regression? It's not clear > from the limi

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-10-17 Thread Vitaly Buka via cfe-commits
vitalybuka marked an inline comment as done. vitalybuka added a comment. Slowdown from this function is below: 0.05% and it's mostly just traversing AST. https://reviews.llvm.org/D24693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

r285159 - [Sema] Handle CaseStmt and DefaultStmt as SwitchCase

2016-10-25 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Oct 25 21:00:00 2016 New Revision: 285159 URL: http://llvm.org/viewvc/llvm-project?rev=285159&view=rev Log: [Sema] Handle CaseStmt and DefaultStmt as SwitchCase Summary: rsmith Differential Revision: https://reviews.llvm.org/D25665 Modified: cfe/trunk/lib/Sema/J

r285158 - [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

2016-10-25 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Oct 25 20:59:57 2016 New Revision: 285158 URL: http://llvm.org/viewvc/llvm-project?rev=285158&view=rev Log: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place Summary: D24693 will need access to it from other places Reviewers: eugenis Subscribers: c

[PATCH] D24695: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place

2016-10-25 Thread Vitaly Buka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285158: [CodeGen] Move shouldEmitLifetimeMarkers into more convenient place (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D24695?vs=72908&id=75827#toc Repository: rL LLV

r285176 - [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-10-25 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Oct 26 00:42:30 2016 New Revision: 285176 URL: http://llvm.org/viewvc/llvm-project?rev=285176&view=rev Log: [CodeGen] Don't emit lifetime intrinsics for some local variables Summary: Current generation of lifetime intrinsics does not handle cases like: ``` { ch

[PATCH] D24693: [CodeGen] Don't emit lifetime intrinsics for some local variables

2016-10-25 Thread Vitaly Buka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285176: [CodeGen] Don't emit lifetime intrinsics for some local variables (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D24693?vs=74814&id=75832#toc Repository: rL LLVM

r277488 - Updated documentation

2016-08-02 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Tue Aug 2 12:51:48 2016 New Revision: 277488 URL: http://llvm.org/viewvc/llvm-project?rev=277488&view=rev Log: Updated documentation Reviewers: kcc, eugenis Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D22992 Modified: cfe/trunk/docs/A

r271443 - Summary: Remove unused option

2016-06-01 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Jun 1 19:00:38 2016 New Revision: 271443 URL: http://llvm.org/viewvc/llvm-project?rev=271443&view=rev Log: Summary: Remove unused option Reviewers: kcc, eugenis, aizatsky Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D20740 Modified:

r271451 - [asan] Added -fsanitize-address-use-after-scope flag

2016-06-01 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Jun 1 19:24:20 2016 New Revision: 271451 URL: http://llvm.org/viewvc/llvm-project?rev=271451&view=rev Log: [asan] Added -fsanitize-address-use-after-scope flag Summary: Also emit lifetime markers for -fsanitize-address-use-after-scope. Asan uses life-time markers for

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

2016-06-06 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. Is anything blocking us on this review? http://reviews.llvm.org/D20499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. I guess you can remove // UNSUPPORTED: mingw32 added by cfe/trunk@271509 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Actually there are other tests with -fsanitize=address I see only difference in %clang vs %clang_cc1? Could you try this? Repository: rL LLVM http://reviews.llvm.org/D21082 _

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. It was accepted accidentally. Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. Oh, I see, most asan tests in clang use cross-compiler, e.g.: -target x86_64-linux-gnu Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D21117: Specify target in lifetime-asan test.

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka created this revision. vitalybuka added reviewers: pcc, eugenis. vitalybuka added subscribers: kubabrecka, chapuni, christof, cfe-commits. Some target platforms -fsanitize=address. http://reviews.llvm.org/D21117 Files: test/CodeGen/lifetime-asan.c Index: test/CodeGen/lifetime-asan.

Re: [PATCH] D21082: Do not assume that -fsanitize=address is valid option in clang tests

2016-06-07 Thread Vitaly Buka via cfe-commits
vitalybuka added a comment. http://reviews.llvm.org/D21117 Repository: rL LLVM http://reviews.llvm.org/D21082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r272185 - Specify target in lifetime-asan test.

2016-06-08 Thread Vitaly Buka via cfe-commits
Author: vitalybuka Date: Wed Jun 8 13:18:08 2016 New Revision: 272185 URL: http://llvm.org/viewvc/llvm-project?rev=272185&view=rev Log: Specify target in lifetime-asan test. Summary: Some target platforms -fsanitize=address. Reviewers: pcc, eugenis Subscribers: cfe-commits, christof, chapuni,

Re: [PATCH] D21117: Specify target in lifetime-asan test.

2016-06-08 Thread Vitaly Buka via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272185: Specify target in lifetime-asan test. (authored by vitalybuka). Changed prior to commit: http://reviews.llvm.org/D21117?vs=59987&id=60071#toc Repository: rL LLVM http://reviews.llvm.org/D211

Re: r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

2016-06-14 Thread Vitaly Buka via cfe-commits
Probably the bot was broken by this CL http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/9922 On Tue, Jun 14, 2016 at 1:03 PM Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This change was generated by running `svn mv -m "Rename Intrin.h to > intrin.h, that

Re: r272701 - Rename Intrin.h to intrin.h, that's how all the documentation calls it.

2016-06-14 Thread Vitaly Buka via cfe-commits
thanks On Tue, Jun 14, 2016 at 1:31 PM Rui Ueyama wrote: > Hans seems to fix it in r272701. > > On Tue, Jun 14, 2016 at 1:26 PM, Vitaly Buka via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Probably the bot was broken by this CL >> http://lab.llvm.o

Re: r275464 - Attempt to workaround Windows bots after my previous commit

2016-07-14 Thread Vitaly Buka via cfe-commits
The patch breaks this test: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/14659/steps/check-clang%20msan/logs/stdio On Thu, Jul 14, 2016 at 1:16 PM Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: benlangmuir > Date: Thu Jul 14 15:08:43 2016 > New

Re: r275464 - Attempt to workaround Windows bots after my previous commit

2016-07-14 Thread Vitaly Buka via cfe-commits
Thank you. On Thu, Jul 14, 2016 at 4:00 PM Ben Langmuir wrote: > Thanks! it was actually my earlier commit that broke it, it just didn’t > turn up until a second build happened. > > Fixed in r275496 > > > > On Jul 14, 2016, at 2:55 PM, Vitaly Buka wrote: > > The patch breaks this test: > http:/

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-14 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Why not just enforce -fsanitize=signed-integer-overflow with -fwrapv? I suspect it's just overlook, and not intentional behavior. https://github.com/llvm/llvm-project/pull/80089 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-14 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > > > Why not just enforce -fsanitize=signed-integer-overflow with -fwrapv? I > > > suspect it's just overlook, and not intentional behavior. > > > > > > +1 > > We should consider this direction > > The UB-vs-non-UB seemed to be a really specific goal in the existing code.

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-14 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > `signed-integer-overflow` Or maybe I am missing the bigger picture? Is there a plan fix signed-integer-overflow for -fwrapv as well? https://github.com/llvm/llvm-project/pull/80089 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] Extend life of variables in `DiagComparison` in `ExprConstant` (PR #79522)

2024-02-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka requested changes to this pull request. As we figured out what was the issue, this patch should not be needed https://github.com/llvm/llvm-project/pull/79522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-20 Thread Vitaly Buka via cfe-commits
@@ -193,7 +193,14 @@ Available checks are: signed division overflow (``INT_MIN/-1``), but not checks for lossy implicit conversions performed before the computation (see ``-fsanitize=implicit-conversion``). Both of these two issues are - handled by ``-fsaniti

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-20 Thread Vitaly Buka via cfe-commits
@@ -193,7 +193,14 @@ Available checks are: signed division overflow (``INT_MIN/-1``), but not checks for lossy implicit conversions performed before the computation (see ``-fsanitize=implicit-conversion``). Both of these two issues are - handled by ``-fsaniti

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-20 Thread Vitaly Buka via cfe-commits
@@ -193,7 +193,14 @@ Available checks are: signed division overflow (``INT_MIN/-1``), but not checks for lossy implicit conversions performed before the computation (see ``-fsanitize=implicit-conversion``). Both of these two issues are - handled by ``-fsaniti

[clang] Sanitizer: Support -fwrapv with -fsanitize=signed-integer-overflow (PR #82432)

2024-02-20 Thread Vitaly Buka via cfe-commits
@@ -399,6 +399,9 @@ Moved checkers Sanitizers -- +- ``-fsanitize=signed-integer-overflow`` now instruments signed arithmetic even + when ``-fwrapv`` is enabled. Previously, only division checks were enabled. vitalybuka wrote: Maybe suggest to add `-f

[clang] Sanitizer: Support -fwrapv with -fsanitize=signed-integer-overflow (PR #82432)

2024-02-20 Thread Vitaly Buka via cfe-commits
@@ -723,7 +723,9 @@ class ScalarExprEmitter if (Ops.Ty->isSignedIntegerOrEnumerationType()) { switch (CGF.getLangOpts().getSignedOverflowBehavior()) { case LangOptions::SOB_Defined: -return Builder.CreateMul(Ops.LHS, Ops.RHS, "mul"); +if (!CGF.Sa

[clang] Sanitizer: Support -fwrapv with -fsanitize=signed-integer-overflow (PR #82432)

2024-02-20 Thread Vitaly Buka via cfe-commits
@@ -723,7 +723,9 @@ class ScalarExprEmitter if (Ops.Ty->isSignedIntegerOrEnumerationType()) { switch (CGF.getLangOpts().getSignedOverflowBehavior()) { case LangOptions::SOB_Defined: -return Builder.CreateMul(Ops.LHS, Ops.RHS, "mul"); +if (!CGF.Sa

[clang] Sanitizer: Support -fwrapv with -fsanitize=signed-integer-overflow (PR #82432)

2024-02-20 Thread Vitaly Buka via cfe-commits
@@ -399,6 +399,9 @@ Moved checkers Sanitizers -- +- ``-fsanitize=signed-integer-overflow`` now instruments signed arithmetic even + when ``-fwrapv`` is enabled. Previously, only division checks were enabled. vitalybuka wrote: It should work, it's abo

[clang] Sanitizer: Support -fwrapv with -fsanitize=signed-integer-overflow (PR #82432)

2024-02-20 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: LGTM https://github.com/llvm/llvm-project/pull/82432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Enable nsan instrumentation pass (PR #97359)

2024-07-01 Thread Vitaly Buka via cfe-commits
@@ -707,6 +708,9 @@ static void addSanitizers(const Triple &TargetTriple, MPM.addPass(createModuleToFunctionPassAdaptor(ThreadSanitizerPass())); } +if (LangOpts.Sanitize.has(SanitizerKind::NumericalStability)) + MPM.addPass(NumericalStabilitySanitizerPass())

[clang] [Clang] Enable nsan instrumentation pass (PR #97359)

2024-07-01 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/97359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-07-01 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %clang_cc1 -ast-dump -fblocks %s | FileCheck -strict-whitespace %s vitalybuka wrote: can this test be autogenerated? https://github.com/llvm/llvm-project/pull/97164 ___ cfe-commits mailing lis

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-07-01 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %clang_cc1 -ast-dump -fblocks %s | FileCheck -strict-whitespace %s vitalybuka wrote: I was thinking about utils/update_cc_test_checks.py But this is AST test Maybe llvm-project/clang/test/AST/gen_ast_dump_json_test.py https://github.co

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-07-01 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/97164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-08 Thread Vitaly Buka via cfe-commits
@@ -67,3 +67,7 @@ D: ThreadSanitizer N: Bill Wendling E: isanb...@gmail.com D: Profile runtime library + vitalybuka wrote: BTW @alexander-shaposhnikov NSAN is missing from here. https://github.com/llvm/llvm-project/pull/92460 _

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-08 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,516 @@ +//===--- rtsan_test_interceptors.cpp - Realtime Sanitizer ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-08 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,516 @@ +//===--- rtsan_test_interceptors.cpp - Realtime Sanitizer ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-08 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. LGTM. but I suggest to rework test into LIT, before or either commit. https://github.com/llvm/llvm-project/pull/92460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] Delay sanitizer args parsing. (PR #107280)

2024-09-05 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/107280 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,69 @@ +//===-- sanitizer/rtsan_interface.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,69 @@ +//===-- sanitizer/rtsan_interface.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,35 @@ +// RUN: %clangxx -fsanitize=realtime %s -o %t +// RUN: not %run %t 2>&1 | FileCheck %s +// RUN: %clangxx %s -fsanitize=realtime -o - -S -emit-llvm | FileCheck %s --check-prefix=CHECK-ENABLED-IR +// RUN: %clangxx %s -o - -S -emit-llvm | FileCheck %s --check-pref

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/106736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
@@ -54,6 +54,8 @@ FEATURE(memtag_globals, FEATURE(xray_instrument, LangOpts.XRayInstrument) FEATURE(undefined_behavior_sanitizer, LangOpts.Sanitize.hasOneOf(SanitizerKind::Undefined)) +FEATURE(realtime_sanitizer, vitalybuka wrote: clang/feature should

[clang] [clang][rtsan] Add realtime_sanitizer to Features.def (PR #106650)

2024-09-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/106650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][rtsan] Add realtime_sanitizer to Features.def (PR #106650)

2024-09-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/106650 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt][rtsan] Introduce rtsan_interface.h and ScopedDisabler (PR #106736)

2024-09-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. LGTM, with addressed comments https://github.com/llvm/llvm-project/pull/106736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

<    1   2   3   4   5   6   7   8   9   10   >