vitalybuka wrote:
Added know some folks who may know how Asan in used by Chromium on Windows.
https://github.com/llvm/llvm-project/pull/81677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/vitalybuka commented:
This is long description, but it does not explain WHY.
Could you please add some explanation there?
https://github.com/llvm/llvm-project/pull/81677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
vitalybuka wrote:
> @vitalybuka Here's a more detailed explination on the motivations behind this
> change from @amyw-msft, who is the original author of these changes on our
> side. (And who I'll add as a co-author using fixup commits)
>
> https://devblogs.microsoft.com/cppblog/msvc-address-s
vitalybuka wrote:
> If you are going to remove this feature, I would rather you simply revert the
> old commit. There is no point leaving the flag in at this point.
>
> I had explored earlier dealing with the optimization at a later time in the
> compilation pipeline, but got nowhere and this
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/84214
With #83470 it reduces UBSAN overhead from 52.5% to 12.6%.
Measured as "Geomean difference" on "test-suite/MultiSource/Benchmarks"
with PGO+ThinLTO build.
On real server apps we see 95% of code instrumented, w
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From f915a90962986cf20a9903ac9995cfee3b8ba990 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/84214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/84214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/84214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From f915a90962986cf20a9903ac9995cfee3b8ba990 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
vitalybuka wrote:
Please ignore buildkite for now, as the patch depends on #83471 which I
uploaded without stacked review.
https://github.com/llvm/llvm-project/pull/84214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
vitalybuka wrote:
> is there a long term plan to add a driver flag for this?
yes, but I'd like to that after we collect feedback from first users
https://github.com/llvm/llvm-project/pull/84214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
@@ -744,6 +750,21 @@ static void addSanitizers(const Triple &TargetTriple,
// LastEP does not need GlobalsAA.
PB.registerOptimizerLastEPCallback(SanitizersCallback);
}
+
+ if (ClRemoveTraps) {
+// We can optimize after inliner, and PGO profile matching. The hook
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/84218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
@@ -744,6 +750,21 @@ static void addSanitizers(const Triple &TargetTriple,
// LastEP does not need GlobalsAA.
PB.registerOptimizerLastEPCallback(SanitizersCallback);
}
+
+ if (ClRemoveTraps) {
+// We can optimize after inliner, and PGO profile matching. The hook
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
@@ -744,6 +750,21 @@ static void addSanitizers(const Triple &TargetTriple,
// LastEP does not need GlobalsAA.
PB.registerOptimizerLastEPCallback(SanitizersCallback);
}
+
+ if (ClRemoveTraps) {
+// We can optimize after inliner, and PGO profile matching. The hook
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/84214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/84214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/6] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/84615
Reverts llvm/llvm-project#74110
Fails on many bots: https://lab.llvm.org/buildbot/#/builders/5/builds/41633
>From 780ee1d80aa1b8cf54bd642e7c2a7e59c2dc9e11 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Sat
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/84615
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
vitalybuka wrote:
> yes, but I'd like to that after we collect feedback from first users
They are introduced by earlier transformations
Note: I'd like to have special intrinsic for this optimization. When we have
it, we likely don't need this SimplifyCFG.
https://github.com/llvm/llvm-project/
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/84214
>From feb5bfa786d1660a7fe0b6c48ec9048cdd315800 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 6 Mar 2024 10:03:46 -0800
Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?UT
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/84214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> @vitalybuka the test you added `remote-traps.c` seems to be failing on a few
> buildbots, can you take a look?
>
> * https://lab.llvm.org/buildbot/#/builders/231/builds/21492
> * https://lab.llvm.org/buildbot/#/builders/280/builds/6
looking
https://github.com/llvm/llvm-pro
Author: Vitaly Buka
Date: 2024-03-11T15:33:32-07:00
New Revision: 6397f223c456ce5a0cc246cd81673794a4860fd1
URL:
https://github.com/llvm/llvm-project/commit/6397f223c456ce5a0cc246cd81673794a4860fd1
DIFF:
https://github.com/llvm/llvm-project/commit/6397f223c456ce5a0cc246cd81673794a4860fd1.diff
L
https://github.com/vitalybuka requested changes to this pull request.
Removing from my pending reviews
https://github.com/llvm/llvm-project/pull/76127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
@@ -1094,6 +1114,27 @@ void ScalarExprEmitter::EmitIntegerTruncationCheck(Value
*Src, QualType SrcType,
{Src, Dst});
}
+static llvm::Value *EmitIsNegativeTestHelper(Value *V, QualType VType,
vitalybuka wrote:
I still see it here, does it need
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/75481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
oskarwirga@ I'd like to use this feature but without counter, preserving ubsan
IDs
Also I think in the current the counter has limited use: in optimized code,
after inlining, it will have a lot of same ids, like 0, 1 from different
functions.
So I propose to undo that part
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/83470
Removing `TrapBB->getParent()->size()` added with #65972. Counter as-is
is not very unique after inlining https://godbolt.org/z/4KfEKq7zb (see
m()).
>From e44df1c386d96472614939658e496cf2a9643e05 Mon Sep 17 0
vitalybuka wrote:
> So long as the debuggability is preserved so that it is possible to attribute
> crashes to specific lines of code, I am fine! Do you have an alternate
> solution?
In IR these traps are not de-duplicated with -ubsan-unique-traps
It happens later, in LLVM backend, it needs t
vitalybuka wrote:
> > It happens later, in LLVM backend, it needs to be fixed.
>
> From [#65972
> (comment)](https://github.com/llvm/llvm-project/pull/65972#issuecomment-1971855638)
>
> Is this something you have planned to fix? If not would replacing the .size()
> counter with perhaps a seed
@@ -4552,16 +4552,22 @@ struct MemorySanitizerVisitor : public
InstVisitor {
}
if (!ElemTy->isSized())
return;
-Value *SizeVal =
- IRB.CreateTypeSize(MS.IntptrTy, DL.getTypeStoreSize(ElemTy));
+auto Size = DL.getTypeStoreSize(ElemTy);
+Value *Siz
@@ -4552,16 +4552,22 @@ struct MemorySanitizerVisitor : public
InstVisitor {
}
if (!ElemTy->isSized())
return;
-Value *SizeVal =
- IRB.CreateTypeSize(MS.IntptrTy, DL.getTypeStoreSize(ElemTy));
+auto Size = DL.getTypeStoreSize(ElemTy);
+Value *Siz
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/79924
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4552,16 +4552,22 @@ struct MemorySanitizerVisitor : public
InstVisitor {
}
if (!ElemTy->isSized())
return;
-Value *SizeVal =
- IRB.CreateTypeSize(MS.IntptrTy, DL.getTypeStoreSize(ElemTy));
+auto Size = DL.getTypeStoreSize(ElemTy);
+Value *Siz
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/78813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Not needed
https://github.com/llvm/llvm-project/pull/78813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13288,9 +13288,23 @@ EvaluateComparisonBinaryOperator(EvalInfo &Info, const
BinaryOperator *E,
// Reject differing bases from the normal codepath; we special-case
// comparisons to null.
if (!HasSameBase(LHSValue, RHSValue)) {
- auto DiagComparison = [&] (
vitalybuka wrote:
> @vitalybuka This seems to have broken the ASAN and HWASAN builds here:
> https://lab.llvm.org/buildbot/#/builders/236/builds/8629/steps/8/logs/stdio
> https://lab.llvm.org/buildbot/#/builders/168/builds/17965/steps/8/logs/stdio
>
> My understanding is that we'd now need to
vitalybuka wrote:
@ldionne @MaskRay
Any ideas what does this mean
https://lab.llvm.org/buildbot/#/builders/85/builds/21530
https://github.com/llvm/llvm-project/pull/77687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
vitalybuka wrote:
Could this be caused by the patch
https://lab.llvm.org/buildbot/#/builders/236/builds/8673 ?
https://github.com/llvm/llvm-project/pull/77511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
vitalybuka wrote:
@petrhosek @ldionne
would it be better detect libunwind in LLVM_ENABLE_RUNTIMES?
We have similar thing for lld in compiler-rt.
There are trade offs:
1. checking LLVM_ENABLE_RUNTIMES simplify out of the end user experience,
1. forcing default ON simplifies cmake files and avoi
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/78534
>From 642d00771072386cbcc2426e749df9a40f3fb745 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 17 Jan 2024 17:57:31 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?U
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/78536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/78536
>From cbdd94e111df298caa38b007b1f46a82a7bac73a Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 17 Jan 2024 18:13:57 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?=
=?U
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/78536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
@XinWang10 Sorry, you accidentally pulled in here by `spr diff` after rebase.
https://github.com/llvm/llvm-project/pull/78536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/78534
>From 642d00771072386cbcc2426e749df9a40f3fb745 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Wed, 17 Jan 2024 17:57:31 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?U
vitalybuka wrote:
I guess buildkite/github-pull-requests is stuck
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/78534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/78534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Looks like after this patch
https://lab.llvm.org/buildbot/#/builders/236/builds/8819
https://github.com/llvm/llvm-project/pull/76218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
Author: Vitaly Buka
Date: 2024-01-18T13:09:13-08:00
New Revision: 160a750e63256e58fc171f1b6cccf8b61bb05f42
URL:
https://github.com/llvm/llvm-project/commit/160a750e63256e58fc171f1b6cccf8b61bb05f42
DIFF:
https://github.com/llvm/llvm-project/commit/160a750e63256e58fc171f1b6cccf8b61bb05f42.diff
L
vitalybuka wrote:
@vgvassilev I end up with suppression, please check, when you have time, if
this can be done better way, or just remove FIXME.
https://github.com/llvm/llvm-project/pull/76218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/77393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
I suspect asan may complain on new/free mismatch
https://github.com/llvm/llvm-project/pull/76218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/78813
None
>From b2c13350471c50f75d7a32d118faf7b04a5fbede Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Fri, 19 Jan 2024 16:07:34 -0800
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/78813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/78813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka converted_to_draft
https://github.com/llvm/llvm-project/pull/78813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Yes, it fixes the leak but on asan bot it's mismatch
https://lab.llvm.org/buildbot/#/builders/168/builds/18159/steps/10/logs/stdio
https://github.com/llvm/llvm-project/pull/76218
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
vitalybuka wrote:
Thanks, I guess symbolizer on Darwin somehow strip inlude/c++ path
https://github.com/llvm/llvm-project/pull/78534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/78843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/78843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> Note that on Gentoo, this isn't right either, we have e.g.:
>
> ```
> /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/bits/new_allocator.h
> /usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14/ext/new_allocator.h
> ```
I guess it's fine to expand the FrameIsInternal to c
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/69240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Either way seems fine, but ignore list looks more usually to me.
https://github.com/llvm/llvm-project/pull/69240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Would it be possible to create an issue, or RFC explain in one place what it
the problem you are trying to solve and how?
https://github.com/llvm/llvm-project/pull/70166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
vitalybuka wrote:
FYI @ldionne
This patch causing test_vector2.pass.cpp trigger memory leak
https://lab.llvm.org/buildbot/#/builders/168/builds/16422
Not sure if this was leaking but lsan didn't see, it's possible. Or some
regression in lsan.
https://github.com/llvm/llvm-project/pull/66285
_
Author: vitalybuka
Date: Fri Aug 23 18:31:38 2019
New Revision: 369830
URL: http://llvm.org/viewvc/llvm-project?rev=369830&view=rev
Log:
NFC: Rename some sanitizer related lifetime checks
Added:
cfe/trunk/test/CodeGen/lifetime-sanitizer.c
cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp
R
r: CHECK-LABEL: expected string not found in input
> > // CHECK-LABEL: cond.true:
> > ^
> > :21:8: note: scanning from here
> > br i1 %7, label %8, label %10
> > ^
> > :25:6: note: possible intended match here
> > store i1 true, i1* %4
Author: vitalybuka
Date: Mon Aug 26 14:29:06 2019
New Revision: 369971
URL: http://llvm.org/viewvc/llvm-project?rev=369971&view=rev
Log:
Revert r369843 "[Testing] Unbreak r369830"
That was not the fix.
This reverts commit 8bcf690ae03db85608b2ea22eac7a91c84df4dc.
Modified:
cfe/trunk/test/Cod
Author: vitalybuka
Date: Mon Aug 26 15:15:50 2019
New Revision: 369979
URL: http://llvm.org/viewvc/llvm-project?rev=369979&view=rev
Log:
msan, codegen, instcombine: Keep more lifetime markers used for msan
Reviewers: eugenis
Subscribers: hiraditya, cfe-commits, #sanitizers, llvm-commits
Tags: #
Author: vitalybuka
Date: Mon Aug 26 15:16:05 2019
New Revision: 369980
URL: http://llvm.org/viewvc/llvm-project?rev=369980&view=rev
Log:
hwasan, codegen: Keep more lifetime markers used for hwasan
Reviewers: eugenis
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.l
Author: vitalybuka
Date: Mon Aug 26 17:11:33 2019
New Revision: 369992
URL: http://llvm.org/viewvc/llvm-project?rev=369992&view=rev
Log:
NFC: Make test work with or without assertions
Modified:
cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp
Modified: cfe/trunk/test/CodeGenCXX/lifetime-sani
p
>> -check-prefixes=CHECK,LIFETIME
>> > --
>> > Exit Code: 1
>> >
>> > Command Output (stderr):
>> > --
>> > /home/dave/s/lp/clang/test/CodeGenCXX/lifetime-sanitizer.cpp:30:18:
>> error: CHECK-LABEL: expected string not found in input
fixed with r369992
On Mon, Aug 26, 2019 at 2:27 PM Vitaly Buka via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vitalybuka
> Date: Mon Aug 26 14:29:06 2019
> New Revision: 369971
>
> URL: http://llvm.org/viewvc/llvm-project?rev=369971&view=rev
> Log
Author: vitalybuka
Date: Tue Aug 27 18:04:50 2019
New Revision: 370141
URL: http://llvm.org/viewvc/llvm-project?rev=370141&view=rev
Log:
Fix "commas at the end of enumerator lists are a C99-specific"
Modified:
cfe/trunk/include/clang-c/Index.h
Modified: cfe/trunk/include/clang-c/Index.h
URL:
llvm-project/lld/test/ELF/lto/Inputs/drop-debug-info.bc needs to be updated
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/34675/steps/check-lld%20msan/logs/stdio
/usr/local/google/home/vitalybuka/slow/bbot/llvm_build/bin/ld.lld -shared
/usr/local/google/home/vitalybuka/slow/
Looks like it's causing
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/1969/steps/build%20clang%2Fmsan/logs/stdio
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRPrinter.cpp.o
/mnt/b/sanitizer-buildbot2/sanitizer-x86_64-linux-bootstrap/build/llvm_build0/bin/clang++
-
Probably not, r310056 fails as well
On Fri, Aug 4, 2017 at 3:19 PM, Vitaly Buka wrote:
> Looks like it's causing
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-
> linux-bootstrap/builds/1969/steps/build%20clang%2Fmsan/logs/stdio
>
> FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MIRPrinter
Author: vitalybuka
Date: Tue Aug 8 21:45:00 2017
New Revision: 310441
URL: http://llvm.org/viewvc/llvm-project?rev=310441&view=rev
Log:
[clang-fuzzer] Resolve proto dependencies
Modified:
cfe/trunk/tools/clang-fuzzer/proto-to-cxx/CMakeLists.txt
Modified: cfe/trunk/tools/clang-fuzzer/proto-t
Author: vitalybuka
Date: Mon Aug 21 22:18:28 2017
New Revision: 311428
URL: http://llvm.org/viewvc/llvm-project?rev=311428&view=rev
Log:
Update libprotobuf-mutator revision
Modified:
cfe/trunk/cmake/modules/ProtobufMutator.cmake
Modified: cfe/trunk/cmake/modules/ProtobufMutator.cmake
URL:
h
Author: Vitaly Buka
Date: 2020-09-11T16:50:30-07:00
New Revision: a8503b87f739776cc9d5738f69aa0990db952340
URL:
https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340
DIFF:
https://github.com/llvm/llvm-project/commit/a8503b87f739776cc9d5738f69aa0990db952340.diff
L
as "static" it was hitting a compiler warning/error & not
>> actually being emitted into the resulting binary for use by an interactive
>> debugger?)
>>
>> +Kristof for comments/thoughts
>>
>> On Fri, Sep 11, 2020 at 4:50 PM Vitaly Buka via cfe-commits
Author: Vitaly Buka
Date: 2020-09-17T17:59:52-07:00
New Revision: 03358becbf22a221d6d965ec8f3f7068668f7d29
URL:
https://github.com/llvm/llvm-project/commit/03358becbf22a221d6d965ec8f3f7068668f7d29
DIFF:
https://github.com/llvm/llvm-project/commit/03358becbf22a221d6d965ec8f3f7068668f7d29.diff
L
Author: Vitaly Buka
Date: 2020-09-17T18:03:55-07:00
New Revision: 55edf7039e22312790ac950305746262d2856d97
URL:
https://github.com/llvm/llvm-project/commit/55edf7039e22312790ac950305746262d2856d97
DIFF:
https://github.com/llvm/llvm-project/commit/55edf7039e22312790ac950305746262d2856d97.diff
L
On Thu, 17 Sep 2020 at 18:00, Vitaly Buka via Phabricator <
revi...@reviews.llvm.org> wrote:
> vitalybuka committed rG03358becbf22: [NFC][Lsan] Fix zero-sized array
> compilation error (authored by vitalybuka).
>
> [NFC][Lsan] Fix zero-sized array compilation error
>
>
> BRANCHES
> master
>
> Fi
301 - 400 of 1471 matches
Mail list logo
