Author: Vitaly Buka
Date: 2025-05-19T15:42:59-07:00
New Revision: b93bc773f86b3746f8023c5dda9a8ab892fa0499
URL:
https://github.com/llvm/llvm-project/commit/b93bc773f86b3746f8023c5dda9a8ab892fa0499
DIFF:
https://github.com/llvm/llvm-project/commit/b93bc773f86b3746f8023c5dda9a8ab892fa0499.diff
L
Author: Vitaly Buka
Date: 2025-05-19T15:45:43-07:00
New Revision: 5db4aeae3c413d586faed03771626818d6a807a9
URL:
https://github.com/llvm/llvm-project/commit/5db4aeae3c413d586faed03771626818d6a807a9
DIFF:
https://github.com/llvm/llvm-project/commit/5db4aeae3c413d586faed03771626818d6a807a9.diff
L
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/140529
>From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Mon, 19 May 2025 11:14:01 +
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?U
@@ -3,11 +3,11 @@
// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow
-fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test2.c -o -
| FileCheck %s --check-prefixes=CHECK2
-// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=sig
@@ -3,11 +3,11 @@
// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow
-fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test2.c -o -
| FileCheck %s --check-prefixes=CHECK2
-// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=sig
vitalybuka wrote:
Note: Use to download my updates `spr patch 140529`
https://github.com/llvm/llvm-project/pull/140529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Also I don't mind we fix multifile and sections in followup patches.
But this one needs at least documentation update.
https://github.com/llvm/llvm-project/pull/140529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
@@ -56,10 +56,20 @@ void SanitizerSpecialCaseList::createSanitizerSections() {
bool SanitizerSpecialCaseList::inSection(SanitizerMask Mask, StringRef Prefix,
StringRef Query,
StringRef Category) c
@@ -70,7 +70,7 @@ class FileSystem;
/// ---
class SpecialCaseList {
public:
- constexpr static std::pair NotFound = {0, 0};
+ static constexpr std::pair NotFound = {0, 0};
vitalybuka wrote:
yes, for consistency
https://github.com/llvm/llvm-project/pull/1415
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/140529
>From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Mon, 19 May 2025 11:14:01 +
Subject: [PATCH 01/16] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?=
=?U
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/140529
>From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Mon, 19 May 2025 11:14:01 +
Subject: [PATCH 01/17] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?=
=?U
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/140529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
I have local changes, I'll push update
https://github.com/llvm/llvm-project/pull/141540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/141540
>From e7540c31c69df827d646e88b271a355c587bd9da Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Tue, 27 May 2025 02:36:29 +
Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
=?U
https://github.com/vitalybuka approved this pull request.
Please double check and merge
https://github.com/llvm/llvm-project/pull/141540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/141540
>From e7540c31c69df827d646e88b271a355c587bd9da Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Tue, 27 May 2025 02:36:29 +
Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
=?U
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/141540
>From e7540c31c69df827d646e88b271a355c587bd9da Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Tue, 27 May 2025 02:36:29 +
Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
=?U
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/141814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/141814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,74 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 5
+// RUN: %clang_cc1 -emit-llvm -triple x86_64 -std=c17 -fsanitize=function %s
-o - \
vitalybuka wrote:
-O1 or -O2 to reduce the bloat?
https:/
@@ -38,19 +38,18 @@ SanitizerSpecialCaseList::createOrDie(const
std::vector &Paths,
void SanitizerSpecialCaseList::createSanitizerSections() {
for (auto &It : Sections) {
vitalybuka wrote:
`auto& S : `
https://github.com/llvm/llvm-project/pull/140127
@@ -132,14 +132,15 @@ class SpecialCaseList {
using SectionEntries = StringMap>;
struct Section {
-Section(std::unique_ptr M) : SectionMatcher(std::move(M)){};
-Section() : Section(std::make_unique()) {}
+Section(std::unique_ptr M) : SectionMatcher(std::move(M)
https://github.com/vitalybuka approved this pull request.
Please use tag [NFC] or [NFCI] if the patch does not change any functionality.
https://github.com/llvm/llvm-project/pull/140127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
@@ -71,9 +76,9 @@ unsigned SpecialCaseList::Matcher::match(StringRef Query)
const {
for (const auto &[Pattern, Pair] : Globs)
if (Pair.first.match(Query))
return Pair.second;
- for (const auto &[Regex, LineNumber] : RegExes)
-if (Regex->match(Query))
- re
@@ -553,7 +553,10 @@ void
WarningsSpecialCaseList::processSections(DiagnosticsEngine &Diags) {
// Each section has a matcher with that section's name, attached to that
// line.
const auto &DiagSectionMatcher = Entry.SectionMatcher;
-unsigned DiagLine = DiagSect
@@ -53,24 +53,27 @@ Error SpecialCaseList::Matcher::insert(StringRef Pattern,
unsigned LineNumber,
return Error::success();
}
- auto [It, DidEmplace] = Globs.try_emplace(Pattern);
- if (DidEmplace) {
-// We must be sure to use the string in the map rather than the
@@ -125,7 +125,7 @@ class SpecialCaseList {
// Returns zero if no match is found.
LLVM_ABI unsigned match(StringRef Query) const;
-StringMap> Globs;
+std::vector>>
Globs;
vitalybuka wrote:
Could be easier with:
```
class Glob {
name
patt
@@ -125,7 +125,7 @@ class SpecialCaseList {
// Returns zero if no match is found.
LLVM_ABI unsigned match(StringRef Query) const;
-StringMap> Globs;
+std::vector>>
Globs;
vitalybuka wrote:
Glob(Glob&&) = delete; // no copy, no move, because
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/140964
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1245,30 +1245,23 @@ void CodeGenFunction::EmitBoundsCheckImpl(const Expr
*E, llvm::Value *Bound,
}
llvm::DILocation *CodeGenFunction::SanitizerAnnotateDebugInfo(
-SanitizerKind::SanitizerOrdinal CheckKindOrdinal) {
- std::string Label;
- switch (CheckKindOrdinal) {
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/142006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
It does not let to add contributors into reviewers so just CC @JustinStitt
https://github.com/llvm/llvm-project/pull/142006
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
@@ -2756,10 +2758,23 @@
CodeGenFunction::SanitizerScope::SanitizerScope(CodeGenFunction *CGF)
: CGF(CGF) {
assert(!CGF->IsSanitizerScope);
CGF->IsSanitizerScope = true;
+
+ assert(!this->ApplyTrapDI);
+}
+
+CodeGenFunction::SanitizerScope::SanitizerScope(
+CodeGen
@@ -1134,18 +1136,32 @@ void
ScalarExprEmitter::EmitIntegerTruncationCheck(Value *Src, QualType SrcType,
(!SrcSigned && DstSigned))
return;
- CodeGenFunction::SanitizerScope SanScope(&CGF);
-
std::pair>
- Check =
- EmitIntegerTruncationCheckHelper(
@@ -2756,10 +2758,23 @@
CodeGenFunction::SanitizerScope::SanitizerScope(CodeGenFunction *CGF)
: CGF(CGF) {
assert(!CGF->IsSanitizerScope);
CGF->IsSanitizerScope = true;
+
+ assert(!this->ApplyTrapDI);
+}
+
+CodeGenFunction::SanitizerScope::SanitizerScope(
+CodeGen
@@ -2755,9 +2757,18 @@
CodeGenFunction::CGCapturedStmtInfo::~CGCapturedStmtInfo() { }
CodeGenFunction::SanitizerScope::SanitizerScope(CodeGenFunction *CGF)
: CGF(CGF) {
assert(!CGF->IsSanitizerScope);
+ assert(!ApplyTrapDI);
vitalybuka wrote:
```sugges
@@ -2755,9 +2757,18 @@
CodeGenFunction::CGCapturedStmtInfo::~CGCapturedStmtInfo() { }
CodeGenFunction::SanitizerScope::SanitizerScope(CodeGenFunction *CGF)
: CGF(CGF) {
assert(!CGF->IsSanitizerScope);
+ assert(!ApplyTrapDI);
CGF->IsSanitizerScope = true;
}
+CodeGe
@@ -2756,10 +2758,23 @@
CodeGenFunction::SanitizerScope::SanitizerScope(CodeGenFunction *CGF)
: CGF(CGF) {
assert(!CGF->IsSanitizerScope);
CGF->IsSanitizerScope = true;
+
+ assert(!this->ApplyTrapDI);
+}
+
+CodeGenFunction::SanitizerScope::SanitizerScope(
+CodeGen
vitalybuka wrote:
could be "Expanding =sanitize for fun" :)
https://github.com/llvm/llvm-project/pull/142074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/142074
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/142527
>From b0bed4bdd6e1ee86d31a1f45824c731673a6f20e Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Mon, 2 Jun 2025 21:54:00 -0700
Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=?U
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/142527
None
>From b0bed4bdd6e1ee86d31a1f45824c731673a6f20e Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Mon, 2 Jun 2025 21:54:00 -0700
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/141997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/142527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/142527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> The tests fail with SIGSEGV without hwasan, so there is some problem revealed
> by this change either in the compiler or in the tests. Bailing out under
> hwasan is not a fix.
>
> Disallowing function pointers makes the problem go away, so might be a useful
> hint. Another
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/145806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2817,7 +2817,9 @@ void CodeGenFunction::EmitVTablePtrCheckForCall(const
CXXRecordDecl *RD,
RD = LeastDerivedClassWithSameLayout(RD);
auto [Ordinal, _] = SanitizerInfoFromCFICheckKind(TCK);
- ApplyDebugLocation ApplyTrapDI(*this, SanitizerAnnotateDebugInfo(Ordinal))
@@ -2817,7 +2817,9 @@ void CodeGenFunction::EmitVTablePtrCheckForCall(const
CXXRecordDecl *RD,
RD = LeastDerivedClassWithSameLayout(RD);
auto [Ordinal, _] = SanitizerInfoFromCFICheckKind(TCK);
- ApplyDebugLocation ApplyTrapDI(*this, SanitizerAnnotateDebugInfo(Ordinal))
@@ -813,19 +813,19 @@ changes to one object won't affect the others, the
object's initializer will run
once per copy, etc.
Specifically, this warning fires when it detects an object which:
- 1. Is defined as ``inline`` in a header file (so it might get compiled into
multipl
vitalybuka wrote:
Closed?
https://github.com/llvm/llvm-project/pull/142659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/142700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka reopened
https://github.com/llvm/llvm-project/pull/142659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/142659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -813,19 +813,19 @@ changes to one object won't affect the others, the
object's initializer will run
once per copy, etc.
Specifically, this warning fires when it detects an object which:
- 1. Is defined as ``inline`` in a header file (so it might get compiled into
multipl
vitalybuka wrote:
Should we just rename stuff of this patch __clang_trap_msg ?
https://github.com/llvm/llvm-project/pull/141997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka reopened
https://github.com/llvm/llvm-project/pull/139772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -44,13 +44,11 @@ bool NoSanitizeList::containsFunction(SanitizerMask Mask,
bool NoSanitizeList::containsFile(SanitizerMask Mask, StringRef FileName,
StringRef Category) const {
- unsigned NoSanLine = SSCL->inSectionBlame(Mask, "src", FileN
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/139772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/142027
>From 3b8af2c0d05fdd1fd95facd0afe0b52bacfe5690 Mon Sep 17 00:00:00 2001
From: Qinkun Bao
Date: Thu, 29 May 2025 19:58:08 +
Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=
=?U
@@ -29,6 +29,8 @@ class SanitizerSpecialCaseList;
class NoSanitizeList {
std::unique_ptr SSCL;
SourceManager &SM;
+ bool containsPrefix(SanitizerMask Mask, StringRef Prefix, StringRef Name,
vitalybuka wrote:
we have one spot where we can use default, we w
@@ -48,11 +59,7 @@ bool NoSanitizeList::containsFunction(SanitizerMask Mask,
bool NoSanitizeList::containsFile(SanitizerMask Mask, StringRef FileName,
StringRef Category) const {
- auto NoSan = SSCL->inSectionBlame(Mask, "src", FileName, Cate
vitalybuka wrote:
> By "switch to" do you mean remove
I mean downstream we already like how nice e.g `__ubsan_check_array_bounds` in
the top of the crash thread.
If we have `__clang_trap_msg_array_bounds`, it's as good as
`__ubsan_check_array_bounds` now.
https://github.com/llvm/llvm-pro
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/141997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
What is debug info size impact?
https://github.com/llvm/llvm-project/pull/145967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
> @fmayer
>
> > I would prefer this to be behind a flag (not necessarily in this PR), even
> > if it's default turned on. People might not want synthetic frames added to
> > their debug information and the top frame to point to the real code; also
> > as this somewhat overla
@@ -85,6 +85,96 @@ enum VariableTypeDescriptorKind : uint16_t {
//Miscellaneous Helper Methods
//======//
+static llvm::StringRef GetUBSanTrapForHandler(SanitizerHandler ID) {
-
@@ -85,6 +85,96 @@ enum VariableTypeDescriptorKind : uint16_t {
//Miscellaneous Helper Methods
//======//
+static llvm::StringRef GetUBSanTrapForHandler(SanitizerHandler ID) {
+ switch
vitalybuka wrote:
> There is still one test case that fails: `cfi-check-fail-debuginfo.c`. From
> the crash report, I thought it was due to double wrapping, so I initially
> added a guard to prevent that, leading the test case to pass. Upon internal
> discussion, the guard has since been remov
https://github.com/vitalybuka approved this pull request.
https://github.com/llvm/llvm-project/pull/148323
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/149244
As-ie example suppresses buffer overflow in
malloc, and leave memory leak in place. It can be
confusing.
Fixes #62421.
>From f885749699d886d77d8290ca250276704e677dd7 Mon Sep 17 00:00:00 2001
From: Vitaly Bu
1401 - 1471 of 1471 matches
Mail list logo
