[clang] TODO (PR #137273)

2025-04-24 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka converted_to_draft https://github.com/llvm/llvm-project/pull/137273 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][CFI] Allow CFI with minimal runtime (PR #137103)

2025-04-24 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/137103 >From b4ae58e13bbbc62272a900cac5e1f158c437e8c1 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 23 Apr 2025 18:16:42 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?= =?

[clang] [Driver][CFI] Allow CFI with minimal runtime (PR #137103)

2025-04-24 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/137103 >From b4ae58e13bbbc62272a900cac5e1f158c437e8c1 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 23 Apr 2025 18:16:42 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?= =?

[clang] [Driver][CFI] Allow CFI with minimal runtime (PR #137103)

2025-04-24 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/137103 >From b4ae58e13bbbc62272a900cac5e1f158c437e8c1 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 23 Apr 2025 18:16:42 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20change?= =?

[clang] [Driver][CFI] Allow CFI with minimal runtime (PR #137103)

2025-04-24 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > TODO: In a separate PRs I will add Codegen and runtime tests. Runtime #137245 Codegen #137225 https://github.com/llvm/llvm-project/pull/137103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [llvm] [fatlto] Add coroutine passes when using FatLTO with ThinLTO (PR #134434)

2025-04-10 Thread Vitaly Buka via cfe-commits
@@ -1692,6 +1692,19 @@ PassBuilder::buildFatLTODefaultPipeline(OptimizationLevel Level, bool ThinLTO, if (ThinLTO && PGOOpt && PGOOpt->Action == PGOOptions::SampleUse) MPM.addPass(buildThinLTODefaultPipeline(Level, /*ImportSummary=*/nullptr)); else { +// ModuleSimp

[clang] [sanitizer] Apply AlwaysIn/Out in parseSanitizeArgs (PR #129405)

2025-04-10 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/129405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: LGTM https://github.com/llvm/llvm-project/pull/135728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Drive] Reorder boolean expression (PR #135881)

2025-04-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/135881 Show why we don't need regular CFI runtime, if CFI diag is linked. >From 4e34bfe6d216142fb712dafe04c266c3ca4f7424 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 15 Apr 2025 16:28:57 -0700 Subject: [P

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Vitaly Buka via cfe-commits
@@ -345,27 +345,25 @@ void llvm::filterDeadComdatFunctions( std::string llvm::getUniqueModuleId(Module *M) { MD5 Md5; - bool ExportsSymbols = false; - auto AddGlobal = [&](GlobalValue &GV) { -if (GV.isDeclaration() || GV.getName().starts_with("llvm.") || -!GV.h

[clang] [llvm] Introduce -funique-source-file-names flag. (PR #135728)

2025-04-15 Thread Vitaly Buka via cfe-commits
@@ -345,27 +345,25 @@ void llvm::filterDeadComdatFunctions( std::string llvm::getUniqueModuleId(Module *M) { MD5 Md5; - bool ExportsSymbols = false; - auto AddGlobal = [&](GlobalValue &GV) { -if (GV.isDeclaration() || GV.getName().starts_with("llvm.") || -!GV.h

[clang] [clang] fix use after free in clang/tools/c-index-test/c-index-test.c (PR #127063)

2025-02-18 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > @metaflow @vitalybuka I've checked in > [8f41d28](https://github.com/llvm/llvm-project/commit/8f41d28d89ee287d0f5a6518116ab316be2657b8) > to fix warnings. Thanks! Thank You! https://github.com/llvm/llvm-project/pull/127063 ___ cf

[clang] Reland "[libclang] Always Dup in createRef(StringRef)" (PR #127078)

2025-02-18 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/127078 >From a831b96cc2eb4b65e7157ee3cb519cf9b4a6af76 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Thu, 13 Feb 2025 07:42:46 -0800 Subject: [PATCH] Revert "Revert "[libclang] Always Dup in createRef(StringRef)"

[clang] [ubsan] Remove -fsanitizer=vptr from -fsanitizer=undefined (PR #121115)

2025-02-28 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/121115 >From bca319184733b4bad1eb6b83aaac18a75be40b8c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 25 Dec 2024 14:22:10 -0800 Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?

[clang] [ubsan] Remove -fsanitizer=vptr from -fsanitizer=undefined (PR #121115)

2025-03-01 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/121115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Lower modf builtin using `llvm.modf` intrinsic (PR #126750)

2025-02-19 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: >From this patch? https://lab.llvm.org/buildbot/#/builders/72/builds/8380 FYI @fmayer https://github.com/llvm/llvm-project/pull/126750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [llvm] Reapply "Reland "[HLSL] Implement the `reflect` HLSL function"" (#124046) (PR #128386)

2025-02-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/128386 This reverts commit 0fe8e70c6609ff86cd40fbb45a85a8ed04c153c2. >From 37bc44832ab10781b467c9b4a9e62af594305534 Mon Sep 17 00:00:00 2001 From: Icohedron Date: Sat, 22 Feb 2025 17:38:18 -0800 Subject: [PATCH] =

[clang] [llvm] Reland "[HLSL] Implement the reflect HLSL function" (PR #125599)

2025-02-22 Thread Vitaly Buka via cfe-commits
@@ -1,6 +1,5 @@ -; RUN: not llc -verify-machineinstrs -O0 -mtriple=spirv64-unknown-unknown %s -o /dev/null 2>&1 | FileCheck %s -; RUN: not llc -verify-machineinstrs -O0 -mtriple=spirv32-unknown-unknown %s -o /dev/null 2>&1 | FileCheck %s -; UNSUPPORTED: hwasan +; RUN: not llc -v

[clang] [llvm] Reapply "Reland "[HLSL] Implement the `reflect` HLSL function"" (#124046) (PR #128386)

2025-02-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka converted_to_draft https://github.com/llvm/llvm-project/pull/128386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland "[HLSL] Implement the reflect HLSL function" (PR #125599)

2025-02-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. LGTM regarding previous HWASAN crash, which is gone https://github.com/llvm/llvm-project/pull/125599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [analyzer] Allow overriding Unknown memspaces using a ProgramState trait (PR #123003)

2025-02-22 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Use after scope: https://lab.llvm.org/buildbot/#/builders/169/builds/8735 https://lab.llvm.org/buildbot/#/builders/94/builds/4653/steps/17/logs/stdio https://github.com/llvm/llvm-project/pull/123003 ___ cfe-commits mailing list cfe-c

[clang] [analyzer] Allow overriding Unknown memspaces using a ProgramState trait (PR #123003)

2025-02-22 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Should be fixed with #128372 https://github.com/llvm/llvm-project/pull/123003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix use after scope after #123003 (PR #128372)

2025-02-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/128372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix use after scope after #123003 (PR #128372)

2025-02-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/128372 In #123003 make_first_range was applied to temporarily. >From d3384dec3f6aa0e3d9d6585f8b2553dfcff2d579 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Sat, 22 Feb 2025 13:32:12 -0800 Subject: [PATCH] =?UTF

[clang] [llvm] Reapply "Reland "[HLSL] Implement the `reflect` HLSL function"" (#124046) (PR #128386)

2025-02-24 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/128386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ubsan] Remove -fsanitizer=vptr from -fsanitizer=undefined (PR #121115)

2025-02-23 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/121115 >From bca319184733b4bad1eb6b83aaac18a75be40b8c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 25 Dec 2024 14:22:10 -0800 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?

[clang] [ubsan] Remove -fsanitizer=vptr from -fsanitizer=undefined (PR #121115)

2025-02-23 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: @AaronBallman @zygoloid Looks like we agree on https://discourse.llvm.org/t/rfc-remove-vptr-from-undefined/83830 So I'd like to merge this patch this week. https://github.com/llvm/llvm-project/pull/121115 ___ cfe-commits mailing lis

[clang] Reland "[libclang] Always Dup in createRef(StringRef)" (PR #127078)

2025-02-20 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: @fmayer Looks like my patch exposed another UAF https://lab.llvm.org/buildbot/#/builders/169/builds/8637 Looking, and will revert if there is no quick fix https://github.com/llvm/llvm-project/pull/127078 ___ cfe-commits mailing list

[clang] f7a10f0 - [Index] Un-XFAIL test with msan

2025-02-20 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2025-02-20T09:41:00-08:00 New Revision: f7a10f0e8d46085cfebfbd53c3ab19a5ab37774f URL: https://github.com/llvm/llvm-project/commit/f7a10f0e8d46085cfebfbd53c3ab19a5ab37774f DIFF: https://github.com/llvm/llvm-project/commit/f7a10f0e8d46085cfebfbd53c3ab19a5ab37774f.diff L

[clang] [compiler-rt] [llvm] [ASan] Add metadata to renamed instructions so ASan doesn't use the i… (PR #119387)

2025-02-20 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/119387 >From 8781ff2355750ae61d140620b1f6862537de07e3 Mon Sep 17 00:00:00 2001 From: gbMattN Date: Tue, 10 Dec 2024 15:01:37 + Subject: [PATCH 01/11] [ASan] Add metadata to renamed instructions so ASan doesn't

[clang] [compiler-rt] [llvm] [ASan] Add metadata to renamed instructions so ASan doesn't use the i… (PR #119387)

2025-02-20 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/119387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ubsan] Remove -fsanitizer=vptr from -fsanitizer=undefined (PR #121115)

2025-02-25 Thread Vitaly Buka via cfe-commits
@@ -214,13 +214,14 @@ Available checks are: the wrong dynamic type, or that its lifetime has not begun or has ended. Incompatible with ``-fno-rtti``. Link must be performed by ``clang++``, not ``clang``, to make sure C++-specific parts of the runtime library and

[clang] [ubsan] Remove -fsanitizer=vptr from -fsanitizer=undefined (PR #121115)

2025-02-25 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/121115 >From bca319184733b4bad1eb6b83aaac18a75be40b8c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 25 Dec 2024 14:22:10 -0800 Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?

[clang] [libclang] Replace createRef with createDup (PR #126683)

2025-02-25 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > Requesting changes just to be sure none of the changes from `createRef()` to > `createDup()` would have generated a `StringRef` holding a null pointer. I'd > be surprised if they did, but a second set of eyes would be helpful. I am not sure how to proceed here. This change

[clang] [ubsan] Remove -fsanitizer=vptr from -fsanitizer=undefined (PR #121115)

2025-02-25 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/121115 >From bca319184733b4bad1eb6b83aaac18a75be40b8c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 25 Dec 2024 14:22:10 -0800 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?

[clang] [ubsan] Remove -fsanitizer=vptr from -fsanitizer=undefined (PR #121115)

2025-02-25 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/121115 >From bca319184733b4bad1eb6b83aaac18a75be40b8c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 25 Dec 2024 14:22:10 -0800 Subject: [PATCH 1/5] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?

[clang] [ubsan] Remove -fsanitizer=vptr from -fsanitizer=undefined (PR #121115)

2025-02-25 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/121115 >From bca319184733b4bad1eb6b83aaac18a75be40b8c Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Wed, 25 Dec 2024 14:22:10 -0800 Subject: [PATCH 1/4] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?

[clang] [clang][unittests] Fix a leak in SearchPathTest (PR #139335)

2025-05-09 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: I checked on the bot, this fixes the leak! Thank you! https://github.com/llvm/llvm-project/pull/139335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][unittests] Fix a leak in SearchPathTest (PR #139335)

2025-05-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/139335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-09 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: This one is still broken https://lab.llvm.org/buildbot/#/builders/55/builds/11054/steps/11/logs/stdio https://github.com/llvm/llvm-project/pull/138234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] [modularize] Use a range-based for loop (NFC) (PR #139398)

2025-05-10 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > sanitizer-aarch64-linux-bootstrap-asan Sorry, this one caused by my zorg changes. https://github.com/llvm/llvm-project/pull/139398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [clang][unittests] Fix a leak in SearchPathTest (PR #139335)

2025-05-09 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/139335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-09 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > That passes for me. I can't even figure out which unit test is failing, they > all say `OK` and not `FAILED`. The one error in there looks like it's > expected since its test still returns `OK`. Are we totally sure this isn't an > infrastructure issue? Unlikely. Process ex

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-09 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: ``` = ==3963603==ERROR: LeakSanitizer: detected memory leaks Direct leak of 576 byte(s) in 1 object(s) allocated from: #0 0xb3001e6d179c in operator new(unsigned long) /home/b/sanitizer-aarch64-linux-bootstrap

[clang] [cfi][NFCI] Pre-commit -fsanitize-annotate-debug-info tests for CFI (PR #139149)

2025-05-08 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,47 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 -triple x86_64-unknown-linux -O0 -fsanitize-cfi-cross-dso \ vitalybuka wrote: would we have less boilerplate if we do e.g. "

[clang] [llvm] [sancov] Introduce optional callback for stack-depth tracking (PR #138323)

2025-05-06 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/138323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-13 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > I am not a fan of the change to the function used for array-bounds. More specific? I like it in general. It's about just about the name of a new fake function? https://github.com/llvm/llvm-project/pull/139809 ___ cfe-commits mailin

[clang] Implement src:*=sanitize for UBSan (PR #139772)

2025-05-13 Thread Vitaly Buka via cfe-commits
@@ -44,7 +44,8 @@ bool NoSanitizeList::containsFunction(SanitizerMask Mask, bool NoSanitizeList::containsFile(SanitizerMask Mask, StringRef FileName, StringRef Category) const { - return SSCL->inSection(Mask, "src", FileName, Category); + bo

[clang] Implement src:*=sanitize for UBSan (PR #139772)

2025-05-13 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Reminder to @thurstond as well :) Please figure out https://llvm.org/docs/GitHub.html#stacked-pull-requests https://github.com/llvm/llvm-project/pull/139772 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] Implement src:*=sanitize for UBSan (PR #139772)

2025-05-13 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,23 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s -check-prefix=CHECK-ALLOWLIST +// RUN: %clang_cc1 -trip

[clang] [NFCI][cfi] Refactor into 'SanitizerInfoFromCFICheckKind' (PR #140117)

2025-05-16 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: LGTM https://github.com/llvm/llvm-project/pull/140117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/139809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Basic] Use llvm::erase_if (NFC) (PR #140309)

2025-05-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/140309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [sanitizer][NFCI] Add 'SanitizerAnnotateDebugInfo' (PR #139965)

2025-05-14 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/139965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-14 Thread Vitaly Buka via cfe-commits
@@ -1217,6 +1217,35 @@ void CodeGenFunction::EmitBoundsCheck(const Expr *E, const Expr *Base, EmitBoundsCheckImpl(E, Bound, Index, IndexType, IndexedType, Accessed); } +llvm::DILocation *CodeGenFunction::SanitizerAnnotateDebugInfo( vitalybuka wrote: This g

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-14 Thread Vitaly Buka via cfe-commits
@@ -2779,13 +2779,50 @@ void CodeGenFunction::EmitTypeMetadataCodeForVCall(const CXXRecordDecl *RD, } } +std::pair +CodeGenFunction::ParseCFITypeCheckKind(CFITypeCheckKind TCK) { + SanitizerKind::SanitizerOrdinal M; + llvm::SanitizerStatKind SSK; + + switch (TCK) { + ca

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-14 Thread Vitaly Buka via cfe-commits
@@ -2842,24 +2882,12 @@ void CodeGenFunction::EmitVTablePtrCheck(const CXXRecordDecl *RD, !CGM.HasHiddenLTOVisibility(RD)) return; - SanitizerKind::SanitizerOrdinal M; - llvm::SanitizerStatKind SSK; + auto [M, SSK] = ParseCFITypeCheckKind(TCK); switch (TCK) {

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-14 Thread Vitaly Buka via cfe-commits
@@ -3353,6 +3353,17 @@ class CodeGenFunction : public CodeGenTypeCache { SanitizerSet SkippedChecks = SanitizerSet(), llvm::Value *ArraySize = nullptr); + /// Returns debug info, with additional annotation if enabled by + /// CGM.get

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-14 Thread Vitaly Buka via cfe-commits
@@ -3353,6 +3353,16 @@ class CodeGenFunction : public CodeGenTypeCache { SanitizerSet SkippedChecks = SanitizerSet(), llvm::Value *ArraySize = nullptr); + /// Returns debug info, with additional annotation if enabled by + /// CGM.get

[clang] [cfi] Enable -fsanitize-annotate-debug-info functionality for CFI checks (PR #139809)

2025-05-14 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka deleted https://github.com/llvm/llvm-project/pull/139809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement src:*=sanitize for UBSan (PR #139772)

2025-05-13 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,23 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s -check-prefix=CHECK-ALLOWLIST +// RUN: %clang_cc1 -trip

[clang] Implement src:*=sanitize for UBSan (PR #139772)

2025-05-13 Thread Vitaly Buka via cfe-commits
@@ -44,7 +44,8 @@ bool NoSanitizeList::containsFunction(SanitizerMask Mask, bool NoSanitizeList::containsFile(SanitizerMask Mask, StringRef FileName, StringRef Category) const { - return SSCL->inSection(Mask, "src", FileName, Category); + bo

[clang] [NFCI][cfi] Refactor into 'SanitizerInfoFromCFICheckKind' (PR #140117)

2025-05-16 Thread Vitaly Buka via cfe-commits
@@ -2779,6 +2779,29 @@ void CodeGenFunction::EmitTypeMetadataCodeForVCall(const CXXRecordDecl *RD, } } +/// Converts the CFITypeCheckKind into SanitizerKind::SanitizerOrdinal and +/// llvm::SanitizerStatKind. +static std::pair +SanitizerInfoFromCFICheckKind(CodeGenFunction:

[clang] [llvm] [NFC] Run code formatter on Diagnostic.h/cpp ProfileList.cpp SpecialCaseList.cpp (PR #140316)

2025-05-17 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. I don't have issues with reformatting the entire files, and https://www.llvm.org/docs/Contributing.html says nothing about that. But I guess convention is to reformat only parts you are going to change - less noise in blame output, and

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-20 Thread Vitaly Buka via cfe-commits
@@ -78,9 +78,7 @@ For example, supplying the above ``ignorelist.txt`` to instrumentation for arithmetic operations containing values of type ``int``. The ``=sanitize`` category is also supported. Any types assigned to the vitalybuka wrote: type -> entry? htt

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-20 Thread Vitaly Buka via cfe-commits
@@ -960,6 +960,7 @@ Sanitizers -- - ``-fsanitize=vptr`` is no longer a part of ``-fsanitize=undefined``. +- UBSan ignorelists now support the syntax ``src:*=sanitize``. vitalybuka wrote: I think it applies to all Sanitizers, with src: syntax https://

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-21 Thread Vitaly Buka via cfe-commits
@@ -63,6 +63,11 @@ Error SpecialCaseList::Matcher::insert(StringRef Pattern, unsigned LineNumber, .moveInto(Pair.first)) return Err; Pair.second = LineNumber; + } else { vitalybuka wrote: Please move llvm/lib/Support/SpecialC

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-20 Thread Vitaly Buka via cfe-commits
@@ -63,6 +63,11 @@ Error SpecialCaseList::Matcher::insert(StringRef Pattern, unsigned LineNumber, .moveInto(Pair.first)) return Err; Pair.second = LineNumber; + } else { vitalybuka wrote: Also we need a patch to Matcher::Glob

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-20 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-20 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-20 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Ubsan a few corner cases for `=sanitize` (PR #140855)

2025-05-20 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/140855 None >From 46288061d9d6acbed8cb3ada1fb2265c379f5d67 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Tue, 20 May 2025 23:45:52 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-20 Thread Vitaly Buka via cfe-commits
@@ -63,6 +63,11 @@ Error SpecialCaseList::Matcher::insert(StringRef Pattern, unsigned LineNumber, .moveInto(Pair.first)) return Err; Pair.second = LineNumber; + } else { vitalybuka wrote: And "Pair.second = LineNumber;" is no

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-21 Thread Vitaly Buka via cfe-commits
@@ -103,6 +101,22 @@ supported sanitizers. char c = toobig; // also not instrumented } +Conflicting entries are resolved by the latest entry, which takes precedence. vitalybuka wrote: If multiple entries match the source, than the latest entry takes the

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-20 Thread Vitaly Buka via cfe-commits
@@ -58,7 +58,7 @@ Usage with UndefinedBehaviorSanitizer ability to adjust instrumentation based on type. By default, supported sanitizers will have their instrumentation disabled for -types specified within an ignorelist. +entris specified within an ignorelist. ---

[clang] [llvm] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-20 Thread Vitaly Buka via cfe-commits
@@ -77,10 +77,8 @@ For example, supplying the above ``ignorelist.txt`` to ``-fsanitize-ignorelist=ignorelist.txt`` disables overflow sanitizer instrumentation for arithmetic operations containing values of type ``int``. -The ``=sanitize`` category is also supported. Any types

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140602 >From 210f005ecccbbd4fed439d3e156d5e0146807bed Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 19:49:33 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?U

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. https://github.com/llvm/llvm-project/pull/140602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s -check-prefix=CHECK-ALLOWLIST vitalybu

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s -check-prefix=CHECK-ALLOWLIST +// RUN: %clang_cc1 -trip

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s --check-prefixes=CHECK1,IGNORE

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s --check-prefixes=CHECK1,IGNORE +// RUN: %cl

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > > The linked pull request (#140529) introduces a new feature rather than > > correcting a bug. > > I would argue that since the `src:*=sanitize` syntax could reasonably be > expected to work, but it did not work, then that is both a missing feature > and a bug (not working

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: rm -rf %t vitalybuka wrote: THe point of SPR to have stacked PR, so this one will already be rebased on #140602 https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140529 >From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 11:14:01 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [DO not merge] demo test for https://github.com/llvm/llvm-project/pull/140529 (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140602 >From 210f005ecccbbd4fed439d3e156d5e0146807bed Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 19:49:33 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?U

[clang] [NFC] Pre-commit UBSAN src:*=sanitize test (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Pre-commit UBSAN src:*=sanitize test (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: rm -rf %t vitalybuka wrote: But in this case we failed to do so, if reordering of patches is needed, SPR often fails. https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing

[clang] [NFC] Pre-commit UBSAN src:*=sanitize test (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140602 >From 210f005ecccbbd4fed439d3e156d5e0146807bed Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 19:49:33 + Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140529 >From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 11:14:01 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [NFC] Pre-commit UBSAN src:*=sanitize test (PR #140602)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/140602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka updated https://github.com/llvm/llvm-project/pull/140529 >From b83755d2aa0c5417ab8f359aa842449213437a7a Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Mon, 19 May 2025 11:14:01 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -44,6 +44,12 @@ bool NoSanitizeList::containsFunction(SanitizerMask Mask, bool NoSanitizeList::containsFile(SanitizerMask Mask, StringRef FileName, StringRef Category) const { + unsigned NoSanLine = SSCL->inSectionBlame(Mask, "src", FileNa

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
@@ -1,17 +1,16 @@ // RUN: rm -rf %t // RUN: split-file %s %t -// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=signed-integer-overflow -fsanitize-ignorelist=%t/src.ignorelist -emit-llvm %t/test1.c -o - | FileCheck %s --check-prefixes=CHECK1,IGNORE +// RUN: %c

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UBSan] Implement src:*=sanitize for UBSan (PR #140529)

2025-05-19 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: llvm-project/clang/docs/SanitizerSpecialCaseList.rst needs to be updated And nice to mention in llvm-project/clang/docs/ReleaseNotes.rst https://github.com/llvm/llvm-project/pull/140529 ___ cfe-commits mailing list cfe-commits@lists.

<    9   10   11   12   13   14   15   >