[PATCH] D99630: phase 01: add new command line flag to enable UAR in 3 modes (always, [runtime], never).

vitalybuka added a reviewer: vitalybuka. vitalybuka added a comment. Smaller incremental patches are highly encouraged. But I assume it's WIP. In the first I'd recommend to try to land clang pieces and leave llvm and compiler-rt parts unchanged. And I can with interactive session next week. Re

[PATCH] D100907: [lsan][docs] Clarify supported platforms

vitalybuka added inline comments. Comment at: clang/docs/LeakSanitizer.rst:49 + +* Android aarch64/i386/x86_64 +* Linux arm/aarch64/mips64/ppc64/ppc64le/s390x/i386/x86\_64 Apple is incomplete and riscv is missing ``` if(APPLE) set(ALL_LSAN_SUPPORTED_ARCH ${X86

[PATCH] D100907: [lsan][docs] Clarify supported platforms

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/LeakSanitizer.rst:49 + +* Android aarch64/i386/x86_64 +* Linux arm/aarch64/mips64/ppc64/ppc64le/s390x/i386/x86\_64 MaskRay

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

vitalybuka added inline comments. Comment at: llvm/include/llvm/IR/Module.h:896 + int getFramePointer() const; + void setFramePointer(int V); + It should be enum, similar to PIELevel. And probably needs IR documentation update? Repository: rG LLVM Github M

[PATCH] D101016: [IR][sanitizer] Add module flag "frame-pointer" and set it for cc1 -mframe-pointer={non-leaf,all}

vitalybuka added inline comments. Comment at: llvm/lib/IR/Function.cpp:346 + case 1: +B.addAttribute("frame-pointer", "non-leaf"); +break; Should these be added into Attribute:: ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

vitalybuka added a comment. Something is not initialized tihttp://lab.llvm.org:8011/#/builders/74/builds/1834/steps/9/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka created this revision. vitalybuka added reviewers: morehouse, eugenis. Herald added a subscriber: mgorny. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. This way is easier to

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377650. vitalybuka added a comment. update a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: clang/docs/tools/clang-formatted-files.txt compiler-rt

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377711. vitalybuka added a comment. remove duplicate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: clang/docs/tools/clang-formatted-files.txt compiler

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377714. vitalybuka added a comment. fixed size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: clang/docs/tools/clang-formatted-files.txt compiler-rt/li

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_persistent_allocator.h:61 uptr mem = (uptr)MmapOrDie(allocsz, "stack depot"); +atomic_fetch_add(&allocated_size, allocsz, memory_order_re

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377900. vitalybuka marked an inline comment as done. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: compiler-rt/lib/sa

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

vitalybuka updated this revision to Diff 377903. vitalybuka added a comment. fix rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111256/new/ https://reviews.llvm.org/D111256 Files: compiler-rt/lib/sanitizer_common/sanitizer_chained_origin_d

[PATCH] D111256: [NFC][sanitizer] Remove global PersistentAllocator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f3e52538d77: [NFC][sanitizer] Remove global PersistentAllocator (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

vitalybuka added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:227 CODEGENOPT(SanitizeAddressUseOdrIndicator, 1, 0) ///< Enable ODR indicator globals +CODEGENOPT(SanitizeAddressUseStackSafety, 1, 0) ///< Use stack safety result. CODEGENOPT(SanitizeM

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:813 +const StackSafetyGlobalInfo *SSI = nullptr; +if (ClUseStackSafety) { + SSI = &getAnalysis().getResult(); usually we don't use {} for one liner

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka added a comment. Flag is not used anywhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:150 +namespace AsanAccessInfo { + kstoimenov wrote: > vitalybuka wrote: > > It's not how enums described here > > https://llvm.org/docs/CodingStandard

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka added a comment. The test is still missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108377/new/ https://reviews.llvm.org/D108377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:166 + ASanAccessInfo(bool IsWrite, bool CompileKernel, uint8_t AccessSizeIndex); +}; + .cpp file is missing Comment at: llvm/lib/Targ

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.llvm.org/D107850 ___

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka added a comment. In D108377#2962445 , @kstoimenov wrote: > Tests are still WIP. This is not ready for review yet. I will ping you when > it it. There is also "Add Acction..."-> "Plan changes", which will remove it from reviewers dashboards.

[PATCH] D107850: [asan] Implemented intrinsic for the custom calling convention similar used by HWASan for X86.

vitalybuka accepted this revision. vitalybuka added a comment. And if it's straightforward fix for the revert you can "reuse" approvals and land without additional review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107850/new/ https://reviews.l

[PATCH] D108377: [asan] Implemented flag to emit intrinsics to optimize ASan callbacks.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/Instrumentation/AddressSanitizer/asan-optimize-callbacks.ll:6 +; RUN: FileCheck %s --check-prefixes=LOAD-KERNEL,STORE-KERNEL + +target tr

<    3   4   5   6   7   8