[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added inline comments. Comment at: clang/lib/Driver/SanitizerArgs.cpp:807 << "-fsanitize-coverage=[func|bb|edge]" -<< "-fsanitize-coverage=[func|bb|edge],[trace-pc-guard|trace-pc]"; +<< "-fsanitize-coverage=[func|bb|edge],[trace-pc-guard|trace

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

vitalybuka added a comment. Looks like it breaks https://lab.llvm.org/buildbot/#/builders/236/builds/206 https://lab.llvm.org/buildbot/#/builders/237/builds/85 https://lab.llvm.org/buildbot/#/builders/238/builds/103 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

vitalybuka added a comment. 897.65s: Clangd Unit Tests :: ./ClangdTests/25/72 In D127082#3776206 , @daiyousei-qz wrote: > In D127082#3776173 , @vitalybuka > wrote: > >> Looks like it breaks >> https://lab.llvm.

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added inline comments. Comment at: clang/docs/SanitizerCoverage.rst:382 + void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, +const uintptr_t *cfs_end) { +// [cfs_beg,cfs_end) is the array of ptr-sized integers representing ---

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added a comment. we need to update llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_coverage_interface.inc llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_interface_internal.h you can search by __sanitizer_cov_8bit_counters_init if anything missing Something like Single

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added inline comments. Comment at: clang/docs/SanitizerCoverage.rst:382 + void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, +const uintptr_t *cfs_end) { +// [cfs_beg,cfs_end) is the array of ptr-sized integers representing ---

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

vitalybuka added a comment. It breaks the bot https://lab.llvm.org/buildbot/#/builders/5/builds/27410 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132997/new/ https://reviews.llvm.org/D132997 ___ cfe-co

[PATCH] D133841: [test][clang] run test for lld emitting dwarf-aranages only if lld is presented

vitalybuka added a comment. the test crashes with sanitizers https://lab.llvm.org/buildbot/#/builders/5/builds/27437 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133841/new/ https://reviews.llvm.org/D133841 __

[PATCH] D133537: [pipelines] RecomputeGlobalsAAPass after OptimizerEarlyEPCallbacks

vitalybuka updated this revision to Diff 460194. vitalybuka added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133537/new/ https://reviews.llvm.org/D133537 F

[PATCH] D133537: [pipelines] RecomputeGlobalsAAPass after OptimizerEarlyEPCallbacks

vitalybuka updated this revision to Diff 460197. vitalybuka edited the summary of this revision. vitalybuka added a comment. remove typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133537/new/ https://reviews.llvm.org/D133537 Files: clang/lib/

[PATCH] D133537: [pipelines] RecomputeGlobalsAAPass after OptimizerEarlyEPCallbacks

vitalybuka updated this revision to Diff 460199. vitalybuka added a comment. fix capture Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133537/new/ https://reviews.llvm.org/D133537 Files: clang/lib/CodeGen/BackendUtil.cpp Index: clang/lib/CodeG

[PATCH] D133537: [pipelines] Require GlobalsAA after sanitizers

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:443 Options.EmulatedTLS = CodeGenOpts.EmulatedTLS; - Options.ExplicitEmulatedTLS = true; + Options.ExplicitEmulatedTLS = CodeGenOpts.ExplicitEmulatedT

[PATCH] D133537: [pipelines] Require GlobalsAA after sanitizers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. vitalybuka marked an inline comment as done. Closed by commit rGc69b26911168: [pipelines] Require GlobalsAA after sanitizers (authored by vitalybuka). Repository: rG

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, + const uintptr_t *cfs_end) { + CFS_BEG =

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM as-is Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t *

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:15 +extern "C" void __sanitizer_cov_cfs_init(const uintptr_t *cfs_beg, + const uintptr_t *cfs_end) { + CFS_BEG =

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

vitalybuka added a comment. check-llvm fails bunch of test for me Failed Tests (12): LLVM :: Transforms/OpenMP/custom_state_machines.ll LLVM :: Transforms/OpenMP/custom_state_machines_remarks.ll LLVM :: Transforms/OpenMP/get_hardware_num_threads_in_block_fold.ll LLV

[PATCH] D133157: Add -fsanitizer-coverage=control-flow

vitalybuka updated this revision to Diff 460518. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133157/new/ https://reviews.llvm.org/D133157 Files: clang/docs/SanitizerCoverage.rst clang/include/clang/Ba

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka added a comment. This bot is broken by this patch https://lab.llvm.org/buildbot/#/builders/85/builds/8881 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-commits mailing list cfe-

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reverted with cdfa15da94f06289dcf86173d18b6627f92ac403 (inlcuding 572b08790a69f955ae0cbb1b4a7d4a215f15dad9

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka updated this revision to Diff 440388. vitalybuka edited the summary of this revision. vitalybuka added a comment. exactly as reverted revision 886715af962de2c92fac4bd37104450345711e4a + 572b08790a69f955ae0cbb1b4a7d4

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

vitalybuka updated this revision to Diff 440396. vitalybuka added a comment. restore blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 Files: clang/docs/ClangCommandLineReference.rst clang/do

[PATCH] D127911: Delete 'llvm.asan.globals' for global metadata.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1355-1356 // at all, we assume it has dynamic initializer (in other TU). - // - // FIXME: Metadata should be attched directly to the global directly instead - // of being

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

vitalybuka added a comment. > Yikes! Thanks for the revert. I didn't see the email from the bot until > just about 2 minutes before you reverted. I'll see if I can reproduce. FYI. The same on a different bot https://lab.llvm.org/buildbot/#/builders/5/builds/25486/steps/19/logs/stdio Reposi

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

vitalybuka added a comment. @erichkeane can you please make sure that committed revisions in git have "Differential Revision: ". Usually it's added by "arc" when you upload review. Also it would be nice if reapply have the same link. Regarding reproducer, you can follow https://github.com/

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

vitalybuka added a comment. @ychen This patch causes 20% .o size increase (x86_64) Is this expected? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-c

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

vitalybuka added a comment. In D115844#3625781 , @ychen wrote: > In D115844#3625776 , @vitalybuka > wrote: > >> @ychen This patch causes 20% .o size increase (x86_64) Is this expected? > > No, it is not expecte

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. In D126907#3623377 , @vitalybuka wrote: > FYI. The same on a different bot > https://lab.llvm.org/buildbot/#/builders/5/builds/25486/steps/19

[PATCH] D129100: [clangd] Support external throttler for preamble builds

vitalybuka added a comment. This looks flaky https://lab.llvm.org/buildbot/#/builders/5/builds/25929 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129100/new/ https://reviews.llvm.org/D129100 ___ cfe-com

[PATCH] D119621: [SanitizerCoverage] Add instrumentation callbacks for FP cmp instructions

vitalybuka added inline comments. Herald added a project: All. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_interface_internal.h:91 void __sanitizer_cov_trace_cmp8(); SANITIZER_INTERFACE_ATTRIBUTE SANITIZER_WEAK_ATTRIBUTE + void __sanitizer_cov_trace_cmp_fp2(); -

[PATCH] D122685: [msan] Add link to the lifetime definition

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122685 Files:

[PATCH] D122685: [msan] Add link to the lifetime definition

vitalybuka updated this revision to Diff 418978. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122685/new/ https://reviews.llvm.org/D122685 Files: clang/docs/MemorySanitizer.rst Index: clang/docs/MemorySaniti

[PATCH] D122685: [msan] Add link to the lifetime definition

vitalybuka updated this revision to Diff 418979. vitalybuka added a comment. fix link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122685/new/ https://reviews.llvm.org/D122685 Files: clang/docs/MemorySanitizer.rst Index: clang/docs/MemorySani

[PATCH] D122685: [msan] Add link to the lifetime definition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG122638d97d91: [msan] Add link to the lifetime definition (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122869: [lit] Fix setup of sanitizer environment

vitalybuka created this revision. vitalybuka added reviewers: eugenis, kda, rnk. Herald added a reviewer: bollu. Herald added subscribers: sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbi

[PATCH] D122869: [lit] Fix setup of sanitizer environment

vitalybuka updated this revision to Diff 419816. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122869/new/ https://reviews.llvm.org/D122869 Files: clang/test/Unit/lit.cfg.py clang/test/lit.cfg.py cross-proj

[PATCH] D122869: [lit] Fix setup of sanitizer environment

vitalybuka added inline comments. Comment at: clang/test/Unit/lit.cfg.py:33 -# Propagate path to symbolizer for ASan/MSan. -for symbolizer in ['ASAN_SYMBOLIZER_PATH', 'MSAN_SYMBOLIZER_PATH']: -if symbolizer in os.environ: -config.environment[symbolizer] = os.environ

[PATCH] D103562: [NFC][compiler-rt][hwasan] Refactor hwasan functions

vitalybuka added a subscriber: smd. vitalybuka added inline comments. Herald added a subscriber: Enna1. Herald added a project: All. Comment at: compiler-rt/lib/hwasan/hwasan.cpp:205 + if (registers_frame && stack->trace && stack->size > 0) { +stack->trace++; +stack->siz

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/test/CodeGen/hwasan-stack-safety-analysis-asm.c:8 + +int main(int argc, char **argv) { + char buf[10]; these tests do not work because %clang is not defined here, in LLVM you can keep them but they need to stay

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka updated this revision to Diff 359154. vitalybuka added a comment. Remove triple Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/h

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/include/llvm/Transforms/Instrumentation/HWAddressSanitizer.h:32 + Triple TargetTriple = {}); PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM); static bool isRequired() { return t

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. Please create *.ll tests, the rest is LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 ___ cfe-commits mailing list cfe-commits@

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2883666 , @eugenis wrote: > Btw Vitaly, will this work with LTO out of the box? I think we used to add > pre-LTO StackSafety pass explicitly for memtag only, but it looks like that > code is gone. What do you mean

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:427 + bool DisableOptimization) { assert(!CompileKernel || Recover); + return new HWAddressSanitizerLegacyPass(CompileKernel, R

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:406 +// architecture that doesn't allow stack tagging we will still load the +// analysis. +// This is so we don't need to plumb TargetTriple all the way to here.

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:410 +Dummy.setArch(Triple::aarch64); +if (shouldUseStackSafetyAnalysis(Dummy, DisableOptimization)) + AU.addRequired(); Why not just: ``` if (!Di

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:409 +// analysis. +// This is so we don't need to plumb TargetTriple all the way to here. +if (mightUseStackSafetyAnalysis(Disab

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. Do you build with assertions enabled? In D105703#2896056 , @fmayer wrote: > Sorry. broke a buildbot again: > https://lab.llvm.org/buildbot/#/builders/139/builds/7613/steps/6/logs/FAIL__Clang__asan_c > > I am not sure why I ca

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:414 INITIALIZE_PASS_BEGIN( HWAddressSanitizerLegacyPass, "hwasan", To fix that revert you need to add INITIALIZE_PASS_DEPENDENCY(StackSafetyGlobalIn

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka updated this revision to Diff 361002. vitalybuka added a comment. fix crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasa

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2898343 , @vitalybuka wrote: > fix crash weird, my config with -DLLVM_ENABLE_ASSERTIONS=ON does not reproduce, however exact cmake from bot does Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D105703: [hwasan] Use stack safety analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96c63492cb95: [hwasan] Use stack safety analysis. (authored by fmayer, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added a comment. In D105703#2898350 , @vitalybuka wrote: > In D105703#2898343 , @vitalybuka > wrote: > >> fix crash > > weird, my config with -DLLVM_ENABLE_ASSERTIONS=ON does not reproduce, however >

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

vitalybuka added a comment. @eugenis Why do we have them in here and in sanitizer/hwasan_interface.h ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 ___ cfe-com

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

vitalybuka added a comment. In D99381#2908102 , @vitalybuka wrote: > @eugenis Why do we have them in here and in sanitizer/hwasan_interface.h ? And if we don't need them in sanitizer/hwasan_interface.h and interface_internal, SANITIZER_INTERFACE_ATTRIB

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

vitalybuka added a comment. In D99381#2911057 , @eugenis wrote: > They are used here: > https://cs.android.com/android/platform/superproject/+/master:bionic/libc/bionic/malloc_common.h;l=54;drc=f3968e89cb72400951f93a2a8237ac1428d2627c Thanks, it's preproc

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_allocation_functions.cpp:20 +#if !SANITIZER_FUCHSIA +extern "C" { isn't HWASAN_WITH_INTERCEPTORS enough? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D99381: [compiler-rt][hwasan] Remove __sanitizer allocation functions from hwasan interface

vitalybuka added inline comments. Comment at: compiler-rt/lib/hwasan/hwasan_allocation_functions.cpp:20 +#if !SANITIZER_FUCHSIA +extern "C" { vitalybuka wrote: > isn't HWASAN_WITH_INTERCEPTORS enough? Ignore this. !SANITIZER_FUCHSIA is OK here. Repository:

[PATCH] D121405: [ASan] Moved optimized callbacks out of asan_static to avoid DSO size increase.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM, but maybe we can chat about that later today Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121405/new/ https://reviews.llvm.org/D1

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

vitalybuka accepted this revision. vitalybuka added a comment. Herald added a project: All. @eugenis I will prepare google3 and land it? Comment at: clang/lib/CodeGen/CGClass.cpp:1872 // Ignore trivial destructors. + if (BaseClassDecl->hasTrivialDestructor()) { --

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

vitalybuka updated this revision to Diff 416040. vitalybuka added a comment. addressing some @kda comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119300/new/ https://reviews.llvm.org/D119300 Files: clang/lib/CodeGen/CGClass.cpp clang/te

[PATCH] D119600: Stricter use-after-dtor detection for trivial members.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcb96464f12c4: Stricter use-after-dtor detection for trivial members. (authored by eugenis, committed by vitalybuka). Repository: rG LLVM Github Mo

[PATCH] D119300: Use-after-dtor detection for trivial base classes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5ea8e913893: Use-after-dtor detection for trivial base classes. (authored by eugenis, committed by vitalybuka). Repository: rG LLVM Github Monore

[PATCH] D123300: [Clang] Enable opaque pointers by default

vitalybuka added a comment. https://lab.llvm.org/buildbot/#/builders/74/builds/10288/steps/14/logs/stdio FAILED: tools/clang/lib/Tooling/ASTNodeAPI.json cd /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm_build_msan_track_origins/tools/clang/lib/Tooling && /b/sanitizer-x86_64-linux-boo

[PATCH] D123300: [Clang] Enable opaque pointers by default

vitalybuka added a comment. In D123300#3443603 , @vitalybuka wrote: > https://lab.llvm.org/buildbot/#/builders/74/builds/10288/steps/14/logs/stdio This looks like a false report. Probably opaque pointers somehow break Msan. Repository: rG LLVM Githu

[PATCH] D123300: [Clang] Enable opaque pointers by default

vitalybuka added a comment. In D123300#3444988 , @nikic wrote: > @vitalybuka Are there any instructions on how to reproduce failures from this > buildbot? It seems like this needs more than a simple bootstrap build due to > the need for instrumented lib

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

vitalybuka reopened this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Reverted with e75d8b70370435b0ad10388afba0df45fcf9bfcc to recover bots Repository: rG LLVM Github Monorepo CH

[PATCH] D123345: Treat `std::move`, `forward`, and `move_if_noexcept` as builtins.

vitalybuka added a comment. It's broken again here https://lab.llvm.org/buildbot/#/builders/74/builds/10427 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123345/new/ https://reviews.llvm.org/D123345 ___

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka created this revision. vitalybuka added reviewers: eugenis, kda. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers, LLVM. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits. By default -fsanitize=address alre

[PATCH] D124058: [msan] Update Use-after-destruction documentation

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124058 Files: clang/docs/MemorySanitizer.rst Ind

[PATCH] D124058: [msan] Update Use-after-destruction documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGb580c0e01982: [msan] Update Use-after-destruction documentation (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124058/new/ https://

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka updated this revision to Diff 424291. vitalybuka added a comment. add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124057/new/ https://reviews.llvm.org/D124057 Files: clang/docs/AddressSanitizer.rst clang/docs/ReleaseN

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka added inline comments. Comment at: clang/docs/ReleaseNotes.rst:175 - Remove anonymous tag locations. - Beautify dump format, add indent for nested struct and struct members. +- Previously disabled sanitizer options now enabled by default @hans PT

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka added inline comments. Comment at: clang/docs/ReleaseNotes.rst:175 - Remove anonymous tag locations. - Beautify dump format, add indent for nested struct and struct members. +- Previously disabled sanitizer options now enabled by default vitalybu

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

vitalybuka added a comment. Breaks multiple builders https://lab.llvm.org/buildbot/#/builders/169/builds/7648 https://lab.llvm.org/buildbot/#/builders/70/builds/20812 https://lab.llvm.org/buildbot/#/builders/77/builds/16736 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D119299: [NFC] clang-format one function.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. I don't think you need approval for that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119299/new/ https://reviews.llvm.org/D119299 ___

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b4437c084e2: [asan] Enable detect_stack_use_after_return=1 by default (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default

vitalybuka updated this revision to Diff 425433. vitalybuka added a comment. redo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124057/new/ https://reviews.llvm.org/D124057 Files: clang/docs/AddressSanitizer.rst clang/docs/ReleaseNotes.rst c

[PATCH] D124057: [asan] Enable detect_stack_use_after_return=1 by default on Linux

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG78582194361e: [asan] Enable detect_stack_use_after_return=1 by default on Linux (authored by vitalybuka). Changed prior to commit: https://reviews

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

vitalybuka added a comment. In D124493#3477432 , @filcab wrote: > Hi @hctim, thanks for the patch. > I have one question, though. Do you really need to remove the information you > removed? > Some people might be testing ASan binaries without access to d

[PATCH] D124493: Move Sanitizer metadata to be on-GlobalValue.

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/SanitizerMetadataFactory.h:6 +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===--===// vitalybuka wrote: > can

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added a comment. looks like check-asan tests fail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/new/ https://reviews.llvm.org/D129448 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:935 SmallVector Labels; +SmallVector LifetimeStartMarkers; LexicalScope *ParentScope; LifetimeStartMarkers -> BypassedLifetimeStartMarkers and below if I read this co

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); vitalybuka wrote: > Please check for lifetime markers, I assume case 2 will have a new one > Please check for lifetime markers, I assume case 2

[PATCH] D128672: Update DynInit generation for ASan globals.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:67-68 - if (FsanitizeArgument.has(SanitizerKind::Address)) { -// TODO(hctim): Make this conditional whe

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); StephenFan wrote: > vitalybuka wrote: > > vitalybuka wrote: > > > Please check for lifetime markers, I assume case 2 will have a new one > > >

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

vitalybuka created this revision. Herald added a project: All. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D129789 Files: clang/test/CodeGen/lifetime.c clan

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

vitalybuka updated this revision to Diff 444735. vitalybuka added a comment. remove debug changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129789/new/ https://reviews.llvm.org/D129789 Files: clang/test/CodeGen/lifetime.c clang/test/CodeGe

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

vitalybuka added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); vitalybuka wrote: > StephenFan wrote: > > vitalybuka wrote: > > > vitalybuka wrote: > > > > Please check for lifetime markers, I assume case 2

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

vitalybuka updated this revision to Diff 444737. vitalybuka added a comment. simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129789/new/ https://reviews.llvm.org/D129789 Files: clang/test/CodeGen/lifetime.c clang/test/CodeGen/lifetime2.

[PATCH] D129789: [test][CodeGen] Don't miss lifetime markers in lifetime tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2e01bdcc214: [test][CodeGen] Don't miss lifetime markers in lifetime tests (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. problem with included files that we don't know which non-inlined version of the function will endup in the binary so using this option, user may unintentionally disable instrumentation on all included headers, even when included from a different place Repository:

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. In D129832#3654066 , @MaskRay wrote: > In D129832#3654040 , @vitalybuka > wrote: > >> problem with included files that we don't know which non-inlined version of >> the function will

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. > mainsrc may still be useful, e.g. if a wildcard is used to ensure the > prevailing one is ignored. Not sure I understand, how can we make that? Usually it's hard to control what is included, especially indirectly. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2786 + const FileEntry &MainFile = *SM.getFileEntryForID(SM.getMainFileID()); + if (NoSanitizeL.containsMainFile(Kind, MainFile.getName())) +return true; we search exactly the

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2786 + const FileEntry &MainFile = *SM.getFileEntryForID(SM.getMainFileID()); + if (NoSanitizeL.containsMainFile(Kind, MainFile.getName())) +return true; vitalybuka wrote: > w

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added inline comments. Comment at: clang/docs/SanitizerSpecialCaseList.rst:110-112 +``mainsrc`` can be useful enabling a ubsan check for a large code base when +finding the direct stack frame triggering the failure for every failure is +difficult. if t

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. The patch is LGTM, but please consider to keep an ignorelist limited. Comment at: clang/docs/SanitizerSpecialCaseList.rst:110-112 +``mainsrc`` can be useful enabling

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. I guess Kirills' complain is about **main** part, not **src**. But I have no idea what name could be better. I guess thechnically it's preprocessed src? :) To me as is name is fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D129832: [sanitizer] Add "mainsrc" prefix to sanitizer special case list

vitalybuka added a comment. "unit:" ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129832/new/ https://reviews.llvm.org/D129832 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

<    1   2   3   4   5   6   7   8   >