[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

vitalybuka added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. Looks like no activity by @ygribov after September LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47817/new/ https://reviews.llvm.org/D47817 ___

[PATCH] D68115: Zero initialize padding in unions

vitalybuka created this revision. vitalybuka added reviewers: rsmith, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. vitalybuka edited the summary of this revision. vitalybuka edited the summary of this revision. Existing implementation puts undef into paddi

[PATCH] D68115: Zero initialize padding in unions

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGenCXX/designated-init.cpp:68 }; -// CHECK: @overwrite_padding = global { { i8, i8 } } { { i8, i8 } { i8 3, i8 1 } } +// CHECK-LE: @overwrite_padding = global { { i8, i8 }

[PATCH] D68115: Zero initialize padding in unions

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGenCXX/designated-init.cpp:68 }; -// CHECK: @overwrite_padding = global { { i8, i8 } } { { i8, i8 } { i8 3, i8 1 } } +// CHECK-LE: @overwrite_padding = global { { i8, i8 }

[PATCH] D68115: Zero initialize padding in unions

vitalybuka updated this revision to Diff 222071. vitalybuka added a comment. remove unused var Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68115/new/ https://reviews.llvm.org/D68115 Files: clang/lib/CodeGen/CGExprConstant.cpp clang/test/Code

[PATCH] D68115: Zero initialize padding in unions

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGen/init.c:197 // CHECK-LABEL: @nonzeroPaddedUnionMemset( - // CHECK-NOT: store - // CHECK-NOT: memcpy - // CHECK: call void @llvm.memset.p0i8.i32(i8* {{.*}}, i8 -16, i

[PATCH] D68115: Zero initialize padding in unions

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGen/init.c:197 // CHECK-LABEL: @nonzeroPaddedUnionMemset( - // CHECK-NOT: store - // CHECK-NOT: memcpy - // CHECK: call void @llvm.memset.p0i8.i32(i8* {{.*}}, i8 -16, i

[PATCH] D68115: Zero initialize padding in unions

vitalybuka marked 2 inline comments as done. vitalybuka added inline comments. Comment at: clang/test/CodeGen/init.c:197 // CHECK-LABEL: @nonzeroPaddedUnionMemset( - // CHECK-NOT: store - // CHECK-NOT: memcpy - // CHECK: call void @llvm.memset.p0i8.i32(i8* {{.*}}, i8 -16, i

[PATCH] D68115: Zero initialize padding in unions

vitalybuka added a comment. In D68115#1686837 , @jfb wrote: > The entire point of this feature is to add guardrails to the language. What > do people expect in the real world? Is there a cost to meeting these > expectations? If we put the pattern (0x00 o

[PATCH] D68115: Zero initialize padding in unions

vitalybuka added a comment. > The patch as-is moves past the scope of the `-ftrivial-auto-var-init` feature. That's because I had misunderstanding of the standard. I would be happy to update the patch to enable it only for -ftrivial-auto-var-init=pattern, if we want "bumper" version. For "non-b

[PATCH] D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl

vitalybuka created this revision. vitalybuka added reviewers: eugenis, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68608 Files: clang/include/clang/Driver/Options.td clang/test/Driver/cl-options.c

[PATCH] D68610: [clang] enable_trivial_var_init_zero should not be Joined<>

vitalybuka created this revision. vitalybuka added a reviewer: rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68610 Files: clang/include/clang/Driver/Options.td Index: clang/include/clang/Driver/Opti

[PATCH] D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1720 " | pattern">, Values<"uninitialized,pattern">; def enable_trivial_var_init_zero : Joined<["-"], "enable-trivial-auto-var-init-zero-knowing-i

[PATCH] D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rL373992: [clang] Accept -ftrivial-auto-var-init in clang-cl (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D68610: [clang] enable_trivial_var_init_zero should not be Joined<>

This revision was automatically updated to reflect the committed changes. Closed by commit rGc831ce8c0619: [clang] enable_trivial_var_init_zero should not be Joined<> (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68610/new/

[PATCH] D68832: [tsan,msan] Insert module constructors in a module pass

vitalybuka created this revision. vitalybuka added reviewers: eugenis, leonardchan. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. If we insert them from function pass some analysis may be missing or invalid. Fixes PR42877. Repository: rG LL

[PATCH] D68832: [tsan,msan] Insert module constructors in a module pass

vitalybuka updated this revision to Diff 224501. vitalybuka marked 2 inline comments as done. vitalybuka added a comment. nfc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68832/new/ https://reviews.llvm.org/D68832 Files: clang/lib/CodeGen/Backe

[PATCH] D68832: [tsan,msan] Insert module constructors in a module pass

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c72aa232e74: [tsan,msan] Insert module constructors in a module pass (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68832/new/ htt

[PATCH] D80039: [NFC, StackSafety] LTO tests for MTE and StackSafety

This revision was automatically updated to reflect the committed changes. Closed by commit rG088fb9734843: [NFC, StackSafety] LTO tests for MTE and StackSafety (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D80039?vs=264361&id=265902#toc Repository: rG LLVM Githu

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

vitalybuka updated this revision to Diff 266316. vitalybuka added a comment. simplify some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/Code

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

This revision was automatically updated to reflect the committed changes. Closed by commit rG14de6e29b131: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list (authored by melver, committed by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D79628?vs=266316&id=266324#t

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka planned changes to this revision. vitalybuka added a comment. I'll probably abandon this. I've converted the pass into pure analysis and I need to upstream that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/ https://reviews.l

[PATCH] D80771: [MTE] Convert StackSafety into analysisThis lets us to remove !stack-safe metadata andbetter controll when to perform StackSafetyanalysis.

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80771 Files: clang/lib/CodeGen/Bac

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka updated this revision to Diff 267384. vitalybuka marked 3 inline comments as done. vitalybuka retitled this revision from "[MTE] Convert StackSafety into analysis This lets us to remove !stack-safe metadata and better controll when to perform StackSafety analysis." to "[MTE] Convert Sta

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/Driver/memtag_lto.c:126 + // XUNSAFE: [4]: full-set + // XSAFE: [4]: [0,4) int x; eugenis wrote: > Alloca order can easily change in the future. Not sure ho

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka marked 2 inline comments as done. vitalybuka added inline comments. Comment at: clang/test/Driver/memtag_lto.c:126 + // XUNSAFE: [4]: full-set + // XSAFE: [4]: [0,4) int x; eugenis wrote: > vitalybuka wrote: > > eugenis wrote: > > > Alloca order c

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka updated this revision to Diff 267710. vitalybuka marked an inline comment as done. vitalybuka added a comment. SmallPtrSet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80771/new/ https://reviews.llvm.org/D80771 Files: clang/lib/CodeG

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka updated this revision to Diff 267731. vitalybuka marked an inline comment as done. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80771/new/ https://reviews.llvm.org/D80771 Files: clang/lib/CodeGen/Ba

[PATCH] D80954: [NFC,MTE] Drop unneeded attribute from test

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. vitalybuka added a child revision: D80908: [StackSafety] Add info into function summary. Depends on D80847

[PATCH] D80771: [MTE] Convert StackSafety into analysis

vitalybuka updated this revision to Diff 267802. vitalybuka added a comment. remove unneeded pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80771/new/ https://reviews.llvm.org/D80771 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Driv

[PATCH] D80771: [MTE] Convert StackSafety into analysis

This revision was automatically updated to reflect the committed changes. Closed by commit rG232d348c6eff: [MTE] Convert StackSafety into analysis (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80771/new/ https://reviews.llv

[PATCH] D80954: [NFC,MTE] Drop unneeded attribute from test

This revision was automatically updated to reflect the committed changes. Closed by commit rG85fdec988fc5: [NFC,MTE] Drop unneeded attribute from test (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80954/new/ https://reviews

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

vitalybuka added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast16labels) return l1 | l2; isn't better just create new set of callbacks? e.

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM either way Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast1

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

vitalybuka added a comment. LGTM as it fixes update_cc_test_checks.py Comment at: llvm/utils/update_cc_test_checks.py:116-126 +def infer_dependent_args(args): + if args.clang is None: +if args.llvm_bin is None: + args.clang = 'clang' +else: + args.clang = os.

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

vitalybuka added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# works as expected +config.substitutions.append( +('%update_cc_test_checks_llvm_bin', "%s %s %s" % ( arichardson wrote: > MaskRay wrote: > > The substituti

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka updated this revision to Diff 255016. vitalybuka added a comment. try arc diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77374/new/ https://reviews.llvm.org/D77374 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/bounds-ch

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:218 Opts.StackDepth = CGOpts.SanitizeCoverageStackDepth; - PM.add(createSanitizerCoverageModulePass(Opts)); + PM.add(createSanitizerCoverageModulePass(Opts, CGOpts.SanitizeCoverageWhitelistFiles

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77374/new/ https://reviews.llvm.org/D77374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D77373: Add more -fsanitize=array-bounds tests

vitalybuka added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77373/new/ https://reviews.llvm.org/D77373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

vitalybuka added a comment. In D77244#1956930 , @pratyai wrote: > It looks like I broke the tests after the `i8 `-> `i1` switch. > > I think it's because of an existing bug. From > https://llvm.org/docs/LangRef.html > > > i1:8:8 - i1 is 8-bit (byte) align

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

vitalybuka added a comment. In D77244#1956805 , @pratyai wrote: > Undid the `arc lint` on autocomplete.c. > `arc lint` does not seem to have an option --style, but it's just one line > diff anyway. yep. it had --style LLVM by mistake. I guess it's fixe

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:922 +auto Store = IRB.CreateStore(ConstantInt::getTrue(Int1Ty), FlagPtr); +Store->setAtomic(AtomicOrdering::NotAtomic); +Store->setAlignment(llvm::MaybeAlign(Functi

[PATCH] D77637: [part 2] sancov/inline-bool-flag clang flags.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/fsanitize-coverage.c:114 +// RUN: %clang -target x86_64-linux-gnu -fsanitize-coverage=inline-8bit-counters,pc-table %s -### 2>&1 |

[PATCH] D77244: [part 1] sancov/inline-bool-flag instrumentation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8d1c6529b95: [SanitizerCoverage] sancov/inline-bool-flag instrumentation. (authored by pratyai, committed by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D77244?vs=256182&id=256190#to

[PATCH] D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag

vitalybuka added a comment. With this patch check-fuzzer does not work FAIL: libFuzzer :: value-profile-load.test (63806 of 66139) TEST 'libFuzzer :: value-profile-load.test' FAILED Script: -- : 'RUN: at line 2'; /us

[PATCH] D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag

vitalybuka added a comment. In D77637#1971417 , @pratyai wrote: > Was unintentionally enabling the bool-flag coverage in SanitizerArgs.cpp > before (line#383, `if (Add & SanitizerKind::FuzzerNoLink) { CoverageFeatures > |= ... }` > > Couldn't catch it be

[PATCH] D77637: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGced398fdc813: [SanitizerCoverage] Add -fsanitize-coverage=inline-bool-flag (authored by pratyai, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:882-887 + while (const BinaryOperator *BO = dyn_cast(E)) { +if (!BO->isCommaOp()) + break; +E = BO->getRHS(); +E = E->IgnoreParens(); + } ---

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM. ThinLTO linking runs dataflow processing on collected function parameters. Then StackSa

[PATCH] D81244: [StackSafety] Control paramer access summary from frontend

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. MAYBE? let me know if you think we need it. I'll improve the patch. This way we don't need to rel

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka updated this revision to Diff 270328. vitalybuka marked 5 inline comments as done. vitalybuka added a comment. @eugenis review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242 Files: clang/test/

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added inline comments. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedAddMayOverflow(C.Offset) != +ConstantRange::OverflowResult::NeverOverflows) -

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka updated this revision to Diff 270553. vitalybuka marked 3 inline comments as done. vitalybuka added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242 Files: clang/test

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added inline comments. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedAddMayOverflow(C.Offset) != +ConstantRange::OverflowResult::NeverOverflows) -

[PATCH] D81242: [StackSafety] Run ThinLTO

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e47b47f884: [StackSafety] Run ThinLTO (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

vitalybuka added subscribers: eugenis, guiand, vitalybuka. vitalybuka added a comment. After this patch we have false msan reports on code like this: bool iv_compare2(const int *op1, const int *op2) { if (op1[1] != op2[1]) return op1[1] < op2[1]; for (int i = 1; i >= 0; i--) { if

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added a comment. Thanks. Looking. In D81242#2183383 , @tejohnson wrote: > I just noticed that generateParamAccessSummary is taking a bit over 5% of the > ThinLTO thin link step in an internal build (and will soon be more than 5% as > I found

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added a comment. In D81242#2183383 , @tejohnson wrote: > Is the stack safety analysis meant to be always on with ThinLTO? During compilation most of the time it should be off. However during linking I assume that most build FS->paramAccesses()

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added a comment. In D81242#2188467 , @tejohnson wrote: > In D81242#2188441 , @vitalybuka > wrote: > >> In D81242#2183383 , @tejohnson >> wrote: >> >>> Is the sta

[PATCH] D85948: [HeapProf] Clang and LLVM support for heap profiling instrumentation

vitalybuka added a comment. LGTM with some nits Comment at: llvm/lib/Transforms/Instrumentation/HeapProfiler.cpp:124 + +namespace { + maybe remove all static about and extend namespace {} Comment at: llvm/lib/Transforms/Instrumentation/HeapPr

[PATCH] D78607: [local-bounds] Ignore volatile operations

vitalybuka added a comment. done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D78607: [local-bounds] Ignore volatile operations

vitalybuka updated this revision to Diff 262239. vitalybuka added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607 Files:

[PATCH] D78607: [local-bounds] Ignore volatile operations

vitalybuka updated this revision to Diff 262240. vitalybuka added a comment. updated doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607 Files: clang/docs/UndefinedBehaviorSanitizer.rst llvm/lib/Transfo

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

vitalybuka requested changes to this revision. vitalybuka added reviewers: eugenis, glider. vitalybuka added a comment. This revision now requires changes to proceed. In D79445#2021502 , @aeubanks wrote: > In D79445#2021311

[PATCH] D78607: [local-bounds] Ignore volatile operations

This revision was automatically updated to reflect the committed changes. Closed by commit rG04bd2c37caf4: [local-bounds] Ignore volatile operations (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.l

[PATCH] D78607: [local-bounds] Ignore volatile operations

vitalybuka updated this revision to Diff 262294. vitalybuka marked an inline comment as done. vitalybuka added a comment. add =undefined note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607 Files: clang/d

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t && \ rnk wrote: > leonardc

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1232 PB.registerScalarOptimizerLateEPCallback( [](FunctionPassManager &FPM, PassBuilder::OptimizationLevel Level) { FPM.addPass(BoundsCheckingPass()); ---

[PATCH] D79628: [Clang][Driver] Add Bounds and Thread to SupportsCoverage list

vitalybuka added a comment. can you please add some basic IR test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79628/new/ https://reviews.llvm.org/D79628 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D77249: [MSan] Pass command line options to MSan with new pass manager

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/chained_origin_empty_stack_npm.cpp:4 +// this test. +// RUN: %clangxx_msan -fsanitize-memory-track-origins=2 \ +// RUN: -fexperimental-new-pass-manager -O3 %s -o %t && \ vitalybuka wrote: > r

[PATCH] D80039: [NFC, StackSafety] LTO tests for MTE and StackSafety

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added a project: clang. vitalybuka updated this revision to Diff 264360. vitalybuka added a comment. vitalybuka updated this revision t

[PATCH] D80039: [NFC, StackSafety] LTO tests for MTE and StackSafety

vitalybuka updated this revision to Diff 264360. vitalybuka added a comment. remove fixme Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80039/new/ https://reviews.llvm.org/D80039 Files: clang/test/Driver/memtag_lto.c Index: clang/test/Driver/me

[PATCH] D80039: [NFC, StackSafety] LTO tests for MTE and StackSafety

vitalybuka updated this revision to Diff 264361. vitalybuka added a comment. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80039/new/ https://reviews.llvm.org/D80039 Files: clang/test/Driver/memtag_lto.c Index: clang/test/Driver/memtag_

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka created this revision. vitalybuka added a reviewer: eugenis. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM. Depends on D80039 . Repository: rG LLVM Github Monorep

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka updated this revision to Diff 264386. vitalybuka added a comment. pm test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/ https://reviews.llvm.org/D80046 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/Driver/memtag_lto

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka added a comment. > It could also be better, instead of iterating over all functions, simply run > the global pass, but make sure that it does not do too much work on > non-sanitize_memtag functions. I.e. the function pass should bail out on such > functions, and then the data flow wi

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka updated this revision to Diff 264399. vitalybuka added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/ https://reviews.llvm.org/D80046 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenModule

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka updated this revision to Diff 264398. vitalybuka added a comment. new line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/ https://reviews.llvm.org/D80046 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenMo

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka updated this revision to Diff 264397. vitalybuka added a comment. module flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80046/new/ https://reviews.llvm.org/D80046 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGe

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka added a comment. In D80046#2040309 , @efriedma wrote: > If I'm understanding this correctly, the stack-safe metadata on allocas is > both produced and consumed at LTO-time. So at the point where the stack-safe > metadata would be produced, we

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka added a comment. In D80046#2042874 , @vitalybuka wrote: > In D80046#2040309 , @efriedma wrote: > > > If I'm understanding this correctly, the stack-safe metadata on allocas is > > both produced and consu

[PATCH] D80046: [StackSafety] Make full LTO to attach metadata if MTE is enabled

vitalybuka added a comment. In D80046#2042937 , @efriedma wrote: > Okay, I think we're mostly on the same page, then. Probably most important is Q no. 4. > I have a few issues here: > > 1. Whether the backend wants this information is really a per-func

[PATCH] D132907: [msan] Add more specific messages for use-after-destroy

vitalybuka created this revision. Herald added a subscriber: Enna1. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D132909: [msan] Use Debug Info to point to affected fields

vitalybuka created this revision. Herald added a subscriber: Enna1. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Depends on: D132907 Repos

[PATCH] D132907: [msan] Add more specific messages for use-after-destroy

vitalybuka updated this revision to Diff 456540. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132907/new/ https://reviews.llvm.org/D132907 Files: clang/lib/CodeGen/CGClass.cpp clang/test/CodeGenCXX/sanitize-

[PATCH] D132909: [msan] Use Debug Info to point to affected fields

vitalybuka updated this revision to Diff 456541. vitalybuka added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132909/new/ https://reviews.llvm.org/D132909 Files: clang/lib/CodeGen/CGClass.cpp clang/test/CodeGenCXX/sanitize-

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

vitalybuka added a comment. Another test under llvm-project/clang/test/CodeGen/ is needed which tests IR generated from C/C++ contains expected info. Random example clang/test/CodeGen/attr-noundef.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D132907: [msan] Add more specific messages for use-after-destroy

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGClass.cpp:1773 // function - EmitSanitizerDtorCallback(CGF, VTablePtr, PoisonSize); + EmitSanitizerDtorCallback(CGF, "__sanitizer_dtor_callback_vptr", +VTablePtr); -

[PATCH] D132907: [msan] Add more specific messages for use-after-destroy

This revision was automatically updated to reflect the committed changes. Closed by commit rGc059ede28ea8: [msan] Add more specific messages for use-after-destroy (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132907/new/ ht

[PATCH] D132909: [msan] Use Debug Info to point to affected fields

This revision was automatically updated to reflect the committed changes. Closed by commit rG960e7a551326: [msan] Use Debug Info to point to affected fields (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D132909?vs=456541&id=457069#toc Repository: rG LLVM Github

[PATCH] D117622: [MSAN] removing redundant tests and parameters (NFC)

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/noundef_analysis.cpp:5 // RUN: FileCheck %s < %t.out -// RUN: %clangxx_msan %s -disable-noundef-analysis -s -fsanitize-memory-param-retval -o %t && not %run %t >%t.out 2>&1 +// RUN: %clangxx_msan %s -disable-no

[PATCH] D130888: [Clang] Introduce -fexperimental-sanitize-metadata=

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Driver/fsanitize-metadata.c:24 + +// RUN: %clang --target=x86_64-linux-gnu \ +// RUN: -fexperimental-sanitize-metadata=covered,atomics %s

[PATCH] D133157: Add -sanitizer-coverage-control-flow

vitalybuka added inline comments. Comment at: compiler-rt/test/sanitizer_common/TestCases/sanitizer_coverage_control_flow.cpp:4 +// RUN: %clangxx -O0 -std=c++11 -fsanitize-coverage=control-flow %s -o %t +// RUN: %run %t 2>&1 | FileCheck %s --implicit-check-not Assertion{{.*}}fai

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

vitalybuka added a comment. Broken by the patch https://lab.llvm.org/buildbot/#/builders/127/builds/35304 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133202/new/ https://reviews.llvm.org/D133202 ___ cf

[PATCH] D133336: [msan] Convert Msan to ModulePass

vitalybuka created this revision. Herald added subscribers: Enna1, ormris, jdoerfert, hiraditya. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. MemorySanitizerPass function pass vio

[PATCH] D133336: [msan] Convert Msan to ModulePass

vitalybuka updated this revision to Diff 458097. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16/new/ https://reviews.llvm.org/D16 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Transform

[PATCH] D133336: [msan] Convert Msan to ModulePass

vitalybuka updated this revision to Diff 458098. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16/new/ https://reviews.llvm.org/D16 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Tra

[PATCH] D133336: [msan] Convert Msan to ModulePass

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7bac3b9fa73: [msan] Convert Msan to ModulePass (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16/new/ https://reviews.llvm.org

<    1   2   3   4   5   6   7   8   >