Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti removed rL LLVM as the repository for this revision. tinti updated this revision to Diff 38803. tinti added a comment. Add context http://reviews.llvm.org/D14184 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp lib/Driver/T

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:524 @@ +523,3 @@ + .Case("5", llvm::EABI::Eabi5) + .Case("gnu", llvm::EABI::Gnu) + .Default(llvm::EABI::Default); compnerd wrote: > I'd really rather see this written in the LLVM

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:458 @@ +457,3 @@ +StringRef Value = A->getValue(); +bool Valid = llvm::StringSwitch(Value) + .Case("default", true) tinti wrote: > compnerd wrote: > > If `llvm::EABI::EABIVer

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti set the repository for this revision to rL LLVM. tinti updated this revision to Diff 39108. tinti added a comment. - Clang format code. - Update eabi names to match new LLVM patch. Repository: rL LLVM http://reviews.llvm.org/D14184 Files: include/clang/Driver/Options.td include/cla

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti updated this revision to Diff 39304. tinti added a comment. Clang format. Repository: rL LLVM http://reviews.llvm.org/D14184 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp lib/Driver/Tools.cpp lib/Frontend/CompilerIn

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti marked 2 inline comments as done. Comment at: lib/Frontend/CompilerInvocation.cpp:459 @@ +458,3 @@ +StringRef Value = A->getValue(); +bool Valid = llvm::StringSwitch(Value) + .Case("default", true) This part of the code does not i

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti removed rL LLVM as the repository for this revision. tinti updated this revision to Diff 39579. http://reviews.llvm.org/D14184 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp lib/Driver/Tools.cpp lib/Frontend/CompilerInvoc

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti set the repository for this revision to rL LLVM. tinti updated this revision to Diff 39596. tinti marked an inline comment as done. tinti added a comment. - Add test for error check - Change StringSwitch to use lllvm::EABI type Repository: rL LLVM http://reviews.llvm.org/D14184 Files:

Re: [PATCH] D14184: [clang] Add initial support for -meabi flag

tinti marked 6 inline comments as done. Comment at: lib/Driver/Tools.cpp:3415 @@ -3414,1 +3414,3 @@ + if (Arg *A = Args.getLastArg(options::OPT_meabi)) { +CmdArgs.push_back("-meabi"); Good point! Fixed. Comment at: lib/Frontend/CompilerInv

[PATCH] D14804: [clang] Disable Unicode in asm files

tinti created this revision. tinti added reviewers: rengolin, zatrazz, compnerd. tinti added a subscriber: cfe-commits. tinti set the repository for this revision to rL LLVM. Clang should not convert tokens to Unicode when preprocessing assembly files. Fixes PR25558 Repository: rL LLVM http:/

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

tinti removed rL LLVM as the repository for this revision. tinti updated this revision to Diff 40595. http://reviews.llvm.org/D14804 Files: lib/Lex/Lexer.cpp test/CodeGen/asm-unicode.S test/CodeGen/c-unicode.c Index: test/CodeGen/c-unicode.c

r253738 - [clang] Disable Unicode in asm files

Author: tinti Date: Fri Nov 20 17:42:39 2015 New Revision: 253738 URL: http://llvm.org/viewvc/llvm-project?rev=253738&view=rev Log: [clang] Disable Unicode in asm files Clang should not convert tokens to Unicode when preprocessing assembly files. Fixes PR25558. Added: cfe/trunk/test/CodeGen

Re: [PATCH] D14804: [clang] Disable Unicode in asm files

tinti closed this revision. tinti added a comment. r253738 Repository: rL LLVM http://reviews.llvm.org/D14804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits