[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1225 - HI.Provider = spellHeader(AST, SM.getFileEntryForID(SM.getMainFileID()), H); + HI.Provider = include_cleaner::spellHeader( + {H, AST.getPreprocessor().getHeaderSearc

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 528341. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90c5fe98: [include-cleaner] Allow multiple strategies for spelling includes. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo updated this revision to Diff 529974. VitaNuo added a comment. Remove unrelated formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152542/new/ https://reviews.llvm.org/D152542 Files: clang-tools-extra/clangd/Hover.cpp clang-tool

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo updated this revision to Diff 531275. VitaNuo added a comment. VitaNuo updated this revision to Diff 531278. VitaNuo added a reviewer: kadircet. VitaNuo published this revision for revi

[PATCH] D152913: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D152913: [clangd] Use include_cleaner spelling strategies in clangd.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6a6c7ed5cd8d: [clangd] Use include_cleaner spelling strategies in clangd. (authored by VitaNuo). Repository: rG LLVM Gi

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo updated this revision to Diff 531718. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153015/new/ https://reviews.llvm.org/D153015 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unit

[PATCH] D153013: [clang-tidy] Correct the include-cleaner-check diagnostic message for missing-includes.

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:49 SourceLocation SymRefLocation; + include_cleaner::Symbol Sym; include_cleaner::Heade

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo added a comment. Duplicate of https://reviews.llvm.org/D152913. Landed the other one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152542/new/ https://reviews.llvm.org/D152542 ___ cfe-commits ma

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added a comment. thanks! Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3726 +TEST(Hover, FunctionParameterDefaulValueNotEvaluated) { + Annotations T("void foo(int p^aram = 5);"); + TestTU TU = TestTU::withCode(T.code()); hokein wrote:

[PATCH] D153018: [include-cleaner] Reorder SymbolReference fields to avoid padding space, NFC

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153018/new/ https://reviews.llvm.org/D153018 __

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo updated this revision to Diff 532042. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153015/new/ https://reviews.llvm.org/D153015 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-ex

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo updated this revision to Diff 532044. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153015/new/ https://reviews.llvm.org/D153015 Files: clang-tools-extra/clangd

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added a comment. Thanks for the review! Comment at: clang-tools-extra/clangd/Hover.cpp:663 + const auto *Var = dyn_cast(D); + if (Var && !llvm::isa(Var)) { if (const Expr *Init = Var->getInit()) hokein wrote: > We're ignoring all `ParmVarDecl` ca

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:663 + const auto *Var = dyn_cast(D); + if (Var && !llvm::isa(Var)) { if (const Expr *Init = Var->getInit()) VitaNuo wrote: > hokein wrote: > > We're ignoring all `ParmVarDecl` ca

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

This revision was automatically updated to reflect the committed changes. VitaNuo marked an inline comment as done. Closed by commit rGc9888dce4474: [clangd] Skip function parameter decls when evaluating variables on hover. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D153015: [clangd] Skip function parameter decls when evaluating variables on hover.

VitaNuo added a comment. Thanks! Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:3726 +TEST(Hover, FunctionParameterDefaulValueNotEvaluatedOnInvalidDecls) { + struct { hokein wrote: > nit: instead of creating a completely-new TEST, it seems sim

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 480375. VitaNuo added a comment. Re-introduce the isUsed check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: clang-tools-extra/include-cleaner/lib/WalkAST

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } hokein wrote: > VitaNuo wrote: > > kadircet wrote: > > > ho

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo updated this revision to Diff 480378. VitaNuo added a comment. Address review comments, mostly style issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139087/new/ https://reviews.llvm.org/D139087 Files: clang-tools-extra/include-clea

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Handles dependent type members in AST. Repository: rG LLVM Github Monor

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 480418. VitaNuo added a comment. Change/remove stale comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: clang-tools-extra/include-cleaner/lib/WalkAST.

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:130 TEST(WalkAST, Using) { - // Make sure we ignore unused overloads. + // We should report unused overloads as ambiguous. testWa

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo updated this revision to Diff 480422. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments: change comment, add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139087/new/ https://reviews

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480466. VitaNuo added a comment. Implement dependent type handling for template specialization types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-t

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480467. VitaNuo added a comment. Remove extra import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480469. VitaNuo added a comment. Adjust implementation to handle pointer types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cle

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480528. VitaNuo added a comment. Add handling of nested types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480530. VitaNuo added a comment. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480539. VitaNuo added a comment. Add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 481213. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Formatting fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: clang-tools-extr

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45659b3bd98e: [include-cleaner] Remove filtering from UsingDecl visit. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:67 bool VisitMemberExpr(MemberExpr *E) { +// A member expr implies a usage of the class type hokein wrote: > while reading it again, I realize that there is anot

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd03e9f8fb074: [include-cleaner] Handle base class member access from derived class. (authored by VitaNuo). Changed prior to commit: https://reviews.llvm.org/D139087?vs=480422&id=481217#toc Repository:

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Use expansion locations for target symbol decls when finding headers for ma

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 481635. VitaNuo added a comment. Remove FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp clang-

[PATCH] D139696: [include-cleaner] Add a unique_ptr-style member expr test in WalkASTTest.

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:200 + testWalk(R"cpp( + template struct unique_ptr { +T *operator->(); ---

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 481659. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-too

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:79 + +if (isa(UnqualifiedType)) { + const TemplateSpecializationType *TST = hokein wrote: > if we just aim to support t

<    1   2   3   4   5