[PATCH] D138821: Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 478265. VitaNuo added a comment. Add another example. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 478267. VitaNuo added a comment. Edit commit message, add "[include-cleaner]". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: clang-tools-extra/include-clea

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo updated this revision to Diff 478483. VitaNuo added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138797/new/ https://reviews.llvm.org/D138797 Files: clang-tools-extra/include-cleaner/lib/Record.cpp clang-too

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo updated this revision to Diff 478545. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138797/new/ https://reviews.llvm.org/D138797 Files: clang-too

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:312 + + size_t offsetToLineNum(llvm::Annotations MainFile, size_t Offset) { +int Count = MainFile.code().substr(0, Offset).count('\n'); hokein wrote: > this

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 478556. VitaNuo added a comment. Address review comments: turn all references into explicit, remove the "isHeader" field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:87 - // headers might still be used by the dependents of the header. - if (!IsUsed && !IsHeader) -continue; ho

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo updated this revision to Diff 478561. VitaNuo added a comment. Remove excessive method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138797/new/ https://reviews.llvm.org/D138797 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:312 + + size_t offsetToLineNum(llvm::Annotations MainFile, size_t Offset) { +int Count = MainFile.code().substr(0, Offset).count('\

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. VitaNuo marked an inline comment as done. Closed by commit rG7452e053e592: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support. (authored by VitaNuo).

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D139087 Fi

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo updated this revision to Diff 479213. VitaNuo added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139087/new/ https://reviews.llvm.org/D139087 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp clang-to

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo marked 4 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } kadircet wrote: >

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 479216. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments, remove excessive tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D13

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo updated this revision to Diff 479319. VitaNuo added a comment. Handle pointer and reference types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139087/new/ https://reviews.llvm.org/D139087 Files: clang-tools-extra/include-cleaner/lib/Wa

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo updated this revision to Diff 479339. VitaNuo added a comment. Refactor QualType to RecordDecl logic into a separate function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139087/new/ https://reviews.llvm.org/D139087 Files: clang-tools-

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo updated this revision to Diff 479556. VitaNuo added a comment. Add more comments. Add unimplemented VisitCXXDependentScopeMemberExpr method with a FIXME comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139087/new/ https://reviews.llv

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:65 +Expr *BE = E->getBase()->IgnoreImpCasts(); +RecordDecl *RD = BE->getType()->getAsRecordDecl(); +report(E->getMemberLoc(), RD); --

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 505147. VitaNuo added a comment. Herald added a subscriber: ChuanqiXu. Re-work the patch to use include_cleaner::headersForSymbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144976/new/ https://reviews.llvm.

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1099 + trace::Span Tracer("Hover::maybeAddSymbolProviders"); + include_cleaner::walkUsed( + AST.getLocalTopLevelDecls(), MacroRefere

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 505460. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144976/new/ https://reviews.llvm.org/D144976 Files: clang

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo added a comment. thanks for the review! Comment at: clang-tools-extra/clangd/Hover.cpp:1094 +void maybeAddSymbolProviders(ParsedAST &AST, HoverInfo &HI, + std::optional UsedDecl, hokein wrote: > we can simplify the signatur

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 506132. VitaNuo marked 15 inline comments as done. VitaNuo added a comment. Address review comments, simplify test. Take care of main file as provider handling: - provider list [main-file,foo.h] and foo.h \#include'd - not show any providers on hover. - pro

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo added a comment. Thanks for the comments and the discussions! Comment at: clang-tools-extra/clangd/Hover.cpp:1118 + + for (const auto &H : Headers) { +if (H.kind() == include_cleaner::Header::Physical && hokein wrote: > now the for-range loop doesn

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 506141. VitaNuo added a comment. Finish the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clan

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 507034. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144976/new/ https://reviews.llvm.org/D144976 Files: clang-to

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo added a comment. Thanks for the review! Comment at: clang-tools-extra/clangd/Hover.cpp:1099 + const SourceManager &SM = AST.getSourceManager(); + llvm::SmallVector Headers = + include_cleaner::headersForSymbol(Sym, SM, AST.getPragmaIncludes()); h

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 507326. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-to

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1158 + const SourceManager &SM = AST.getSourceManager(); + std::set UsedSymbolNames; + include_cleaner::walkUsed( hokein wrote: > just want to check the intentio

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 507748. VitaNuo added a comment. Remove unrelated diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146727/new/ https://reviews.llvm.org/D146727 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-t

[PATCH] D144976: [clangd] Add provider info on symbol hover.

This revision was automatically updated to reflect the committed changes. VitaNuo marked 3 inline comments as done. Closed by commit rG2bececb8bed1: [clangd] Add provider info on symbol hover. (authored by VitaNuo). Changed prior to commit: https://reviews.llvm.org/D144976?vs=507034&id=507764#t

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 507793. VitaNuo marked 5 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-too

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1172 +include_cleaner::Includes ConvertedIncludes = +convertIncludes(SM, llvm::ArrayRef{Inc}); +for (const incl

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 508586. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments. Use spelling locations for macro arguments, and expansion locations for everything else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:382 -auto &Tokens = AST.getTokens(); -auto SpelledForExpanded = -Tokens.spelledForExpanded(Tokens.ex

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:380 +auto Loc = SM.getFileLoc(Ref.RefLocation); +auto Range = Lexer::makeFileCharRange( +CharSourceRange{SourceRange{Loc},

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 508645. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146727/new/ https://reviews.llvm.org/D146727 Files: clang-too

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 508648. VitaNuo added a comment. Format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146727/new/ https://reviews.llvm.org/D146727 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-extra/clan

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo added a comment. thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:380 +auto Loc = SM.getFileLoc(Ref.RefLocation); +auto Range = Lexer::makeFileCharRange( +CharSourceRange{SourceRange{Loc}, true}, SM, AST.getLan

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481f88853685: [clangd] Use expansion location for missing include diagnostics. (authored by VitaNuo). Changed prior to commit: https://reviews.llv

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508661. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-to

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1175 + +for (const include_cleaner::Header &H : Providers) { + if (!ConvertedIncludes.match(H).empty()) { kadircet wrote: > note that this will att

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508675. VitaNuo added a comment. Add a couple more macro test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-tools-extra/clangd/Hover.cpp cla

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508708. VitaNuo added a comment. Remove extra check (already done in walkUsed). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-tools-extra/clangd/Hove

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508948. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Herald added a subscriber: mgrang. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.l

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo added a comment. Thanks for the comments, see the updated version. Comment at: clang-tools-extra/clangd/Hover.cpp:1173 +if (Ref.RT != include_cleaner::RefType::Explicit || +UsedSymbolNames.find(getRefName(Ref)) != UsedSymbolNames.end()) + re

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 508975. VitaNuo added a comment. Smaller improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 508986. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd/un

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo updated this revision to Diff 508994. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146244/new/ https://reviews.llvm.org/D146244 Files: clang-too

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1175 + +for (const include_cleaner::Header &H : Providers) { + if (!ConvertedIncludes.match(H).empty()) { hokein wrote: > VitaNuo wrote: > > kadircet wrote: > > > note

[PATCH] D146244: [clangd] Show used symbols on #include line hover.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG655baae2af0b: [clangd] Show used symbols on #include line hover. (authored by VitaNuo). Changed prior to commit: https://reviews.llvm.org/D146244?

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo updated this revision to Diff 509010. VitaNuo added a comment. Use vscode command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-too

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 509015. VitaNuo added a comment. Remove redundant code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extr

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 509017. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra/clangd/un

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo updated this revision to Diff 509019. VitaNuo added a comment. Remove unrelated code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo updated this revision to Diff 509028. VitaNuo added a comment. Remove unneeded code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-t

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo updated this revision to Diff 509041. VitaNuo added a comment. Replace the used symbol computation impl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSP

[PATCH] D144862: Include highlighed, include on hover, code lense for used symbols

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repositor

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 501162. VitaNuo added a comment. Replace start with arrow for optional access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144976/new/ https://reviews.llvm.org/D144976 Files: clang-tools-extra/clangd/Hover

[PATCH] D145059: [clangd] Add support from showing used symbols on cross ref request

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D145075: [clangd] Show used symbol on include hover.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 502084. VitaNuo marked 23 inline comments as done. VitaNuo added a comment. Improve test coverage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tool

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thank you for all the thoughtful comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:414 + +std::string findResolvedPath(const include_cleaner::Header &SymProvider) { + std::string ResolvedPath; -

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503012. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-to

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:712 + for (auto *Inc : ConvertedIncludes.match(H)) { +if (Pragmas == nullptr || Pragmas->getPublic(Inc->Resolved).empty()) + Satisfie

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503033. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-too

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo added a comment. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503043. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-too

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503045. VitaNuo added a comment. Rebase to main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/clangd

[PATCH] D143496: [clangd] Add support for missing includes analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38b9fb5a129d: [clangd] Add support for missing includes analysis. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D145576: Re-land [clangd] Add support for missing includes analysis.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This reverts commit 2eb5ac99a76dbbf8ac68c53

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503315. VitaNuo added a comment. Try to fix windows build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/unittests/IncludeCleanerT

[PATCH] D143496: [clangd] Add support for missing includes analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46447e0ba2e3: Revert "Revert "Re-land [clangd] Add support for missing includes analysis."" (authored by VitaNuo). Changed prior to commit: https:

[PATCH] D145577: Re-land [clangd] Add support for missing includes analysis.

VitaNuo created this revision. Herald added subscribers: ChuanqiXu, kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This reverts commit fd8c9ef20a95

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503322. VitaNuo added a comment. Try another approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/

[PATCH] D143496: [clangd] Add support for missing includes analysis.

VitaNuo updated this revision to Diff 503335. VitaNuo added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143496/new/ https://reviews.llvm.org/D143496 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/clangd

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 504717. VitaNuo marked 14 inline comments as done. VitaNuo added a comment. Implement the most recent version from the design document: always show a single provider, whether directly included or not (as long as there is a provider). Address review comments.

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo added a comment. Thank you for the comments! I've implemented the new version as per the design doc, as well as did my best to address the review comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1093 +std::vector +collectMacroReferences(ParsedAST &AST) { + con

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 504720. VitaNuo added a comment. Rebase to main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144976/new/ https://reviews.llvm.org/D144976 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clang

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 532964. VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Herald added a subscriber: javed.absar. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/ https://revi

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:393-395 +const auto *FileEntry = SM.getFileEntryForID(FID); +for (const auto *Export : PI.getExporters(FileEntry, SM.getFileManager())) + return toURI(E

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 535740. VitaNuo marked 27 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/ https://reviews.llvm.org/D152900 Files: clang-to

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo added a comment. Thanks for comments! Comment at: clang-tools-extra/clangd/index/CanonicalIncludes.h:40 /// Adds a file-to-string mapping from \p ID to \p CanonicalPath. void addMapping(FileEntryRef Header, llvm::StringRef CanonicalPath); kadirc

[PATCH] D154068: [clangd] Don't show header for namespace decl in Hover

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154068/new/ https://reviews.llvm.org/D154068 __

[PATCH] D144862: Implement code lense for used symbols.

VitaNuo updated this revision to Diff 509633. VitaNuo added a comment. Use custom command. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-too

[PATCH] D144862: Implement code lense for used symbols.

VitaNuo updated this revision to Diff 509636. VitaNuo added a comment. Improve argument handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144862/new/ https://reviews.llvm.org/D144862 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cl

[PATCH] D147325: Implement cross reference request for #include lines.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510027. VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-to

[PATCH] D147325: Implement cross reference request for #include lines.

VitaNuo abandoned this revision. VitaNuo added a comment. Erroneously created patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147325/new/ https://reviews.llvm.org/D147325 ___ cfe-commits mailing lis

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510032. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Incl

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510036. VitaNuo added a comment. Remove extra formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510039. VitaNuo added a comment. Rename function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clan

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/XRefs.cpp:1348 + auto Loc = SM.getFileLoc(Ref.RefLocation); + for (const auto &H : Providers) { +auto MatchingIncludes = ConvertedMainFileIncludes.match(H);

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510042. VitaNuo added a comment. Simplify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Incl

[PATCH] D147044: [clangd] Implement cross reference request for #include lines.

VitaNuo updated this revision to Diff 510484. VitaNuo marked 5 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147044/new/ https://reviews.llvm.org/D147044 Files: clang-too

<    1   2   3   4   5   >