[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 542000. VitaNuo marked 9 inline comments as done. VitaNuo added a comment. Address the latest comment batch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/ https://reviews.llvm.org/D152900 Files:

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f7c7d4bdd7b: [clangd] Update symbol collector to use include-cleaner. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

VitaNuo updated this revision to Diff 544684. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156403/new/ https://reviews.llvm.org/D156403 Files: clang-tools-extr

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

VitaNuo updated this revision to Diff 544689. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156403/new/ https://reviews.llvm.org/D156403 Files: clang-tools-extra

[PATCH] D156403: [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c6a7b0045af: [clangd] Revert the symbol collector behavior to old pre-include-cleaner… (authored by VitaNuo). Repository: rG LLVM Github Monorepo

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo updated this revision to Diff 544751. VitaNuo marked 8 inline comments as done. VitaNuo added a comment. Address review comments. Update the action to trigger when source action is requested explicitly or from the preamble range. Add unit test. Repository: rG LLVM Github Monorepo CHA

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/refactor/tweaks/OrganizeImports.cpp:62 + const auto &SM = Inputs.AST->getSourceManager(); + std::set Spellings; + for (const auto &Missing : Findings.MissingIncludes) kadi

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo updated this revision to Diff 549443. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 Files: clang-too

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:122 llvm::DenseSet SeenSymbols; + std::string ResourceDir = HS->getHeaderSearchOpts().ResourceDir; // FIXME: Find a way to have less code duplication b

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:63 + bool shouldKeep(unsigned HashLineNumber) const; + bool shouldKeep(const FileEntry *FE) const; Why wouldn't you actually inline the implem

[PATCH] D156123: [include-cleaner] Unify always_keep with rest of the keep logic

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:248 + if (Top.SeenAtFile == SM.getMainFileID() && IncludedFile) +Out->ShouldKeep.insert(IncludedFile->getUniqueID()); } If I understand correctly, you sh

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156122/new/ https://reviews.llvm.org/D156122 __

[PATCH] D156123: [include-cleaner] Unify always_keep with rest of the keep logic

VitaNuo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156123/new/ https://reviews.llvm.org/D156123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D157093: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping.

VitaNuo created this revision. Herald added subscribers: carlosgalvezp, kadircet, arphaman, xazax.hun. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D157093: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d492766a8fb: [clangd][clang-tidy][stdlib] Add a missing symbol to the mapping. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D157256: [clangd][clang-tidy][std_symbol_map] Add missing symbol.

VitaNuo created this revision. VitaNuo added a reviewer: kadircet. Herald added subscribers: carlosgalvezp, arphaman, xazax.hun. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Rep

[PATCH] D157256: [clangd][clang-tidy][std_symbol_map] Add missing symbol.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a5c0ccee293: [clangd][clang-tidy][std_symbol_map] Add missing symbol. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D157390: [clang-tidy][include-cleaner] Add option to control deduplication of findings per symbol

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.h:48 + // Whether emit only one finding per usage of a symbol. + const bool EmitOnce; llvm::S

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157395 Fi

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548204. VitaNuo added a comment. Remove accidental comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548217. VitaNuo added a comment. Remove the preferred header hint for exporters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files: clang-tools-extra/include-cl

[PATCH] D157400: [include-cleaner] Dont boost private headers beyond public ones

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thanks. Comment at: clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp:474 + Inputs.ExtraFiles["bar.h"] = + guard(R"cpp(#include "foo.h" // IWYU pragma:

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548540. VitaNuo added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/D157395 Files: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

VitaNuo updated this revision to Diff 548546. VitaNuo added a comment. Add a test with private headers involved. Order of exporters is from outermost to innermost. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157395/new/ https://reviews.llvm.org/

[PATCH] D157395: [include-cleaner] Follow `IWYU pragma: export` links transitively.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc3ad4b763602: [include-cleaner] Follow `IWYU pragma: export` links transitively. (authored by VitaNuo). Changed prior to commit: https://reviews.l

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo created this revision. Herald added subscribers: PiotrZSL, kadircet, carlosgalvezp, arphaman, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

This revision was automatically updated to reflect the committed changes. Closed by commit rG64366d4935d3: [clangd] Rollforward include-cleaner library usage in symbol collector. (authored by VitaNuo). Changed prior to commit: https://reviews.llvm.org/D156659?vs=556135&id=556396#toc Repository

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo marked 10 inline comments as done. VitaNuo added a comment. Thank you for the comments! Comment at: clang-tools-extra/clangd/ClangdServer.cpp:752 auto Action = [File = File.str(), Sel, TweakID = TweakID.str(), - CB = std::move(CB), + C

[PATCH] D159498: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D159498: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo updated this revision to Diff 556531. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159498/new/ https://reviews.llvm.org/D159498 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo marked 2 inline comments as done. VitaNuo added a comment. I'm sorry I think the upload failed because I tried to upload without a message or something, and I didn't notice that it failed :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo updated this revision to Diff 556532. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153769/new/ https://reviews.llvm.org/D153769 Files: clang-too

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo added a comment. I think I also managed to update the wrong patch. Not sure how an alternative patch got created in the first place :( Sorry for the mess, should be fine now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153769/new/ https:

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Respond to comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/OrganizeImports.cpp:56 +return false; + Range PreambleRange; + PreambleRange.start = kadircet wrote: > VitaNuo wro

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

VitaNuo updated this revision to Diff 539121. VitaNuo added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154962/new/ https://reviews.llvm.org/D154962 Files: clang-tools-extra/clangd/Headers.cpp Index: clang-tools-e

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154962/new/ https://reviews.llvm.org/D154962 ___ cfe-commits mailing list cfe-comm

[PATCH] D154962: [clangd] Use canonical path as resolved path for includes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7322f2d5ed54: [clangd] Use canonical path as resolved path for includes. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo marked 19 inline comments as done. VitaNuo added a comment. Thank you! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:839 + if (!Headers.empty()) +SymbolProviders.insert({S.ID, Headers[0]}); } kadircet wrote: > once we have the opt

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 539908. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/ https://reviews.llvm.org/D152900 Files: clang-too

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D155217: [clang-tidy][include-cleaner] Don't warn for the same symbol twice

VitaNuo added a comment. Hi Alex, Thank you for the patch. We are aware that issuing one diagnostic per symbol reference might be overwhelming. However, we have decided to choose it over other options after considering the use cases that we'd like to cover. This check is intended to be used in

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo updated this revision to Diff 540321. VitaNuo added a comment. Re-use the logic from include cleaner in clangd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155215/new/ https://reviews.llvm.org/D155215 Files: clang-tools-extra/clangd/In

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo updated this revision to Diff 540385. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155215/new/ https://reviews.llvm.org/D155215 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155215/new/ https://reviews.llvm.org/D155215 ___ cfe-commits mail

[PATCH] D155215: [clangd] Fix the range for include reference to itself.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96e50797d6ea: [clangd] Fix the range for include reference to itself. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo updated this revision to Diff 555985. VitaNuo added a comment. Fix analysis test to properly recognize the resource directory. Use HeaderSearch->getModuleMap().BuiltinDir to find out the resource directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the help in resolving the resource dir issues! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 ___

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo updated this revision to Diff 555995. VitaNuo added a comment. Rebase to current main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 Files: clang-tools-extra/clang-tidy/misc/IncludeCleanerChec

[PATCH] D159462: [clangd][clang-tidy] Add missing symbols to the symbol map.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman, xazax.hun. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https

[PATCH] D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D159463 Fi

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo updated this revision to Diff 556004. VitaNuo marked 5 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 Files: clang-too

[PATCH] D159463: [include-cleaner] Map the 4-argument move overload to the algorithm header.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd71adebb9fb8: [include-cleaner] Map the 4-argument move overload to the algorithm header. (authored by VitaNuo). Repository: rG LLVM Github Monore

[PATCH] D159462: [clangd][clang-tidy] Add missing symbols to the symbol map.

This revision was automatically updated to reflect the committed changes. Closed by commit rG625891288087: [clangd][clang-tidy] Add missing symbols to the symbol map. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159462/new/ h

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo updated this revision to Diff 556127. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 Files: clang-too

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

VitaNuo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157610/new/ https://reviews.llvm.org/D157610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D157610: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include-cleaner analysis.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43c20367f417: [include-cleaner][clangd][clang-tidy] Ignore resource dir during include… (authored by VitaNuo). Repository: rG LLVM Github Monorepo

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:912 +if (Directives & Symbol::Import) { + if (auto IncludeHeader = HeaderFileURIs->getIncludeHeader(FID); + !IncludeHeader.empty()) { kadircet wrote: >

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo updated this revision to Diff 556130. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 Files: clang-tools-e

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:919 + if (IncludeHeader.empty()) +HeaderFileURIs->getIncludeHeader(FID); + kadircet wrote: > i guess LHS of the as

[PATCH] D156659: [clangd] Rollforward include-cleaner library usage in symbol collector.

VitaNuo updated this revision to Diff 556135. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156659/new/ https://reviews.llvm.org/D156659 Files: clang-tools-extr

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Records macro references in #ifdef clauses as ambiguous. Repository: rG LLVM Github Monorepo https://review

[PATCH] D138564: Format changes with clang-format

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138564 Files: clang-tools-extra/include-clea

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477461. VitaNuo added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp clang-tools-extra/

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477549. VitaNuo added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp clang-tools-extra

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477551. VitaNuo added a comment. Remove the extra test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp cl

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477554. VitaNuo added a comment. Make explicit RefType default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477707. VitaNuo added a comment. Add support for #if defined(X), #elifdef, #elifndef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/includ

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477711. VitaNuo added a comment. Address review comments. Format and simplify code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:95 private: - void recordMacroRef(const Token &Tok, const MacroInfo &MI) { + void recordMacroRef(const Token &Tok, const MacroInfo &MI, RefType RT) { if (MI.isBuiltinMacro()) -

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:248 + SourceManager &SM = AST.sourceManager(); + ASSERT_THAT(Recorded.MacroReferences, Not(IsEmpty())); + hokein wrote: > nit: this can be removed, as the EXPE

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477716. VitaNuo added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp clang-tools-e

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477721. VitaNuo added a comment. Add -std=c++2b argument to avoid compiler warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/includ

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:249 + + Inputs.Code = MainFile.code(); + auto AST = build(); hokein wrote: > The `elifndef` and `elifdef` is a C++2b extension feature, so > `Inputs.ExtraArgs

[PATCH] D138559: Record macro references in #ifdef clause.

VitaNuo updated this revision to Diff 477722. VitaNuo added a comment. Simplify test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138559/new/ https://reviews.llvm.org/D138559 Files: clang-tools-extra/include-cleaner/lib/Record.cpp clang-tool

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Save file IDs of IWYU private headers and report them as private. Repository: rG LLVM Github Monorepo https

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477874. VitaNuo added a comment. Herald added a subscriber: kadircet. Improve the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477876. VitaNuo added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-include-clea

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477940. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-inc

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo marked 4 inline comments as done. VitaNuo added a comment. The formatting has introduced a bit of unrelated diff. It's not much, so I hope that's fine. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:95 + /// Contains all files ma

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477944. VitaNuo marked an inline comment as done. VitaNuo added a comment. Fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/inclu

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477946. VitaNuo added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477954. VitaNuo added a comment. Small refactoring. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-include-c

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:237 + auto *FE = SM.getFileEntryForID(SM.getFileID(Range.getBegin())); + if (!FE) { +return false; kadircet wro

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477956. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Fix build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/inclu

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477958. VitaNuo added a comment. Fix history. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 477960. VitaNuo added a comment. Apply the local changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-inc

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 478145. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address the remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: cl

[PATCH] D138678: [include-cleaner] Capture private headers in PragmaIncludes.

VitaNuo updated this revision to Diff 478148. VitaNuo added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138678/new/ https://reviews.llvm.org/D138678 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Reco

[PATCH] D138782: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Keep the includes contained between IWYU begin_keep and end_keep pragmas.

[PATCH] D138782: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo updated this revision to Diff 478166. VitaNuo added a comment. Remove unnecessary code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138782/new/ https://reviews.llvm.org/D138782 Files: clang-tools-extra/include-cleaner/lib/Record.cpp

[PATCH] D138782: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Record.cpp:299 + } else if (Pragma->starts_with("end_keep")) { +InsidePragmaKeepBlock = false; + } hokein wrote: > using a simple variable is not enough to handle t

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Implement support for begin_keep/end_keep pragmas. Repository: rG LLVM

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo updated this revision to Diff 478203. VitaNuo added a comment. Add a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138797/new/ https://reviews.llvm.org/D138797 Files: clang-tools-extra/include-cleaner/lib/Record.cpp clang-tool

[PATCH] D138821: Remove filtering from UsingDecl visit.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Removes filtering from the VisitUsingDecl method for implementation files.

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo updated this revision to Diff 478256. VitaNuo added a comment. Address review comments. Use annotation points instead of line numbers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138797/new/ https://reviews.llvm.org/D138797 Files: clan

[PATCH] D138797: [include-cleaner] Implement IWYU begin_keep/end_keep pragma support.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/RecordTest.cpp:349 EXPECT_TRUE(PI.shouldKeep(3)); + EXPECT_FALSE(PI.shouldKeep(13)); + EXPECT_TRUE(PI.shouldKeep(14)); hokein wro

<    1   2   3   4   5   >