r339955 - [InstrProf] Use atomic profile counter updates for TSan

Author: vedantk Date: Thu Aug 16 15:24:47 2018 New Revision: 339955 URL: http://llvm.org/viewvc/llvm-project?rev=339955&view=rev Log: [InstrProf] Use atomic profile counter updates for TSan Thread sanitizer instrumentation fails to skip all loads and stores to profile counters. This can happen if

r339964 - Relax a CHECK line to allow for dso_local

Author: vedantk Date: Thu Aug 16 16:19:50 2018 New Revision: 339964 URL: http://llvm.org/viewvc/llvm-project?rev=339964&view=rev Log: Relax a CHECK line to allow for dso_local Fixes a bot failure: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/11806 Modified:

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

Hi Eric, I think there might be a cyclic dependency issue here, possibly one that's only visible with LLVM_ENABLE_MODULES=On. I see: While building module 'Clang_Tooling' imported from /Users/vsk/src/llvm.org-master/llvm/tools/clang/lib/Tooling/Execution.cpp:10: Wh

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

I wiped my build directory, updated to r332734 and rebuilt, but hit the same error while building check-clang. For completeness, I did: $ cmake -G Ninja /Users/vsk/src/llvm.org-master/llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=On -DCLANG_ENABLE_ARCMT=Off -DCLANG_ ENABLE_STATIC_ANA

Re: r332720 - Move #include manipulation code to new lib/Tooling/Inclusions.

> On May 18, 2018, at 11:48 AM, Eric Liu wrote: > > So I have reverted this with r332751. Thanks! > I can't see how this introduced cyclic dependencies in module build, as the > dependencies should be clangTooling -> clangFormat -> clangToolingInclusions. > I'm wondering if there is any modu

r314749 - [ubsan] Save a ptrtoint when emitting alignment checks

Author: vedantk Date: Mon Oct 2 18:27:24 2017 New Revision: 314749 URL: http://llvm.org/viewvc/llvm-project?rev=314749&view=rev Log: [ubsan] Save a ptrtoint when emitting alignment checks The alignment check emits a ptrtoint instruction which can be reused in the call to the diagnostic handler.

r314750 - [ubsan] Add helpers to decide when null/vptr checks are required. NFC.

Author: vedantk Date: Mon Oct 2 18:27:25 2017 New Revision: 314750 URL: http://llvm.org/viewvc/llvm-project?rev=314750&view=rev Log: [ubsan] Add helpers to decide when null/vptr checks are required. NFC. Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp cfe/trunk/lib/CodeGen/CodeGenFunction.h

r314751 - [ubsan] Save the result of getLLVMContext. NFC.

Author: vedantk Date: Mon Oct 2 18:27:26 2017 New Revision: 314751 URL: http://llvm.org/viewvc/llvm-project?rev=314751&view=rev Log: [ubsan] Save the result of getLLVMContext. NFC. Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp Modified: cfe/trunk/lib/CodeGen/CGExpr.cpp URL: http://llvm.org/vi

r314752 - [ubsan] Skip alignment checks which are folded away

Author: vedantk Date: Mon Oct 2 18:27:26 2017 New Revision: 314752 URL: http://llvm.org/viewvc/llvm-project?rev=314752&view=rev Log: [ubsan] Skip alignment checks which are folded away Don't emit alignment checks which the IR constant folder throws away. I've tested this out on X86FastISel.cpp.

r315142 - [Driver] Fix -static-libsan / -shared-libsan on Darwin

Author: vedantk Date: Fri Oct 6 18:42:09 2017 New Revision: 315142 URL: http://llvm.org/viewvc/llvm-project?rev=315142&view=rev Log: [Driver] Fix -static-libsan / -shared-libsan on Darwin Don't ignore these flags on Darwin. The old behavior of using the dynamic runtime when neither flag is passe

r315518 - [Driver] Export symbols needed to use profile runtime

Author: vedantk Date: Wed Oct 11 14:54:09 2017 New Revision: 315518 URL: http://llvm.org/viewvc/llvm-project?rev=315518&view=rev Log: [Driver] Export symbols needed to use profile runtime Apple's API verification tool (tapi) checks that the symbols exported from a program match a whitelist. When

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

n Tue, Sep 12, 2017 at 5:05 PM Vedant Kumar via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: vedantk > Date: Tue Sep 12 17:04:35 2017 > New Revision: 313096 > > URL: http://llvm.org/viewvc/llvm-project?rev=313096&view=rev > <http://llvm.org

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

; Hi Vedant, >> >> So this actually broke -fsanitize=function on linux. Han is working up a >> testcase for it, but letting you know for now that we'll probably need some >> change here. >> >> -eric >> >> On Tue, Sep 12, 2017 at 5:05 PM Ved

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

vedant > >> >> vedant >> >> >>> On Oct 13, 2017, at 1:33 PM, Eric Christopher >> <mailto:echri...@gmail.com>> wrote: >>> >>> Hi Vedant, >>> >>> So this actually broke -fsanitize=function on linux. Han is worki

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

> Thanks! > > -eric > > vedant > >> >> Thanks! >> >> -eric >> >> vedant >> >>> >>> vedant >>> >>> >>>> On Oct 13, 2017, at 1:33 PM, Eric Christopher >>> <mailto:echri...@

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

he *-sections options there. I'm not sure whether that's what > caused the failure, but the extra coverage couldn't hurt :). I would do it > myself but I don't have a Linux machine to test on. > > vedant > >> >> While we figure that out here&

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

sing -ffunction-sections, using data-sections, >>> etc). Basically I'm not sure why this would work on some Linux setups but >>> not others. >>> >>> >>> Definitely using the latter two options and gold as a linker. I'll see what &g

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

;>>>> Appreciated :) >>>>> >>>>> Basically we were getting an error of: >>>>> >>>>> error: Cannot represent a difference across sections >>>>> >>>>> trying to compile things with the current co

r315786 - [ubsan] Don't emit function signatures for non-static member functions

Author: vedantk Date: Fri Oct 13 18:23:30 2017 New Revision: 315786 URL: http://llvm.org/viewvc/llvm-project?rev=315786&view=rev Log: [ubsan] Don't emit function signatures for non-static member functions The function sanitizer only checks indirect calls through function pointers. This excludes a

Re: r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

gt; compiler-rt but we could have missing coverage there. >>>>>>> >>>>>>> The original version of this patch restricted the prologue data changes >>>>>>> to Darwin only. We can switch back to that easily, just let me know. >>>>>

r315979 - [Coverage] Explicitly mark the l.h.s of && and || (fixes PR33465)

Author: vedantk Date: Mon Oct 16 23:51:54 2017 New Revision: 315979 URL: http://llvm.org/viewvc/llvm-project?rev=315979&view=rev Log: [Coverage] Explicitly mark the l.h.s of && and || (fixes PR33465) This makes it possible to view sub-line region counts for the l.h.s of && and || expressions in c

r315982 - [Coverage] Discard deferred region in closing if-else

Author: vedantk Date: Tue Oct 17 00:47:39 2017 New Revision: 315982 URL: http://llvm.org/viewvc/llvm-project?rev=315982&view=rev Log: [Coverage] Discard deferred region in closing if-else A trailing deferred region isn't necessary in a function that ends with this pattern: ... else { ...

r340558 - [options] Document -(static|shared)-libsan

Author: vedantk Date: Thu Aug 23 10:54:48 2018 New Revision: 340558 URL: http://llvm.org/viewvc/llvm-project?rev=340558&view=rev Log: [options] Document -(static|shared)-libsan Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Driver/Options.td URL: http:

r340559 - [docs] Regenerate ClangCommandLineReference.rst

Author: vedantk Date: Thu Aug 23 10:55:03 2018 New Revision: 340559 URL: http://llvm.org/viewvc/llvm-project?rev=340559&view=rev Log: [docs] Regenerate ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst

r340849 - [ubsan] Enable -fsanitize=vptr on Apple devices and simulators

Author: vedantk Date: Tue Aug 28 11:01:42 2018 New Revision: 340849 URL: http://llvm.org/viewvc/llvm-project?rev=340849&view=rev Log: [ubsan] Enable -fsanitize=vptr on Apple devices and simulators It seems like an oversight that this check was not always enabled for on-device or device simulator

r341985 - [gcov] Update a clang test for r341977

Author: vedantk Date: Tue Sep 11 12:42:58 2018 New Revision: 341985 URL: http://llvm.org/viewvc/llvm-project?rev=341985&view=rev Log: [gcov] Update a clang test for r341977 Update test/CodeGen/code-coverage.c so that it doesn't refer to a gcov function which is no longer emitted after r341977. F

r342194 - [Sema] Remove location from implicit capture init expr

Author: vedantk Date: Thu Sep 13 16:28:25 2018 New Revision: 342194 URL: http://llvm.org/viewvc/llvm-project?rev=342194&view=rev Log: [Sema] Remove location from implicit capture init expr A lambda's closure is initialized when the lambda is declared. For implicit captures, the initialization cod

[clang-tools-extra] r342195 - Update a clang-tidy test for r342194

Author: vedantk Date: Thu Sep 13 16:50:20 2018 New Revision: 342195 URL: http://llvm.org/viewvc/llvm-project?rev=342195&view=rev Log: Update a clang-tidy test for r342194 The location of implicit captures has changed. Update a use-after-move checker test to reflect that. This fixes a bot failure

r342196 - Relax alignment assumptions in a test after r342194

Author: vedantk Date: Thu Sep 13 17:16:37 2018 New Revision: 342196 URL: http://llvm.org/viewvc/llvm-project?rev=342196&view=rev Log: Relax alignment assumptions in a test after r342194 Don't hardcode align 8. Fixes a bot failure: http://lab.llvm.org:8011/builders/clang-cmake-armv8-full/builds/6

Re: r337928 - [OPENMP] Fix PR38256: Fix locations of the artificial conditional op.

Thanks! Just out of curiosity, what is the "omp_outlined" function you're checking for? Is it implicitly-defined? If it's not user-visible, i.e it doesn't actually appear in the source code of a program, why should we generate a code coverage mapping for it at all? vedant > On Jul 25, 2018, a

Re: r337928 - [OPENMP] Fix PR38256: Fix locations of the artificial conditional op.

Ah, great. Thanks again! vedant > On Jul 25, 2018, at 10:33 AM, Alexey Bataev wrote: > > This is visible to the user, the statement under #pragma omp parallel > directive is outlined as a function. > - > Best regards, > Alexey Bataev > 25.07.2018 13:31, Vedant Kumar пишет: >> Thank

r324527 - [clang-import-test] Run clang-format, NFC

Author: vedantk Date: Wed Feb 7 13:17:22 2018 New Revision: 324527 URL: http://llvm.org/viewvc/llvm-project?rev=324527&view=rev Log: [clang-import-test] Run clang-format, NFC I ran across clang-import-test while looking into testing for lldb. There shouldn't be any harm in running clang-format o

r325319 - [Coverage] Handle break/continue outside of loop bodies

Author: vedantk Date: Thu Feb 15 23:59:43 2018 New Revision: 325319 URL: http://llvm.org/viewvc/llvm-project?rev=325319&view=rev Log: [Coverage] Handle break/continue outside of loop bodies Teach the coverage mapping logic to handle break or continue statements within for loop increments. Fixes

Re: [clang-tools-extra] r303977 - [clangd] Allow to use vfs::FileSystem for file accesses.

Hi Ilya, The unit test introduced by this commit hits an assertion failure on our bots. Could you please take a look at the issue? lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/6733 I see: [ RUN ]

Re: r304201 - [ARM] Fix Neon vector type alignment to 64-bit

Hi, I think this change is responsible for a tablgen failure in stage2 builds: http://green.lab.llvm.org/green/job/clang-stage2-configure-Rthinlto_build/2171/ > On May 30, 2017, at 4:59 AM, Diana Picus via cfe

[libcxx] r304450 - Remove ubsan XFAILS in two tests

Author: vedantk Date: Thu Jun 1 13:48:27 2017 New Revision: 304450 URL: http://llvm.org/viewvc/llvm-project?rev=304450&view=rev Log: Remove ubsan XFAILS in two tests These two tests are ubsan-clean now: http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/3553/ Modified: libcx

r304459 - [ubsan] Add a check for pointer overflow UB

Author: vedantk Date: Thu Jun 1 14:22:18 2017 New Revision: 304459 URL: http://llvm.org/viewvc/llvm-project?rev=304459&view=rev Log: [ubsan] Add a check for pointer overflow UB Check pointer arithmetic for overflow. For some more background on this check, see: https://wdtz.org/catching-point

[libcxx] r304462 - Mark two coroutine tests as unsupported under ubsan

Author: vedantk Date: Thu Jun 1 15:00:40 2017 New Revision: 304462 URL: http://llvm.org/viewvc/llvm-project?rev=304462&view=rev Log: Mark two coroutine tests as unsupported under ubsan They appear to crash inside of SelectionDAG on some Linux bots, when ubsan is enabled. https://bugs.llvm.org/s

r304463 - [Modules] Handle sanitizer feature mismatches when importing modules

Author: vedantk Date: Thu Jun 1 15:01:01 2017 New Revision: 304463 URL: http://llvm.org/viewvc/llvm-project?rev=304463&view=rev Log: [Modules] Handle sanitizer feature mismatches when importing modules This patch makes it an error to have a mismatch between the enabled sanitizers in a CU, and in

Re: r304459 - [ubsan] Add a check for pointer overflow UB

t; > Thanks > > Galina > > On Thu, Jun 1, 2017 at 12:22 PM, Vedant Kumar via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: vedantk > Date: Thu Jun 1 14:22:18 2017 > New Revision: 304459 > > URL: http://llvm.org/viewvc/llvm-project

r304486 - Relax test to try and appease builders. NFC.

Author: vedantk Date: Thu Jun 1 17:27:39 2017 New Revision: 304486 URL: http://llvm.org/viewvc/llvm-project?rev=304486&view=rev Log: Relax test to try and appease builders. NFC. I'm not sure why, but on some bots, the order of two instructions are swapped (as compared to the output on my machine

Re: r304459 - [ubsan] Add a check for pointer overflow UB

I checked in r304486 to try and address the issue. thanks, vedant > On Jun 1, 2017, at 3:21 PM, Vedant Kumar via cfe-commits > wrote: > > Taking a look. > > vedant > >> On Jun 1, 2017, at 2:45 PM, Galina Kistanova > <mailto:gkistan...@gmail.com>>

[libcxx] r304580 - Revert "Mark two coroutine tests as unsupported under ubsan"

Author: vedantk Date: Fri Jun 2 13:30:16 2017 New Revision: 304580 URL: http://llvm.org/viewvc/llvm-project?rev=304580&view=rev Log: Revert "Mark two coroutine tests as unsupported under ubsan" This reverts commit r304462, thereby re-enabling two tests under ubsan. We expect these tests to pass

[libcxx] r304591 - Mark two coroutine tests as unsupported under ubsan, again

Author: vedantk Date: Fri Jun 2 15:06:49 2017 New Revision: 304591 URL: http://llvm.org/viewvc/llvm-project?rev=304591&view=rev Log: Mark two coroutine tests as unsupported under ubsan, again This reverts commit r304580, making bool_await_suspend.pass.cpp and generator.pass.cpp unsupported on ub

Re: [libcxx] r304591 - Mark two coroutine tests as unsupported under ubsan, again

Hi Gor, This is just a heads-up that I tried re-enabling ubsan for the two tests affected by PR33271, but saw some similar failures. The commit message below has more details about what was tested and what went wrong. best, vedant > On Jun 2, 2017, at 1:06 PM, Vedant Kumar via cfe-comm

Re: [libcxx] r304591 - Mark two coroutine tests as unsupported under ubsan, again

Hm, sorry, the compiler on the bot could not have picked up r304518, so I jumped the gun here. I'll try again later and report back in PR33271. vedant > On Jun 2, 2017, at 1:09 PM, Vedant Kumar via cfe-commits > wrote: > > Hi Gor, > > This is just a heads-up that I

r305216 - [ubsan] Detect invalid unsigned pointer index expression (clang)

Author: vedantk Date: Mon Jun 12 13:42:51 2017 New Revision: 305216 URL: http://llvm.org/viewvc/llvm-project?rev=305216&view=rev Log: [ubsan] Detect invalid unsigned pointer index expression (clang) Adding an unsigned offset to a base pointer has undefined behavior if the result of the expression

Re: [PATCH] D33910: [ubsan] Detect invalid unsigned pointer index expression (clang)

> On Jun 12, 2017, at 12:34 PM, Eli Friedman via Phabricator > wrote: > > efriedma added inline comments. > > > > Comment at: cfe/trunk/lib/CodeGen/CGExprScalar.cpp:2666 > + bool isSigned = > indexOperand->getType()->isSignedIntegerOrEnumerationType(); > + bool mayHaveNega

r305269 - [docs] Add some ubsan changes to the release notes

Author: vedantk Date: Mon Jun 12 21:52:31 2017 New Revision: 305269 URL: http://llvm.org/viewvc/llvm-project?rev=305269&view=rev Log: [docs] Add some ubsan changes to the release notes Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/v

r305546 - [ubsan] PR33081: Skip the standard type checks for volatile

Author: vedantk Date: Thu Jun 15 22:27:36 2017 New Revision: 305546 URL: http://llvm.org/viewvc/llvm-project?rev=305546&view=rev Log: [ubsan] PR33081: Skip the standard type checks for volatile Skip checks for null dereference, alignment violation, object size violation, and dynamic type violatio

r305568 - [ubsan] docs: Add a note about pointers to volatile

Author: vedantk Date: Fri Jun 16 13:38:43 2017 New Revision: 305568 URL: http://llvm.org/viewvc/llvm-project?rev=305568&view=rev Log: [ubsan] docs: Add a note about pointers to volatile Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Modified: cfe/trunk/docs/UndefinedBehaviorSanitize

r305743 - [docs] Coverage: document issue with the BFD linker

Author: vedantk Date: Mon Jun 19 16:22:05 2017 New Revision: 305743 URL: http://llvm.org/viewvc/llvm-project?rev=305743&view=rev Log: [docs] Coverage: document issue with the BFD linker Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst

r305745 - [docs] Coverage: Improve the wording a bit

Author: vedantk Date: Mon Jun 19 16:26:04 2017 New Revision: 305745 URL: http://llvm.org/viewvc/llvm-project?rev=305745&view=rev Log: [docs] Coverage: Improve the wording a bit Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst URL: htt

r306163 - [ubsan] Improve diagnostics for return value checks (clang)

Author: vedantk Date: Fri Jun 23 16:32:38 2017 New Revision: 306163 URL: http://llvm.org/viewvc/llvm-project?rev=306163&view=rev Log: [ubsan] Improve diagnostics for return value checks (clang) This patch makes ubsan's nonnull return value diagnostics more precise, which makes the diagnostics mor

r306181 - [ubsan] Disable the object size check at -O0

Author: vedantk Date: Fri Jun 23 18:15:24 2017 New Revision: 306181 URL: http://llvm.org/viewvc/llvm-project?rev=306181&view=rev Log: [ubsan] Disable the object size check at -O0 This check currently isn't able to diagnose any issues at -O0, not is it likely to [1]. Disabling the check at -O0 lea

r306183 - Add a warning to a group

Author: vedantk Date: Fri Jun 23 18:34:32 2017 New Revision: 306183 URL: http://llvm.org/viewvc/llvm-project?rev=306183&view=rev Log: Add a warning to a group Add warn_drv_object_size_disabled_O0 to the invalid command line argument group. This should fix some bot failures: lab.llvm.org:8011/

r320902 - [CodeGen] Specialize mixed-sign mul-with-overflow (fix PR34920)

Author: vedantk Date: Fri Dec 15 17:28:25 2017 New Revision: 320902 URL: http://llvm.org/viewvc/llvm-project?rev=320902&view=rev Log: [CodeGen] Specialize mixed-sign mul-with-overflow (fix PR34920) This patch introduces a specialized way to lower overflow-checked multiplications with mixed-sign o

r321231 - [ubsan] Diagnose noreturn functions which return

Author: vedantk Date: Wed Dec 20 16:10:25 2017 New Revision: 321231 URL: http://llvm.org/viewvc/llvm-project?rev=321231&view=rev Log: [ubsan] Diagnose noreturn functions which return Diagnose 'unreachable' UB when a noreturn function returns. 1. Insert a check at the end of functions marked no

r321230 - [Driver] Ensure no overlap between trapping & recoverable sanitizers. NFC.

Author: vedantk Date: Wed Dec 20 16:10:24 2017 New Revision: 321230 URL: http://llvm.org/viewvc/llvm-project?rev=321230&view=rev Log: [Driver] Ensure no overlap between trapping & recoverable sanitizers. NFC. This is NFC because in EmitCheck(), -fsanitize-trap=X overrides -fsanitize-recover=X. M

Re: r321395 - [ODRHash] Support ODR violation detection in functions.

Oops, the build log was too big to attach. Resending with just the bot link, then: http://lab.llvm.org:8080/green/view/Experimental/job/clang-stage2-coverage-R/2193/consoleText vedant > On Jan 3, 20

r321771 - [CGBuiltin] Handle unsigned mul overflow properly (PR35750)

Author: vedantk Date: Wed Jan 3 15:11:32 2018 New Revision: 321771 URL: http://llvm.org/viewvc/llvm-project?rev=321771&view=rev Log: [CGBuiltin] Handle unsigned mul overflow properly (PR35750) r320902 fixed the IRGen for some types of checked multiplications. It did not handle unsigned overflow

[libcxx] r327064 - Low-hanging fruit optimization in string::__move_assign().

Author: vedantk Date: Thu Mar 8 13:15:26 2018 New Revision: 327064 URL: http://llvm.org/viewvc/llvm-project?rev=327064&view=rev Log: Low-hanging fruit optimization in string::__move_assign(). shrink_to_fit() ends up doing a lot work to get information that we already know since we just called cl

r327317 - Check that ubsan is the only supported sanitizer on OpenBSD

Author: vedantk Date: Mon Mar 12 12:18:51 2018 New Revision: 327317 URL: http://llvm.org/viewvc/llvm-project?rev=327317&view=rev Log: Check that ubsan is the only supported sanitizer on OpenBSD Patch by David Carlier! Differential Revision: https://reviews.llvm.org/D44069 Modified: cfe/trun

r333609 - [Coverage] Discard the last uncompleted deferred region in a decl

Author: vedantk Date: Wed May 30 16:35:44 2018 New Revision: 333609 URL: http://llvm.org/viewvc/llvm-project?rev=333609&view=rev Log: [Coverage] Discard the last uncompleted deferred region in a decl Discard the last uncompleted deferred region in a decl, if one exists. This prevents lines at the

r333715 - [Coverage] End deferred regions before labels, fixes PR35867

Author: vedantk Date: Thu May 31 17:37:13 2018 New Revision: 333715 URL: http://llvm.org/viewvc/llvm-project?rev=333715&view=rev Log: [Coverage] End deferred regions before labels, fixes PR35867 A deferred region should end before the start of a label, and should not extend to the start of the la

r333775 - [Coverage] Remove a test dependency on the itanium ABI

Author: vedantk Date: Fri Jun 1 10:11:18 2018 New Revision: 333775 URL: http://llvm.org/viewvc/llvm-project?rev=333775&view=rev Log: [Coverage] Remove a test dependency on the itanium ABI This should address a bot failure: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/

r350952 - [MergeFunc] Update clang test for r350939

Author: vedantk Date: Fri Jan 11 10:51:02 2019 New Revision: 350952 URL: http://llvm.org/viewvc/llvm-project?rev=350952&view=rev Log: [MergeFunc] Update clang test for r350939 In r350939, the MergeFunc pass learned to erase duplicate functions which are discardable if unused. Modified: cfe/t

r346276 - [Darwin] Export new weak external symbols when compiling with coverage

Author: vedantk Date: Tue Nov 6 14:25:00 2018 New Revision: 346276 URL: http://llvm.org/viewvc/llvm-project?rev=346276&view=rev Log: [Darwin] Export new weak external symbols when compiling with coverage Some weak external symbols were added to the profile runtime in D49953, and on Darwin, these

r347262 - [Coverage] Fix PR39258: support coverage regions that start deeper than they end

Author: vedantk Date: Mon Nov 19 12:10:22 2018 New Revision: 347262 URL: http://llvm.org/viewvc/llvm-project?rev=347262&view=rev Log: [Coverage] Fix PR39258: support coverage regions that start deeper than they end popRegions used to assume that the start location of a region can't be nested deep

r347261 - [Sema] Fix PR38987: keep end location of a direct initializer list

Author: vedantk Date: Mon Nov 19 12:10:21 2018 New Revision: 347261 URL: http://llvm.org/viewvc/llvm-project?rev=347261&view=rev Log: [Sema] Fix PR38987: keep end location of a direct initializer list If PerformConstructorInitialization of a direct initializer list constructor is called while ins

r347803 - [Coverage] Do not visit artificial stmts in defaulted methods (PR39822)

Author: vedantk Date: Wed Nov 28 12:48:07 2018 New Revision: 347803 URL: http://llvm.org/viewvc/llvm-project?rev=347803&view=rev Log: [Coverage] Do not visit artificial stmts in defaulted methods (PR39822) There is no reason to emit coverage mappings for artificial statements contained within def

r347804 - [Coverage] Specify the Itanium ABI triple for a C++ test

Author: vedantk Date: Wed Nov 28 12:51:09 2018 New Revision: 347804 URL: http://llvm.org/viewvc/llvm-project?rev=347804&view=rev Log: [Coverage] Specify the Itanium ABI triple for a C++ test Modified: cfe/trunk/test/CoverageMapping/default-method.cpp Modified: cfe/trunk/test/CoverageMapping/

r348187 - [gcov/Darwin] Ensure external symbols are exported when using an export list

Author: vedantk Date: Mon Dec 3 12:53:58 2018 New Revision: 348187 URL: http://llvm.org/viewvc/llvm-project?rev=348187&view=rev Log: [gcov/Darwin] Ensure external symbols are exported when using an export list Make sure that symbols needed to implement runtime support for gcov are exported when

r357501 - [os_log] Mark os_log_helper `nounwind`

Author: vedantk Date: Tue Apr 2 10:42:38 2019 New Revision: 357501 URL: http://llvm.org/viewvc/llvm-project?rev=357501&view=rev Log: [os_log] Mark os_log_helper `nounwind` Allow the optimizer to remove unnecessary EH cleanups surrounding calls to os_log_helper, to save some code size. As a foll

r343883 - [DebugInfo] Add support for DWARF5 call site-related attributes

Author: vedantk Date: Fri Oct 5 13:37:17 2018 New Revision: 343883 URL: http://llvm.org/viewvc/llvm-project?rev=343883&view=rev Log: [DebugInfo] Add support for DWARF5 call site-related attributes DWARF v5 introduces DW_AT_call_all_calls, a subprogram attribute which indicates that all calls (bo

r311787 - [Frontend] Fix printing policy for AST context loaded from file

Author: vedantk Date: Fri Aug 25 11:07:03 2017 New Revision: 311787 URL: http://llvm.org/viewvc/llvm-project?rev=311787&view=rev Log: [Frontend] Fix printing policy for AST context loaded from file In ASTUnit::LoadFromASTFile, the context object is set up using default-constructed LangOptions (wh

r312818 - [Coverage] Precise region termination with deferred regions (reapply)

Author: vedantk Date: Fri Sep 8 11:44:56 2017 New Revision: 312818 URL: http://llvm.org/viewvc/llvm-project?rev=312818&view=rev Log: [Coverage] Precise region termination with deferred regions (reapply) The current coverage implementation doesn't handle region termination very precisely. Take fo

r312947 - [Lexer] Report more precise skipped regions (PR34166)

Author: vedantk Date: Mon Sep 11 13:47:42 2017 New Revision: 312947 URL: http://llvm.org/viewvc/llvm-project?rev=312947&view=rev Log: [Lexer] Report more precise skipped regions (PR34166) This patch teaches the preprocessor to report more precise source ranges for code that is skipped due to cond

[clang-tools-extra] r312948 - [pp-trace] Update skipped source ranges in tests

Author: vedantk Date: Mon Sep 11 13:47:45 2017 New Revision: 312948 URL: http://llvm.org/viewvc/llvm-project?rev=312948&view=rev Log: [pp-trace] Update skipped source ranges in tests Depends on D36642 Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp clang-tools-extra/tru

r312957 - [ubsan-minimal] Document the new runtime

Author: vedantk Date: Mon Sep 11 14:37:05 2017 New Revision: 312957 URL: http://llvm.org/viewvc/llvm-project?rev=312957&view=rev Log: [ubsan-minimal] Document the new runtime Differential Revision: https://reviews.llvm.org/D37647 Modified: cfe/trunk/docs/ReleaseNotes.rst cfe/trunk/docs/U

r312958 - [Driver] Support ubsan-minimal on Darwin

Author: vedantk Date: Mon Sep 11 14:37:06 2017 New Revision: 312958 URL: http://llvm.org/viewvc/llvm-project?rev=312958&view=rev Log: [Driver] Support ubsan-minimal on Darwin Make it possible to use the minimal ubsan runtime on Darwin. Differential Revision: https://reviews.llvm.org/D37649 Modi

r313062 - [ubsan] Extend default blacklist support to integer/nullability groups

Author: vedantk Date: Tue Sep 12 11:58:00 2017 New Revision: 313062 URL: http://llvm.org/viewvc/llvm-project?rev=313062&view=rev Log: [ubsan] Extend default blacklist support to integer/nullability groups The default blacklist should also apply when the integer or nullability checks are enabled.

r313065 - [Driver] Darwin: Link in the profile runtime archive first

Author: vedantk Date: Tue Sep 12 12:15:31 2017 New Revision: 313065 URL: http://llvm.org/viewvc/llvm-project?rev=313065&view=rev Log: [Driver] Darwin: Link in the profile runtime archive first While building a project with code coverage enabled, we can link in dependencies which export a weak def

r313087 - [Driver] Disable uwtable by default in -ffreestanding mode

Author: vedantk Date: Tue Sep 12 15:51:53 2017 New Revision: 313087 URL: http://llvm.org/viewvc/llvm-project?rev=313087&view=rev Log: [Driver] Disable uwtable by default in -ffreestanding mode We make the same decision when compiling the kernel or kexts -- we should do this in -ffreestanding mode

r313096 - [ubsan] Function Sanitizer: Don't require writable text segments

Author: vedantk Date: Tue Sep 12 17:04:35 2017 New Revision: 313096 URL: http://llvm.org/viewvc/llvm-project?rev=313096&view=rev Log: [ubsan] Function Sanitizer: Don't require writable text segments This change will make it possible to use -fsanitize=function on Darwin and possibly on other platf

r313098 - Tighten up a test case. NFC.

Author: vedantk Date: Tue Sep 12 17:04:36 2017 New Revision: 313098 URL: http://llvm.org/viewvc/llvm-project?rev=313098&view=rev Log: Tighten up a test case. NFC. Modified: cfe/trunk/test/CodeGenCXX/catch-undef-behavior.cpp Modified: cfe/trunk/test/CodeGenCXX/catch-undef-behavior.cpp URL: h

r313099 - [ubsan] Enable -fsanitize=function on Darwin

Author: vedantk Date: Tue Sep 12 17:04:36 2017 New Revision: 313099 URL: http://llvm.org/viewvc/llvm-project?rev=313099&view=rev Log: [ubsan] Enable -fsanitize=function on Darwin https://reviews.llvm.org/D37598 Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst cfe/trunk/lib/Driver/

r313446 - Remove comment accidentally committed with D36642. NFC.

Author: vedantk Date: Fri Sep 15 23:26:51 2017 New Revision: 313446 URL: http://llvm.org/viewvc/llvm-project?rev=313446&view=rev Log: Remove comment accidentally committed with D36642. NFC. Modified: cfe/trunk/lib/Lex/PPDirectives.cpp Modified: cfe/trunk/lib/Lex/PPDirectives.cpp URL: http:/

r313598 - [Coverage] Use a new API to label gap areas

Author: vedantk Date: Mon Sep 18 16:37:30 2017 New Revision: 313598 URL: http://llvm.org/viewvc/llvm-project?rev=313598&view=rev Log: [Coverage] Use a new API to label gap areas This will make it possible for llvm-cov to pick better line execution counts, and is part of the fix for llvm.org/PR346

r313603 - [Coverage] Remove deferred region for trailing return, fixes PR34611

Author: vedantk Date: Mon Sep 18 17:29:46 2017 New Revision: 313603 URL: http://llvm.org/viewvc/llvm-project?rev=313603&view=rev Log: [Coverage] Remove deferred region for trailing return, fixes PR34611 As a special case, throw away deferred regions for trailing returns. This allows the closing c

r314002 - [Coverage] Add an option to emit limited coverage info

Author: vedantk Date: Fri Sep 22 11:23:04 2017 New Revision: 314002 URL: http://llvm.org/viewvc/llvm-project?rev=314002&view=rev Log: [Coverage] Add an option to emit limited coverage info Add an option to emit limited coverage info for unused decls. It's just a cl::opt for now to allow us to exp

r314013 - [lit.cfg] Avoid concatenating which(clang-func-mapping) if it's missing

Author: vedantk Date: Fri Sep 22 11:42:28 2017 New Revision: 314013 URL: http://llvm.org/viewvc/llvm-project?rev=314013&view=rev Log: [lit.cfg] Avoid concatenating which(clang-func-mapping) if it's missing This un-breaks a lit workflow where you run lit tests from a test sub-directory within clan

r314036 - [test] Enable clang-func-mapping as a test dep with the analyzer

Author: vedantk Date: Fri Sep 22 15:17:10 2017 New Revision: 314036 URL: http://llvm.org/viewvc/llvm-project?rev=314036&view=rev Log: [test] Enable clang-func-mapping as a test dep with the analyzer clang-func-mapping should not be a test dependency when the static analyzer isn't being built. Mo

r365809 - [CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC

Author: vedantk Date: Thu Jul 11 12:11:46 2019 New Revision: 365809 URL: http://llvm.org/viewvc/llvm-project?rev=365809&view=rev Log: [CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC Replace a `llvm::Function *` parameter with a bool, which seems harder to set to the wrong value by acciden

r365814 - Revert "[CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC"

Author: vedantk Date: Thu Jul 11 12:28:07 2019 New Revision: 365814 URL: http://llvm.org/viewvc/llvm-project?rev=365814&view=rev Log: Revert "[CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC" This reverts commit 1af41074445229fea66b99710a850e5f42ecfa95. Modified: cfe/trunk/lib/CodeGen

r366744 - [Driver] Set the default win32-macho debug format to DWARF

Author: vedantk Date: Mon Jul 22 14:46:45 2019 New Revision: 366744 URL: http://llvm.org/viewvc/llvm-project?rev=366744&view=rev Log: [Driver] Set the default win32-macho debug format to DWARF rdar://53267670 Differential Revision: https://reviews.llvm.org/D65116 Modified: cfe/trunk/lib/Dri

r367269 - [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627)

Author: vedantk Date: Mon Jul 29 15:49:55 2019 New Revision: 367269 URL: http://llvm.org/viewvc/llvm-project?rev=367269&view=rev Log: [DebugInfo] Don't emit incorrect descriptions of thunk params (PR42627) The `this` parameter of a thunk requires adjustment. Stop emitting an incorrect dbg.declare

r367270 - [docs] Add a note about where UBSan emits logs

Author: vedantk Date: Mon Jul 29 15:54:43 2019 New Revision: 367270 URL: http://llvm.org/viewvc/llvm-project?rev=367270&view=rev Log: [docs] Add a note about where UBSan emits logs Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst Modified: cfe/trunk/docs/UndefinedBehaviorSanitizer.rst

r365716 - [CGDebugInfo] Fix -femit-debug-entry-values crash on os_log_helpers

Author: vedantk Date: Wed Jul 10 17:09:16 2019 New Revision: 365716 URL: http://llvm.org/viewvc/llvm-project?rev=365716&view=rev Log: [CGDebugInfo] Fix -femit-debug-entry-values crash on os_log_helpers An os_log_helper FunctionDecl may not have a body. Ignore these for the purposes of debug entry

Re: r364424 - [clang/DIVar] Emit the flag for params that have unmodified value

Hi Djordje, Just a heads-up that I’ve landed r365716 to fix a crash in a stage2 build of AppleClang with -femit-debug-entry-values enabled. I went ahead and landed the fix as it seemed simple enough. Let me know if you have any concerns. Thanks, Vedant > On Jun 26, 2019, at 6:32 AM, Djordje T

  1   2   3   4   5   6   >