[PATCH] D32724: [Modules] Include the enabled sanitizers in the module hash

vsk added a comment. Offline, @aprantl mentioned a concern about module hashes being required for correctness. I'm not sure whether this is OK or not (@bruno, any thoughts?). AFAICT there are items included in the module hash that, were they removed, would break implicit module builds (e.g '-DF

[PATCH] D32724: [Modules] Include the enabled sanitizers in the module hash

vsk added a comment. In https://reviews.llvm.org/D32724#749868, @dexonsmith wrote: > In https://reviews.llvm.org/D32724#747728, @aprantl wrote: > > > Is it the right solution to use the module hash for correctness, or should > > the mismatch of the serialized langopts trigger a module rebuild an

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

vsk updated this revision to Diff 98343. vsk retitled this revision from "[Modules] Include the enabled sanitizers in the module hash" to "[Modules] Handle sanitizer feature mismatches when importing modules". vsk edited the summary of this revision. vsk added a comment. If compatible difference

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

vsk updated this revision to Diff 98349. vsk marked 7 inline comments as done. vsk added a comment. Add a comment explaining how and why ASTReader checks for sanitizer feature mismatches. https://reviews.llvm.org/D32724 Files: include/clang/Basic/Sanitizers.h lib/Basic/LangOptions.cpp li

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

vsk updated this revision to Diff 98363. vsk added a comment. I've uploaded the correct diff this time, sorry for the confusion. https://reviews.llvm.org/D32724 Files: include/clang/Basic/Sanitizers.h lib/Basic/LangOptions.cpp lib/Frontend/CompilerInvocation.cpp lib/Serialization/ASTRea

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

vsk updated this revision to Diff 98371. vsk marked 2 inline comments as done. vsk added a comment. Address comments from Adrian. (I settled on renaming 'getModularSanitizers' to 'getPPTransparentSanitizers'.) https://reviews.llvm.org/D32724 Files: include/clang/Basic/Sanitizers.h lib/Basi

[PATCH] D30949: [CodeGen] Add an option to enable LLVM IR linting

vsk abandoned this revision. vsk added a comment. I'll try doing this some other way, maybe with optimization remarks. https://reviews.llvm.org/D30949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

vsk added a comment. Ping. https://reviews.llvm.org/D32842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D33305: [ubsan] Add a check for pointer overflow UB

vsk created this revision. Herald added a subscriber: krytarowski. Check pointer arithmetic for overflow. For some more background on this check, see: https://wdtz.org/catching-pointer-overflow-bugs.html https://reviews.llvm.org/D20322 Patch by Will Dietz and John Regehr! This version of t

[PATCH] D33305: [ubsan] Add a check for pointer overflow UB

vsk added a comment. Thanks for the comments, responses inline -- Comment at: lib/CodeGen/CGExprScalar.cpp:3854 + const Twine &Name) { + Value *GEPVal = Builder.CreateInBoundsGEP(Ptr, IdxList, Name); + filcab wrote

[PATCH] D32842: Specify which sanitizers are covered by a sanitizer blacklist

vsk added a subscriber: george.karpenkov. vsk added a comment. Ping. (@george.karpenkov, do you have the time to take a look?) https://reviews.llvm.org/D32842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D32724: [Modules] Handle sanitizer feature mismatches when importing modules

vsk added a comment. Ping. https://reviews.llvm.org/D32724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. This looks great, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101000/new/ https://reviews.llvm.org/D101000 ___ cfe-commits mailing lis

[PATCH] D101000: Coverage: Document how to collect a profile without a filesystem

vsk added a subscriber: efriedma. vsk added a comment. Thanks for doing this! + Eli to comment on whether any workarounds documented in https://lists.llvm.org/pipermail/llvm-dev/2017-September/117156.html are still necessary. To my knowledge it's not currently necessary to explicitly pass -mll

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

vsk updated this revision to Diff 315472. vsk added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a clang driver test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94324/new/ https://reviews.llvm.org/D94324

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

vsk updated this revision to Diff 315473. vsk added a comment. Fix a typo in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94324/new/ https://reviews.llvm.org/D94324 Files: clang/test/Driver/sigpipe-handling.c llvm/include/llvm/Suppo

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

vsk updated this revision to Diff 315498. vsk added a comment. Reduce the test a bit further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94324/new/ https://reviews.llvm.org/D94324 Files: clang/test/Driver/sigpipe-handling.c llvm/include/llv

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

vsk added a comment. In D94324#2487572 , @aganea wrote: > What are the exact conditions to repro Nick's failure? On Fedora 32, I ran > `py llvm-lit sigpipe-handling.c` before this patch and before > rGbf401256edd00e921a5d3a0bf4cf6ee66ae51cd6 >

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

This revision was automatically updated to reflect the committed changes. Closed by commit rGe05baf40de8a: [InitLLVM] Ensure SIGPIPE handler installed before sigaction() (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94324/new/ htt

[PATCH] D94820: Support for instrumenting only selected files or functions

vsk added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:851 +return "csllvm"; + default: +llvm_unreachable("unknown instrumentation type"); If we add an instrumentation kind, it may be more convenient to trigger a -Wcove

[PATCH] D111793: [Driver][Darwin] Use T reference instead of getToolChain().getTriple().

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111793/new/ https://reviews.llvm.org/D111793

<    2   3   4   5   6   7