[clang] [clang-repl][CMake][MSVC] Use LINKER: instead of `-Wl` (PR #118518)

https://github.com/vgvassilev approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/118518 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] fix error recovery while parsing completely fails (PR #127087)

https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/127087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] fix error recovery while parsing completely fails (PR #127087)

https://github.com/vgvassilev approved this pull request. Lgtm! Thank you, @Vipul-Cariappa! https://github.com/llvm/llvm-project/pull/127087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

@@ -2639,6 +2628,19 @@ void Sema::MergeTypedefNameDecl(Scope *S, TypedefNameDecl *New, notePreviousDefinition(Old, New->getLocation()); } +void Sema::CleanupMergedEnum(Scope *S, Decl *New) { vgvassilev wrote: I realize that `Sema::ActOnDuplicateDefinition`

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

@@ -2551,18 +2551,7 @@ void Sema::MergeTypedefNameDecl(Scope *S, TypedefNameDecl *New, // Make the old tag definition visible. makeMergedDefinitionVisible(Hidden); - // If this was an unscoped enumeration, yank all of its enumerators - // out of the scop

[clang] [clang-repl] Fix error recovery while PTU cleanup (PR #127467)

@@ -114,6 +114,13 @@ TEST_F(InterpreterTest, Errors) { RecoverErr = Interp->Parse("var1 = 424;"); EXPECT_TRUE(!!RecoverErr); + + Err = Interp->Parse("int x = 5; auto capture = [&]() { return x * 2; };").takeError(); vgvassilev wrote: There is no such a

[clang] [clang-repl] Fix error recovery while PTU cleanup (PR #127467)

@@ -114,6 +114,13 @@ TEST_F(InterpreterTest, Errors) { RecoverErr = Interp->Parse("var1 = 424;"); EXPECT_TRUE(!!RecoverErr); + + Err = Interp->Parse("int x = 5; auto capture = [&]() { return x * 2; };").takeError(); vgvassilev wrote: Can we move this te

[clang] [clang-repl] Fix error recovery while PTU cleanup (PR #127467)

@@ -178,8 +178,8 @@ void IncrementalParser::CleanUpPTU(TranslationUnitDecl *MostRecentTU) { if (!ND) continue; // Check if we need to clean up the IdResolver chain. -if (ND->getDeclName().getFETokenInfo() && !D->getLangOpts().ObjC && -!D->getLangOpts(

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

@@ -571,11 +571,8 @@ StmtResult Parser::ParseExprStatement(ParsedStmtContext StmtCtx) { } Token *CurTok = nullptr; - // If the semicolon is missing at the end of REPL input, consider if - // we want to do value printing. Note this is only enabled in C++ mode - // since

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

https://github.com/vgvassilev approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/114240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

vgvassilev wrote: Please rebase this PR. https://github.com/llvm/llvm-project/pull/114240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Disable EmulatedTLS on Windows for interpreter executor (PR #127468)

vgvassilev wrote: Our local windows expert is @bellenot. Maybe he can help us out here. https://github.com/llvm/llvm-project/pull/127468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix error recovery while PTU cleanup (PR #127467)

@@ -1,7 +1,8 @@ // REQUIRES: host-supports-jit // UNSUPPORTED: system-aix // RUN: cat %s | clang-repl | FileCheck %s -// RUN: cat %s | clang-repl -Xcc -O2 | FileCheck %s +// RUN: cat %s | not clang-repl -Xcc -Xclang -Xcc -verify -Xcc -O2 | FileCheck %s vgvassi

[clang] [modules] Add missing test file for b21ee08e57173102b67bc18237b135550 (PR #129221)

https://github.com/vgvassilev approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/129221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add `pragma clang scope [push|pop]` (PR #121025)

vgvassilev wrote: I wonder if we had an rfc for this. Maybe we should solicit some feedback before moving forward with this extension. https://github.com/llvm/llvm-project/pull/121025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [clang-repl] Fix error recovery while PTU cleanup (PR #127467)

https://github.com/vgvassilev approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/127467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix target creation in Wasm.cpp (PR #130909)

https://github.com/vgvassilev approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/130909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix error recovery while PTU cleanup (PR #127467)

@@ -14,4 +15,13 @@ auto r2 = l2(); auto r3 = l2(); // CHECK: TWO -%quit +// Verify non-local lambda capture error is correctly reported +int x = 42; + +// expected-error {{non-local lambda expression cannot have a capture-default}} +auto capture = [&]() { return x * 2; }; + --

[clang] [Serialization] Fix lazy template loading (PR #133057)

vgvassilev wrote: > > > While I may not able to look into them in detail recently, it may be > > > helpful to split this into seperate patches to review and to land. > > > > > > I initially considered this, but @vgvassilev said in > > [root-project/root#17722 > > (comment)](https://github.co

[clang] [clang-repl] Implement LoadDynamicLibrary for clang-repl wasm use cases (PR #133037)

@@ -711,6 +712,14 @@ llvm::Error Interpreter::Undo(unsigned N) { } llvm::Error Interpreter::LoadDynamicLibrary(const char *name) { +#ifdef __EMSCRIPTEN__ + void *handle = dlopen(name, RTLD_NOW | RTLD_GLOBAL); + if (!handle) { +llvm::errs() << dlerror() << '\n'; +retu

[clang] [Serialization] Fix lazy template loading (PR #133057)

vgvassilev wrote: @ilya-biryukov, would you mind giving this PR a test on your infrastructure and if it works maybe share some performance results? https://github.com/llvm/llvm-project/pull/133057 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [Serialization] Fix lazy template loading (PR #133057)

vgvassilev wrote: > > > > > While I may not able to look into them in detail recently, it may be > > > > > helpful to split this into seperate patches to review and to land. > > > > > > > > > > > > I initially considered this, but @vgvassilev said in > > > > [root-project/root#17722 > > > >

[clang] [clang-repl] Implement LoadDynamicLibrary for clang-repl wasm use cases (PR #133037)

vgvassilev wrote: > > We really need to figure out how to add in-tree tests. > > Yupp sadly I was only able to test this through cppinterop and xeus-cpp as > I've commented above ([#133037 > (comment)](https://github.com/llvm/llvm-project/pull/133037#discussion_r2015819533)) > where it works

[clang] [Serialization] Fix lazy template loading (PR #133057)

vgvassilev wrote: > The small-scale benchmarks we had show 10% improvement in CPU and 23% > improvement in memory usage for some compilations! That's very good news. I think we can further reduce these times. IIRC, we still deserialize declarations that we do not need. One of the places to loo

[clang] [clang-repl] Implement LoadDynamicLibrary for clang-repl wasm use cases (PR #133037)

vgvassilev wrote: We really need to figure out how to add in-tree tests. https://github.com/llvm/llvm-project/pull/133037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix error recovery while PTU cleanup (PR #127467)

https://github.com/vgvassilev approved this pull request. Lgtm! https://github.com/llvm/llvm-project/pull/127467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Define LLVM_ABI and CLANG_ABI for __EMSCRIPTEN__ builds (PR #131578)

https://github.com/vgvassilev milestoned https://github.com/llvm/llvm-project/pull/131578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    5   6   7   8   9   10