[clang] [llvm] Update llvm::Registry to work for LLVM shared library builds on windows (PR #109024)

2024-10-15 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/109024 >From 983e3e9efb3a090d1ef4c232a2912d3abc9ffdf4 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Wed, 28 Aug 2024 16:08:52 +0100 Subject: [PATCH 1/8] Update llvm::Registry to work for LLVM shared library

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-08 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,67 @@ +//===-- clang/Support/Compiler.h - Compiler abstraction support -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-10-02 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/110154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-02 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. Looks good to me, too. We can wait a couple of more days for @AaronBallman to have the final say. https://github.com/llvm/llvm-project/pull/108276 ___ cfe-commits mailing list cfe-commits@lists

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-02 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/108276 >From 3c19f9edb391988c180b6a2dd35198b7b95e2144 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Tue, 10 Sep 2024 02:22:18 +0100 Subject: [PATCH 1/6] [Clang] Add explicit visibility symbol macros and updat

[clang] b8882be - Revert "Update llvm::Registry to work for LLVM shared library builds on windows (#109024)"

2024-10-15 Thread Vassil Vassilev via cfe-commits
Author: Vassil Vassilev Date: 2024-10-16T06:03:45Z New Revision: b8882be26f00d2a053269948ee6ecaeff8db8eb8 URL: https://github.com/llvm/llvm-project/commit/b8882be26f00d2a053269948ee6ecaeff8db8eb8 DIFF: https://github.com/llvm/llvm-project/commit/b8882be26f00d2a053269948ee6ecaeff8db8eb8.diff LO

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-10-18 Thread Vassil Vassilev via cfe-commits
@@ -13,246 +13,40 @@ #include "IncrementalParser.h" #include "clang/AST/DeclContextInternals.h" -#include "clang/CodeGen/BackendUtil.h" -#include "clang/CodeGen/CodeGenAction.h" -#include "clang/CodeGen/ModuleBuilder.h" #include "clang/Frontend/CompilerInstance.h" -#include "

[clang] [Clang][ASTMatchers] Add visibility macros to variables declared by macros (PR #110206)

2024-10-20 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/110206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tools-extra] Fix add_clang_library usage (PR #109321)

2024-10-07 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/109321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-07 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/108276 >From fff6064a63ddf85857ea5036333866317a156ffc Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Tue, 10 Sep 2024 02:22:18 +0100 Subject: [PATCH 1/6] [Clang] Add explicit visibility symbol macros and updat

[clang] Clang tooling generated visibility macros for Clang (PR #109702)

2024-10-22 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @efriedma-quic, @rnk, @compnerd, @AaronBallman can we make another round of review here? https://github.com/llvm/llvm-project/pull/109702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-14 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/108276 >From d598242a9e938153a106b421c9b0f69139e192f3 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Tue, 10 Sep 2024 02:22:18 +0100 Subject: [PATCH 1/9] [Clang] Add explicit visibility symbol macros and updat

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-14 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: Unless there is more discussion or comments worth addressing I'd propose to merge this PR in the next day or two as it is a bottleneck for a few others in the pipeline. https://github.com/llvm/llvm-project/pull/108276 ___ cfe-commit

[clang] [Clang][ASTMatchers] Add visibility macros to variables declared by macros (PR #110206)

2024-10-14 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/110206 >From bf2a9fe2d755adc8dfdd43418e15c35cf912edca Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Thu, 26 Sep 2024 21:23:50 +0100 Subject: [PATCH] [Clang][ASTMatchers] Add visibility macros to variables de

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-10-14 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/109362 >From 12b2bd669a46590247e5bd6ac8c76dc61529f331 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Mon, 8 Jul 2024 01:48:46 +0100 Subject: [PATCH 1/2] [Clang][TableGen] Add explicit symbol visibility macros

[clang] [llvm] Update llvm::Registry to work for LLVM shared library builds on windows (PR #109024)

2024-10-14 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/109024 >From beef0d9f53f05c31041677101577929281e908b1 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Wed, 28 Aug 2024 16:08:52 +0100 Subject: [PATCH 1/7] Update llvm::Registry to work for LLVM shared library

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-14 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/108276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-22 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/108051 >From 7761ab1ad8eee08fa86aba04e89f7aab5064cb4f Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Sat, 7 Sep 2024 15:53:09 +0100 Subject: [PATCH 1/5] [llvm] Support llvm::Any across shared libraries on win

[clang] [clang-tools-extra] [flang] [llvm] Reland 'Update llvm::Registry to work for LLVM shared library builds on windows' (#109024) (PR #112640)

2024-10-22 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/112640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-22 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @ymand, is your concern resolved? https://github.com/llvm/llvm-project/pull/108051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix undefined lld::wasm::link symbol while building clangInterpreter for wasm (PR #113446)

2024-10-24 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. Unfortunately this feature is only tested externally... LGTM! https://github.com/llvm/llvm-project/pull/113446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [clang-repl] Fix undefined lld::wasm::link symbol while building clangInterpreter for wasm (PR #113446)

2024-10-24 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/113446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Nominate Vassil Vassilev for Modules and Plugins (PR #114058)

2024-10-29 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. I accept the nomination. Thank you! https://github.com/llvm/llvm-project/pull/114058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-11-04 Thread Vassil Vassilev via cfe-commits
@@ -13,246 +13,40 @@ #include "IncrementalParser.h" #include "clang/AST/DeclContextInternals.h" -#include "clang/CodeGen/BackendUtil.h" -#include "clang/CodeGen/CodeGenAction.h" -#include "clang/CodeGen/ModuleBuilder.h" #include "clang/Frontend/CompilerInstance.h" -#include "

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-11-05 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/109362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-11-02 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @fsfod, can you rebase? https://github.com/llvm/llvm-project/pull/109362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][TableGen] Add explicit symbol visibility macros to code generated (PR #109362)

2024-11-02 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @AaronBallman, ping. https://github.com/llvm/llvm-project/pull/109362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl][CUDA] Move CUDA module registration to beginning of global_ctors (PR #66658)

2024-10-28 Thread Vassil Vassilev via cfe-commits
@@ -794,7 +794,7 @@ void CodeGenModule::Release() { AddGlobalCtor(ObjCInitFunction); if (Context.getLangOpts().CUDA && CUDARuntime) { if (llvm::Function *CudaCtorFunction = CUDARuntime->finalizeModule()) - AddGlobalCtor(CudaCtorFunction); + AddGlobalCtor(C

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-11 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/110418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-10-23 Thread Vassil Vassilev via cfe-commits
@@ -13,246 +13,40 @@ #include "IncrementalParser.h" #include "clang/AST/DeclContextInternals.h" -#include "clang/CodeGen/BackendUtil.h" -#include "clang/CodeGen/CodeGenAction.h" -#include "clang/CodeGen/ModuleBuilder.h" #include "clang/Frontend/CompilerInstance.h" -#include "

[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-23 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/108051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-10 Thread Vassil Vassilev via cfe-commits
@@ -47,6 +78,58 @@ static llvm::cl::opt OptHostSupportsJit("host-supports-jit", static llvm::cl::list OptInputs(llvm::cl::Positional, llvm::cl::desc("[code to run]")); +static llvm::Error sanitizeOopArguments(const char *ArgV0) { +

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-10 Thread Vassil Vassilev via cfe-commits
@@ -34,10 +41,34 @@ LLVM_ATTRIBUTE_USED int __lsan_is_turned_off() { return 1; } #endif +#define DEBUG_TYPE "clang-repl" + static llvm::cl::opt CudaEnabled("cuda", llvm::cl::Hidden); static llvm::cl::opt CudaPath("cuda-path", llvm::cl::Hidden); static llvm::cl::opt OffloadA

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-12 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @SahilPatidar, can you revert if there is not an easy fix? https://github.com/llvm/llvm-project/pull/110418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-12 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > Ah, so it isn't failing only for me. Apparently, it blows away all the > environments where ORC is deliberately disabled. We probably need a `host-supports-oop-jit` similar to what we have in `host-supports-jit`... https://github.com/llvm/llvm-project/pull/110418 _

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-09-23 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/107737 >From d2096a6445b803a74bd8cb56653f4ca1791d1d9f Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Fri, 6 Sep 2024 09:52:36 + Subject: [PATCH 1/5] [clang-repl] Simplify the value printing logic to enable

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-09-23 Thread Vassil Vassilev via cfe-commits
@@ -39,11 +44,13 @@ class IncrementalCUDADeviceParser : public IncrementalParser { ~IncrementalCUDADeviceParser(); protected: - IncrementalParser &HostParser; + std::unique_ptr DeviceCI; int SMVersion; llvm::SmallString<1024> PTXCode; llvm::SmallVector FatbinCont

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-09-23 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/107737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-09-23 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/107737 >From 2aa7527b52656d064c39aec94c9f1001ed10f7d8 Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Fri, 6 Sep 2024 09:52:36 + Subject: [PATCH 1/5] [clang-repl] Simplify the value printing logic to enable

[clang] [Clang] Include the clang-shlib CMake project when building for MSVC (PR #109457)

2024-09-23 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @fsfod, do you have a clue what's going on here? I do not see how this could be related to the current PR. https://github.com/llvm/llvm-project/pull/109457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] [Clang] Include the clang-shlib CMake project when building for MSVC (PR #109457)

2024-09-22 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/109457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-09-22 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > > One thing I don't understand about this PR is why we need Compiler.h in > > Clang -- wouldn't the LLVM definitions in their Compiler.h work for Clang > > as well? (This would probably be worth explaining in the patch summary.) > > The symbol lookup in PE/COFF is two level

[clang] [clang] return first Decl for CanonicalDecl in TranslationUnitDecl (PR #110101)

2024-09-26 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: Can we add a unittest under clang/unittest/Interpreter? https://github.com/llvm/llvm-project/pull/110101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] return first Decl for CanonicalDecl in TranslationUnitDecl (PR #110101)

2024-09-27 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. Lgtm! https://github.com/llvm/llvm-project/pull/110101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] return first Decl for CanonicalDecl in TranslationUnitDecl (PR #110101)

2024-09-27 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/110101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-26 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/110154 >From 5658a272777a2e399dec39e7ad412bcb68d3090d Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Thu, 26 Sep 2024 18:59:33 +0100 Subject: [PATCH] [Clang] Update Interpreter tests to use clang_target_link_

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-26 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/110154 >From 2df58c48c063b162128f7826c5605f06f5684a7c Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Thu, 26 Sep 2024 18:59:33 +0100 Subject: [PATCH] [Clang] Update Interpreter tests to use clang_target_link_

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-26 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/110154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-27 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/110154 >From a9d8655d493e6de3b36ccd9f24fa8fefe17fbff6 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Thu, 26 Sep 2024 18:59:33 +0100 Subject: [PATCH] [Clang] Update Interpreter tests to use clang_target_link_

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-09-29 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/110154 >From 23e9dc99199c94f904a2f7b00bf6b463f469c8ad Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Thu, 26 Sep 2024 18:59:33 +0100 Subject: [PATCH] [Clang] Update Interpreter tests to use clang_target_link_

[clang-tools-extra] [clang-tools-extra] Fix add_clang_library usage (PR #109321)

2024-09-29 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/109321 >From cf06606f1d3db2e741a1ca14e84b724201ec14d7 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Thu, 19 Sep 2024 16:53:20 +0100 Subject: [PATCH] [clang-tools-extra] Fix add_clang_library usage If a add_c

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-09-29 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @compnerd, does this PR require more care at that stage or it is good to go? https://github.com/llvm/llvm-project/pull/108276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang-tools-extra] [clang-tools-extra] Fix add_clang_library usage (PR #109321)

2024-09-29 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. This change looks good to me. Let’s wait some more time for other reviewers before merging this. https://github.com/llvm/llvm-project/pull/109321 ___ cfe-commits mailing list cfe-commits@lists

[clang] [Clang] Change Attribute plugin to link clang-cpp like other examples (PR #109319)

2024-09-19 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/109319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Change Attribute plugin to link clang-cpp like other examples (PR #109319)

2024-09-19 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. This change looks reasonable to me. https://github.com/llvm/llvm-project/pull/109319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [clang-repl] Implement continuation for preprocessor directives. (PR #107552)

2024-09-20 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/107552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Simplify the value printing logic to enable out-of-process. (PR #107737)

2024-09-20 Thread Vassil Vassilev via cfe-commits
@@ -53,6 +53,7 @@ class MultiplexConsumer : public SemaConsumer { public: // Takes ownership of the pointers in C. MultiplexConsumer(std::vector> C); + MultiplexConsumer(std::unique_ptr C); vgvassilev wrote: Surprisingly we can’t do this unfortunately htt

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-10-01 Thread Vassil Vassilev via cfe-commits
@@ -702,10 +723,8 @@ llvm::Error Interpreter::LoadDynamicLibrary(const char *name) { if (!EE) return EE.takeError(); - auto &DL = EE->getDataLayout(); - - if (auto DLSG = llvm::orc::DynamicLibrarySearchGenerator::Load( - name, DL.getGlobalPrefix())) + if (au

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-10-01 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev commented: I'd feel more comfortable if @lhames takes a look, too. Can you run some benchmarks and compare in-process to out-of-process to out-of-process with shared memory (same architecture)? https://github.com/llvm/llvm-project/pull/110418 _

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-10-01 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/110418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-02 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/108276 >From b987a75b114d953a8c481363d5b726d08393d16b Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Tue, 10 Sep 2024 02:22:18 +0100 Subject: [PATCH 1/6] [Clang] Add explicit visibility symbol macros and updat

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-06 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,261 @@ +//===-- RemoteJITUtils.cpp - Utilities for remote-JITing *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-06 Thread Vassil Vassilev via cfe-commits
@@ -47,6 +76,59 @@ static llvm::cl::opt OptHostSupportsJit("host-supports-jit", static llvm::cl::list OptInputs(llvm::cl::Positional, llvm::cl::desc("[code to run]")); +static llvm::Error sanitizeOopArguments(const char *ArgV0) { +

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-06 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,263 @@ +//===-- RemoteJITUtils.cpp - Utilities for remote-JITing *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-06 Thread Vassil Vassilev via cfe-commits
@@ -47,6 +76,59 @@ static llvm::cl::opt OptHostSupportsJit("host-supports-jit", static llvm::cl::list OptInputs(llvm::cl::Positional, llvm::cl::desc("[code to run]")); +static llvm::Error sanitizeOopArguments(const char *ArgV0) { +

[clang] [llvm] [Clang-Repl] Add support for out-of-process execution. (PR #110418)

2024-11-06 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: Any chance in adding tests? https://github.com/llvm/llvm-project/pull/110418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix generation of wasm binaries while running clang-repl in browser (PR #117978)

2024-11-29 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. LGTM, with my suggestion. https://github.com/llvm/llvm-project/pull/117978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix generation of wasm binaries while running clang-repl in browser (PR #117978)

2024-11-29 Thread Vassil Vassilev via cfe-commits
@@ -69,27 +95,30 @@ llvm::Error WasmIncrementalExecutor::addModule(PartialTranslationUnit &PTU) { llvm::inconvertibleErrorCode()); } - OutputFile.close(); + ObjectFileOutput.close(); std::vector LinkerArgs = {"wasm-ld",

[clang] [clang-repl] Fix generation of wasm binaries while running clang-repl in browser (PR #117978)

2024-11-29 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev milestoned https://github.com/llvm/llvm-project/pull/117978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix generation of wasm binaries while running clang-repl in browser (PR #117978)

2024-11-29 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/117978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix generation of wasm binaries while running clang-repl in browser (PR #117978)

2024-11-29 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/117978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl]: Print stack-trace on crash (PR #117896)

2024-11-27 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. LGTM! Do you have commit access or shall I land this change for you? https://github.com/llvm/llvm-project/pull/117896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [clang-repl] Fix generation of wasm binaries while running clang-repl in browser (PR #117978)

2024-11-28 Thread Vassil Vassilev via cfe-commits
@@ -51,45 +76,50 @@ llvm::Error WasmIncrementalExecutor::addModule(PartialTranslationUnit &PTU) { llvm::TargetMachine *TargetMachine = Target->createTargetMachine( PTU.TheModule->getTargetTriple(), "", "", TO, llvm::Reloc::Model::PIC_); PTU.TheModule->setDataLayout(T

[clang] [clang-repl] Fix generation of wasm binaries while running clang-repl in browser (PR #117978)

2024-11-28 Thread Vassil Vassilev via cfe-commits
@@ -109,12 +139,12 @@ llvm::Error WasmIncrementalExecutor::runCtors() const { return llvm::Error::success(); } -llvm::Error WasmIncrementalExecutor::cleanUp() const { vgvassilev wrote: We should not need this change. https://github.com/llvm/llvm-project/pu

[clang] [clang-repl] Fix generation of wasm binaries while running clang-repl in browser (PR #117978)

2024-11-28 Thread Vassil Vassilev via cfe-commits
@@ -51,45 +76,50 @@ llvm::Error WasmIncrementalExecutor::addModule(PartialTranslationUnit &PTU) { llvm::TargetMachine *TargetMachine = Target->createTargetMachine( PTU.TheModule->getTargetTriple(), "", "", TO, llvm::Reloc::Model::PIC_); PTU.TheModule->setDataLayout(T

[clang] [clang-repl] Improve flags responsible for generating shared wasm binaries (PR #116735)

2024-11-19 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/116735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Include consistency using the default clang actions. (PR #116610)

2024-11-18 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev created https://github.com/llvm/llvm-project/pull/116610 This patch improves the code reuse of the actions system and adds several improvements for easier debugging via clang-repl --debug-only=clang-repl. The change inimproves the consistency of the TUKind when ac

[clang] [clang-repl] Include consistency using the default clang actions. (PR #116610)

2024-11-19 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/116610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Clang tooling generated visibility macros for Clang (PR #109702)

2024-11-15 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: A gentle ping on reviewing. https://github.com/llvm/llvm-project/pull/109702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-11-24 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: It is worth adding a test here. https://github.com/llvm/llvm-project/pull/117475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-11-25 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > I have added a test, but it should only run on Darwin (macOS) platforms. > > ```c++ > // REQUIRES: host-supports-jit > > // RUN: cat %s | env SDKROOT=$(xcrun --show-sdk-path) > DYLD_LIBRARY_PATH=%S/Inputs:$DYLD_LIBRARY_PATH clang-repl > > %lib vec.dylib > #include > std::

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-11-27 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/117475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-11-27 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/117475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-11-27 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,20 @@ +// REQUIRES: host-supports-jit, x86_64-linux + +// RUN: rm -rf %t +// RUN: mkdir -p %t +// +// RUN: split-file %s %t +// +// RUN: %clang++ -std=c++20 -fPIC -c %t/vec.cpp -o %t/vec.o +// RUN: %clang++ -shared %t/vec.o -o %t/vec.so +// +// RUN: cat %t/Test.cpp | LD

[clang] [clang-tools-extra] [clangd] Update clangDaemonTweaks to set symbol visibility macros (PR #112304)

2024-11-15 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @AaronBallman, can you help us move forward here? https://github.com/llvm/llvm-project/pull/112304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-11-25 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > I came across the following setup: > > ```c++ > // REQUIRES: host-supports-jit > > // RUN: rm -rf %t > // RUN: mkdir -p %t > // > // RUN: split-file %s %t > // > // RUN: %clang++ -std=c++20 -fPIC -c %t/vec.cpp -o %t/vec.o > // RUN: %clang++ -shared %t/vec.o -o %t/vec.dylib >

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-11-26 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > Would it be okay if I push the test for the Linux modification and check the > results here? I don’t have access to a Linux x86 setup for testing. Yes, that's what the pre-merge checks are for ;) https://github.com/llvm/llvm-project/pull/117475 _

[clang] [clang-repl] Remove redundant shared flag while running clang-repl in browser (PR #118107)

2024-12-05 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. Lgtm! https://github.com/llvm/llvm-project/pull/118107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Remove redundant shared flag while running clang-repl in browser (PR #118107)

2024-12-05 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/118107 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix ASTWriter crash after merging named enums (PR #114240)

2025-02-03 Thread Vassil Vassilev via cfe-commits
@@ -2639,6 +2628,19 @@ void Sema::MergeTypedefNameDecl(Scope *S, TypedefNameDecl *New, notePreviousDefinition(Old, New->getLocation()); } +void Sema::CleanupMergedEnum(Scope *S, Decl *New) { vgvassilev wrote: I feel like this is a property of merging. Can

[clang] [clang-tools-extra] [clangd] Update clangDaemonTweaks to set symbol visibility macros (PR #112304)

2024-12-11 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: ping. https://github.com/llvm/llvm-project/pull/112304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [Serialization] Support loading template specializations lazily (PR #119333)

2024-12-11 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @ChuanqiXu9, can we insert a fix for windows? https://github.com/llvm/llvm-project/pull/119333 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-09 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/117475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Temporarily disable test `clang/Interpreter/crash.cpp` (PR #119978)

2024-12-14 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/119978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Interpreter test should not depend on system header (PR #119903)

2024-12-13 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. Great catch, apologies for overlooking it. LGTM! https://github.com/llvm/llvm-project/pull/119903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-13 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,20 @@ +// REQUIRES: host-supports-jit, x86_64-linux + +// RUN: rm -rf %t +// RUN: mkdir -p %t +// +// RUN: split-file %s %t +// +// RUN: %clang++ -std=c++20 -fPIC -c %t/vec.cpp -o %t/vec.o +// RUN: %clang++ -shared %t/vec.o -o %t/vec.so vgvassilev wrote

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-13 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,20 @@ +// REQUIRES: host-supports-jit, x86_64-linux + +// RUN: rm -rf %t +// RUN: mkdir -p %t +// +// RUN: split-file %s %t +// +// RUN: %clang++ -std=c++20 -fPIC -c %t/vec.cpp -o %t/vec.o +// RUN: %clang++ -shared %t/vec.o -o %t/vec.so vgvassilev wrote

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-13 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: @SahilPatidar, could you help us with this? https://github.com/llvm/llvm-project/pull/117475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang-REPL] Fix crash during `__run_exit_handlers` with dynamic libraries. (PR #117475)

2024-12-13 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev edited https://github.com/llvm/llvm-project/pull/117475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Temporarily disable test `clang/Interpreter/crash.cpp` (PR #119978)

2024-12-14 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > Obsoleted by > [61ab36a](https://github.com/llvm/llvm-project/commit/61ab36a3e226df32855286dd31a2c3859800475d) That was the right fix, not the revert... https://github.com/llvm/llvm-project/pull/119978 ___ cfe-commits mailing list

<    4   5   6   7   8   9   10   >