Re: r279024 - PR28438: Update the information on an identifier with local definitions before

On 18/08/16 03:16, Richard Smith via cfe-commits wrote: Author: rsmith Date: Wed Aug 17 20:16:55 2016 New Revision: 279024 URL: http://llvm.org/viewvc/llvm-project?rev=279024&view=rev Log: PR28438: Update the information on an identifier with local definitions before trying to write out its macr

Re: [PATCH] D23314: [analyzer] CloneDetector allows comparing clones for suspicious variable pattern errors.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D23314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3600-3605 @@ -3598,2 +3599,8 @@ // which definitions should be visible. + if (DiagnoseUninstantiableTemplate(PointOfInstantiation, Function, +Function->getI

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68536. v.g.vassilev marked 2 inline comments as done. v.g.vassilev added a comment. Add setHidden(false) and update fixme. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp lib/Sema/SemaTemplateInstantiate

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68620. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Move DiagnoseUninstantiableTemplate before the late template parsing. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp l

r279164 - PR28794: Don't try to instantiate function templates which are not visible.

Author: vvassilev Date: Thu Aug 18 17:01:25 2016 New Revision: 279164 URL: http://llvm.org/viewvc/llvm-project?rev=279164&view=rev Log: PR28794: Don't try to instantiate function templates which are not visible. Reviewed by Richard Smith. Added: cfe/trunk/test/Modules/Inputs/PR28794/ cfe

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev updated this revision to Diff 68723. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Sink some of the diagnostics in the DiagnoseUninstantiableTemplate. https://reviews.llvm.org/D23492 Files: include/clang/Sema/Sema.h lib/Sema/SemaTemplate.cpp lib

r279371 - PR28423: Compare primary declaration contexts.

Author: vvassilev Date: Sat Aug 20 09:50:22 2016 New Revision: 279371 URL: http://llvm.org/viewvc/llvm-project?rev=279371&view=rev Log: PR28423: Compare primary declaration contexts. In certain cases (mostly coming from modules), Sema's idea of the StdNamespace does not point to the first declara

Re: [PATCH] D23418: [analyzer] Added a reusable constraint system to the CloneDetector

v.g.vassilev added inline comments. Comment at: include/clang/Analysis/CloneDetection.h:235 @@ +234,3 @@ + /// respective virtual methods. + class Constraint { + public: I am still unsure about the name. It is too generic. What about `CloneConstraint`? https

Re: [PATCH] D23400: Implement Use-Define Chain.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 68833. v.g.vassilev added a comment. Adapt to the new APIs. Now it builds. https://reviews.llvm.org/D23400 Files: lib/Sema/SemaExceptionSpec.cpp test/Modules/Inputs/PR28423/Allocator

Re: [PATCH] D23400: Implement Use-Define Chain.

v.g.vassilev updated this revision to Diff 68834. v.g.vassilev added a comment. Add the right diff. https://reviews.llvm.org/D23400 Files: include/clang/Analysis/DefUse.h lib/Analysis/CMakeLists.txt lib/Analysis/DefUse.cpp Index: lib/Analysis/DefUse.cpp ==

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3617 @@ +3616,3 @@ +PatternDef = nullptr; + // FIXME: We need to track the instantiation stack in order to know which + // definitions should be visible within this instantiation. --

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:3617 @@ +3616,3 @@ +PatternDef = nullptr; + // FIXME: We need to track the instantiation stack in order to know which + // definitions should be visible within this instantiation. --

Re: r279486 - Fix regression introduced by r279164: only pass definitions as the PatternDef

Thanks a lot! On 23/08/16 22:50, Richard Smith via cfe-commits wrote: Thanks. Fixed and reapplied as r279557. On Mon, Aug 22, 2016 at 7:08 PM, Chandler Carruth > wrote: Reverted this per Richard's request in r279500. On Mon, Aug 22, 2016 at 3:33 PM Richard

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev added a comment. Thanks! Shall I close this? https://reviews.llvm.org/D23492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23492: Make function local tags visible.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r279164 and r279486. https://reviews.llvm.org/D23492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r262189 - [modules] Prefer more complete array types.

int k = 2; }; void foo2() { C c; c.foo1(); } $ cat f3.cpp void foo1() { extern int foo0[1]; } template void foo2() { extern int foo0[n ? 1 : -1]; } void foo3() { foo2<5>(); } The code looks legal, so I don’t think clang should complain? On Feb 28, 2016, at 11:08 AM, Vassil Vassilev

Re: r262189 - [modules] Prefer more complete array types.

t static int k = 2; }; void foo2() { C c; c.foo1(); } $ cat f3.cpp void foo1() { extern int foo0[1]; } template void foo2() { extern int foo0[n ? 1 : -1]; } void foo3() { foo2<5>(); } The code looks legal, so I don’t think clang should complain? On Feb 28, 2016, at 11:08 AM,

r280827 - Add missing include. White space.

Author: vvassilev Date: Wed Sep 7 12:30:50 2016 New Revision: 280827 URL: http://llvm.org/viewvc/llvm-project?rev=280827&view=rev Log: Add missing include. White space. Modified: cfe/trunk/include/clang/Lex/ModuleMap.h Modified: cfe/trunk/include/clang/Lex/ModuleMap.h URL: http://llvm.org

r280984 - [modules] Apply ODR merging for function scoped tags only in C++ mode.

Author: vvassilev Date: Thu Sep 8 15:34:41 2016 New Revision: 280984 URL: http://llvm.org/viewvc/llvm-project?rev=280984&view=rev Log: [modules] Apply ODR merging for function scoped tags only in C++ mode. In C mode, if we have a visible declaration but not a visible definition, a tag defined in

Re: [PATCH] D24278: [analyzer] Extend bug reports with extra notes.

v.g.vassilev added a comment. Thanks for working on this! On my browser the note "Detected code clone" note appears slightly off the highlighted range which was a bit confusing to me. Given my limited understanding of the SA bug reports, this looks good to me. Comment at: lib

r281315 - Simplify. NFC.

Author: vvassilev Date: Tue Sep 13 05:36:12 2016 New Revision: 281315 URL: http://llvm.org/viewvc/llvm-project?rev=281315&view=rev Log: Simplify. NFC. Modified: cfe/trunk/lib/Sema/SemaLookup.cpp cfe/trunk/lib/Sema/SemaTemplateInstantiateDecl.cpp Modified: cfe/trunk/lib/Sema/SemaLookup.cp

r281316 - Revert accidentally checked in change in r281315.

Author: vvassilev Date: Tue Sep 13 05:38:26 2016 New Revision: 281316 URL: http://llvm.org/viewvc/llvm-project?rev=281316&view=rev Log: Revert accidentally checked in change in r281315. Modified: cfe/trunk/lib/Sema/SemaLookup.cpp Modified: cfe/trunk/lib/Sema/SemaLookup.cpp URL: http://llvm.

[PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev created this revision. v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D24508 Files: lib/Sema/SemaTemplate.cpp lib/Sema/SemaTemplateI

Re: [PATCH] D22439: Add missing includes.

v.g.vassilev added a comment. The 'atomic' bug was fixed I assume as part of https://llvm.org/bugs/show_bug.cgi?id=28794 Other includes landed in r281450. https://reviews.llvm.org/D22439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D24508: PR28752: Do not instantiate var decls which are not visible.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 71317. v.g.vassilev marked 4 inline comments as done. v.g.vassilev added a comment. Address comments. I still find the regression test a bit clumsy. I will try to add it to `test/Modules/

r298606 - Publish RAIIObjectsForParser.h for external usage.

Author: vvassilev Date: Thu Mar 23 10:11:07 2017 New Revision: 298606 URL: http://llvm.org/viewvc/llvm-project?rev=298606&view=rev Log: Publish RAIIObjectsForParser.h for external usage. Some clients (eg the cling interpreter) need to recover their parser from errors. Patch by Axel Naumann (D311

Re: r298742 - [ODRHash] Add error messages for mismatched parameters in methods.

Hi, This seems broke quite a lot of code, similarly to this: http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/5727/steps/compile.llvm.stage2/logs/stdio and also http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules/builds/4162 Could we back t

r298816 - Revert 298754 and 298742.

Author: vvassilev Date: Sun Mar 26 13:32:53 2017 New Revision: 298816 URL: http://llvm.org/viewvc/llvm-project?rev=298816&view=rev Log: Revert 298754 and 298742. They broke llvm modules builds and our internal modules infrastructure. Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializ

r298824 - Revert r298742 "[ODRHash] Add error messages for mismatched parameters in methods."

Author: vvassilev Date: Sun Mar 26 16:39:16 2017 New Revision: 298824 URL: http://llvm.org/viewvc/llvm-project?rev=298824&view=rev Log: Revert r298742 "[ODRHash] Add error messages for mismatched parameters in methods." I failed to revert this in r298816. Modified: cfe/trunk/include/clang/B

r298842 - Publish one more parser RAII for external use.

Author: vvassilev Date: Mon Mar 27 08:11:32 2017 New Revision: 298842 URL: http://llvm.org/viewvc/llvm-project?rev=298842&view=rev Log: Publish one more parser RAII for external use. Modified: cfe/trunk/include/clang/Parse/RAIIObjectsForParser.h cfe/trunk/lib/Parse/Parser.cpp Modified: c

r299639 - PR16106: Correct the docs to reflect the actual behavior of the interface.

Author: vvassilev Date: Thu Apr 6 05:05:46 2017 New Revision: 299639 URL: http://llvm.org/viewvc/llvm-project?rev=299639&view=rev Log: PR16106: Correct the docs to reflect the actual behavior of the interface. Modified: cfe/trunk/include/clang-c/Index.h Modified: cfe/trunk/include/clang-c/I

r299930 - Warn about unused static file scope function template declarations.

Author: vvassilev Date: Tue Apr 11 05:13:54 2017 New Revision: 299930 URL: http://llvm.org/viewvc/llvm-project?rev=299930&view=rev Log: Warn about unused static file scope function template declarations. Reviewed by Richard Smith (D29877)! Modified: cfe/trunk/lib/Sema/Sema.cpp cfe/trunk

r299956 - Revert temporarily D29877 "Warn about unused static file scope function template declarations."

Author: vvassilev Date: Tue Apr 11 11:05:23 2017 New Revision: 299956 URL: http://llvm.org/viewvc/llvm-project?rev=299956&view=rev Log: Revert temporarily D29877 "Warn about unused static file scope function template declarations." We need to address cases (breaking libc++) such as template st

r300110 - [modules] Delay calling DeclMustBeEmitted until it's safe.

Author: vvassilev Date: Wed Apr 12 16:56:05 2017 New Revision: 300110 URL: http://llvm.org/viewvc/llvm-project?rev=300110&view=rev Log: [modules] Delay calling DeclMustBeEmitted until it's safe. This patch implements the suggestion in D29753 that calling DeclMustBeEmitted in the middle of deseria

r300313 - PR32280: Do not crash on nested initializers.

Author: vvassilev Date: Fri Apr 14 03:48:08 2017 New Revision: 300313 URL: http://llvm.org/viewvc/llvm-project?rev=300313&view=rev Log: PR32280: Do not crash on nested initializers. Patch by Yuka Takahashi (D31591)! Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk/test/Sema/designated

Re: r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions

+ Richard Thanks for the example. We've seen similar issue with inlines (without the reverted patch). My guess this patch exposed it. It is not clear to me why we think the declaration is a definition there... On 17/04/17 23:10, Benjamin Kramer via cfe-commits wrote: This broke our internal b

r300594 - PR30508: Downgrade error to warning if the umbrella folder doesn't exist.

Author: vvassilev Date: Tue Apr 18 15:57:29 2017 New Revision: 300594 URL: http://llvm.org/viewvc/llvm-project?rev=300594&view=rev Log: PR30508: Downgrade error to warning if the umbrella folder doesn't exist. Patch by Yuka Takahashi (D32119)! Modified: cfe/trunk/include/clang/Basic/Diagnost

r291753 - PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

Author: vvassilev Date: Thu Jan 12 03:16:26 2017 New Revision: 291753 URL: http://llvm.org/viewvc/llvm-project?rev=291753&view=rev Log: PR31469: Don't add friend template class decls to redecl chain in dependent contexts. Fixes a crash in modules where the template class decl becomes the mos

Fwd: buildbot failure in LLVM on lldb-x86_64-ubuntu-14.04-cmake

Hi Sean, I am wondering what is the policy when introducing clang API changes. Shall I commit a fix in LLDB? Cheers, Vassil Forwarded Message Subject:buildbot failure in LLVM on lldb-x86_64-ubuntu-14.04-cmake Date: Thu, 12 Jan 2017 01:34:10 -0800 From: llvm.b

r294359 - Enable -dump-deserialized-decls and -error-on-deserialized-decl for modules.

Author: vvassilev Date: Tue Feb 7 15:49:41 2017 New Revision: 294359 URL: http://llvm.org/viewvc/llvm-project?rev=294359&view=rev Log: Enable -dump-deserialized-decls and -error-on-deserialized-decl for modules. Modified: cfe/trunk/lib/Frontend/FrontendAction.cpp Modified: cfe/trunk/lib/Fro

Re: r306127 - [GSoC] Add support for CC1 options.

On 27/06/17 07:17, Saleem Abdulrasool via cfe-commits wrote: I think that we shouldn't be providing completion for `-cc1` options. `-cc1as` options are fine as the IAS serves as a replacement for the traditional unix `as`. But, the `NoDriverOption` values shouldn't be exposed to users. They

r306692 - Initialize variable and silence potentially uninitialized warning.

Author: vvassilev Date: Thu Jun 29 09:08:10 2017 New Revision: 306692 URL: http://llvm.org/viewvc/llvm-project?rev=306692&view=rev Log: Initialize variable and silence potentially uninitialized warning. Patch by Liza Sakellari! Modified: cfe/trunk/include/clang/Sema/Lookup.h Modified: cfe/t

Re: r306692 - Initialize variable and silence potentially uninitialized warning.

constructors that do not mention it. Indeed. Do you have a solution in mind? The only way I see to fix this is by using an llvm::Optional. On Thu, Jun 29, 2017 at 9:08 AM, Vassil Vassilev via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: vvassilev Date: Thu Jun 29 09

r306809 - Ambiguity might be also uninitialized. Use llvm::Optional.

Author: vvassilev Date: Fri Jun 30 02:25:43 2017 New Revision: 306809 URL: http://llvm.org/viewvc/llvm-project?rev=306809&view=rev Log: Ambiguity might be also uninitialized. Use llvm::Optional. Modified: cfe/trunk/include/clang/Sema/Lookup.h Modified: cfe/trunk/include/clang/Sema/Lookup.h

r306903 - Reinstate "Load lazily the template specialization in multi-module setups."

Author: vvassilev Date: Fri Jun 30 15:40:17 2017 New Revision: 306903 URL: http://llvm.org/viewvc/llvm-project?rev=306903&view=rev Log: Reinstate "Load lazily the template specialization in multi-module setups." It was reverted in r305460 but the issue appears to only break our self-host libcxx m

r306964 - [modules] Teach clang how to merge typedef over anonymous structs in C mode.

Author: vvassilev Date: Sat Jul 1 13:44:49 2017 New Revision: 306964 URL: http://llvm.org/viewvc/llvm-project?rev=306964&view=rev Log: [modules] Teach clang how to merge typedef over anonymous structs in C mode. In C mode clang fails to merge the textually included definition with the one impor

r323051 - [cmake] Use CLANG_BINARY_DIR to determine the build directory.

Author: vvassilev Date: Sat Jan 20 13:43:35 2018 New Revision: 323051 URL: http://llvm.org/viewvc/llvm-project?rev=323051&view=rev Log: [cmake] Use CLANG_BINARY_DIR to determine the build directory. The patch puts the ClangConfig.cmake in the expected location when clang is embedded into a frame

r323368 - Revert r323051 "[cmake] Use CLANG_BINARY_DIR to determine the build directory."

Author: vvassilev Date: Wed Jan 24 11:26:50 2018 New Revision: 323368 URL: http://llvm.org/viewvc/llvm-project?rev=323368&view=rev Log: Revert r323051 "[cmake] Use CLANG_BINARY_DIR to determine the build directory." This broke swift builds. Thanks for the post-commit review of Chris Bieneman and

r296779 - Mark function as llvm dump method.

Author: vvassilev Date: Thu Mar 2 12:13:19 2017 New Revision: 296779 URL: http://llvm.org/viewvc/llvm-project?rev=296779&view=rev Log: Mark function as llvm dump method. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified: cfe/trunk/lib/Serialization/ASTReader.cpp URL: http://llvm

r296781 - Add coding and shebang.

Author: vvassilev Date: Thu Mar 2 12:47:22 2017 New Revision: 296781 URL: http://llvm.org/viewvc/llvm-project?rev=296781&view=rev Log: Add coding and shebang. Reviewed by Artem Dergachev (D26030)! Modified: cfe/trunk/tools/scan-view/share/Reporter.py cfe/trunk/tools/scan-view/share/star

r297030 - [modules] Make GNUMode a normal language option to fix module compilation.

Author: vvassilev Date: Mon Mar 6 10:54:40 2017 New Revision: 297030 URL: http://llvm.org/viewvc/llvm-project?rev=297030&view=rev Log: [modules] Make GNUMode a normal language option to fix module compilation. GNUMode shouldn't be a benign language option because it influences the resulting AST

r297037 - [modules] Add missing test from r297030.

Author: vvassilev Date: Mon Mar 6 11:47:57 2017 New Revision: 297037 URL: http://llvm.org/viewvc/llvm-project?rev=297037&view=rev Log: [modules] Add missing test from r297030. Added: cfe/trunk/test/Modules/Inputs/gnumode-non-benign/ cfe/trunk/test/Modules/Inputs/gnumode-non-benign/module

r289213 - Document and publish the useful module-file-info flag.

Author: vvassilev Date: Fri Dec 9 08:20:32 2016 New Revision: 289213 URL: http://llvm.org/viewvc/llvm-project?rev=289213&view=rev Log: Document and publish the useful module-file-info flag. Modified: cfe/trunk/include/clang/Driver/Options.td Modified: cfe/trunk/include/clang/Driver/Options.

r300825 - PR19260: Teach doxygen to spell correctly the include paths.

Author: vvassilev Date: Thu Apr 20 03:57:41 2017 New Revision: 300825 URL: http://llvm.org/viewvc/llvm-project?rev=300825&view=rev Log: PR19260: Teach doxygen to spell correctly the include paths. Currently we have #include in the doxygen page documenting Sema. The patch changes it ot #include "

r301563 - Remove leaking UnknownPragmaHandlers right after we are done with them.

Author: vvassilev Date: Thu Apr 27 11:58:33 2017 New Revision: 301563 URL: http://llvm.org/viewvc/llvm-project?rev=301563&view=rev Log: Remove leaking UnknownPragmaHandlers right after we are done with them. The UnknownPragmaHandlers added by DoPrintPreprocessedInput conflict with the real Pragma

Re: r302312 - Permit keywords in module names in #pragma clang module *.

Thanks! On 06/05/17 00:34, Richard Smith via cfe-commits wrote: Author: rsmith Date: Fri May 5 17:34:07 2017 New Revision: 302312 URL: http://llvm.org/viewvc/llvm-project?rev=302312&view=rev Log: Permit keywords in module names in #pragma clang module *. This is necessary to be able to build a

r302518 - Reland "Warn about unused static file scope function template declarations."

Author: vvassilev Date: Tue May 9 06:25:41 2017 New Revision: 302518 URL: http://llvm.org/viewvc/llvm-project?rev=302518&view=rev Log: Reland "Warn about unused static file scope function template declarations." This patch reinstates r299930, reverted in r299956, as a separate diagnostic option

r302521 - PR5935: Adjust documentation.

Author: vvassilev Date: Tue May 9 07:37:15 2017 New Revision: 302521 URL: http://llvm.org/viewvc/llvm-project?rev=302521&view=rev Log: PR5935: Adjust documentation. https://reviews.llvm.org/D31867 Patch by Johannes Altmanninger! Modified: cfe/trunk/include/clang/Basic/TargetOptions.h Modi

Re: [PATCH] D29877: Warn about unused static file scope function template declarations.

On 11/04/17 22:25, Richard Smith wrote: On 11 April 2017 at 08:35, Marshall Clow via Phabricator via cfe-commits > wrote: mclow.lists added a comment. Complete reproducer: // Tested with with: clang++ -std=c++14 -Wunused-function UnusedFVass

r303250 - Constify.

Author: vvassilev Date: Wed May 17 07:09:11 2017 New Revision: 303250 URL: http://llvm.org/viewvc/llvm-project?rev=303250&view=rev Log: Constify. Modified: cfe/trunk/include/clang/Basic/SourceManager.h Modified: cfe/trunk/include/clang/Basic/SourceManager.h URL: http://llvm.org/viewvc/llvm-

r303432 - [modules] Further delay calling DeclMustBeEmitted until it's safe.

Author: vvassilev Date: Fri May 19 11:46:06 2017 New Revision: 303432 URL: http://llvm.org/viewvc/llvm-project?rev=303432&view=rev Log: [modules] Further delay calling DeclMustBeEmitted until it's safe. As discussed in D30793, we have some unsafe calls to isConsumerInterestedIn(). This patch impl

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

On 17/10/16 16:40, Benjamin Kramer wrote: Too slow ;) Do you have the fix somewhere, so I can try it? That would be https://reviews.llvm.org/D25678 Do you run into something else than what I have as a test case (merging templated constexpr variables)? On Mon, Oct 17, 2016 at 4:38 PM, Vassil

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, bkramer. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. Repository: rL LLVM https://reviews.llvm.org/D25678 Files: lib/Sema/SemaDecl.cpp test/Modules/Input

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 74955. v.g.vassilev marked an inline comment as done. https://reviews.llvm.org/D25678 Files: lib/Sema/SemaDecl.cpp test/Modules/Inputs/merge-var-template-def/a.h test/Modules/Inputs/

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10129 +!Var->isThisDeclarationADemotedDefinition()) { + assert(Var->isThisDeclarationADemotedDefinition() && getLangOpts().Modules + && "Demoting decls is only in the contest of module

[PATCH] D22638: Module: add debug_type to dump debugging messages related to modules being out of date

v.g.vassilev added a comment. I am not sure whether that's useful for debugging out-of-date issues but this is what I use and it is helpful. Some debugging aids (suggested by Richard Smith): -fdiagnostics-show-note-include-stack will tell you which module a note comes from #pragma clang __

[PATCH] D22638: Module: add debug_type to dump debugging messages related to modules being out of date

v.g.vassilev added a comment. Also, creduce (I've specialized it a bit for modules) helps reducing the modules complexity (https://github.com/vgvassilev/creduce/blob/master/USAGE.md#reducing-clang-c-modules-bugs). After reduction, the debugger is much more useful. https://reviews.llvm.org/D22

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev updated this revision to Diff 75050. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Remove assert. https://reviews.llvm.org/D25678 Files: lib/Sema/SemaDecl.cpp test/Modules/Inputs/merge-var-template-def/a.h test/Modules/Inputs/merge-var-template-

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

On 17/10/16 17:07, Benjamin Kramer wrote: I'm running into something else and your patch doesn't fix it. It boils down to 'std::is_nothrow_move_constructible' from libstdc++ not compiling because Foo is not visible inside the noexcept specification of that template. I failed to come up with a sm

r284577 - [modules] Do not report missing definitions of demoted constexpr variable templates.

Author: vvassilev Date: Wed Oct 19 06:19:30 2016 New Revision: 284577 URL: http://llvm.org/viewvc/llvm-project?rev=284577&view=rev Log: [modules] Do not report missing definitions of demoted constexpr variable templates. This is a followup to regression introduced in r284284. This should fix ou

[PATCH] D25678: [modules] Do not report missing definitions of demoted constexpr variable templates.This is a followup to regression introduced in r284284.This should fix our libstdc++ modules builds.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r284577. https://reviews.llvm.org/D25678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r284382 - Revert "Reinstate r281429, reverted in r281452, with a fix for its mishandling of"

I totally misinterpreted this revert. I was confused it reverted r284284. Sorry for the noise. With the fix introduced in r284577 our bots should be happy. On 19/10/16 09:50, Vassil Vassilev wrote: On 17/10/16 17:07, Benjamin Kramer wrote: I'm running into something else and your patch doesn'

[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

v.g.vassilev added inline comments. Comment at: clang-tidy/utils/UsingInserter.cpp:58 + if (AlreadyHasUsingDecl) { +AddedUsing.emplace(NameInFunction(Function, QualifiedName.str())); +return None; Using emplace seems to break our modules libstdc++ 4.7 bu

[PATCH] D24997: [ClangTidy] Add UsingInserter and NamespaceAliaser

v.g.vassilev added a subscriber: rsmith. v.g.vassilev added inline comments. Comment at: clang-tidy/utils/UsingInserter.cpp:58 + if (AlreadyHasUsingDecl) { +AddedUsing.emplace(NameInFunction(Function, QualifiedName.str())); +return None; bkramer wrote: >

r284877 - Remove accidentally checked in assert.

Author: vvassilev Date: Fri Oct 21 15:30:30 2016 New Revision: 284877 URL: http://llvm.org/viewvc/llvm-project?rev=284877&view=rev Log: Remove accidentally checked in assert. Thanks to Manman for spotting this. Modified: cfe/trunk/lib/Sema/SemaDecl.cpp Modified: cfe/trunk/lib/Sema/SemaDecl.

Re: r284577 - [modules] Do not report missing definitions of demoted constexpr variable templates.

On 21/10/16 00:19, Manman wrote: On Oct 19, 2016, at 4:19 AM, Vassil Vassilev via cfe-commits wrote: Author: vvassilev Date: Wed Oct 19 06:19:30 2016 New Revision: 284577 URL: http://llvm.org/viewvc/llvm-project?rev=284577&view=rev Log: [modules] Do not report missing definitions of dem

r285184 - [modules] PR28812: Modules can return duplicate field decls.

Author: vvassilev Date: Wed Oct 26 05:24:29 2016 New Revision: 285184 URL: http://llvm.org/viewvc/llvm-project?rev=285184&view=rev Log: [modules] PR28812: Modules can return duplicate field decls. If two modules contain duplicate class definitions the lookup result can contain more than 2 element

[PATCH] D25604: Add support for Mageia Linux

v.g.vassilev removed rL LLVM as the repository for this revision. v.g.vassilev updated this revision to Diff 75868. v.g.vassilev added a comment. Add another triple we use. https://reviews.llvm.org/D25604 Files: lib/Driver/ToolChains.cpp Index: lib/Driver/ToolChains.cpp

r285277 - Empty the CtorLists/DtorLists once emitted.

Author: vvassilev Date: Thu Oct 27 04:12:20 2016 New Revision: 285277 URL: http://llvm.org/viewvc/llvm-project?rev=285277&view=rev Log: Empty the CtorLists/DtorLists once emitted. This is essential when clang is running in incremental processing mode because we don't want to reemit the 'tors over

[PATCH] D25605: Empty the C/DtorLists once emitted. This is essential when running in incremental processing mode, because we don't want to reemit the 'tors over and over again.

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r285277. Repository: rL LLVM https://reviews.llvm.org/D25605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D26030: Add shebang.

v.g.vassilev created this revision. v.g.vassilev added reviewers: NoQ, zaks.anna. v.g.vassilev added a subscriber: cfe-commits. v.g.vassilev set the repository for this revision to rL LLVM. This is another home grown patch I'd like to upstream. Repository: rL LLVM https://reviews.llvm.org/D26

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

v.g.vassilev added a comment. Could you include more context when creating the diff eg. git diff -U, or equivalent. Comment at: include/clang/Lex/ModuleMap.h:278 + /// headers. + static bool isBuiltinHeader(StringRef FileName); + It seems this is in the

Re: r245779 - [modules] Rearrange how redeclaration chains are loaded, to remove a walk over

On 22/08/15 03:47, Richard Smith via cfe-commits wrote: Author: rsmith Date: Fri Aug 21 20:47:18 2015 New Revision: 245779 URL: http://llvm.org/viewvc/llvm-project?rev=245779&view=rev Log: [modules] Rearrange how redeclaration chains are loaded, to remove a walk over all modules and reduce the n

Fwd: [modules] PR24954

Forwarding to cfe-commits Forwarded Message Subject:[modules] PR24954 Date: Thu, 8 Oct 2015 15:53:55 +0200 From: Vassil Vassilev To: Richard Smith , cfe-...@cs.uiuc.edu CC: Ben Langmuir Hi Richard, I started working on https://llvm.org/bugs/show_bug.c

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

v.g.vassilev requested changes to this revision. v.g.vassilev added a comment. I guess the question about the binary size holds here, too. What would be the impact on the binary size? Comment at: lib/Analysis/CloneDetection.cpp:104 @@ +103,3 @@ +/// defines what a 'similar' clo

Re: [PATCH] D20795: Added basic capabilities to detect source code clones.

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM, given the comments are addressed. Comment at: include/clang/Analysis/CloneDetection.h:37 @@ +36,3 @@ + /// Stmt, then S is a pointer to this Stmt. + Stmt c

Re: [PATCH] D22514: CloneDetection now respects statement specific data when searching for clones.

v.g.vassilev added a comment. Could we stress test the implementation by running on files from llvm's/clang's test suite. For example, for a test TST we could do something like: cat TST >> tmp_TST; cat TST >> tmp_TST and run our our copy-paste checker on tmp_TST. This way we know how many clon

r276469 - Add regression test for PR27699.

Author: vvassilev Date: Fri Jul 22 15:49:31 2016 New Revision: 276469 URL: http://llvm.org/viewvc/llvm-project?rev=276469&view=rev Log: Add regression test for PR27699. Added: cfe/trunk/test/Modules/Inputs/PR27699/ cfe/trunk/test/Modules/Inputs/PR27699/Subdir/ cfe/trunk/test/Modules/I

r276473 - [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader.

Author: vvassilev Date: Fri Jul 22 16:08:24 2016 New Revision: 276473 URL: http://llvm.org/viewvc/llvm-project?rev=276473&view=rev Log: [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader. Processing update records (and loading a module, in general) might trigger unexpecte

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev added a subscriber: v.g.vassilev. Comment at: include/clang/Lex/Preprocessor.h:270 @@ +269,3 @@ + /// on the stem that is to be code completed. + IdentifierInfo *CodeCompletionII; + Can you initialize this variable in the PP's ctor? Repository:

Re: r276473 - [modules] Teach the ASTWriter to ignore mutations coming from the ASTReader.

It could, it fixes a set of issues wrt to modules. On 25/07/16 22:39, Hans Wennborg wrote: Should this be merged to 3.9? On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev via cfe-commits wrote: Author: vvassilev Date: Fri Jul 22 16:08:24 2016 New Revision: 276473 URL: http://llvm.org/viewvc

Re: r275590 - [AST] Keep track of the left brace source location of a tag decl.

Thanks! This is really handy interface. Would it make sense adding the same for NamespaceDecl for consistency? On 15/07/16 20:11, Argyrios Kyrtzidis via cfe-commits wrote: Author: akirtzidis Date: Fri Jul 15 13:11:33 2016 New Revision: 275590 URL: http://llvm.org/viewvc/llvm-project?rev=275590&

Re: r275590 - [AST] Keep track of the left brace source location of a tag decl.

(forgot to click "reply all") Thanks! This is really handy interface. Would it make sense adding the same for NamespaceDecl for consistency? On 15/07/16 20:11, Argyrios Kyrtzidis via cfe-commits wrote: Author: akirtzidis Date: Fri Jul 15 13:11:33 2016 New Revision: 275590 URL: http://llvm.org/

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev requested changes to this revision. v.g.vassilev added a reviewer: v.g.vassilev. This revision now requires changes to proceed. Comment at: lib/Lex/Preprocessor.cpp:748 @@ +747,3 @@ + if (Result.is(tok::code_completion)) + setCodeCompletionIdentifierInfo(Result.

r276878 - Implement filtering for code completion of identifiers.

Author: vvassilev Date: Wed Jul 27 09:56:59 2016 New Revision: 276878 URL: http://llvm.org/viewvc/llvm-project?rev=276878&view=rev Log: Implement filtering for code completion of identifiers. Patch by Cristina Cristescu and Axel Naumann! Agreed on post commit review (D17820). Modified: cfe/

Re: [PATCH] D17820: Clang Code Completion Filtering

v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in r276878. Repository: rL LLVM https://reviews.llvm.org/D17820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D17820: Clang Code Completion Filtering

Looking into it. On 27/07/16 18:34, Jun Bum Lim wrote: junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change : llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:448:3: error: default label in switch which covers all enumeration values [-W

Re: r276889 - Fix unnecessary default switch warning

Thanks a lot! On 27/07/16 18:41, Simon Pilgrim via cfe-commits wrote: Author: rksimon Date: Wed Jul 27 11:41:56 2016 New Revision: 276889 URL: http://llvm.org/viewvc/llvm-project?rev=276889&view=rev Log: Fix unnecessary default switch warning Modified: cfe/trunk/lib/Sema/CodeCompleteConsum

Re: [PATCH] D17820: Clang Code Completion Filtering

Fixed in r276889 by Simon Pilgrim! On 27/07/16 22:03, Vassil Vassilev wrote: Looking into it. On 27/07/16 18:34, Jun Bum Lim wrote: junbuml added a subscriber: junbuml. junbuml added a comment. It appears that build fails due to this change : llvm/tools/clang/lib/Sema/CodeCompleteConsumer.cpp:

<    1   2   3   4   5   6   7   8   9   10   >