[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 228870. usaxena95 added a comment. Fixed typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tools-extra/clangd/CollectMacros.h clang-tools-extra/

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:29 std::vector Ranges; + llvm::DenseMap> MacroRefs; }; hokein wrote: > I think the `Ranges` and `MacrosRefs` have a lot of dupli

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 marked 7 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:898 + // Handle macros. + if (auto Macro = locateMacroAt(Loc, AST.getPreprocessor())) { +if (auto MacroSID = getSymbolID(Macro->Name, Macro->Info, SM)

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229492. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Uploading latest patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-t

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229529. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Modified tests for better error messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D7000

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp:80 +<< Test; +EXPECT_THAT(collectKnownReferences(AST.getMacros()), AreMacroRefsFrom(T)) +<< Test; hokein wrote: > usaxena95 wrote: > > hokei

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229535. usaxena95 added a comment. Minor change: Resued variable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tools-extra/clangd/CollectMacros.h

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 229836. usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tool

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/CollectMacrosTests.cpp:28 + )cpp", + // FIXME: Locating macro in duplicate definitions doesn't work. Enable + // this once LocateMacro is fix

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This adds the references for macros to the SymbolCollector (used for static index). Enabled if `CollectM

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:374 +Roles & static_cast(index::SymbolRole::Definition) || +Roles & static_cast(index::SymbolRole::Reference))) return

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 231648. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files: clang-tool

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 marked 2 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:374 +Roles & static_cast(index::SymbolRole::Definition) || +Roles & static_cast(index::SymbolRole::Reference))) return

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 231660. usaxena95 added a comment. Added correct documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files: clang-tools-extra/clangd/index/SymbolCollecto

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:532 + const IdentifierInfo *II = MacroRef.first; + if (const auto *MI = PP->getMacroDefinition(II).getMacroInfo()) +if (auto ID = getSymbolID(II->getName(), MI, PP->g

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 231834. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Will update the increase in size of index shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 added a comment. **Before this patch** `CollectMacro` is disabled by default Loaded Dex from static-index.idx with estimated memory usage 354410880 bytes - number of symbols: 462463 - number of refs: 6361763 - numnber of relations: 20322 **Before this patch** `CollectMacr

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232079. usaxena95 added a comment. Explicitly turn off CollectMacro in test. #Updatin D70489 : [clangd] Add xref for macro to static index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232078. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files: clang-tool

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232125. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files: clang-tool

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:472 } - if (Opts.CollectMacro) { -assert(PP); hokein wrote: > hokein wrote: > > this code should not be modified, since we don't use the `CollectMacro` > > op

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232126. usaxena95 added a comment. Removed unintended space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files: clang-tools-extra/clangd/index/SymbolCollector.c

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232250. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files: clang-tool

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 added a comment. Updated benchmarks: **Before this patch** Loaded Dex from static-index.idx with estimated memory usage 354410880 bytes - number of symbols: 462463 - number of refs: 6361763 - numnber of relations: 20322 **After this patch** Num refs increases by **5.7%**

[PATCH] D70489: [clangd] Add xref for macro to static index.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9347655a2754: [clangd] Add xref for macro to static index. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Adds macro references to the dynamic index. Tests added. Also exposed a new API to convert path to URI i

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 updated this revision to Diff 248416. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. - Populated score in CodeCompletion before invoking the callback. - Tested that CodeCompletion is scored - Updated comment for callback. Repository: rG LL

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.h:139 + /// in the output. + std::function *RecordCCResult = nullptr; sammccall wrote: > I'd suggest including the final score in the signature rather than recompute > it, just

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

usaxena95 updated this revision to Diff 248422. usaxena95 added a comment. Passed score as a float as an explicit argument of the callback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75603/new/ https://reviews.llvm.org/D75603 Files: clang-too

[PATCH] D75603: [clangd] Add instrumentation mode in clangd for metrics collection.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe397a0a5c3c0: [clangd] Add instrumentation mode in clangd for metrics collection. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7560

[PATCH] D74305: [clangd] Expose completion range in code completion results (C++ API)

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. LG. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:2680 +TEST(CompletionTest, CompletionRange) { + const char* WithRange = "auto x = [[ab

[PATCH] D145642: [clang-format] Annotate lambdas with requires clauses.

usaxena95 added a comment. > starting a line with an opening paren is pretty weird!) I do not think this is weird. On the contrary, this is more readable to me and separates the requires clause from the parameters list. For example this one looks so much better: // trunk. template void

[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

usaxena95 updated this revision to Diff 501822. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144480/new/ https://reviews.llvm.org/D144480 Files: clang-to

[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4d9ac8b453e: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode (authored by usaxena95). Repository: rG LLVM Github Monorep

[PATCH] D145154: Change ClangTidy unit tests to run in C++20 mode instead of C++11.

usaxena95 created this revision. usaxena95 added a reviewer: gribozavr2. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145

[PATCH] D145154: Change ClangTidy unit tests to run in C++20 mode instead of C++11.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc396073a0de6: Change ClangTidy unit tests to run in C++20 mode instead of C++11. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14515

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 added a comment. This does not seem to be a pressing issue as there are no other reported module/cpp20 related crashes which were fixed by this. Also since it has no tests, it should be fine to postpone it to the next release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 updated this revision to Diff 513165. usaxena95 added a comment. More refactorings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213 Files: clang-tools-extra/clangd/Diagnostics.cpp clang-tool

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 updated this revision to Diff 513168. usaxena95 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213 Files: clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clan

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

usaxena95 updated this revision to Diff 513219. usaxena95 marked 6 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ https://reviews.llvm.org/D148213 Files: clang-to

[PATCH] D148213: [clangd] Use FileEntryRef for canonicalizing filepaths.

This revision was automatically updated to reflect the committed changes. Closed by commit rGed365f464a0a: [clangd] Use FileEntryRef for canonicalizing filepaths. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148213/new/ htt

[PATCH] D144480: [C++20][ClangTidy] Update the ClangTidy tests to also test in C++20 mode

usaxena95 created this revision. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is useful for running cl

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

usaxena95 updated this revision to Diff 341168. usaxena95 marked 4 inline comments as done. usaxena95 edited the summary of this revision. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101388/new/ http

[PATCH] D101388: [clangd] Add SymbolID to LocatedSymbol.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7cb2305a1e8: [clangd] Add SymbolID to LocatedSymbol. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D101750: [clangd] Find implementors only when index is present.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github

[PATCH] D101750: [clangd] Find implementors only when index is present.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3d5f306e910: [clangd] Find implementors only when index is present. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101750/new/ http

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:7 # namespace-qualified class name. +set(CLANGD_QUALITY_DIR ${CMAKE_CURRENT_LIST_DIR}) function(gen_decision_forest model filename cpp_class) nit: Directly refer

[PATCH] D101851: Make clangd CompletionModel not depend on directory layout.

usaxena95 accepted this revision. usaxena95 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:9 function(gen_decision_forest model filename cpp_class) - set(model_compiler ${LLVM_EXTERNAL_

[PATCH] D116326: [CodeCompletion] Signature help for aggregate initialization.

usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3699 + unsigned ChunkIndex = 0; + auto AddChunk = [&](std::string Placeholder) { +if (ChunkIndex > 0) nit: const ref. Comment at: clang/lib/Sema/SemaCodeComp

[PATCH] D116443: [clangd] Implement textDocument/typeDefinition

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. LGTM. Comment at: clang-tools-extra/clangd/XRefs.cpp:1869 + QualType VisitDesignatedInitExpr(const DesignatedInitExpr *S) { +for (auto &D : llvm::r

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 created this revision. usaxena95 added reviewers: kadircet, sammccall. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. `expandedTokens(SourceRange)` used to do a binary search to get the expanded tokens bel

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:372 + // useful while finding expanded tokens in a 'token range'. + llvm::DenseMap ExpandedTokIndex; llvm::DenseMap Files; kadircet wrote: > this definitely makes sense,

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 updated this revision to Diff 333045. usaxena95 marked 6 inline comments as done. usaxena95 edited the summary of this revision. usaxena95 added a comment. Herald added a subscriber: arphaman. Herald added a project: clang-tools-extra. Made the optimization an 'opt-in'. Created `TokenBuf

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 updated this revision to Diff 333052. usaxena95 added a comment. Remove unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99086/new/ https://reviews.llvm.org/D99086 Files: clang-tools-extra/clangd/ParsedAST.cpp clang/

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

usaxena95 updated this revision to Diff 44. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99086/new/ https://reviews.llvm.org/D99086 Files: clang-tool

[PATCH] D99086: [clang][Syntax] Optimize expandedTokens for token ranges.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. usaxena95 marked an inline comment as done. Closed by commit rGaa979084dffb: [clang][Syntax] Optimize expandedTokens for token ranges. (authored by usaxena95). Reposit

[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

usaxena95 created this revision. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99934 Files: clang/lib/Tooling/Syntax/Tokens.cpp Index: clang/lib/T

[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

usaxena95 added a comment. Clangd was seen to be crashing on Objective C/C++ files. It could not be reproduced but inspection of coredump showed that the `expandedTokens` returned arrayref with begin > end (negative length). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D99934: [clang][Syntax] Handle invalid source range in expandedTokens.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd824a48cccb: [clang][Syntax] Handle invalid source range in expandedTokens. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D92749: [clangd] go-to-implementation on a base class jumps to all subclasses.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92749/new/ https://reviews.llvm.org/D92749 __

[PATCH] D94393: [clangd] Add metrics for go-to-implementation.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LG. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94393/new/ https://reviews.llvm.org/D94393

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman, javed.absar. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Many useful signals can be derived from a valid AST which is regula

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 315839. usaxena95 added a comment. Documentation change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.llvm.org/D94424 Files: clang-tools-extra/clangd/TUScheduler.cpp clang-too

[PATCH] D94390: [clangd] Extend find-refs to include overrides.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LG. Thanks! Comment at: clang-tools-extra/clangd/XRefs.cpp:1324 + +llvm::DenseSet OverrideSymbols; +if (Index) { nit: s/OverrideSymbols/Overrid

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94473 Files:

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

usaxena95 updated this revision to Diff 316071. usaxena95 added a comment. Edge cases fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94473/new/ https://reviews.llvm.org/D94473 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-ex

[PATCH] D94513: [clangd] Remove "decision-forest-base" experimental flag.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The value of this flag can only be fine t

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 316379. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.llvm.org/D94424 Files: clang-tool

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/TUSchedulerTests.cpp:720 + #include "foo.h" + namespace ns1 { + namespace ns2 { adamcz wrote: > Can you add anonymous namespaces as well? Good point. Avoided capturing anonymous na

[PATCH] D94513: [clangd] Remove "decision-forest-base" experimental flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4f386688239: [clangd] Remove "decision-forest-base" experimental flag. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94513/new/ ht

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 316669. usaxena95 marked 13 inline comments as done. usaxena95 added a comment. Herald added a subscriber: mgorny. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:841 +void ASTWorker::updateASTSignals(ParsedAST &AST) { + ASTSignals Signals; sammccall wrote: > This implementation doesn't belong in TUScheduler, which is all about > mana

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 316670. usaxena95 added a comment. Removed unused headers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.llvm.org/D94424 Files: clang-tools-extra/clangd/ASTSignals.cpp clang-to

[PATCH] D94697: [clangd] Update CC Ranking model with better sampling.

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. A better sampling strategy was used to gener

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 316681. usaxena95 added a comment. Addressed comments. Ready for landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.llvm.org/D94424 Files: clang-tools-extra/clangd/ASTSignals

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

usaxena95 updated this revision to Diff 316683. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added newline at end of new file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94424/new/ https://reviews.llvm.org/D94424 Files

[PATCH] D94424: [clangd] Make AST-based signals available to runWithPreamble.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f395b7092bd: [clangd] Make AST-based signals available to runWithPreamble. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

usaxena95 updated this revision to Diff 316853. usaxena95 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94473/new/ https://reviews.llvm.org/D94473 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/clan

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Previously we did not record local class declarations. Now with features like fi

[PATCH] D94697: [clangd] Update CC Ranking model with better sampling.

usaxena95 updated this revision to Diff 316969. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94697/new/ https://reviews.llvm.org/D94697 Files: clang-tools-extra/clangd/Quality.cpp clang-tools-ext

[PATCH] D94697: [clangd] Update CC Ranking model with better sampling.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd5047d762f39: [clangd] Update CC Ranking model with better sampling. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317015. usaxena95 added a comment. Added tests for not indexing lambdas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files: clang-tools-extra/clangd/index/FileI

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 added a comment. In D94785#2501312 , @njames93 wrote: > My only question is does this try and index lambdas, under the hood they are > declared as a CXXRecordDecl, defined in function scope? I would not expect that to happen as it is an anonymo

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

usaxena95 updated this revision to Diff 317307. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94473/new/ https://reviews.llvm.org/D94473 Files: clang-tool

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317339. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Left a todo to fix the bug in RefContainers later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ h

[PATCH] D94473: [clangd] Use AST-based signals in CodeCompletion.

This revision was automatically updated to reflect the committed changes. Closed by commit rG275716d6db79: [clangd] Derive new signals in CC from ASTSignals. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94473/new/ https://r

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94927 Files:

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 marked an inline comment as done. usaxena95 added a comment. In D94785#2506186 , @hokein wrote: > I think we'd better bump the index version, even though this is not a > breaking change, but we will collect more data. Not bumping the index versi

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317522. usaxena95 added a comment. Index all member functions instead of only polymorphic functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files: clang-to

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 updated this revision to Diff 317525. usaxena95 added a comment. Herald added a subscriber: wenlei. Updated index tests's input files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/ https://reviews.llvm.org/D94785 Files: clan

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

usaxena95 added a comment. In D94785#2506685 , @hokein wrote: > if you don't mind, could you rerun the benchmark (we have a behavior changes > from original version, I guess it won't not change significantly)? and update > the data in the description bef

[PATCH] D94785: [clangd] Index local classes, virtual and overriding methods.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bf7116d50bf: [clangd] Index local classes, virtual and overriding methods. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94785/new/

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

usaxena95 updated this revision to Diff 317613. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added a comment about the calculation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94927/new/ https://reviews.llvm.org/D94927

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17846ed5af4a: [clangd] Use ASTSignals in Heuristics CC Ranking. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

<    1   2   3   4   5