[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9f63d22fafb: [clangd] Disable msan instrumentation for generated Evaluate(). (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88495/ne

[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This allows us MSAN to instrument this function. Previous version is not instrum

[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

usaxena95 updated this revision to Diff 295284. usaxena95 added a comment. Minor formatting fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88536/new/ https://reviews.llvm.org/D88536 Files: clang-tools-extra/clangd/quality/CompletionModelCo

[PATCH] D88590: [clangd] Add bencmark for measuring latency of DecisionForest model.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, mgorny. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88590

[PATCH] D88590: [clangd] Add bencmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295338. usaxena95 added a comment. Minor fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 Files: clang-tools-extra/clangd/benchmarks/CMakeLists.txt clang-to

[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:168 +nline.join(class_members), +nline.join([" float EvaluateTree%d() const;" % tree_num +for tree_num in range(num_trees)]), -

[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

usaxena95 updated this revision to Diff 295473. usaxena95 added a comment. Addressed comments: Move the evaluate functions to anonymous namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88536/new/ https://reviews.llvm.org/D88536 Files: cl

[PATCH] D88590: [clangd] Add bencmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295478. usaxena95 added a comment. Added benchmark. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 Files: clang-tools-extra/clangd/benchmarks/CMakeLists.txt clan

[PATCH] D88590: [clangd] Add bencmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295479. usaxena95 added a comment. Distribution change and better formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 Files: clang-tools-extra/clangd/benchm

[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

This revision was automatically updated to reflect the committed changes. Closed by commit rG45698ac0052a: [clangd] Split DecisionForest Evaluate() into one func per tree. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88536/n

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295796. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments: Default seeded the RNG for the benchmark. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://re

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295797. usaxena95 added a comment. Added newline at end of files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 Files: clang-tools-extra/clangd/benchmarks/CMakeLi

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

usaxena95 updated this revision to Diff 295837. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88590/new/ https://reviews.llvm.org/D88590 Files: clang-tool

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp:74 + for (auto _ : State) { +srand(0); +State.PauseTiming(); adamcz wrote: > Move this out of the loop. Right now we re-generate

[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb2a646c5f00: [clangd] Add bencmark for measuring latency of DecisionForest model. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D885

[PATCH] D88745: [clangd][WIP] Add new code completion signals to improve MRR by 3%.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Adds two more signals. - NumNameInContext: Strength of match of name with conte

[PATCH] D88745: [clangd][WIP] Add new code completion signals to improve MRR by 3%.

usaxena95 updated this revision to Diff 296159. usaxena95 edited the summary of this revision. usaxena95 added a comment. Updated the references to old signals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88745/new/ https://reviews.llvm.org/D8874

[PATCH] D88985: [clangd] Temporary fix for bad inference in Decision Forest.

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Unreachable file distances are represented a

[PATCH] D88985: [clangd] Temporary fix for bad inference in Decision Forest.

usaxena95 abandoned this revision. usaxena95 added a comment. Yeah. Not very critical as of now. You can patch it if you want incase you want to try it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88985/new/ https://reviews.llvm.org/D88985

[PATCH] D89035: [clangd] New CC Ranking Model to fix bad inference due to overflow.

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Unreachable file distances are represented a

[PATCH] D89035: [clangd] New CC Ranking Model to fix bad inference due to overflow.

usaxena95 updated this revision to Diff 296925. usaxena95 added a comment. Update model to LambdaMART instead of XE_NDCG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89035/new/ https://reviews.llvm.org/D89035 Files: clang-tools-extra/clangd/qu

[PATCH] D89035: [clangd] New CC Ranking Model to fix bad inference due to overflow.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0a6fd435c60: [clangd] New CC Ranking Model to fix bad inference due to overflow. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8903

[PATCH] D89119: [clangd] Update CC Ranking model to use SymbolCategory::Macro

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. A bug in the dataset generation pipeline captured a SymbolCategory::Macro as Sym

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

usaxena95 marked 3 inline comments as done. usaxena95 added a comment. > Looks like the patch is based on the old revision (pre-merging tests are > failing), I assume you have fixed the failure tests last week? Yes. That was fixed last week. Rebased. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

usaxena95 updated this revision to Diff 306969. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91721/new/ https://reviews.llvm.org/D91721 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-t

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb31486ad9717: [clangd] textDocument/implementation (LSP layer) (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

usaxena95 added inline comments. Comment at: clang/include/clang/Tooling/CompilationDatabase.h:194 + static std::unique_ptr + loadFromBuffer(StringRef Path, StringRef Data, std::string &ErrorMsg); + `Path` is not meaningful for load from buffer. May be change n

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92640/new/ https://reviews.llvm.org/D92640

[PATCH] D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

usaxena95 accepted this revision. usaxena95 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:711 +// Returns true if ExtZone contains any ReturnStms. +bool hasReturnStmt(const Extrac

[PATCH] D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:724 + ReturnStmtVisitor V; + for (const auto *RootStmt : ExtZone.RootStmts) { +V.TraverseStmt(const_cast(RootStmt)); nit: s/auto/Stmt ==

[PATCH] D89700: [clangd] Don't offer to expand auto in structured binding declarations.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LGTM! Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89700/new/ https://reviews.llvm.org/D89700 __

[PATCH] D90014: [clangd] Add support for multiple DecisionForest model experiments.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. With every incremental change, one needs to check-in new model upstream. This al

[PATCH] D90014: [clangd] Add support for multiple DecisionForest model experiments.

usaxena95 updated this revision to Diff 300582. usaxena95 added a comment. Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90014/new/ https://reviews.llvm.org/D90014 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra

[PATCH] D90014: [clangd] Add support for multiple DecisionForest model experiments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7df80a1204f0: [clangd] Add support for multiple DecisionForest model experiments. (authored by usaxena95). Repository: rG LLVM Github Monorepo CH

[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added a subscriber: arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Tweaks like DefineOutline depend on FS

[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

usaxena95 updated this revision to Diff 345793. usaxena95 marked an inline comment as done. usaxena95 added a comment. added comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102519/new/ https://reviews.llvm.org/D102519 Files: clang-tools-e

[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e7c7d461df1: [clangd] Set FileSystem for tweaks in Check tool. (a

[PATCH] D102519: [clangd] Set FileSystem for tweaks in Check tool.

usaxena95 added a comment. Did you need any other change ? Didn't realised the revision was not "accepted". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102519/new/ https://reviews.llvm.org/D102519 ___

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. See: https://github.com/clangd/clangd/issues/668 struct A { virtual void foo(

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320563. usaxena95 added a comment. Move Index query to more logical place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320673. usaxena95 added a comment. Rebase + Add OverriddenBy flag for such references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clan

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 added a comment. In D95812#2535077 , @sammccall wrote: > This looks about right to me... > Unfortunately I landed ff4832dbff0ccf1fd29f726efe72fd1220cd645a > and > 1eb7fd089e2

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320683. usaxena95 added a comment. Print value of new OverriddenBy flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320685. usaxena95 added a comment. Remove unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tools-extra/clangd/XRefs.cpp clang-tool

[PATCH] D95852: [clangd] Report xref for base methods.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. See: https://github.com/clangd/clangd/issues/668 struct A { virtual void foo(

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

usaxena95 updated this revision to Diff 320737. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95812/new/ https://reviews.llvm.org/D95812 Files: clang-tool

[PATCH] D95812: [clangd] Report only decl of overridding method in xref.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbeff2ec2bc6: [clangd] Report only decl of overridding method in xref. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D95852: [clangd] Report xref for base methods.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1902 +void test(BaseBase* BB, Base* B, Derived* D) { + BB->func(); // refs to base's base method are not reported. + B->[[func]](); // References to the base

[PATCH] D95852: [clangd] Report xref for base methods.

usaxena95 updated this revision to Diff 321038. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95852/new/ https://reviews.llvm.org/D95852 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra

[PATCH] D95852: [clangd] Report xref for base methods.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54afcade3bbc: [clangd] Report xref for base methods. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

usaxena95 created this revision. usaxena95 added reviewers: hokein, kadircet. Herald added a subscriber: arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Addresses https://github.com/cla

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

usaxena95 updated this revision to Diff 377111. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111039/new/ https://reviews.llvm.org/D111039 Files: clang-to

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

usaxena95 updated this revision to Diff 377114. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111039/new/ https://reviews.llvm.org/D111039 Files: clang-to

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1397 + OverriddenBy.Subjects.insert(ID); getOverriddenMethods(CMD, OverriddenMethods); } kadircet

[PATCH] D111039: [clangd] Include refs of base method in refs for derived method.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6831c1d8689b: [clangd] Include refs of base method in refs for derived method. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111039/

[PATCH] D96262: [clang][index] report references from unreslovedLookupExpr.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. LG. Couple of comments about adding tests to clangd as well. Comment at: clang/test/Index/Core/index-dependent-source.cpp:233 +// CHECK: [[@LINE-1]]:3 | functio

[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Also treat Keywords separately as they are n

[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

usaxena95 updated this revision to Diff 322922. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96353/new/ https://reviews.llvm.org/D96353 Files: clang-tool

[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:651 + auto Results = + completions("int main() { abs^ }", {func("absl"), func("absb")}); EXPECT_THAT(Results.Completions, hokein wrote: > sorry, I didn'

[PATCH] D112530: [clangd] AddUsing: Fix support for template specializations.

usaxena95 added a comment. No worries. Thanks for taking a look :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112530/new/ https://reviews.llvm.org/D112530 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D113555: [clangd] Mark macros from preamble for code completion

usaxena95 accepted this revision. usaxena95 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:567 S.CanonicalDeclaration = R.Location; +if (!HeaderFileURIs->getIncludeHeader(SM.g

[PATCH] D97620: Fix DecisionForestBenchmark.cpp compile errors

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LG. Thanks for noticing and fixing it! Comment at: clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp:41 E.setSymbolCategory(RandInt(

[PATCH] D96353: [clangd] Use ML Code completion ranking as default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG438b5bb05a42: [clangd] Use ML Code completion ranking as default. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96353/new/ https://

[PATCH] D97620: Fix DecisionForestBenchmark.cpp compile errors

This revision was automatically updated to reflect the committed changes. Closed by commit rGbad8e577f9c7: Fix DecisionForestBenchmark.cpp compile errors (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97620/new/ https://revie

[PATCH] D97770: [clangd] Make categorical features 64 bit in DecisionForest Model.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. CodeCompletionContext::Kind has 36 Kinds. The completion model used to support c

[PATCH] D97770: [clangd] Make categorical features 64 bit in DecisionForest Model.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf935a034b34: [clangd] Make categorical features 64 bit in DecisionForest Model. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHA

[PATCH] D98424: [clangd] Reject renames to non-identifier characters

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 +case InvalidName::BadIdentifier: + return "the chosen name \"{0}\" is not a valid i

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

usaxena95 added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p1-2a.cpp:106 template - constexpr int goo(const int b) requires AtLeast2 { + constexpr int goo(const int b) requires AtLeast2 { // expected-note {{candidate function}} return 2

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

usaxena95 added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p1-2a.cpp:106 template - constexpr int goo(const int b) requires AtLeast2 { + constexpr int goo(const int b) requires AtLeast2 { // expected-note {{candidate function}} return 2

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: https://github.com/llvm/llvm-project/issues/53354 Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

usaxena95 updated this revision to Diff 468925. usaxena95 added a comment. Added test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136259/new/ https://reviews.llvm.org/D136259 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaTe

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

usaxena95 updated this revision to Diff 468962. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136259/new/ https://reviews.llvm.org/D136259 Files: clang/li

[PATCH] D136259: Fix crash in constraining partial specialization on nested template.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c87e12484b3: Fix crash in constraining partial specialization on nested template. (authored by usaxena95). Repository: rG LLVM Github Monorepo C

[PATCH] D136440: Do not hide base member using decls with different template head.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136440 Files: clang/lib/Sema/SemaOverload.cpp clan

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 469552. usaxena95 added a comment. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D136440 Files: clang/lib/Sema/SemaOverload.cpp clang/test/CXX/dcl.d

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 marked 4 inline comments as done. usaxena95 added a comment. I have switched to a version where we matched template heads only when they are constraints. This is for the moment to unblock the existing bugs and not break existing code prior to C++20. Let us continue the discussion over

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 470174. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D136440 Files: clang/in

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 470505. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D136440 Files: clang/incl

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 added inline comments. Comment at: clang/test/SemaTemplate/concepts-using-decl.cpp:112 + expect<1>(baz{}.foo()); // expected-error {{call to member function 'foo' is ambiguous}} +} +} ilya-biryukov wrote: > Could you also check that `requires` clauses

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 471086. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Added release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D1364

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56099d242809: [clang] Do not hide base member using-decls with different template head. (authored by usaxena95). Changed prior to commit: https://

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

usaxena95 added a comment. Not sure if this has come up already but this would still crash on template concept C = requires(T a) { foo(a); }; struct D1 { template D1(TO); }; struct D2 { friend void foo(D1); }; static_assert(C); as we only consider conversion to its

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

usaxena95 added a comment. My suggestion would be to properly handle cycles in `CheckConstraintSatisfaction`. This problem goes beyond cycles introduced by conversion. See #53213 and #44304

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

usaxena95 added a comment. Coincidentally 2 of the bugs were just fixed in b9a77b56d8 . I do not completely agree with the approach there though. We should be fixing the root cause instead of circumventing the

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 updated this revision to Diff 451731. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D131479 Files: clang/li

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 added inline comments. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:805 +void func() { + default_ctor fail0; // expected-error-re {{call to consteval function '{{.*::default_ctor<.*::foo>}}::default_ctor' is not a constant expression}} \ +

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 updated this revision to Diff 451839. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Removed regex matching for diagnostics. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D13147

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 updated this revision to Diff 452123. usaxena95 added a comment. Added a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D131479 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaD

[PATCH] D131479: Handle explicitly defaulted consteval special members.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72ac7cac3f14: Handle explicitly defaulted consteval special members. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D131385: [clangd] Support for standard type hierarchy

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:1228 +Result["parents"] = RP.parents; + return std::move(Result); +} Nit: Allow RVO. Comment at: clang-tools-extra/clangd/Protocol.h:1415 + /// The range t

[PATCH] D131385: [clangd] Support for standard type hierarchy

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LG. Thanks! Comment at: clang-tools-extra/clangd/Protocol.cpp:1228 +Result["parents"] = RP.parents; + return std::move(Result); +} kadircet wrote:

[PATCH] D132031: Do not evaluate dependent immediate invocations

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We deferred the evaluation of dependent immediate invocations in https://reviews.llvm.org/D119375. We should also not c

[PATCH] D132031: Do not evaluate dependent immediate invocations

usaxena95 updated this revision to Diff 453526. usaxena95 marked an inline comment as done. usaxena95 edited the summary of this revision. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132031/new/ http

[PATCH] D132031: Do not evaluate dependent immediate invocations

usaxena95 added a comment. Addressed comments. Added release note. Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:665 +Bar f; +Bar g; +} // namespace issue_55601 aaron.ballman wrote: > Do you think it's worth it to add a test case like: > ``` > struct derp

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

usaxena95 added a comment. I would like to see this land. This also fixes https://github.com/llvm/llvm-project/issues/57046. Are there any pending concerns of the reviewers which we need to address ? Happy to help in any way to move this patch forward. CC: @erichkeane @cor3ntin Repository:

[PATCH] D132031: Do not evaluate dependent immediate invocations

usaxena95 updated this revision to Diff 453562. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Updated release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132031/new/ https://reviews.llvm.org/D132031 Files: clang

[PATCH] D132031: Do not evaluate dependent immediate invocations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e0e8b65765e: Do not evaluate dependent immediate invocations (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D119651: [clang] Fix evaluation context type for consteval function calls in instantiations

usaxena95 added a comment. Herald added a project: All. Hi, I have been trying to get consteval in a better shape. In D119651#3327212 , @Izaron wrote: > After an investigation in GDB I can say that the assert seems to be wrong. > Since Clang instantiate

[PATCH] D113859: [Sema] Fix consteval function calls with value-dependent args

usaxena95 added a comment. Herald added a project: All. Update: The mentioned cases here are all now fixed at head (after D132031 ) // 1 consteval int f(int n) { return n; } template constexpr int broken() { return f(M); } static_assert(broke

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

usaxena95 added a comment. Can you please also add `consteval` related test case (mentioned in https://github.com/llvm/llvm-project/issues/57046#issuecomment-1211665079) to cxx2a-consteval.cpp Reposit

<    1   2   3   4   5   >