[PATCH] D129648: Use pseudo parser for folding ranges

This revision was automatically updated to reflect the committed changes. Closed by commit rG70914aa63156: Use pseudo parser for folding ranges (authored by usaxena95). Changed prior to commit: https://reviews.llvm.org/D129648?vs=445002&id=445432#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

usaxena95 updated this revision to Diff 445547. usaxena95 added a comment. Removed option to fallback to AST based implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130011/new/ https://reviews.llvm.org/D130011 Files: clang-tools-extr

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

usaxena95 added a comment. Let us land this after the branch cut then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130011/new/ https://reviews.llvm.org/D130011 ___ cfe-commits mailing list cfe-commits@

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 445890. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-to

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:351 +int c; +[[// A comment +// expanding more than hokein wrote: > For this case, my personal preference would be to have 3 differ

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 445893. usaxena95 added a comment. Do not fill Kind in JSON when it is unspecified. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-tools-extra/clang

[PATCH] D130199: [pseudo] Add ambiguity & unparseability metrics to -print-statistics

usaxena95 added a comment. Would it make sense to expose this tool run + statistics as a library. This would help share the code for all the metrics with google3 (as we wanted to keep these metrics in both the places). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D130199: [pseudo] Add ambiguity & unparseability metrics to -print-statistics

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd9d554a3f464: [pseudo] Add ambiguity & unparseability metrics to -print-statistics (authored by sammccall, committed by us

[PATCH] D130199: [pseudo] Add ambiguity & unparseability metrics to -print-statistics

usaxena95 added a comment. Landed the patch. Will extract this as a library to share this with other continuous evaluation pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130199/new/ https://reviews.llvm.org/D130199 __

[PATCH] D130414: [pseudo] Reorganize CXX.h enums

usaxena95 added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/cxx/CXX.h:54-62 +namespace dummy { +enum Rule { +//clang-format off +#define NONTERMINAL(NAME, ID) };} namespace NAME { enum Rule : RuleID { +#define RULE(LHS, RHS, ID) RHS = ID, #include

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Reduces time spent in findRef by 66%. Repository: rG LLVM

[PATCH] D125682: Add documentHighlight in clangd check for performance measurements.

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

usaxena95 updated this revision to Diff 429696. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125675/new/ https://reviews.llvm.org/D125675 Files: clang-tool

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:951 if (const auto *Tok = TB.spelledTokenAt(L)) -References.push_back({*Tok, Roles, ID}); +References.push_back({*Tok, Roles, getSymbolID(D)}); } kadircet

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

usaxena95 updated this revision to Diff 429697. usaxena95 added a comment. Format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125675/new/ https://reviews.llvm.org/D125675 Files: clang-tools-extra/clangd/XRefs.cpp Index: clang-tools-extra/cla

[PATCH] D125682: Add documentHighlight in clangd check for performance measurements.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5edd7665fd16: Add documentHighlight in clangd check for performance measurements. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1256

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

usaxena95 updated this revision to Diff 429807. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments and added performance measurements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125675/new/ https://reviews.

[PATCH] D125675: Optimise findRefs for XRefs and docHighlights

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fb6ece2ca83: Optimise findRefs for XRefs and docHighlights (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D125925: Add an option to fill container for ref

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This allows index implementations

[PATCH] D125925: Add an option to fill container for ref

usaxena95 updated this revision to Diff 430657. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125925/new/ https://reviews.llvm.org/D125925 Files: clang-to

[PATCH] D125925: Add an option to fill container for ref

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bbf6ad5b64c: Add an option to fill container for ref (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D67358: Implement semantic selections.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. For a given cursor position, it returns ranges that are interesting to the user. Currently the semantic ranges correspond to the nodes of the syntax trees.

[PATCH] D67358: Implement semantic selections.

usaxena95 updated this revision to Diff 219381. usaxena95 added a comment. Removed logs for debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-tools-extra/clangd/CMakeLists.txt clan

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 219386. usaxena95 added a comment. Create range only if it represents a valid file range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-tools-extra/c

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:86 +// Add macro references. +for (const auto &IDToRefs : MacroRefsToIndex->MacroRefs) { + for (const auto &Range : IDToRefs.second) { ilya-biryukov wrote: > ho

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236037. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Added another version of `handleMacroOccurence` to handle MacroReferences from main file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236541. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.llvm.org/D71406 Files: clang-tool

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 marked 2 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:362 + R.Location.End.setColumn(Range.end.character); + R.Location.FileURI = MainFileURI.c_str(); + // FIXME: Add correct RefK

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236569. usaxena95 marked an inline comment as done. usaxena95 added a comment. Removed extra tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.llvm.org/D71406 Files: clang-too

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236618. usaxena95 added a comment. Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.llvm.org/D71406 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-ex

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

This revision was automatically updated to reflect the committed changes. Closed by commit rG583ba07884ed: [clangd] Add xref for macros to FileIndex. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.l

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. With this patch the `findReferences` API will return Xref for macros. If the symbol under the cursor is a macro t

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

usaxena95 updated this revision to Diff 236829. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72395/new/ https://reviews.llvm.org/D72395 Files: clang-tool

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

usaxena95 marked 2 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:463 + } + // Query the index for references from other files. + if (Index && Results.References.size() < Limit) { kadircet w

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

usaxena95 updated this revision to Diff 237596. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Removed repeated check from the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72395/new/ https://reviews.llvm.org/D72395 F

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1093 + + // If the main file is in the index, we don't return duplicates. + // (even if the references are in a different location) kadircet wrote: > i know the comme

[PATCH] D72395: [clangd] Publish xref for macros from Index and AST.

This revision was automatically updated to reflect the committed changes. Closed by commit rG734aa1d133f2: [clangd] Publish xref for macros from Index and AST. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72395/new/ https:/

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291205. usaxena95 added a comment. Added README.md for the code completion model. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CM

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291813. usaxena95 added a comment. Fixed namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-ext

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291909. usaxena95 added a comment. Fixed namespace ending. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.txt clang-to

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292188. usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tool

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:39 +'''Returns the header guard for the generated header.''' +return "GENERATED_DECISION_FOREST_MODEL_{}_H".format(filename.upper()) + adamcz wrote: >

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 marked an inline comment as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:13 + + set(output_dir ${CMAKE_BINARY_DIR}/generated/decision_forest) + set(header_file ${output_dir}/${filename}.h)

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292717. usaxena95 marked 12 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-too

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292818. usaxena95 added a comment. Removed generated (for review) files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 292828. usaxena95 added a comment. Fixed output_dir cmake variable. Clean build succeeds now. Ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files:

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9b6765e784b3: [clangd] Add Random Forest runtime for code completion. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88071: [clangd] Add a trained DecisionForest for code completion.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Replaces the dummy CodeCompletion model with a trained DecisionForest model. The

[PATCH] D88146: Dummy git message. Update from phabricator.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D88146 Files: clang-tools-extra/clangd/Quality.cpp clang-tool

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 updated this revision to Diff 293706. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79500/new/ https://reviews.llvm.org/D79500 Files: clang-tool

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/Quality.h:129 + // Properties and utilites used to compute derived signals. These are ignored + // by a scoring function. Must be explicitly assigned. sammccall wrote: > Why is it better to

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 closed this revision. usaxena95 added a comment. Closed with commit 158af0d3d165c0382a6a291e81ffecf0b18ffe77 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. By default clangd scores a code completion item using heuristic model. S

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

usaxena95 updated this revision to Diff 294281. usaxena95 added a comment. Moved DF evaluation to Quality.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88281/new/ https://reviews.llvm.org/D88281 Files: clang-tools-extra/clangd/CodeComplete.c

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

usaxena95 updated this revision to Diff 294684. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88281/new/ https://reviews.llvm.org/D88281 Files: clang-tool

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

usaxena95 added a comment. If we just consider ranking, there are not many code paths. Most of the code paths are for gathering and creating code completion items. In the end all the code paths end up in the `addCandidate` method to get `scored` either by heuristics or by decision forest. So I h

[PATCH] D88281: [clangd] Use Decision Forest to score code compeltions.

usaxena95 updated this revision to Diff 294711. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added fixme for renaming evaluate() and fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88281/new/ https://reviews.llvm

[PATCH] D88071: [clangd] Add a trained DecisionForest for code completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5f7e9e26cd0: [clangd] Add a trained DecisionForest for code completion. (authored by usaxena95). Changed prior to commit: https://reviews.llvm.org/D88071?vs=293346&id=294732#toc Repository: rG LLVM

[PATCH] D88281: [clangd] Use Decision Forest to score code completions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8b55b6939a5: [clangd] Use Decision Forest to score code completions. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D88431: [clangd] Rename evaluate() to evaluateHeuristics()

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Since we have 2 scoring functions (heuristics and decision forest), renaming the

[PATCH] D88431: [clangd] Rename evaluate() to evaluateHeuristics()

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b1666f3ce2b: [clangd] Rename evaluate() to evaluateHeuristics() (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88431/new/ https://r

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 291024. usaxena95 marked 23 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-too

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:30 + +set(DF_COMPILER ${CMAKE_CURRENT_SOURCE_DIR}/CompletionModelCodegen.py) +include(${CMAKE_CURRENT_SOURCE_DIR}/CompletionModel.cmake) sammccall wrote: > if you want the comp

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added a comment. Hi @jkorous > Do you guys intend to open-source also the training part of the model > pipeline ? Open sourcing the training part (both dataset generation and using an open sourced DecisionForest based framework for training) has been on our radar. Although gathering

[PATCH] D93029: [clangd] Find relations in Dex exploration tool.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https

[PATCH] D93029: [clangd] Find relations in Dex exploration tool.

usaxena95 updated this revision to Diff 310861. usaxena95 added a comment. Update error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93029/new/ https://reviews.llvm.org/D93029 Files: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp I

[PATCH] D93029: [clangd] Find relations in Dex exploration tool.

usaxena95 updated this revision to Diff 310893. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93029/new/ https://reviews.llvm.org/D93029 File

[PATCH] D93029: [clangd] Find relations in Dex exploration tool.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ce242a163c3: [clangd] Find relations in Dex exploration tool. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D92299: [clangd] Go-to-definition on pure virtual method decls jumps to all overrides.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. LG. Thanks. Comment at: clang-tools-extra/clangd/XRefs.cpp:316 +if (!DefLoc) { + elog("Failed to convert location:", DefLoc.takeError()); + return; --

[PATCH] D90828: [clangd] Trivial: Log missing completion signals.

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https

[PATCH] D90828: [clangd] Trivial: Log missing completion signals.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf253823398dd: [clangd] Trivial: Log missing completion signals. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This was previously explored in reviews.llvm.org/D69094

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

usaxena95 updated this revision to Diff 305727. usaxena95 added a comment. added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files: clang-tools-extra/clangd/index/Relation.cpp clang-tool

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91626 Files:

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

usaxena95 updated this revision to Diff 305776. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files: clang-tool

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

usaxena95 marked an inline comment as done. usaxena95 added a comment. Bumped the index version. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 ___ cfe-c

[PATCH] D91610: [clangd] Add OverridenBy Relation to index.

usaxena95 updated this revision to Diff 305780. usaxena95 added a comment. Herald added a subscriber: wenlei. Updated sample input for index-serialization test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D9161

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/Relation.h:24 BaseOf, + OverridenBy, }; Quuxplusone wrote: > s/Overriden/Overridden/g Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

usaxena95 updated this revision to Diff 305783. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. s/OverridenBy/OverriddenBy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files: cla

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

usaxena95 updated this revision to Diff 305787. usaxena95 marked an inline comment as done. usaxena95 added a comment. Add documentation for change in index test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305800. usaxena95 added a comment. Herald added a subscriber: wenlei. Type fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/Clan

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

usaxena95 updated this revision to Diff 305802. usaxena95 added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610 Files: clang-tools-extra/clangd/index/Relation.cpp clang-tools-extra/

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305808. usaxena95 added a comment. Typo fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305825. usaxena95 added a comment. Refactor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305835. usaxena95 edited the summary of this revision. usaxena95 added a comment. Minor fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-ex

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305972. usaxena95 added a comment. Addressed final comments. Ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/ClangdLS

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 305974. usaxena95 added a comment. Remove unintended change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp c

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

usaxena95 updated this revision to Diff 305976. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed final comments. Ready to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91610/new/ https://reviews.llvm.org/D91610

[PATCH] D91610: [clangd] Add OverriddenBy Relation to index.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bc085f5b3ed: [clangd] Add OverridenBy Relation to index. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D91702: [clangd] Implement textDocument/implementation (Xref layer)

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Implements textdocument/implementation (https://microsoft.github.io/language-se

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 306076. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tool

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:1153 + Index->relations(Req, [&](const SymbolID &Subject, const Symbol &Object) { +if (auto Loc = symbolToLocation(Object, *MainFilePath)) + Results.References.push_back(*Loc); -

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 306079. usaxena95 added a comment. Added test for no implementation for concrete methods. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tools-extra/c

[PATCH] D91702: [clangd] Implement textDocument/implementation (Xref layer)

usaxena95 updated this revision to Diff 306114. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91702/new/ https://reviews.llvm.org/D91702 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-extra

[PATCH] D91626: [clangd] Implement textDocument/implementation.

usaxena95 updated this revision to Diff 306115. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91626/new/ https://reviews.llvm.org/D91626 Files: clang-tool

[PATCH] D91721: [clangd] textDocument/implementation (LSP layer)

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D91721 Files:

[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

usaxena95 created this revision. usaxena95 added a reviewer: adamcz. Herald added subscribers: cfe-commits, kadircet, arphaman. Herald added a project: clang. usaxena95 requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. MSAN build times out for generated DecisionF

[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

usaxena95 updated this revision to Diff 295005. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88495/new/ https://reviews.llvm.org/D88495 Files: clang-tools-extra/clangd/quality/CompletionModelCodege

<    1   2   3   4   5   >