[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 created this revision. Herald added a subscriber: cfe-commits. Added support of creating a hardlink from one file to another file. After a hardlink is added between two files, both file will have the same: 1. UniqueID (inode) 2. Size 3. Buffer This will bring replay of compilation clos

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 updated this revision to Diff 163128. usaxena95 added a comment. Created InMemoryHardLink Class which can handle the resolved InMemoryFile Repository: rC Clang https://reviews.llvm.org/D51359 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp uni

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Applied the suggested changes. Added InMemoryHardLink as a subclass of InMemoryNode. Modified the tests accordingly. Repository: rC Clang https://reviews.llvm.org/D51359 ___

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 marked 7 inline comments as done. usaxena95 added a comment. > Could we try removing Status from the base class and move it into > `InMemoryFile` and `InMemoryDir`? Moved the Stat and **getStatus** into the subclasses. User of **getStatus** now calls **getStatus** of individual subcla

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 updated this revision to Diff 163330. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. - Moved Stat to the subclasses of InMemoryNode Repository: rC Clang https://reviews.llvm.org/D51359 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileS

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 updated this revision to Diff 163549. usaxena95 marked 15 inline comments as done. usaxena95 added a comment. - Made suggested changes. Repository: rC Clang https://reviews.llvm.org/D51359 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittest

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 added a comment. Made the suggested changes. Comment at: include/clang/Basic/VirtualFileSystem.h:359 + public: + /// Add a HardLink to a File. + /// The To path must be an existing file or a hardlink. The From file must not ilya-biryukov wrote: >

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 marked 16 inline comments as done. usaxena95 added a comment. Applied suggested changes. Comment at: lib/Basic/VirtualFileSystem.cpp:653 + // Cannot create HardLink from a directory. + if (HardLinkTarget && (!isa(HardLinkTarget) || Buffer)) +return false; --

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 updated this revision to Diff 163713. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. - applied suggested changes Repository: rC Clang https://reviews.llvm.org/D51359 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittes

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 updated this revision to Diff 163720. usaxena95 added a comment. - Moved helper function into anonymous namespace Repository: rC Clang https://reviews.llvm.org/D51359 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/VirtualFileSys

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 added a comment. Applied the changes suggested. Comment at: lib/Basic/VirtualFileSystem.cpp:677 +if (HardLinkTarget) + Child.reset(new detail::InMemoryHardLink(P.str(), *HardLinkTarget)); +else { ilya-biryukov wrote: > NIT: `.

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 updated this revision to Diff 163739. usaxena95 marked 14 inline comments as done. usaxena95 added a comment. - applied changes Repository: rC Clang https://reviews.llvm.org/D51359 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/Basic/

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 updated this revision to Diff 163785. usaxena95 marked 9 inline comments as done. usaxena95 added a comment. - fixed the style issues Repository: rC Clang https://reviews.llvm.org/D51359 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/VirtualFileSystem.cpp unittests/

[PATCH] D51359: Adding HardLink Support to VirtualFileSystem.

usaxena95 added a comment. I don't have commit access. Can you please submit this ? Repository: rC Clang https://reviews.llvm.org/D51359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D52620: Added Support for StatOnly Files in VFS.

usaxena95 created this revision. Herald added subscribers: cfe-commits, mgrang. Some files are only Statted by Clang and not read. Clang mostly uses them for checking the existence of some files and in rare cases uses the value of the Status to proceed further (for example while loading module fil

[PATCH] D52620: Added Support for StatOnly Files in VFS.

usaxena95 added a comment. > it sounds like this is for record-replay. Yes this is for record-replay purpose. > What are these files in practice? During loading a modules the files that were required to make the module are stat()ed and their sizes are used to verify that the module is still va

[PATCH] D52620: Added Support for StatOnly Files in VFS.

usaxena95 added inline comments. Comment at: lib/Basic/VirtualFileSystem.cpp:2097 void YAMLVFSWriter::write(llvm::raw_ostream &OS) { - llvm::sort(Mappings, [](const YAMLVFSEntry &LHS, const YAMLVFSEntry &RHS) { + llvm::sort(Mappings.begin(), Mappings.end(), + [](co

[PATCH] D58278: Prepare ground for re-lexing modular headers.

usaxena95 added a comment. +cc myself Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58278/new/ https://reviews.llvm.org/D58278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D65866: Code completion should not ignore default parameters in functions.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Inorder to display the default arguments we must process the CK_Optional chunks of CodeCompletionString while creating the Sign

[PATCH] D65866: Code completion should not ignore default parameters in functions.

usaxena95 updated this revision to Diff 213871. usaxena95 added a comment. Removed unused include of logger. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65866/new/ https://reviews.llvm.org/D65866 Files: clang-tools-extra/clangd/CodeCompletionS

[PATCH] D65866: Code completion should not ignore default parameters in functions.

usaxena95 updated this revision to Diff 213926. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Added tests in CodeCompletionStringsTests.cpp Resolved comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65866/new/ https:/

[PATCH] D65866: Code completion should not ignore default parameters in functions.

usaxena95 updated this revision to Diff 213927. usaxena95 added a comment. Formatted new test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65866/new/ https://reviews.llvm.org/D65866 Files: clang-tools-extra/clangd/CodeCompletionStrings.cpp c

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220071. usaxena95 marked 13 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-too

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:33 + if (!Offset) { +llvm::errs() << "Unable to convert postion to offset"; +return {}; sammccall wrote: > we use log() or elog() for this, make sure you include

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220074. usaxena95 added a comment. Minor changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220075. usaxena95 added a comment. Remove extraneous namespace comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-tools-extra/clangd/CMakeLists.t

[PATCH] D67358: [clangd] Implement semantic selections.

usaxena95 updated this revision to Diff 220303. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Resolved comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 Files: clang-tools

[PATCH] D67358: [clangd] Implement semantic selections.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371976: Implement semantic selections. (authored by usaxena95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D6

[PATCH] D67650: Add SemanticRanges to Clangd server.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Adds Semantic Ranges capabilities to Clangd server. Also adds tests for running it via clangd server. Th

[PATCH] D67650: [clangd] Add SemanticRanges to Clangd server.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372102: Add SemanticRanges to Clangd server. (authored by usaxena95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D67650: [clangd] Add SemanticRanges to Clangd server.

usaxena95 updated this revision to Diff 220465. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67650/new/ https://reviews.llvm.org/D67650 Files: clang-tool

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This adds semantic selection to the LSP Server. Adds support for serialization of input request and the o

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 220703. usaxena95 added a comment. Fixed error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 220710. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tool

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1135 + Params.positions.size()); +Reply(llvm::make_error("failed to decode request", + ErrorCode::InvalidRequest)); ilya-biry

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221499. usaxena95 marked 7 inline comments as done. usaxena95 added a comment. Addressed comments: Added client/server capabilities. Made lit test smaller. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added a comment. I am not sure adding client capability is useful here. I have not used the client capability for selectionRange anywhere and I think we can remove it. WDYT ? Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1131 +Callback> Reply) { + if

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221510. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tool

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added a comment. > The SelectionRangeClientCapabilities determines what should the LSP server > send the client, if it is true, clangd should send > SelectionRangeRegistrationOptions. > But looking at the current specification, it doesn't seem to add too much > value. I think we can

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221521. usaxena95 marked 9 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tool

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1169 +Result.emplace_back(render(std::move(*Ranges))); +return Reply(std::move(Result)); + }); hokein wrote: > does `Reply({render(std::move(*Ranges))})

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221534. usaxena95 added a comment. Removed ununsed header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cla

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372753: [clangd] Add semantic selection to ClangdLSPServer. (authored by usaxena95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Removes the 'using namespace' under the cursor and qualifies all accesses in the current file. E.g.: using namespace std;

[PATCH] D68565: [clang] Add test for FindNextToken in Lexer.

usaxena95 created this revision. usaxena95 added a reviewer: ilya-biryukov. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68565 Files: clang/unittests/Lex/LexerTest.cpp Index: clang/unittests/Lex/LexerTes

[PATCH] D68565: [clang] Add test for FindNextToken in Lexer.

usaxena95 updated this revision to Diff 223503. usaxena95 added a comment. Revert unintended formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68565/new/ https://reviews.llvm.org/D68565 Files: clang/unittests/Lex/LexerTest.cpp Index: c

[PATCH] D68565: [clang] Add test for FindNextToken in Lexer.

usaxena95 updated this revision to Diff 223524. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments and fixed build failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68565/new/ https://reviews.llvm.org/D68

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 223592. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Make the tweak trigger only for TopLevelDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llvm.org/D

[PATCH] D68565: [clang] Add test for FindNextToken in Lexer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGedf5027689c5: [clang] Add test for FindNextToken in Lexer. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68565/new/ https://reviews

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 223898. usaxena95 marked 8 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llvm.org/D68562 Files: clang-tool

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:99 +return false; + if (!dyn_cast(TargetDirective->getDeclContext())) +return false; ilya-biryukov wrote: > I believe this check is redundant i

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:87 +return false; + if (const Decl *ParentDecl = Node->Parent->ASTNode.get()) +return llvm::isa(ParentDecl); ilya-biryukov wrote: > Can we use

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 224038. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Make action unavailable if the namespace contains a using namespace decl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 224067. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Added documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llvm.org/D68562 Files: clang-too

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 225183. usaxena95 marked 11 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llvm.org/D68562 Files: clang-too

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:139 + SourceLocation FirstUsingDirectiveLoc = + SM.getLocForEndOfFile(SM.getMainFileID()); + for (auto *D : AllDirectives) { ilya-biryukov wrote

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb62b45412168: [clangd] Add RemoveUsingNamespace tweak. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llv

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 created this revision. usaxena95 added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. This patch extends the removing using-namespace code action to remove using-namespace decl that are prese

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 updated this revision to Diff 225596. usaxena95 added a comment. Added additional tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69162/new/ https://reviews.llvm.org/D69162 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUsi

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 added a comment. The features refers to the code completion signals in https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clangd/Quality.h These signals are currently used to map the code completion candidates to a relevance score using hand-coded heuristics. We intend

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 280406. usaxena95 added a comment. Addressed offline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814 Files: clang-tools-extra/clangd/CMakeLists.txt clan

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 updated this revision to Diff 280455. usaxena95 edited the summary of this revision. usaxena95 added a comment. Better formatting in generated files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83814/new/ https://reviews.llvm.org/D83814

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

usaxena95 created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. [WIP] - Proposes a json format for representing Random Forest model. - Proposes a way to test the generated runtime using a test mod

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 created this revision. usaxena95 added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Current implementation of heuristic-based scoring function also contains computation of derived signal

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

usaxena95 updated this revision to Diff 262852. usaxena95 added a comment. - Added DerivedSignals struct containing all the derived signals. - Added NameMatchesContext and proximtiy signals to this struct. - We need to call computeDerivedSignals() before calling evaluate() if we set non-concrete

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 456321. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-tool

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 456335. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-to

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa11ec00afea3: FoldingRanges: Handle LineFoldingsOnly clients. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://rev

[PATCH] D132919: [clangd] Enable folding ranges by default.

usaxena95 created this revision. usaxena95 added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository

[PATCH] D132919: [clangd] Enable folding ranges by default.

usaxena95 updated this revision to Diff 456584. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132919/new/ https://reviews.llvm.org/D132919 Files: clang-to

[PATCH] D132919: [clangd] Enable folding ranges by default.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc33873502003: [clangd] Enable folding ranges by default. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D132918: [clang] Fix a crash in constant evaluation

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. This looks reasonable. As discussed offline, this verifiably fixes the crash but it is hard to come up with a reduced reproducer. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes: https://github.com/llvm/llvm-project/issues/56183 Fixes: https://github.com/llvm/llvm-project/issues/51695 Fixes:

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 updated this revision to Diff 456684. usaxena95 added a comment. More tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D132945 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 updated this revision to Diff 456685. usaxena95 added a comment. new line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D132945 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp cl

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 updated this revision to Diff 456739. usaxena95 added a comment. Add some test with expected errors as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D132945 Files: clang/docs/ReleaseNotes.rst

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 updated this revision to Diff 456745. usaxena95 added a comment. This actually fixes two more issues. Update release notes and add more documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D132

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 added a comment. Gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D132945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

usaxena95 updated this revision to Diff 457546. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments and added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132945/new/ https://reviews.llvm.org/D1329

[PATCH] D132945: [clang] Skip re-building lambda expressions in parameters to consteval fns.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7eec3824656: [clang] Skip re-building lambda expressions in parameters to consteval fns. (authored by usaxena95). Changed prior to commit: https:

[PATCH] D133299: [clangd] Fix LineFoldingOnly flag is not propagated correctly to ClangdServer.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. Sorry I missed this. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:487-497 { // Switch caller's context with LSPServer's background context.

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 447926. usaxena95 marked 4 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-to

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:232 +while (T != Tokens.end() && T->Kind == tok::comment && + LastComment->Line == T->Line + 1) { + LastComment = T; hokein wrote: > this seems incorrec

[PATCH] D130081: Add foldings for multi-line comment.

usaxena95 updated this revision to Diff 447928. usaxena95 added a comment. Remove unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.org/D130081 Files: clang-tools-extra/clangd/Protocol.cpp clang

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf537bef6393: Use pseudoparser-based folding ranges in ClangdServer. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130011/new/ http

[PATCH] D130081: Add foldings for multi-line comment.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ef11616b228: Add foldings for multi-line comment. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130081/new/ https://reviews.llvm.o

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Do not fold the endline wh

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 449928. usaxena95 added a comment. Do same for multi-line comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-tools-extra/clangd/ClangdLSPServe

[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

usaxena95 updated this revision to Diff 449931. usaxena95 added a comment. More tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131154/new/ https://reviews.llvm.org/D131154 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-e

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 created this revision. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D131479 Files: clang/lib/Sema/SemaDeclCXX.cpp clang

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 updated this revision to Diff 451333. usaxena95 added a comment. Added tests for multiple constructors in a templated class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D131479 Files: clang/lib/Se

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 updated this revision to Diff 451353. usaxena95 added a comment. Verify that non-consteval constructors (among others) cannot be used in a consteval context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 updated this revision to Diff 451432. usaxena95 marked an inline comment as done. usaxena95 added a comment. Addressed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131479/new/ https://reviews.llvm.org/D131479 Files: clang/lib

[PATCH] D131479: Handle explicitly defaulted consteval special members.

usaxena95 added a comment. As discussed offline, we are already following the discussion 2602 . We are keeping the constructor `consteval` to allow complaining when we are actually processing the call to data member constructors

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 created this revision. Herald added subscribers: kadircet, arphaman, mgorny. Herald added a project: All. usaxena95 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. For sharing. WIP Repository: rG LLVM Github Monore

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 444755. usaxena95 added a comment. Addressed offline comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-tools-extra/clangd/CMakeLists.txt cl

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 444765. usaxena95 added a comment. Removed changes from previous revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-tools-extra/clangd/CMakeLi

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 444975. usaxena95 marked 15 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-t

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:185 +if (auto *Paired = Tok.pair()) { + if (Tok.Line < Paired->Line) { +Position Start = offsetToPosition( hokein wrote: > The `if` logic seems tricky, it

[PATCH] D129648: Use pseudo parser for folding ranges

usaxena95 updated this revision to Diff 445002. usaxena95 added a comment. Removed unused headers and fix spellings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129648/new/ https://reviews.llvm.org/D129648 Files: clang-tools-extra/clangd/CMake

  1   2   3   4   5   >