Re: [PATCH] D11738: Add new llvm.loop.unroll.enable metadata which is now generated by "#pragma unroll" directive

tyler.nowicki added a subscriber: tyler.nowicki. tyler.nowicki added a comment. Hi Mark, The patch LGTM! Tyler http://reviews.llvm.org/D11738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [Patch][LoopVectorize]Late evaluation of vectorization requirements

Hi, Could I get a review of these patches? Thanks, Tyler > On Jul 27, 2015, at 4:45 PM, Tyler Nowicki wrote: > > Please ignore the debug line in the LLVM late-evaluation patch. It won’t be > part of the commit. > > + DEBUG(dbgs() << "LV: Emitting anal

Re: [PATCH] D48808: [CodeGen] Emit parallel_loop_access for each loop in the loop stack.

fety' applies to the same loop scope(s) as the other loop pragmas, or it applies to all nested loops? My opinion is that for consistency 'assume_safety' and similar options apply to the same scope(s) as 'vectorize(enable)'. But I am open to alternatives if others see it diffe

Re: [PATCH] D69088: [Lex] #pragma clang transform

Sorry if this is answered in the patches but what happens if a loop has both #pragma clang loop and transform defined before it? I guess it probably shouldn't work. Perhaps instead you could create a new option to indicate that the order should be respected. #pragma clang loop respect_order <- o

Re: [Patch][LoopVectorize]Late evaluation of vectorization requirements

Thanks! Committed in clang r244492, llvm r244489/r244505/r244494. Tyler > On Aug 9, 2015, at 9:33 PM, Hal Finkel wrote: > > Hi Tyler, > > These LGTM, thanks! > > -Hal > > - Original Message ----- >> From: "Tyler Nowicki" >> To: "H

r244506 - Remove non-ascii characters.

Author: tnowicki Date: Mon Aug 10 16:18:01 2015 New Revision: 244506 URL: http://llvm.org/viewvc/llvm-project?rev=244506&view=rev Log: Remove non-ascii characters. Modified: cfe/trunk/include/clang/Basic/DiagnosticFrontendKinds.td cfe/trunk/test/Frontend/optimization-remark-options.c Mod

Re: r244492 - Append options for floating-point commutivity when related diagnostics are produced.

Thanks Aaron! Fixed in r244506. Tyler On Mon, Aug 10, 2015 at 12:58 PM, Aaron Ballman wrote: > On Mon, Aug 10, 2015 at 3:56 PM, Tyler Nowicki via cfe-commits > wrote: > > Author: tnowicki > > Date: Mon Aug 10 14:56:40 2015 > > New Revision: 244492 > > > &

r244517 - Make frontend floating-point commutivity test X86 specific to avoid cost-model related problems on arm-thumb and hexagon.

Author: tnowicki Date: Mon Aug 10 17:17:40 2015 New Revision: 244517 URL: http://llvm.org/viewvc/llvm-project?rev=244517&view=rev Log: Make frontend floating-point commutivity test X86 specific to avoid cost-model related problems on arm-thumb and hexagon. Modified: cfe/trunk/test/Frontend/o

r244526 - Append options for vectorization when pointer checking threshold is exceeded.

Author: tnowicki Date: Mon Aug 10 18:05:16 2015 New Revision: 244526 URL: http://llvm.org/viewvc/llvm-project?rev=244526&view=rev Log: Append options for vectorization when pointer checking threshold is exceeded. Following one of the appended options will allow the loop to be vectorized. We do n

Re: [Patch][LoopVectorize] Late evaluate of runtime pointer check's threshold

ate set of > patches regardless). > > Otherwise, LGTM. > > Thanks again, > Hal > > - Original Message - >> From: "Tyler Nowicki" mailto:tnowi...@apple.com>> >> To: "Hal J. Finkel" mailto:hfin...@anl.gov>>, "Commit &g

Re: r244526 - Append options for vectorization when pointer checking threshold is exceeded.

Oh, sorry about that! I'll make that change. Tyler On Mon, Aug 10, 2015 at 4:35 PM, Hal Finkel wrote: > - Original Message - > > From: "Tyler Nowicki via cfe-commits" > > To: cfe-commits@lists.llvm.org > > Sent: Monday, August 10, 2015 6:05:17 PM &

r244556 - Print vectorization analysis when loop hint is specified.

Author: tnowicki Date: Mon Aug 10 20:10:08 2015 New Revision: 244556 URL: http://llvm.org/viewvc/llvm-project?rev=244556&view=rev Log: Print vectorization analysis when loop hint is specified. This patche and a related llvm patch solve the problem of having to explicitly enable analysis when spe

r244561 - Make the analysis reporting test with x86 to fix the hexagon build.

Author: tnowicki Date: Mon Aug 10 20:54:48 2015 New Revision: 244561 URL: http://llvm.org/viewvc/llvm-project?rev=244561&view=rev Log: Make the analysis reporting test with x86 to fix the hexagon build. Modified: cfe/trunk/test/Frontend/optimization-remark-analysis.c Modified: cfe/trunk/test

Re: [Patch][LoopVectorize] Print vectorization analysis when loop hint pragma is specified

a > FIXME if you're not going to do this yourself). Another place where this > would be useful is to warn the user when a function marked always_inline is > not actually inlined. > > -Hal > > - Original Message - >> From: "Tyler Nowicki" mailt

Re: [Patch][LoopVectorize] Print vectorization analysis when loop hint pragma is specified

Thanks! Tyler > On Aug 11, 2015, at 3:27 PM, Mark Heffernan wrote: > > Nice! > > On Mon, Aug 10, 2015 at 6:57 PM, Tyler Nowicki <mailto:tnowi...@apple.com>> wrote: > Mark: Would you be interested in extending this to the loop unroller as well? > > I'd

Improved Diagnostics and Extended vectorize(enable)

Hi, I’ve been working on the vectorization diagnostics a little more. The first patch makes sure the analysis diagnostics are printed unless a disabling hint is provided. And the two pairs of LLVM and Clang patches make the diagnostic messages easier to understand and extend the vectorize(enabl

r246189 - Improve options printed on vectorization analysis diagnostics.

Author: tnowicki Date: Thu Aug 27 13:58:34 2015 New Revision: 246189 URL: http://llvm.org/viewvc/llvm-project?rev=246189&view=rev Log: Improve options printed on vectorization analysis diagnostics. The LLVM patch changes the analysis diagnostics produced when loops with floating-poin

Re: [Patch][LoopVectorize]Late evaluation of vectorization requirements

: Binary data Clang-Add-diagnostic-to-append-fp-commute-clang-options-to.patch Description: Binary data On Aug 5, 2015, at 1:57 PM, Tyler Nowicki <tnowi...@apple.com> wrote:Hi,Could I get a review of these patches?Thanks,TylerOn Jul 27, 2015, at 4:45 PM, Tyler Nowicki <tnowi...@

[Patch][LoopVectorize] Late evaluate of runtime pointer check's threshold

Hi,This patch extends the patches in 'Late evaluation of vectorization requirements’ (still in review). This makes the num runtime pointer checks test into a late diagnostic so we can give the user a better diagnostic message. Clang appends the diagnostic with options for getting the loop vectorize

[Patch][LoopVectorize] Print vectorization analysis when loop hint pragma is specified

Hi,Currently, when loop hint is used but vectorization fails we generate a warning. To get the analysis the user needs to provide the command line option -Rpass-analysis= with the correct pass name. BUT we don’t tell the user which pass name they will need to get the analysis message. We should be

r244492 - Append options for floating-point commutivity when related diagnostics are produced.

Author: tnowicki Date: Mon Aug 10 14:56:40 2015 New Revision: 244492 URL: http://llvm.org/viewvc/llvm-project?rev=244492&view=rev Log: Append options for floating-point commutivity when related diagnostics are produced. With this patch clang appends the command line options that would allow vec

[PATCH] D69088: [Lex] #pragma clang transform

tyler.nowicki added a comment. In D69088#1713648 , @Meinersbur wrote: > In D69088#1713623 , @hsaito wrote: > > > @Meinersbur, if I remember correctly, there was an RFC discussion on this > > topic, right? If yes, w