https://github.com/tuliom created
https://github.com/llvm/llvm-project/pull/73146
Struct Module::Header is not a POD type. As such, qsort() and
llvm::array_pod_sort() must not be used to sort it. This became an issue with
the new implementation of qsort() in glibc 2.39 that is not guaranteed t
https://github.com/tuliom updated
https://github.com/llvm/llvm-project/pull/73146
>From d0a86b80256a45bfdee790a7aec5a48d2d71e6bb Mon Sep 17 00:00:00 2001
From: Tulio Magno Quites Machado Filho
Date: Wed, 22 Nov 2023 14:01:24 -0300
Subject: [PATCH 1/2] [clang] Fix sorting module headers
Struct
tuliom wrote:
I've just fixed the code format.
https://github.com/llvm/llvm-project/pull/73146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tuliom wrote:
> Sorry, I don't quite understand tnhis
@dwblaikie Would you have any questions? I'd be glad to answer them.
https://github.com/llvm/llvm-project/pull/73146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
tuliom wrote:
> Sorry, I don't quite understand tnhis - but I guess the second field (
> PathRelativeToRootModuleDirectory ) comparison was to address this bug?
@dwblaikie Yes.
> It'd probably be good to fix that separately, so it can be discussed in more
> detail, etc.
The commit is already
https://github.com/tuliom updated
https://github.com/llvm/llvm-project/pull/73146
>From d0a86b80256a45bfdee790a7aec5a48d2d71e6bb Mon Sep 17 00:00:00 2001
From: Tulio Magno Quites Machado Filho
Date: Wed, 22 Nov 2023 14:01:24 -0300
Subject: [PATCH 1/3] [clang] Fix sorting module headers
Struct
https://github.com/tuliom edited https://github.com/llvm/llvm-project/pull/73146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tuliom wrote:
OK. I modified this PR in order to only make the changes that fix #73145 .
Sorting will remain broken as it has been since 2021. I will provide another PR
after this one gets merged.
https://github.com/llvm/llvm-project/pull/73146
___
cf
https://github.com/tuliom closed https://github.com/llvm/llvm-project/pull/73146
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tuliom created
https://github.com/llvm/llvm-project/pull/73323
This code was initially written in commit
7ff29148ac7883881e62dc9e1714057c68ad4436 with the intention of sorting headers
according to their path. At the time, the path was saved in field NameAsWritten
of Module::
tuliom wrote:
> So what breakage is caused by the sorting failure?
@dwblaikie This is not causing a breakage. It is just not working as designed
because the sort function has been comparing `""` against `""` since commit
https://github.com/llvm/llvm-project/commit/e6830b6028ec5434ccf8dbebdd992
https://github.com/tuliom created
https://github.com/llvm/llvm-project/pull/84186
Use a path that works for both standalone as well as full repository builds.
Fixes: 9b672de99760 ("[clang][Builtins] Parse clang extended vectors types.
(#83584)")
>From 46e044a7c97fe1891a9109e423c66ff75c9c4a14
tuliom wrote:
@fpetrogalli I found a small issue with this PR. Could you take a look at PR
#84186 and review it, please?
https://github.com/llvm/llvm-project/pull/83584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/tuliom closed https://github.com/llvm/llvm-project/pull/84186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Tulio Magno Quites Machado Filho
Date: 2023-07-18T16:12:07-03:00
New Revision: 1be4db73642fa0658d3b1e1dad7ec95259d1d261
URL:
https://github.com/llvm/llvm-project/commit/1be4db73642fa0658d3b1e1dad7ec95259d1d261
DIFF:
https://github.com/llvm/llvm-project/commit/1be4db73642fa0658d3b1e1dad7
tuliom wrote:
> `clang::Driver` has this method which allows you to specify the starting path
> for the clang installation to use for the resource lookup.
>
> ```c++
> /// Takes the path to a binary that's either in bin/ or lib/ and returns
> /// the path to clang's resource directory.
> static
tuliom wrote:
> I wonder if that last one is a bug...?
Agreed.
> If so, it seems it would be better to just fold `CLANG_RESOURCE_DIR` into
> `Driver::GetResourcesPath` and remove the optional argument.
Or making `CustomResourceDir = CLANG_RESOURCE_DIR` by default instead of `""`.
This would a
tuliom wrote:
@kimgr Good points. I agree with you.
https://github.com/llvm/llvm-project/pull/97197
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tuliom wrote:
> Is there an out-of-tree scenario where CLANG_RESOURCE_DIR needs to be
> replaced with something else at runtime, i.e. a real use-case for the
> optional CustomResourceDir optional argument I removed?
@kimgr I have also looked for this and I haven't found an use-case where this
tuliom wrote:
> Do we need anything more to make progress with this PR?
@kimgr Do you have committer permission? Would you like some help to get this
merged?
https://github.com/llvm/llvm-project/pull/103388
___
cfe-commits mailing list
cfe-commits@li
tuliom wrote:
Agreed. Let me merge this.
https://github.com/llvm/llvm-project/pull/103388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tuliom closed
https://github.com/llvm/llvm-project/pull/103388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tuliom wrote:
@wwwatermiao I noticed the author name in the commit is `unknown`.
Is that intentional? Would you like to change it?
https://github.com/llvm/llvm-project/pull/118109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/tuliom closed
https://github.com/llvm/llvm-project/pull/118109
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
24 matches
Mail list logo
