[PATCH] D9403: llvm.noalias - Clang CodeGen for local restrict-qualified pointers

troyj added a comment. Hi, I got here via llvm-dev => https://reviews.llvm.org/D9375 => https://reviews.llvm.org/D9403 (this) and have read through everything. I see that this patch has been stalled for about a year and I would like to know its status. Is it waiting on a resolution in LLVM fo

[PATCH] D54489: Implement -frecord-gcc-switches

troyj added a comment. I realize that you're probably striving for option compatibility with gcc, but continuing to name it -frecord-gcc-switches when it actually records Clang switches seems weird to me. It almost sounds like something that would dump gcc equivalents of all Clang options, or

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

troyj added a comment. Hi, we just inherited this commit at Cray when we did our latest upstream merge and there are a few problems with it that I'd like to point out. Sorry that I was not part of the initial discussion here, but I didn't know that this work was being done and I had already do

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

This revision was automatically updated to reflect the committed changes. Closed by commit rG10c0eca25523: [clang][Lexer] Speed up HeaderSearch when there are many HeaderMaps (authored by troyj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135801/n

[PATCH] D136190: [clang][Sema] remove redundant isTypeValid

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These isTypeValid calls are redundant because the isDerivedFrom call performs the same checks.

[PATCH] D136633: [clang][AST] avoid unnecessary FunctionProtoTypes.FindNodeOrInsertPos call

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. getFunctionTypeInternal forms a FoldingSetNodeID and then calls FunctionProtoTypes.FindNodeOrIns

[PATCH] D136779: [clang][AST] make FunctionProtoType::Profile consistent for FoldingSet

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the Profile function to match the FunctionProtoType constructor, which uses e

[PATCH] D136190: [clang][Sema][NFC] Remove redundant isTypeValid

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG488cf1038c88: [clang][Sema][NFC] Remove redundant isTypeValid (authored by troyj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137179: [clang][Lex] Header search case insensitivity

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Correct D135801 to be case insensitive. Repository: rG LLV

[PATCH] D137179: [clang][Lex] Header map search case insensitivity

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00022c5613a7: [clang][Lex] Header map search case insensitivity (authored by troyj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

troyj created this revision. troyj added a reviewer: rsmith. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rG04ba1856 introduced a

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

troyj updated this revision to Diff 465759. troyj added a comment. Pulled and regenerated diff. I'm not sure what the problem was and it still looks the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135370/new/ https://reviews.llvm.org/D1353

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

troyj updated this revision to Diff 466072. troyj added a comment. Added more diff context as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135370/new/ https://reviews.llvm.org/D135370 Files: clang/lib/Sema/SemaTemplateInstantiateDecl

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb62f5fb64ede: [Clang][Sema] Narrow inline namespace filtration for unqualified friend… (authored by troyj). Repository: rG LLVM Github Monorepo C

[PATCH] D135370: Narrow inline namespace filtration for unqualified friend declarations

troyj added a comment. I agree. I wouldn't want to mislead people into thinking that they'll see this improvement on everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135370/new/ https://reviews.llvm.org/D135370 __

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. HeaderSearch already uses a caching system to avoid duplicate searches, but the initial cold mis

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

troyj added inline comments. Comment at: clang/include/clang/Lex/HeaderSearch.h:255 + /// lets us avoid scanning them all to find a match. + llvm::StringMap SearchDirHeaderMapIndex; + bruno wrote: > Did you end up getting data on the memory footprint of this ma

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

troyj updated this revision to Diff 467496. troyj added a comment. Addressed Bruno's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135801/new/ https://reviews.llvm.org/D135801 Files: clang/include/clang/Lex/HeaderMap.h clang/include/

[PATCH] D137458: [clang] Add __decay as a builtin template

troyj created this revision. troyj added a reviewer: bruno. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `__decay(T)` exists as a bui

[PATCH] D137458: [clang] Add __decay as a builtin template

troyj added a comment. > Also, it would be nice to have some numbers for the 'measurably faster' claim > :) Sure. Here's an example of a library change that started using builtins for `__make_integer_seq` and `__type_pack_element` https://github.com/facebook/fatal/commit/58102a3f7e66ad122d7d33

[PATCH] D53608: [builtins] Build float128 soft float builtins for x86_64.

troyj added a comment. Wound up here while trying to use compiler-rt for static linking with our downstream compiler. It seems that compiler-rt's current approach of only providing these routines on certain platforms is problematic because libgcc always provides them, and thus compiler-rt is n

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

troyj added a comment. I ran into this same problem and would like to see this patch or a similar one land. Note that there is also a -Og option to consider, which currently has the same problem. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63976/new/ https:/

[PATCH] D100502: Allow lib64 in driver test

troyj created this revision. troyj added a reviewer: clang. troyj added a project: clang. troyj requested review of this revision. Herald added a subscriber: cfe-commits. The test clang/test/Driver/rocm-detect.hip does not consider that "lib" may be "lib64" instead. Repository: rG LLVM Github

[PATCH] D100502: Allow lib64 in driver test

troyj updated this revision to Diff 337827. troyj added a comment. Correct + to *. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100502/new/ https://reviews.llvm.org/D100502 Files: clang/test/Driver/rocm-detect.hip Index: clang/test/Driver/roc

[PATCH] D100502: Allow lib64 in driver test

This revision was automatically updated to reflect the committed changes. Closed by commit rG8628ed0310e2: [Driver] Allow both lib64 and lib in rocm-detect test. (authored by troyj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100502/new/ https://