[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta created this revision. tkuchta added reviewers: vitalybuka, glider. tkuchta added a project: Sanitizers. Herald added a subscriber: Enna1. Herald added a project: All. tkuchta requested review of this revision. This patch adds support for the following libc functions in DFSAN: strnlen, st

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 487936. tkuchta added a comment. applied newer version of clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_custom.cpp compiler-rt/lib/dfsan/done_abilist.t

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added a comment. Hello browneee, Thank you very much for the comments! I will take a closer look at the issue you pointed out. Do you prefer me to send a couple of diffs (one per each function) at once or one by one? Kind regards, CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:213 + char *res = strsep(s, delim); + s_label = dfsan_read_label(base, strlen(base)); + if (res && (res != base)) { browneee wrote: > tkuchta wrote: > > browneee wrote: > > > The

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:213 + char *res = strsep(s, delim); + s_label = dfsan_read_label(base, strlen(base)); + if (res && (res != base)) { browneee wrote: > tkuchta wrote: > > browneee wrote: > > > tku

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:213 + char *res = strsep(s, delim); + s_label = dfsan_read_label(base, strlen(base)); + if (res && (res != base)) { browneee wrote: > tkuchta wrote: > > browneee wrote: > > > tku

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 495268. tkuchta added a comment. Please find the patch for strsep only attached Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_cus

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:213 + char *res = strsep(s, delim); + s_label = dfsan_read_label(base, strlen(base)); + if (res && (res != base)) { browneee wrote: > The `s_label` represents the taint label for

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? s_label : 0; + } else { browneee wrote: > When `res != NULL`, then `res` is derived from `*s`, not from `s`.

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 510041. tkuchta marked an inline comment as done. tkuchta added a comment. Hello, I applied the review comments for strsep. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/df

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 510047. tkuchta added a comment. Updates after the review of strsep. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_custom.cpp compiler-rt/lib/dfsan/done_abilist.txt

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added a comment. there is a strange build error which seems unrelated to my change - please let me know if that's an issue, I will try to rebase to newest master then CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 ___

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan_custom.cpp:221 + if (flags().strict_data_dependencies) { +*ret_label = res ? dfsan_read_label(base, sizeof(base)) : 0; + } else { browneee wrote: > `base, sizeof(base)` does not make sen

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 510442. tkuchta added a comment. Applied the latest review comments for strsep CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_custom.cpp compiler-rt/lib/dfsan/done_a

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 51. tkuchta added a comment. Thank you, I have uploaded a new diff with "&" fixed in the test function. How should be proceed with the other functions once strsep is done? Should I open another review or add the code to the current patch? CHANGES SINCE

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta added a comment. Got it, thank you. Please submit the patch for e-mail t.kuc...@samsung.com I will prepare next reviews for the other functions. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 ___