[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar added a comment. In D112730#3133822 , @carlosgalvezp wrote: > @tstellar @tonic I have finally received an answer from AUTOSAR. Let me know > if you'd like me to CC you the mail chain to see the exact discussion. Can you cc bo...@llvm.org on th

[PATCH] D114025: [clang][NFC] Inclusive terms: replace some uses of sanity in clang

tstellar added a comment. @ZarkoCA If you are planning to do a lot of this, it might be good to write a script (or a clang-tidy check even) that we can add to CI, so these terms don't get re-introduced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

tstellar added a comment. In D134337#3864288 , @mgorny wrote: > In D134337#3863744 , @tstellar > wrote: > >> In what scenarios will clang load the clang.cfg file? > > It will load it if all of the following are t

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

tstellar added a comment. In D134337#3865753 , @mgorny wrote: > In D134337#3865541 , @tstellar > wrote: > >> I know I'm a little late here, but having a default config file that's >> always loaded makes triaging

[PATCH] D131919: Move googletest to the third-party directory

tstellar updated this revision to Diff 468784. tstellar marked 4 inline comments as done. tstellar added a comment. Herald added a subscriber: zero9178. Rebase and fix some missed path updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/ne

[PATCH] D136660: [clang] Replace BACKEND_PACKAGE_STRING with LLVM_VERSION_STRING

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. This seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136660/new/ https://reviews.llvm.org/D136660 _

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG74384c7fcec7: Disable update_cc_test_checks.py tests in stand-alone builds (authored by tstellar). Repository: rG LLVM

[PATCH] D131919: Move googletest to the third-party directory

tstellar created this revision. tstellar added reviewers: stellaraccident, rnk, lattner, probinson, jyknight, phosek. Herald added subscribers: Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, mstorsjo, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufen

[PATCH] D131919: Move googletest to the third-party directory

tstellar added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:1257 + +set(LLVM_THIRD_PARTY_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../third-party CACHE STRING +"Directory containing third party software used by LLVM (e.g. googletest)") stel

[PATCH] D131919: Move googletest to the third-party directory

tstellar updated this revision to Diff 453194. tstellar added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919 Files: clang/CMakeLists.txt compiler-rt/CMakeLists.txt lld/CMakeLists

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added a subscriber: thieta. tstellar added a comment. @dblaikie Is there anything we need to do in the release branch for this still? cc @thieta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117616/new/ https://reviews.llvm.org/D117616 _

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. @dblaikie Can you file a bug and add the 15.0.0 Release Milestone, so we don't forget to fix this in the release branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511

[PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

tstellar added a comment. In D130586#3734012 , @Ericson2314 wrote: > Sorry. I have reverted this. I see why the `lib` and `lib64` mixup could be > caused by this, but I am baffled how the missing headers could be. Headers > search paths should be unaf

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

tstellar added inline comments. Comment at: clang/docs/UsersManual.rst:954 + +For example, ``x86_64-pc-linux-gnu-clang-g++`` will attempt to load two +configuration files named respectively:: Is `x86_64-pc-linux-gnu-clang-g++ ` being passed to --driver= in this e

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

tstellar added a comment. In what scenarios will clang load the clang.cfg file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list cfe

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

tstellar created this revision. tstellar added reviewers: mgorny, phosek, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137224 Files: clang/CMakeLists.txt In

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a959334707: clang/cmake: Simplify lit detection for standalone builds (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137224/new/ ht

[PATCH] D131919: Move googletest to the third-party directory

tstellar added a comment. Herald added a subscriber: Moerafaat. @probinson Does this latest update look better? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919

[PATCH] D125860: [clang] Only use major version in resource dir

tstellar added a comment. @tbaeder That CI failure seems unrelated. Maybe just commit early in the day so you have time to deal with the bot failures (if any). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 _

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

tstellar created this revision. tstellar added reviewers: phosek, mgorny, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the FileCheck, count, and not tools are not found in LLVM_TOOLS_

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

tstellar added a comment. In D137669#3916493 , @mgorny wrote: > Could you issue a warning though? It's really annoying when targets disappear > like that and you have to guess which of the checks failed. What about just making it an error if LLVM_INCLUD

[PATCH] D131919: Move googletest to the third-party directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59052468c3e3: Move googletest to the third-party directory (authored by tstellar). Changed prior to commit: https://reviews.llvm.org/D131919?vs=46

[PATCH] D137669: clang/cmake: Require pre-built test dependencies for stand-alone builds

tstellar added a comment. In D137669#3915899 , @mstorsjo wrote: > This does, somewhat, coincide with what I'm trying to do in D131052 > . There, I don't point out the binaries for > `FileCheck` and similar, but point ou

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

tstellar added a comment. I think this looks OK. What kind of errors were you seeing before this fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___ cfe-c

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

tstellar added a comment. In D137917#3925161 , @Trass3r wrote: > Thanks could you also commit it? Sure, what name and email should I use for you when committing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da41fe69622: [cmake] Fix _GNU_SOURCE being added unconditionally (authored by Trass3r, committed by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

tstellar added a comment. @thetruestblue What paths besides LLVM_TOOLS_BINARY_DIR do you need? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

tstellar added a comment. In D137024#3931499 , @thetruestblue wrote: > In D137024#3931497 , @tstellar > wrote: > >> @thetruestblue What paths besides LLVM_TOOLS_BINARY_DIR do you need? > > TBD. > So far this s

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

tstellar created this revision. tstellar added reviewers: mgorny, phosek, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. This fixes a bug where tests would be disabled when LLVM_EXTERNAL_LIT was set if lit couldn't be found in a

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

tstellar added a subscriber: gkistanova. tstellar added a comment. @luke You'll need to contact the bot owners so they can update machine. The workers running the publish-sphinx-docs will need to be updated too. @gkistanova should be able to help. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

tstellar added inline comments. Comment at: clang/test/Driver/SOURCE_DATE_EPOCH.c:2 +// RUN: %clang -E %s -### 2>&1 | FileCheck %s -check-prefix=NO_EPOCH +// NO_EPOCH-NOT: "-source-date-epoch" + Hi @benlangmuir, this test fails in our build environment, because w

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

tstellar added inline comments. Comment at: clang/test/Frontend/sarif-diagnostics.cpp:8 +// Omit filepath to llvm project directory +// CHECK: clang/test/Frontend/sarif-diagnostics.cpp"},"mimeType":"text/plain","roles":["resultFile"]}],"columnKind":"unicodeCodePoints","results":

[PATCH] D142511: [clang][test] Remove check that fails if SOURCE_DATE_EPOCH is set globally

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142511/new/ https://reviews.llvm.org/D142511 ___

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

tstellar added a comment. Does this mean that clang will no longer search for the ROCM and CUDA library paths for every C compile? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142606/new/ https://reviews.llvm.org/D142606

[PATCH] D142606: Lazyly initialize uncommon toolchain detector

tstellar added a comment. In D142606#4082783 , @serge-sans-paille wrote: > In D142606#4082753 , @tstellar > wrote: > >> Does this mean that clang will no longer search for the ROCM and CUDA >> library paths for

[PATCH] D143348: [Clang][Doc][OpenCL] Release 16 notes

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143348/new/ https://reviews.llvm.org/D143348 ___ cfe-commits mailing list cfe-comm

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

tstellar created this revision. tstellar added reviewers: JonChesterfield, MaskRay. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tstellar requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:799 +.Default(false); +} + I wasn't sure exactly how to determine if something is a system path, so I'm open to other ideas here. Repository: rG LLVM Github Monorepo

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

tstellar added inline comments. Herald added a subscriber: asb. Comment at: flang/docs/ComplexOperations.md:37 **FIR** -```c func.func @_QPpow_self(%arg0: !fir.ref>) -> !fir.complex<4> { Do these changes have any affected on the output html? Is there another w

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. Is LLVMTargetParser a library In D141581#4057177 , @fpetrogalli wrote: > In D141581#4056825 , @barannikov88 > wrote: > >> clangBasic and clangDriver already have a dependency on Target

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. So, what's the actual dependency here? Do libBasic and libDriver just need the header to be generated or does it actually need to link to the library? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://rev

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. I don't think this is the correct way to specify dependencies if it's just an issue of the header being included before a generated file it needs has been generated. Are there other places in the code where a generated header file is included by another header? Repo

[PATCH] D141581: [clang] Make clangBasic and clangDriver depend on LLVMTargetParser.

tstellar added a comment. I spent some time looking at this. Rather than changing the dependency from RISCVTargetParserTableGen to LLVMTargetParser, I think the correct fix is to handle RISCVTargetParserTableGen in llvm/cmake/modules/LLVMConfig.cmake.in. alongside the intrinsics_gen, omp_gen,

[PATCH] D142199: [Docs] Replace recommonmark with myst-parser

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Can you add something to the release notes about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142199/new/ https://reviews.llvm

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:113 omp_gen - RISCVTargetParserTableGen ) Doesn't this break the monorepo (non-standalone) build? If the monorepo build still works with this, then you don't need the changes to

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. I tested this patch and it works, so I'll give it an LGTM. However, I think the LLVMConfig.cmake.in changes are now unnecessary since the RISCVTargetParserTableGen has been dropped from

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added a comment. @fpetrogalli Please go ahead and push this since it is blocking others, we can fix up any of the other issues later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581

[PATCH] D141581: [build] Fix stand-alone builds of clang.

tstellar added a comment. @fpetrogalli The solution is to add RISCVTargetParserTableGen to the Depnds list of clang/lib/Driver and clang/lib/Basic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141581/new/ https://reviews.llvm.org/D141581 _

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

tstellar added a comment. This is still the wrong change IMO. I don't know, maybe I'm not being clear, but I don't 'think you ever actually tried my suggestion in D141581 which was to leave the RISCVTargetParserTableGen Depends as is and add the pseudo targe

[PATCH] D142403: [build] Force building LLVMTargetParser before other non-LLVM components.

tstellar added a comment. In D142403#4074905 , @fpetrogalli wrote: > In D142403#4074885 , @tstellar > wrote: > >> This is still the wrong change IMO. I don't know, maybe I'm not being >> clear, but I don't 'th

[PATCH] D142403: [build] Fix stand-alone builds of clang.

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. I tested and this fixes the build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142403/new/ https://reviews.llvm.org/D142403 __

[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

tstellar added a comment. In D123064#3575503 , @cor3ntin wrote: > @tstellar I saw you say in another path that you got confirmation from > lawyers that it's okay to include UnicodeData.txt (which this patch doesn't > do) and derived data (which this pat

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

tstellar added a comment. This Comment at: clang/utils/hmaptool/CMakeLists.txt:5 -add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/${CLANG_HMAPTOOL} - COMMAND ${CMAKE_COMMAND} -E make_directory - ${CMAKE_BINARY_DIR}/

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

tstellar added inline comments. Comment at: clang/utils/hmaptool/CMakeLists.txt:5 -add_custom_command(OUTPUT ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/${CLANG_HMAPTOOL} - COMMAND ${CMAKE_COMMAND} -E make_directory - ${CMAKE_BINARY_DIR}/$

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

tstellar added a comment. I'm curious what is your system configuration where this patch actually allows for detection of devtoolset? I noticed that if clang and gcc are both installed to /usr/, then driver will pick the gcc in /usr/ over the one in /opt/rh/.../ Repository: rG LLVM Github

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. What is the motivation for this change? I really don't like bundling external headers like this, because it can lead to subtle hard to catch bugs. It also makes it harder to di

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar added a comment. In D125624#3552238 , @ruiu wrote: > The motivation of doing this is to be able to build LLVMgold.so without > binutils' source files and make it clear that LLVMgold.so does not include > any GPL code. OK, as I mentioned. I th

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar added a subscriber: tonic. tstellar added a comment. In D125624#3552463 , @ruiu wrote: >> OK, as I mentioned. I think we need an attorney to review this change and >> confirm that it actually accomplishes this goal. > > Can you add an attorney a

[PATCH] D112916: Confusable identifiers detection

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. In D112916#3554158 , @Mordante wrote: > In D112916#3113140 , @tstellar > wrote: > >> The LLVM Board of D

[PATCH] D156599: [profiling] Move option declarations into headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7247f1010b5: [profiling] Move option declarations into headers (authored by tstellar). Changed prior to commit: https://reviews.llvm.org/D156599?

[PATCH] D155509: Revert "Remove rdar links; NFC"

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155509/new/ https://reviews.llvm.org/D155509 __

[PATCH] D143813: [ClangFE] Check that __sync builtins are naturally aligned.

tstellar added a comment. This introduced a build failure on s390x: https://github.com/llvm/llvm-project/issues/69146 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143813/new/ https://reviews.llvm.org/D143813 ___ cfe-commits mailing list cfe

[PATCH] D156599: [profiling] Move option declarations into headers

tstellar created this revision. tstellar added reviewers: bogner, dnovillo, hoy, huangjd. Herald added subscribers: wlei, Enna1, ormris, wenlei, hiraditya. Herald added a project: All. tstellar requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-com

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

tstellar added a comment. In D138258#3936260 , @kwk wrote: > As much as I would like this to be fixed. I vote against this patch because > in `lld/CMakeLists.txt` there's an almost (if not entirely) identical piece > of code >

[PATCH] D138258: clang/cmake: Fix incorrectly disabling tests when LLVM_EXTERNAL_LIT is used

tstellar added inline comments. Comment at: clang/CMakeLists.txt:97 # Seek installed Lit. -find_program(LLVM_LIT - NAMES llvm-lit lit.py lit - PATHS "${LLVM_MAIN_SRC_DIR}/utils/lit" - DOC "Path to lit.py") +if (NOT LLVM

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

tstellar created this revision. tstellar added reviewers: mgorny, phosek, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138472 Files: clang/CMakeLists.txt In

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

tstellar added inline comments. Comment at: clang/CMakeLists.txt:103 if (LLVM_LIT AND LLVM_UTILS_PROVIDED) - set(UNITTEST_DIR ${LLVM_THIRD_PARTY_DIR}/utils/unittest) - if(EXISTS ${UNITTEST_DIR}/googletest/include/gtest/gtest.h - AND NOT EXISTS ${LLVM_LIBRA

[PATCH] D75056: [Driver] Default to -fno-common

tstellar added a comment. I am in favor of this change. Could you also add something to the release notes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar updated this revision to Diff 247123. tstellar marked 4 inline comments as done. tstellar added a comment. Address most recent review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72875/new/ https://reviews.llvm.org/D72875 Files

[PATCH] D75056: [Driver] Default to -fno-common for all targets

tstellar accepted this revision. tstellar added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D70157: Align branches within 32-Byte boundary

tstellar added a comment. Are there any optimizations in lld that might undo the 32-byte alignment emitted by the compiler? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 ___

[PATCH] D51567: CMake: Consolidate gtest detection code

tstellar abandoned this revision. tstellar added a comment. Herald added a project: clang. Dropping this since it is more Fedora specific. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51567/new/ https://reviews.llvm.org/D51567

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

tstellar added a comment. In D67463#1767919 , @rnk wrote: > @hans, are we still accepting 9.0.1 patches? I thought we'd already made a > release candidate. I'm still accepting patches until rc2 (which should have been Monday, but was delayed), so I can

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

tstellar added a comment. In D67463#1769557 , @rnk wrote: > In D67463#1769238 , @tstellar wrote: > > > In D67463#1767919 , @rnk wrote: > > > > > @hans, are we still accepting

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar added a comment. After thinking about this more, do we want to even try to support the BUILD_SHARED=ON + CLANG_LINK_CLANG_DYLIB=ON configuration? We don't support this in llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ ht

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar added a comment. In D68520#1782387 , @tstellar wrote: > After thinking about this more, do we want to even try to support the > BUILD_SHARED=ON + CLANG_LINK_CLANG_DYLIB=ON configuration? We don't support > this in llvm. Actually, even if we d

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72875/new/ https://reviews.llvm.org/D72875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

This revision was automatically updated to reflect the committed changes. Closed by commit rG87d8ae700b80: [clang][cmake] Include generated rst files in html built by docs-clang-html… (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar requested review of this revision. tstellar added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520 ___ cfe-commits mailing list cfe-com

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rGebcf25ea8100: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar added a comment. Any other commits before I commit this? Comment at: llvm/cmake/modules/AddSphinxTarget.cmake:33 + if (NOT ARG_SOURCE_DIR) +set(ARG_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) + endif() delcypher wrote: > @tstellar I'm not 100% sure a

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar created this revision. tstellar added reviewers: rsmith, aaron.ballman, beanz, smeenai, phosek, compnerd. Herald added subscribers: llvm-commits, mgorny. Herald added projects: clang, LLVM. This is an attempt to simply the process of building the clang documentation, which should help av

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar updated this revision to Diff 238893. tstellar added a comment. - Fix indentation. - Remove placeholder AttributeReference.rst. The install target was replacing the generated AttributeReference.rst with this which caused the html page to be empty. - Tested with stand-alone clang builds

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar updated this revision to Diff 238914. tstellar marked 2 inline comments as done. tstellar added a comment. - Add quotes around ${CMAKE_CURRENT_SOURCE_DIR} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72875/new/ https://reviews.llvm.org/D7

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar added a comment. Ping. This bug is preventing upstream projects from using libclang-cpp.so, since building with -DENABLE_SHARED=ON is still common. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf839cfda09d: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON (authored by tstellar). Changed prior to commit: https://reviews.llvm.org/D68520?vs=223325&id=239726#toc Reposi

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar updated this revision to Diff 239764. tstellar added a comment. Rewrite patch to use cmake features available with cmake >= 3.4. The previous version used a 3.6 feature: list(FILTER ...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar updated this revision to Diff 239919. tstellar marked 2 inline comments as done. tstellar added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520 Files: clang/too

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:28 +foreach(lib ${interface}) + string(REGEX MATCH "^clang" is_clang_lib ${lib}) + if (NOT is_clang_lib) mgorny wrote: > Any reason not to use `if(${lib} MATCHES ...)

[PATCH] D73603: Driver: Add gcc search path for RHEL devtoolset-9

tstellar created this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73603 Files: clang/lib/Driver/ToolChains/Gnu.cpp Index: clang/lib/Driver/ToolChains/Gnu.cpp === --- c

[PATCH] D32577: CMake: Replace open-coded find_package

tstellar updated this revision to Diff 141793. tstellar added a comment. Herald added a subscriber: cfe-commits. Rebased this patch on ToT. Repository: rC Clang https://reviews.llvm.org/D32577 Files: CMakeLists.txt Index: CMakeLists.txt ===

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

tstellar added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:1840 +// Yet, still look for RHEL devtoolsets +// (should it be done Linux-only??) +Prefixes.push_back("/opt/rh/devtoolset-6/root/usr"); fedor.sergeev wrote: > aaron.ballman wro

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar added a comment. Ping. https://reviews.llvm.org/D34848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

tstellar added a comment. Would this make more sense in a config file rather than a CMake option? @MaskRay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144853/new/ https://reviews.llvm.org/D144853 ___

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. In D118493#4182583 , @JonChesterfield wrote: > Duplicating a comment from the commit thread so it's easier for me to find > later. > > You've applied this to the release branches going back as far as 14. It's a > user facing b

[PATCH] D145704: Revert "Set FLT_EVAL_METHOD to -1 when fast-math is enabled."

tstellar added a comment. We're holding -rc4 until this is merged, so it would be great if we could merge it on Friday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145704/new/ https://reviews.llvm.org/D145704 ___ cfe-commits mailing list c

[PATCH] D142174: [OpenMP] Don't set rpath for system paths

tstellar abandoned this revision. tstellar added a comment. -fopenmp-add-rpath has been removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142174/new/ https://reviews.llvm.org/D142174 ___ cfe-commits

[PATCH] D143306: [Driver] Default to -fno-openmp-implicit-rpath

tstellar added a comment. Should we apply this patch to the release/16.x branch to create a more smooth transition since the option has been removed in main? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143306/new/ https://reviews.llvm.org/D14330

[PATCH] D138472: clang/cmake: Use installed gtest libraries for stand-alone builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG821691039585: clang/cmake: Use installed gtest libraries for stand-alone builds (authored by tstellar). Changed prior to commit: https://reviews.l

<    1   2   3   4   >