[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

tstellar added a comment. Can you elaborate more on the problem this is solving? Also, what are the user visible changes? Will check-all and check-clang run the same set of tests as before? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121838/ne

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar updated this revision to Diff 449681. tstellar marked an inline comment as done. tstellar added a comment. Fix option spelling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 Files: clang/test

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:19 +# for any of the clang source code. +config.unsupported = True else: h-vetinari wrote: > I couldn't tell from the diff where this is used (though admitte

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar updated this revision to Diff 449783. tstellar added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128777/new/ https://reviews.llvm.org/D128777 Files: clang/CMakeLists.txt Index: clang/CMakeLists.txt ===

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar added inline comments. Comment at: clang/CMakeLists.txt:21-23 + set(INCLUDE_DIRS "${LLVM_BINARY_DIR}/include" "${MAIN_INCLUDE_DIR}") + # Pull values from LLVMConfig.cmake. + set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}") This doesn't look right (even tho

[PATCH] D130553: [clang][lld][cmake] Simplify header dirs

tstellar added a comment. > When LLVM is being built, the list is two elements long: generated headers > and headers from source. All these changes are guarded by if (CLANG_BUILT_STANDALONE), which means LLVM should already be built. What build configuration are you using where you needed thi

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar updated this revision to Diff 449857. tstellar added a comment. Remove more of the existing code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128777/new/ https://reviews.llvm.org/D128777 Files: clang/CMakeLists.txt Index: clang/CMak

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar added inline comments. Comment at: clang/CMakeLists.txt:21-23 + set(INCLUDE_DIRS "${LLVM_BINARY_DIR}/include" "${MAIN_INCLUDE_DIR}") + # Pull values from LLVMConfig.cmake. + set(MAIN_INCLUDE_DIR "${LLVM_INCLUDE_DIR}") tstellar wrote: > This doesn't lo

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

tstellar added a comment. In D130735#3691016 , @Ericson2314 wrote: > Should I wait for anyone else / do something like announcing this on > discourse? > > It looks like the only other use case is libclc, which sadly only supports > the old way so we wi

[PATCH] D130735: [Clang][LLD][cmake] Drop deprecated support for `llvm-config`-based build

tstellar accepted this revision. tstellar added a comment. LGTM. I just tested this patch in our build config and it works fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130735/new/ https://reviews.llvm.org/D130735 __

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

tstellar added a comment. In D129973#3699055 , @kadircet wrote: > Reverted in df48e3fbcc8be1f4c04bd97517d12e662f54de75 > , > @tstellar it needs to be cherry-picked into release branch

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar added a comment. @Ericson2314 Your version of these patches removed a few more things than mine (which seems better to me), do you want to just split your patch and commit the parts separately? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D131172: [clang][llvm][doc] Add more information for the ABI change in FP16

tstellar added a comment. @pengfei You can commit this directly to the release/15.x branch whenever you are ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131172/new/ https://reviews.llvm.org/D131172

[PATCH] D129973: [clang] Pass FoundDecl to DeclRefExpr creator for operator overloads

tstellar added a comment. The revert doesn't apply cleanly, can someone try to fix it up: https://github.com/llvm/llvm-project/issues/56928#issuecomment-1205483442 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129973/new/ https://reviews.llvm.org/

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar added a comment. @h-vetinari Do these updates look OK to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 ___ cfe-commits mailing list cfe-commits@

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar updated this revision to Diff 360517. tstellar marked 3 inline comments as done. tstellar added a comment. Address some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 Files: c

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:82 + +if (LLVM_EXPORTED_SYMBOL_FILE) + add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} MaskRay wrote: > What does this do? > > A hard-coded list cannot catch up with the real

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar updated this revision to Diff 360654. tstellar added a comment. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 Files: clang/test/CMakeLists.txt clang/test/LibClang/lit.loc

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar updated this revision to Diff 360656. tstellar added a comment. Add missing file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 Files: clang/test/CMakeLists.txt clang/test/LibClang/lit.loca

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar updated this revision to Diff 361734. tstellar added a comment. Add test case for local symbols and reformat version script. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 Files: clang/test/CM

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc7b3a91017d2: libclang.so: Make SONAME independent from LLVM version (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:67 set(LLVM_EXPORTED_SYMBOL_FILE ${CMAKE_CURRENT_SOURCE_DIR}/libclang.exports) +set(LIBCLANG_VERSION_SCRIPT_FILE ${CMAKE_CURRENT_SOURCE_DIR}/libclang.map) thakis wrote: > This is s

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. In D105527#2906247 , @Bigcheese wrote: > For future reference this was very difficult to merge into external changes. > It looks like you resorted this at the same time as renaming it, and that > messes up git's rename logic.

[PATCH] D106914: [libclang] Check LLVM_HAVE_LINK_VERSION_SCRIPT

tstellar added a comment. LGTM. Thanks for fixing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106914/new/ https://reviews.llvm.org/D106914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. In D105527#2908944 , @Bigcheese wrote: > Also, this python script just doesn't work. It's missing a sys import, a "w" > flag, and a new line after each write. It also dumps the output into the > source directory. Was this actua

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. In D105527#2910319 , @jrtc27 wrote: > I'm seeing the test fail locally (on ca0fe3447fb85762838468537d93d4ef82c5a1af > ) with: > > 000d1799 t clang_Co

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. It looks like that function is missing from libclang.map, I think if you add it there it should fix the test. I'm going to check to see if there are any more missing functions and then commit a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D106974: libcang: Add missing function to libclang.map

tstellar created this revision. tstellar added a reviewer: jrtc27. tstellar requested review of this revision. Herald added a project: clang. This function is marked with CINDEX_LINKAGE, but was never added to the export list / linker script. Repository: rG LLVM Github Monorepo https://review

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. Can you let me know if D106974 fixes the problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527

[PATCH] D106974: libcang: Add missing function to libclang.map

tstellar updated this revision to Diff 362439. tstellar added a comment. Add missing ; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106974/new/ https://reviews.llvm.org/D106974 Files: clang/tools/libclang/libclang.map Index: clang/tools/libcl

[PATCH] D106974: libcang: Add missing function to libclang.map

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa4edb2b1ba0b: libcang: Add missing function to libclang.map (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D106898: Revert "Revert "[clang][pp] adds '#pragma include_instead'""

tstellar added a comment. I've backported this as 6eaf46beb4628abf8f5b09a333bcd44d2fb2aff9 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106898/new/ https://reviews.llvm.org/D1

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. I'm fine with reverting if you think this is the best solution. I just would like to conclude soon so I can make the final release candidate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. In D118511#3373082 , @dblaikie wrote: > In D118511#3372728 , @jyknight > wrote: > >> In D118511#3371432 , @tstellar >> wrote: >> >>> I'm fine w

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

tstellar added a comment. @xbolva00 I've removed your comment due to inappropriate language and tone. Please find a more constructive way to communicate your point. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.llvm.or

[PATCH] D121983: Driver: Don't warn on -mbranch-protection when linking

tstellar created this revision. tstellar added reviewers: chill, vhscampos, stuij, amilendra. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. The -mbranch-protection definition in Options.td was not given a Group, so this was causing clang to

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. Herald added a project: All. Fedora recently banned RUNPATH, so packages built with clang and -fopenmp are rejected by the build system with this change. Can you elaborate more about the intend

[PATCH] D118493: Set rpath on openmp executables

tstellar added a comment. In D118493#3398808 , @JonChesterfield wrote: > It lets applications run with the libomp and libomptarget built with the > toolchain. For users, they don't have to be root. For compiler devs, we test > our work instead of whate

[PATCH] D121983: Driver: Don't warn on -mbranch-protection when linking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98fd3b359866: Driver: Don't warn on -mbranch-protection when linking (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

tstellar added a comment. Can't we add a timeout exception for this test in buildkite? Splitting the file in two actually increases the runtime, due to the overhead of setting up each test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123601/new

[PATCH] D123601: [clang][AArch64] Split neon tests into 2 files

tstellar added a comment. Ok, so maybe my concerns about testing overhead are not that legitimate. That's just something I've heard mentioned in the past. However, I still think this should be fixed in buildkite. It's seems much more sustainable to just bump the timeout in buildkite rather

[PATCH] D123850: [Clang] Fix Unevaluated LambdasBackport to Clang 14.0.1

tstellar added a comment. In D123850#3453750 , @cor3ntin wrote: > @tstellar I wasn't sure what the procedure was for backporting fixes, so I > made a PR. I think your suggestion of keeping the old signature works well. > This also modifies the serialized

[PATCH] D123957: Update the developer policy to mention release notes

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 __

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. The script is located in the llvm/ sub-directory, so it is not available for when doing a stand-alone build. Repository: rG

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar updated this revision to Diff 424040. tstellar added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 Files: clang/test/CMakeLists.txt clang/test/lit.site.c

[PATCH] D118876: [HIPSPV] Fix literals are mapped to Generic address space

tstellar added a comment. @yaxunl This looks good to me, you can go ahead and cherry-pick it directly to release/14.x. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118876/new/ https://reviews.llvm.org/D118876

[PATCH] D119383: [clang][CMake] Add a warning about the Standalone build being deprecated

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. I would like to keep this supported upstream as this is how we build clang in Fedora. If some people find the stand-alone builds burdensome, then I think it would be best to sta

[PATCH] D111100: enable plugins for clang-tidy

tstellar added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:91 + if(TARGET CTTestTidyModule) + list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello) + target_include_directories(CTTestTidyModule PUBLIC BEFORE "${CLANG_TOOLS_SOURCE_DIR}")

[PATCH] D111100: enable plugins for clang-tidy

tstellar added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:91 + if(TARGET CTTestTidyModule) + list(APPEND CLANG_TOOLS_TEST_DEPS CTTestTidyModule LLVMHello) + target_include_directories(CTTestTidyModule PUBLIC BEFORE "${CLANG_TOOLS_SOURCE_DIR}")

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar updated this revision to Diff 444843. tstellar added a comment. Add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 Files: clang/docs/ReleaseNotes.rst clang/tools/libclang/CMake

[PATCH] D130254: [CMake][Clang] Copy folder without permissions

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Those pre-commit failure seem to be unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130254/new/ https://reviews.llvm.org/D13

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

tstellar added a comment. I think this commit broke our standalone builds: CMake Error at utils/hmaptool/CMakeLists.txt:1 (install): install PROGRAMS given no DESTINATION! Was the LLVM_TOOLS_INSTALL_DIR in this file supposed to be changed to CLANG_TOOLS_INSTALL_DIR ? Repository: rG LLVM

[PATCH] D130362: Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`

tstellar added a comment. Thanks for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130362/new/ https://reviews.llvm.org/D130362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar added a comment. @h-vetinari Does the release note look OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129160/new/ https://reviews.llvm.org/D129160 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar added a comment. In D129160#3678441 , @h-vetinari wrote: > In D129160#3678431 , @tstellar > wrote: > >> @h-vetinari Does the release note look OK? > > Basically yes, thank you! I'd still be more precise

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc39d7bdd497: libclang.so: Make SONAME the same as LLVM version (authored by tstellar). Changed prior to commit: https://reviews.llvm.org/D129160?vs=444843&id=447566#toc Repository: rG LLVM Github Mo

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

tstellar added a comment. In D125165#3504252 , @tra wrote: > LGTM in principle. > > Given that we're introducing a new tool dependency we may want to get a stamp > from someone dealing with build and release. > @tstellar -- do we need to change anything

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2154 Prefixes.push_back("/opt/rh/gcc-toolset-10/root/usr"); +Prefixes.push_back("/opt/rh/devtoolset-11/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-10/root/usr");

[PATCH] D125499: Enabling the detection of devtoolset-11 toolchain.

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2156 Prefixes.push_back("/opt/rh/devtoolset-10/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-9/root/usr"); Prefixes.push_back("/opt/rh/devtoolset-8/root/usr"); Mas

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

tstellar added inline comments. Comment at: clang/docs/ReleaseNotes.rst:239-243 +- GCC doesn't pack non-POD members in packed structs unless the packed + attribute is also specified on the member. Clang historically did perform + such packing. Clang now matches the gcc behavior

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

tstellar added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:115 +clang_target_link_libraries(libclang + PRIVATE + ${CLANG_LIB_DEPS} aaronpuchert wrote: > This might not be correct for static builds, I think we need `INTERFACE` here. This pat

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar added a comment. Ping.u1 https://reviews.llvm.org/D34848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34212: docs: Document binary compatibility issue due to bug in gcc

tstellar updated this revision to Diff 109438. tstellar added a comment. Add links to index.rst and UsersManual.rst, and fix link to bug. https://reviews.llvm.org/D34212 Files: docs/BinaryCompatibilityWithOtherCompilers.rst docs/UsersManual.rst docs/index.rst Index: docs/index.rst =

[PATCH] D68720: Support -fstack-clash-protection for x86

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2575 + default: +return; + case llvm::Triple::ArchType::x86: Do we need to warn (or error) here for arches that don't implement -fstack-clash-protection? Repository: rG L

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

This revision was automatically updated to reflect the committed changes. tstellar marked an inline comment as done. Closed by commit rG3203143f1356: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int) (authored by tstellar). Herald added a subscriber: pengfei. Repository:

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

tstellar created this revision. tstellar added reviewers: ddunbar, krememek. Herald added subscribers: Charusso, mgorny. tstellar requested review of this revision. Herald added a project: clang. I'm not exactly sure what this is, but it appears to be a tool for reporting internal issues at Apple.

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbb01536f6f4: scan-view: Remove Reporter.py and associated AppleScript files (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93565/new/

[PATCH] D91107: [Clang][Driver] Added the support for setting GCC toolchain via environment variable

tstellar added a comment. This code could be improved, but I don't think adding a specific environment variable for this a good solution. You can use the existing CCC_OVERRIDE_OPTIONS to get the same effect. e.g. CCC_OVERRIDE_OPTIONS=^--gcc-toolchain=/path/to/gcc More documentation can be fo

[PATCH] D92445: [PowerPC] Add powerpcle target.

tstellar added a comment. Could you add some more information to the commit message to better describe the powerpcle target. It's not clear from the target name exactly what it is for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92445/new/ htt

[PATCH] D90007: [clang][Sema] Fix PR47676: Handle dependent AltiVec C-style cast

tstellar created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. tstellar requested review of this revision. Fix premature decision in the presence of type-dependent expression operands on whether AltiVec vector initializations from single expressions are "spl

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

tstellar added a comment. Are you still seeing failures in the main branch? I thought I had fixed this with Revision: https://reviews.llvm.org/D96367. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93565/new/ https://reviews.llvm.org/D93565 _

[PATCH] D93565: scan-view: Remove Reporter.py and associated AppleScript files

tstellar added a comment. In D93565#2773761 , @puremourning wrote: > Erm, doh. I thought I was on main, but I was using clang 12.0.0 (tag > llvmorg-12.0.0 from llvm-project). We tend to only use release tagged > versions. OK, I've cherry-picked this fi

[PATCH] D96016: Release notes: Deprecate the clang-cl /fallback flag (patch for the release/12.x branch)

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. Yes, go ahead and push this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96016/new/ https://reviews.llvm.org/D96016 _

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

tstellar added a comment. The goal here is for distributions to be able to build libc++ one way and then have it work with clang without requiring that users add additional linker flags besides -static or -stdlib=libc++. Is there a combination of CMake arguments we can use when building libc++

[PATCH] D96163: [analyzer] Add 12.0.0. release notes

tstellar added a comment. You can push this directly to the release/12.x branch when it's ready. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96163/new/ https://reviews.llvm.org/D96163 ___ cfe-commits m

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

tstellar added a comment. @aaronpuchert Can you file a bug? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D110899: [Driver][XRay][test] XFAIL on linux with no environment specified

tstellar created this revision. tstellar added a reviewer: dberris. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D110899 Files: clang/test/Driver/XRay/xray-instr

[PATCH] D95055: [clang] Don't look into for C++ headers if they are found alongside the toolchain

tstellar added a comment. Sorry, it's too late for 11.1.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95055/new/ https://reviews.llvm.org/D95055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96367: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files"

tstellar created this revision. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts some of commit dbb01536f6f49fa428f170e34466072ef439b3e9

[PATCH] D96367: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript files"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3cd3a3c9152: Partially Revert "scan-view: Remove Reporter.py and associated AppleScript… (authored by tstellar). Changed prior to commit: https:/

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

tstellar added a comment. I'm curious, what kind of system are you running on where you need to use --gcc-toolchain x86_64-redhat-linux-gnu is required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104831/new/ https://reviews.llvm.org/D104831 __

[PATCH] D104831: [clang] Add x86_64-redhat-linux-gnu as a platform triplet

tstellar added a comment. In D104831#2838835 , @hoy wrote: > In D104831#2837712 , @MaskRay wrote: > >>> Adding the platform tripplet x86_64-redhat-linux-gnu the while list of >>> supported x86_64 triplets so that

[PATCH] D107231: [clang-repl] Fix building with win32 dylibs

tstellar added a comment. @mstorsjo Yes, go ahead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107231/new/ https://reviews.llvm.org/D107231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D99353: [driver] Make `clang` warn rather then error on `flang` options

tstellar added a comment. This is something we could merge, just need a code owner ack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99353/new/ https://reviews.llvm.org/D99353 ___ cfe-commits mailing li

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

tstellar added a comment. Do we have all the issues fixed in trunk yet or do we need to revert in the release/13.x branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

tstellar added a comment. Can someone file a bug for this and put release-13.0.0 in the blocks field so we can track it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436

[PATCH] D107559: [clang] Fix libclang linking on Solaris

tstellar added a comment. Is there any kind of comment that is supported by all linkers? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107559/new/ https://reviews.llvm.org/D107559 ___ cfe-commits mailing

[PATCH] D107559: [clang] Fix libclang linking on Solaris

tstellar added a comment. In D107559#2928999 , @ro wrote: > In D107559#2928851 , @tstellar > wrote: > >> Is there any kind of comment that is supported by all linkers? > > Seems there isn't. In that case, we cou

[PATCH] D108173: [WIP][clang] Add a cmake flag for choosing to build clang-repl

tstellar added a comment. > Not all downstream users may want to build all tools shipped with clang. > clang-repl for us in particular can sometimes lead to flaky builds when > testing a toolchain built with LTO. Can we just fix clang-repl instead? I think there needs to be a more compelling

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar created this revision. tstellar added reviewers: dim, MaskRay. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105527 Files: clang/tools/libclang/CMakeLists.tx

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added a comment. I tried to keep this simple and only add the Linux support for now. There seem to be some subtle differences of how different operating systems handle export lists and linker scripts, and I wasn't confident about how to make this work on those systems. Repository:

[PATCH] D105594: cmake: Allow shared libraries to customize the soname using LLVM_ABI_REVISION

tstellar created this revision. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. The LLVM_ABI_REVISION variable is intended to be used for release candidates which introduce an ABI change to a

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

tstellar added a comment. It looks like this patch breaks the utils/update_cc_test_checks/check-globals.test on stand-alone builds of clang, because it hard codes lit to lit.py in the llvm source tree. I think it should using the lit passed to -DLLVM_EXTERNAL_LIT= (if that option was specified

[PATCH] D105873: Fix utils/update_cc_test_checks/check-globals.test on stand-alone builds

tstellar created this revision. tstellar added a reviewer: jdenny. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. We want to use LLVM_EXTERNAL_LIT if defined for the %lit substitution. Repository: rG LLVM Github Monorepo https://r

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

tstellar added a comment. In D104714#2872826 , @tstellar wrote: > It looks like this patch breaks the > utils/update_cc_test_checks/check-globals.test on stand-alone builds of > clang, because it hard codes lit to lit.py in the llvm source tree. I thin

[PATCH] D105873: Fix utils/update_cc_test_checks/check-globals.test on stand-alone builds

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG303ddb60a2d2: Fix utils/update_cc_test_checks/check-globals.test on stand-alone builds (authored by tstellar). Repository: rG LLVM Github Monorep

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. @carlosgalvezp Did you write this patch or did you get it from someone else? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730

[PATCH] D112916: Confusable identifiers detection

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. The LLVM Board of Directors will do a legal review of this change. We will give an update in 4-6 weeks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112916/new/ https

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar added a comment. @carlosgalvezp The LLVM Foundation Board will conduct a legal reivew of this patch. Would you be able to share any information you have about the license or usage restrictions for the AUTOSAR specification? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

tstellar added a comment. In D8467#3095610 , @zixuan-wu wrote: > Hi, I am wondering could -fsized-deallocation this be enabled by default > nowadays in 2021? Were you planning to work on this? Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

<    1   2   3   4   >