[PATCH] D51020: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++

tstellar created this revision. tstellar added a reviewer: homerdin. Repository: rT test-suite https://reviews.llvm.org/D51020 Files: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMR/MallocPlus.h Index: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMR/MallocPlus.h =

[PATCH] D51021: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp

tstellar created this revision. tstellar added a reviewer: Sunil_Srivastava. The check lines for this test assume the old c++11 ABI. This resolved PR33132. Repository: rT test-suite https://reviews.llvm.org/D51021 Files: ABI-Testsuite/test/mangling/test.xpp Index: ABI-Testsuite/test/man

[PATCH] D51020: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++

This revision was automatically updated to reflect the committed changes. Closed by commit rL340320: MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMP: Fix build with newer libstdc++ (authored by tstellar, committed by ). Repository: rL LLVM https://reviews.llvm.org/D51020 Files: test-suite/tr

[PATCH] D51021: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp

This revision was automatically updated to reflect the committed changes. Closed by commit rL340322: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp (authored by tstellar, committed by ). Repository: rL LLVM https://reviews.llvm.org/D51021 Files: test-suite/trunk/ABI-Testsuite/t

[PATCH] D51567: CMake: Consolidate gtest detection code

tstellar created this revision. tstellar added reviewers: chandlerc, beanz. Herald added a subscriber: mgorny. This makes it possible to build the unittests with only the gtest sources and without a full LLVM source tree. Repository: rC Clang https://reviews.llvm.org/D51567 Files: CMakeLis

[PATCH] D51567: CMake: Consolidate gtest detection code

tstellar added a comment. In https://reviews.llvm.org/D51567#1222704, @chandlerc wrote: > I mean, sure. > > I really don't know that supporting this ever expanding diversity of build > strategies is worth its cost, but I don't see a specific reason to not take > this patch I actually agre

[PATCH] D32577: CMake: Replace open-coded find_package

tstellar updated this revision to Diff 164141. tstellar added a comment. Rebase on trunk. Repository: rC Clang https://reviews.llvm.org/D32577 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

tstellar created this revision. tstellar added reviewers: chandlerc, beanz, mgorny, chapuni. Herald added subscribers: dexonsmith, mehdi_amini. clang currently uses llvm-config to determine the installation paths for llvm's headers and binaries. clang is also using LLVM's cmake files to determine

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

tstellar added a comment. In https://reviews.llvm.org/D51714#1225545, @mgorny wrote: > Is LLVM_CONFIG dropped from cache here? I suspect the warning might fire for > everyone who has LLVM configured. Yes, it is dropped from the cache, is it a problem to having the warning fire for people who

[PATCH] D32595: CMakeLists: Don't set LLVM_MAIN_SRC_DIR when building stand-alone clang

tstellar added a comment. In https://reviews.llvm.org/D32595#769044, @beanz wrote: > Is this really something we should be supporting? Building and testing clang > with potentially out-of-sync lit or gtest seems undesirable to me. This is actually what this patch is trying to avoid. For exam

[PATCH] D34212: docs: Document binary compatibility issue due to bug in gcc

tstellar created this revision. Reported in PR33161. https://reviews.llvm.org/D34212 Files: docs/BinaryCompatibilityWithOtherCompilers.rst Index: docs/BinaryCompatibilityWithOtherCompilers.rst === --- /dev/null +++ docs/BinaryC

[PATCH] D44130: Driver: Add gcc search path for RHEL devtoolset-7

tstellar created this revision. Repository: rC Clang https://reviews.llvm.org/D44130 Files: lib/Driver/ToolChains/Gnu.cpp Index: lib/Driver/ToolChains/Gnu.cpp === --- lib/Driver/ToolChains/Gnu.cpp +++ lib/Driver/ToolChains/Gnu

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar added a comment. Ping. https://reviews.llvm.org/D34848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42608: Driver: Prefer vendor supplied gcc toolchain

tstellar added a comment. Ping Repository: rC Clang https://reviews.llvm.org/D42608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32577: CMake: Replace open-coded find_package

This revision was automatically updated to reflect the committed changes. Closed by commit rL346731: CMake: Replace open-coded find_package (authored by tstellar, committed by ). Repository: rL LLVM https://reviews.llvm.org/D32577 Files: cfe/trunk/CMakeLists.txt Index: cfe/trunk/CMakeList

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

This revision was automatically updated to reflect the committed changes. Closed by commit rC346732: CMake: Deprecate using llvm-config to detect llvm installation (authored by tstellar, committed by ). Changed prior to commit: https://reviews.llvm.org/D51714?vs=167413&id=173808#toc Repository

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar updated this revision to Diff 188500. tstellar added a comment. Use macros instead of functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https://reviews.llvm.org/D58537 Files: clang/lib/Headers/CMakeLists.txt Index: c

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar added a comment. In D58537#1411657 , @tstellar wrote: > Use macros instead of functions. I mean "Use functions instead of macros." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ https:/

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar updated this revision to Diff 188749. tstellar added a comment. Fix an issue with the generated arm headers that I discovered after doing some more testing. Also, remove comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58537/new/ ht

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar added a comment. In D58537#1415534 , @smeenai wrote: > @tstellar are you planning to land this soon? It'll conflict with D58791 > , but I'm not planning to land that for > another few days, so I can rebase on top

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

This revision was automatically updated to reflect the committed changes. Closed by commit rL355253: lib/Header: Simplify CMakeLists.txt (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[PATCH] D58791: [build] Rename clang-headers to clang-resource-headers

tstellar added a comment. This looks good, but could you also add an entry in the ReleaseNotes for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58791/new/ https://reviews.llvm.org/D58791 ___ cfe

[PATCH] D59987: Add support for detection of devtoolset-8

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59987/new/ https://reviews.llvm.org/D59987 __

[PATCH] D59987: Add support for detection of devtoolset-8

tstellar added a comment. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59987/new/ https://reviews.llvm.org/D59987 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D59987: Add support for detection of devtoolset-8

tstellar added a comment. In D59987#1454543 , @rpopescu wrote: > In D59987#1454422 , @tstellar wrote: > > > Do you have commit access? > > > Hi Tom, I don't think that I do. I have created the account just before >

[PATCH] D59987: Add support for detection of devtoolset-8

This revision was automatically updated to reflect the committed changes. Closed by commit rL358002: Add support for detection of devtoolset-8 (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar added a comment. In D58537#1474824 , @smeenai wrote: > @tstellar ping. Someone appears to be running into this on the CMake mailing > list too: https://cmake.org/pipermail/cmake/2019-April/069359.html Sorry, I missed this. I will take a look.

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar marked an inline comment as done. tstellar added inline comments. Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ - DESTINATION lib${LLV

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

tstellar added inline comments. Comment at: llvm/trunk/lib/Target/AMDGPU/R600ISelLowering.cpp:1717-1722 +// Fix spurious warning with gcc 7.3 -O3 for NewBldVec[i] below +// warning: array subscript is above array bounds [-Warray-bounds] +#if defined(__GNUC__) && __GNUC__

[PATCH] D61054: lib/Header: Fix Visual Studio builds

tstellar created this revision. tstellar added reviewers: smeenai, vzakhari, phosek. Herald added a subscriber: mgorny. Herald added a project: clang. This is a follow up to r355253, which inadvertently broke Visual Studio builds by trying to copy files from CMAKE_CFG_INTDIR. See https://reviews.

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar marked an inline comment as done. tstellar added a comment. Can you test D61054 ? Comment at: cfe/trunk/lib/Headers/CMakeLists.txt:168 install( - FILES ${cuda_wrapper_files} - COMPONENT clang-headers - PERMISSIONS OWNER_READ OWNER_W

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

tstellar added inline comments. Comment at: llvm/trunk/unittests/Transforms/Scalar/CMakeLists.txt:14-17 +# Workaround for the gcc 6.1 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. +if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0) + set

[PATCH] D61046: Fix compilation warnings when compiling with GCC 7.3

tstellar added inline comments. Comment at: llvm/trunk/unittests/Transforms/Scalar/CMakeLists.txt:14-17 +# Workaround for the gcc 6.1 bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80916. +if (CMAKE_COMPILER_IS_GNUCXX AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 6.0) + set

[PATCH] D61054: lib/Header: Fix Visual Studio builds

This revision was automatically updated to reflect the committed changes. Closed by commit rC359257: lib/Header: Fix Visual Studio builds (authored by tstellar, committed by ). Changed prior to commit: https://reviews.llvm.org/D61054?vs=196373&id=196771#toc Repository: rC Clang CHANGES SINC

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

tstellar created this revision. tstellar added reviewers: smeenai, vzakhari, phosek. Herald added a subscriber: mgorny. Herald added a project: clang. This is a follow up to r355253 and a better fix than the first attempt which was r359257. We can't install anything from ${CMAKE_CFG_INTDIR}, beca

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

tstellar updated this revision to Diff 197233. tstellar added a comment. - Fix install directory - Use a separate install targets for each sub-directory like it was done before r355253. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/ http

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

tstellar updated this revision to Diff 197244. tstellar marked an inline comment as done. tstellar added a comment. Make sure to install the generated files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61220/new/ https://reviews.llvm.org/D61220

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

This revision was automatically updated to reflect the committed changes. Closed by commit rL359654: lib/Header: Fix Visual Studio builds try #2 (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

tstellar updated this revision to Diff 167413. tstellar added a comment. Use cmake's DEPRECATION message. Repository: rC Clang https://reviews.llvm.org/D51714 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.tx

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

tstellar added a comment. In https://reviews.llvm.org/D51714#1248643, @smeenai wrote: > Is there anything holding this up? No hold up, I just wanted to address the review comment. I'll commit on Monday if there are no other comments. Repository: rC Clang https://reviews.llvm.org/D51714

[PATCH] D42608: Driver: Prefer vendor supplied gcc toolchain

tstellar added a comment. I've implemented an alternative solution here that I think is a little more robust: https://reviews.llvm.org/D52861 Repository: rC Clang https://reviews.llvm.org/D42608 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D52861: Driver: Prefer gcc toolchains with libgcc_s.so when not static linking libgcc

tstellar created this revision. Fedora ships cross-compilers on all platforms, so a user could end up with a gcc x86_64 cross-compiler installed on an x86_64 system. clang maintains a list of supported triples for each target and when all else is equal will prefer toolchains with triples that app

[PATCH] D57930: [Driver] Verify GCCInstallation is valid

tstellar added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:259-260 if (GCCInstallation.getParentLibPath().find("opt/rh/devtoolset") != StringRef::npos) // With devtoolset on RHEL, we want to add a bin directory that is relative

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

tstellar created this revision. tstellar added reviewers: phosek, andrewrk, smeenai. Herald added subscribers: cfe-commits, mgorny. Herald added projects: clang, LLVM. Handle the case where LLVM_MAIN_SRC_DIR is not set and also use LLVM_CMAKE_DIR for locating installed cmake files rather than LLVM

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

tstellar marked an inline comment as done. tstellar added inline comments. Comment at: clang/lib/Basic/CMakeLists.txt:13 -set(generate_vcs_version_script "${LLVM_CMAKE_PATH}/GenerateVersionFromVCS.cmake") +set(generate_vcs_version_script "${LLVM_CMAKE_DIR}/GenerateVersionFrom

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

tstellar updated this revision to Diff 186769. tstellar added a comment. Updated patch to fix non-standalone builds. There is more refactoring that could be done, but this at least restores functionality to before r353268. I have tested non-standalone builds and standalone builds with and withou

[PATCH] D54880: Ignore gcc's stack-clash-protection flag

tstellar added a comment. Herald added a project: clang. See D42593 , I don't think it's good to ignore security flags like this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54880/new/ https://reviews.llvm.org/D54880 ___

[PATCH] D42593: GCC compatibility: Ignore -fstack-clash-protection

tstellar abandoned this revision. tstellar added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. I agree with Joerg, I don't think we should be ignoring these kinds of security flags (even though we already ignore -fstack-check). Repository: rC Clang CHANGES S

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

This revision was automatically updated to reflect the committed changes. Closed by commit rL354417: CMake: Fix stand-alone clang builds since r353268 (authored by tstellar, committed by ). Changed prior to commit: https://reviews.llvm.org/D58204?vs=186769&id=187473#toc Repository: rL LLVM

[PATCH] D58537: lib/Header: Simplify CMakeLists.txt

tstellar created this revision. tstellar added reviewers: chandlerc, smeenai, mgorny. Herald added a project: clang. Herald added a subscriber: cfe-commits. Replace cut and pasted code with cmake macros and reduce the number of install commands. This fixes an issue where the headers were being in

[PATCH] D63503: cmake: Add CLANG_LINK_CLANG_DYLIB option

tstellar created this revision. tstellar added reviewers: mgorny, beanz, smeenai, phosek, sylvestre.ledru. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Setting CLANG_LINK_CLANG_DYLIB=ON causes clang tools to link against libclang_shared.so instead of the individu

[PATCH] D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros

tstellar created this revision. tstellar added reviewers: beanz, smeenai. Herald added subscribers: dexonsmith, steven_wu, mgorny, mehdi_amini. Herald added projects: clang, LLVM. This will simplify the macros by allowing us to remove the hard-coded list of libraries that should be installed when

[PATCH] D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

tstellar created this revision. tstellar added reviewers: beanz, smeenai. Herald added a subscriber: mgorny. Herald added a project: clang. tstellar added a parent revision: D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros. If CLANG_LINK_CLANG_DYLIB is also enabled, then t

[PATCH] D64608: [OpenCL] Make TableGen'd builtin tables and helper functions static

tstellar created this revision. tstellar added reviewers: Pierre, Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64608 Files: clang/lib/Sema/SemaLookup.cpp clang/utils/TableGen/ClangOpenCLBuiltinEmi

[PATCH] D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL365902: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros (authored by tstellar, committed by ). Changed prior to commit: https://reviews.llvm.org/D64580?vs=209285&id=209482#toc Reposito

[PATCH] D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rL365905: cmake: Fix install of libclang-cpp.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D64608: [OpenCL] Make TableGen'd builtin tables and helper functions static

This revision was automatically updated to reflect the committed changes. Closed by commit rL366143: [OpenCL] Make TableGen'd builtin tables and helper functions static (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

tstellar created this revision. tstellar added reviewers: dyung, rsmith, hansw. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66176 Files: clang/test/Driver/modules.cpp Index: clang/test/Driver/modules.cpp =

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

tstellar updated this revision to Diff 214960. tstellar added a comment. Another attempt to fix this that depends less on the build directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66176/new/ https://reviews.llvm.org/D66176 Files: clang/

[PATCH] D61909: Add Clang shared library with C++ exports

tstellar added a comment. In D61909#1563678 , @sylvestre.ledru wrote: > For now, it isn't part of the debian packaging. > > https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/blob/snapshot/debian/rules#L563 > it is removed as packaging phase as I ha

[PATCH] D63503: cmake: Add CLANG_LINK_CLANG_DYLIB option

tstellar added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63503/new/ https://reviews.llvm.org/D63503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D63503: cmake: Add CLANG_LINK_CLANG_DYLIB option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL365092: cmake: Add CLANG_LINK_CLANG_DYLIB option (authored by tstellar, committed by ). Herald added a project: LLVM. Cha

[PATCH] D64278: Rename libclang_shared to libclang-cpp

tstellar added a comment. I'm fine with this new name. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64278/new/ https://reviews.llvm.org/D64278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D61804: Support building shared and static libraries simultaneously

tstellar added a comment. Not sure if this would be relevant for your use case, but it would be really nice to have a libCLANG.so with all the C++ symbols, like we do for llvm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61804/new/ https://revie

[PATCH] D61804: Support building shared and static libraries simultaneously

tstellar added a comment. > ! In D61804#149 , @beanz wrote: > I apologize that I missed your thread on the dev list, because that would > have been a much better place to have this conversation. Having gone back and > read it now, it sounds to me lik

[PATCH] D61909: Add Clang shared library with C++ exports

tstellar added a comment. Thanks for working on this, I have wanted something like this for a while. It would also be nice to have a CLANG_LINK_CLANG_DYLIB option like we have for llvm, but this can be a follow on patch, and I would be happy to help with this if needed. Comm

[PATCH] D61909: Add Clang shared library with C++ exports

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. We can add CLANG_LINK_CLANG_DYLIB as a follow-up patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

tstellar updated this revision to Diff 05. tstellar added a comment. Don't check .s suffix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66176/new/ https://reviews.llvm.org/D66176 Files: clang/test/Driver/modules.cpp Index: clang/test/Dri

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

tstellar marked an inline comment as done. tstellar added inline comments. Comment at: clang/test/Driver/modules.cpp:19 +// CHECK-COMPILE-SAME: {{ -o }} +// CHECK-COMPILE-SAME: module{{2*}}.{{pcm.o|s}} // CHECK-COMPILE-SAME: -x pcm dyung wrote: > I'm not sure wh

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

This revision was automatically updated to reflect the committed changes. Closed by commit rL373275: Fix Driver/modules.cpp test to work when build directory name contains '.s' (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D44130: Driver: Add gcc search path for RHEL devtoolset-7

This revision was automatically updated to reflect the committed changes. Closed by commit rL329854: Driver: Add gcc search path for RHEL devtoolset-7 (authored by tstellar, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44130 Files:

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar updated this revision to Diff 142294. tstellar added a comment. Replaced the if (Distro.isRedhat()) check with a string compare on the GCC installation lib. This narrows the scope of the fix and also makes it possible to write a test case. The code that detects distros ignores sysroot a

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

This revision was automatically updated to reflect the committed changes. Closed by commit rL336037: Driver: Don't mix system tools with devtoolset tools on RHEL (authored by tstellar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D34

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar created this revision. tstellar added a reviewer: beanz. Herald added a subscriber: mgorny. Herald added a project: clang. We were linking all the clang objects and shared libraries into libclang-cpp.so, which was causing the command line options to be registered twice. Repository: rG

[PATCH] D68720: Support -fstack-clash-protection for x86

tstellar added inline comments. Comment at: clang/test/CodeGen/stack-clash-protection.c:3 +// RUN: %clang -target x86_64 -o %t.out %s -fstack-clash-protection && %t.out + +#include There were concerns[1] raised recently about adding clang tests that were codege

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar created this revision. tstellar added reviewers: vsk, efriedma. Herald added a project: clang. Add a special case for handling __builtin_mul_overflow with unsigned inputs and a signed output to avoid emitting the __muloti4 library call on x86_64. __muloti4 is not implemented in libgcc, s

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar updated this revision to Diff 280104. tstellar added a comment. Remove stray comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84405/new/ https://reviews.llvm.org/D84405 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/b

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar added a comment. In D84405#2170110 , @vsk wrote: > How were you able to show that the specialized IRGen is equivalent to the > generic kind? I tried doing this with direct inspection > (https://godbolt.org/z/o5WEn3), but wasn't able to convince

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar updated this revision to Diff 281092. tstellar added a comment. Herald added a subscriber: mstorsjo. Add 64-bit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84405/new/ https://reviews.llvm.org/D84405 Files: clang/lib/CodeGen/CGBu

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar added a comment. This is the test driver I used for testing. I compared the clang 11 + this patch with gcc 10 and saw no differences: https://gist.github.com/tstellar/80dae2ab8a18d810b10b8e42777f4fe4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar added a comment. Here is the assembly comparison for the 64-bit test I added between gcc and clang trunk + patch: https://reviews.llvm.org/P8227 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84405/new/ https://reviews.llvm.org/D84405 _

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar updated this revision to Diff 281419. tstellar added a comment. Add volatile test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84405/new/ https://reviews.llvm.org/D84405 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/buil

[PATCH] D84405: CodeGen: Improve generated IR for __builtin_mul_overflow(uint, uint, int)

tstellar marked an inline comment as done. tstellar added inline comments. Comment at: clang/test/CodeGen/builtins-overflow.c:123 + // CHECK: br i1 [[C2]] + int r; + if (__builtin_mul_overflow(x, y, &r)) vsk wrote: > vsk wrote: > > Could you add a test for the

[PATCH] D81424: Driver: Accept multiple --config options if filenames are the same

tstellar created this revision. tstellar added reviewers: sepavloff, hfinkel. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're trying to use the --config options to pass distro specific options for Fedora via the CFLAGS variable. However, some projects end up using the

[PATCH] D81424: Driver: Accept multiple --config options if filenames are the same

This revision was automatically updated to reflect the committed changes. Closed by commit rGd970ab63e22e: Driver: Accept multiple --config options if filenames are the same (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81424/

[PATCH] D78190: Add Bfloat IR type

tstellar added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBFloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32 bit floating point type */ --

[PATCH] D82694: [clang-shlib] Don't link with static clang libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d68a780b34e: [clang-shlib] Don't link with static clang libraries (authored by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82694/new/ https://

[PATCH] D82694: [clang-shlib] Don't link with static clang libraries

tstellar created this revision. tstellar added a reviewer: smeenai. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. If we are building static libraries we don't need to link them into clang-shlib, since clang-shlib already has all the individual object files linked in

[PATCH] D79279: Add overloaded versions of builtin mem* functions

tstellar added a comment. In D79279#2200916 , @rsmith wrote: > In D79279#2197176 , @rjmccall wrote: > >> I thought part of the point of `__builtin_memcpy` was so that C library >> headers could do `#define memcpy(x

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

tstellar added a comment. In D74051#2017115 , @mgorny wrote: > Nevermind, I figured out good enough workaround. What was the workaround? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74051/new/ https://rev

[PATCH] D85844: [Driver] Change -fnostack-clash-protection to -fno-stack-clash-protection

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85844/new/ https://reviews.llvm.org/D85844

[PATCH] D79617: Add cet.h for writing CET-enabled assembly code

tstellar reopened this revision. tstellar added a comment. This revision is now accepted and ready to land. Did @rsmith ever approve this patch? I was following the discussion at llvm.org/PR45484 but did not see an explicit approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D34848: Driver: Don't mix system tools with devtoolset tools on RHEL

tstellar added a comment. Ping. https://reviews.llvm.org/D34848 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D125624: [gold] Remove an external dependency to GNU binutils' header file

tstellar added a comment. In D125624#3614298 , @ruiu wrote: > In D125624#3552770 , @tstellar > wrote: > >> In D125624#3552463 , @ruiu wrote: >> OK, as I mentioned. I

[PATCH] D123967: Disable update_cc_test_checks.py tests in stand-alone builds

tstellar added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123967/new/ https://reviews.llvm.org/D123967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D128777: clang/cmake: Drop use of llvm-config for LLVM install discovery

tstellar created this revision. Herald added a subscriber: mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This has been deprecated for a while, remove it in favor of using cmake's find_package(

[PATCH] D129160: libclang.so: Make SONAME the same as LLVM version

tstellar created this revision. tstellar added reviewers: MaskRay, h-vetinari. Herald added subscribers: StephenFan, fedor.sergeev, mgorny. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This partially

[PATCH] D109621: [clang][Driver] Default to loading clang.cfg if config file not specified

tstellar added a comment. I similar RFC for this was proposed here: https://discourse.llvm.org/t/rfc-adding-a-default-file-location-to-config-file-support/63606 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109621/new/ https://reviews.llvm.org/D109621 _

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

tstellar added a comment. The reason I used a minimal check string is because if the warning text changes at all, then the test becomes useful (this is the downside of using -NOT). I wonder if there is another way to test this that might be robust? If not, then I think this change is fine.

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. In D122487#3408425 , @rs wrote: > @tstellar thanks for the review. I can't really think of any other way to > test this. I'll wait till Monday if

  1   2   3   4   >