[PATCH] D35046: [coroutines] Include "this" type when looking up coroutine_traits

2017-10-04 Thread Toby Allsopp via Phabricator via cfe-commits
toby-allsopp abandoned this revision. toby-allsopp added a comment. Yes, @EricWF made a much more comprehensive change that has been in for a while now. Abandoning. https://reviews.llvm.org/D35046 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D35046: [coroutines] Include "this" type when looking up coroutine_traits

2017-07-06 Thread Toby Allsopp via Phabricator via cfe-commits
toby-allsopp created this revision. In N4663, section [dcl.fct.def.coroutine] states that, in a coroutine that is a non-static member function, the type of the implicit object parameter is included immediately before the types of the function parameters. https://reviews.llvm.org/D35046 Files:

[PATCH] D35046: [coroutines] Include "this" type when looking up coroutine_traits

2017-07-09 Thread Toby Allsopp via Phabricator via cfe-commits
toby-allsopp added a comment. In https://reviews.llvm.org/D35046#802838, @EricWF wrote: > I think the test could be improved. First could you add the test within > `test/SemaCXX/coroutines.cpp`? Second could you add some negative tests that > check the diagnostics generated when you don't provi