[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta created this revision. Herald added subscribers: llvm-commits, cfe-commits, mstorsjo, dexonsmith, mgorny. Herald added projects: clang, LLVM. These are a collection of small fixes to make LLVM/Clang build with a clang+mingw toolchain to target Windows. The three commits address the follo

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta marked 5 inline comments as done. thieta added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:71 + list(APPEND LIBS ${CMAKE_DL_LIBS}) endif() mstorsjo wrote: > If you say this is the same way it's done elsewhere, then sure - although

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. I am planning to revise this one now that we have thinlto-cache-dir option landed here are my plans: - Keep the libdl patch as is (seems like there are no more comments on this). - Remove the symlink patch for now and potentially move that to another patch - Rework the ca

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Sounds good - I'll close this one and open three new ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list

[PATCH] D80492: Avoid linking libdl unless needed

thieta created this revision. thieta added a reviewer: mstorsjo. thieta added a project: clang. Herald added subscribers: cfe-commits, mgorny. This fixes cross-compilation when targeting a platform not using libdl and mirrors libdl linking in other parts of the code. Repository: rG LLVM Githu

[PATCH] D80492: Avoid linking libdl unless needed

thieta added a comment. @mstorsjo mind landing this for me as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096

thieta accepted this revision. thieta added a comment. Thanks for handling this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77746/new/ https://reviews.llvm.org/D77746 ___ cfe-commits mailing list cf

[PATCH] D80492: Avoid linking libdl unless needed

thieta added a comment. Thanks - I'll look into a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D81385: Fix libdl linking for libclang in standalone mode

thieta created this revision. thieta added reviewers: mstorsjo, beanz, lebedev.ri. thieta added a project: clang. Herald added subscribers: cfe-commits, mgorny. As noted in https://reviews.llvm.org/D80492 that change broke standalone builds of clang. This reverts the old behavior of libdl linking

[PATCH] D80492: Avoid linking libdl unless needed

thieta added a comment. @lebedev.ri fix for your issue posted here: https://reviews.llvm.org/D81385 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 ___ cfe-comm

[PATCH] D132791: Fix formatting in release notes

thieta accepted this revision. thieta added a comment. This revision is now accepted and ready to land. Thanks for doing this pass! Much appreciated. As long as you tried to build the docs after you changes and it passes without any warnings or errors I am happy for you to commit this directly t

[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

thieta added a comment. Hmm. 15.0.0 is just a week away - I am not planning any more RCs unless we hit something critical. What's the risk of taking this specific change at this point? Would it make more sense to wait for 15.0.1? (I am guessing it's better if it goes into 15.0.0 or not in 15.x

[PATCH] D133044: [Frontend] Restore Preprocessor::getPredefines()

thieta accepted this revision. thieta added a comment. LGTM and seems pretty safe so I am not opposed to merge it before 15 final. I would maybe add a link to the GitHub issue in the comment, but that's a nit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D133800: [Clang 15.0.1] Downgrade implicit int and implicit function declaration to warning only

thieta added a comment. I think the easiest way to handle this is that when you have it approved here - push it to fork on GitHub based on the release branch and create a GitHub issue and write /branch aballman/llvm-project/my_branch in a comment and it will queue up the cherry pick. Reposito

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440178. thieta added a comment. Added tests and moved the check for TY_Plist and TY_AST to it's own if statement block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440227. thieta added a comment. Fixed missing -- in test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta added a comment. Fixed the test issue. Regarding `/Fo` bit - if you want I can change it to only handle `/o` in this if statement. I don't mind either way. Comment at: clang/test/Driver/ast.c:30 +// Also check clang-cl since the driver is slightly different +// RUN: %cl

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440242. thieta added a comment. Just handle /o for AST and plist files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/include/clang/Driver/Options.td

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

thieta updated this revision to Diff 440243. thieta added a comment. Updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128409/new/ https://reviews.llvm.org/D128409 Files: clang/include/clang/Driver/Options.td clang/lib/Drive

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta created this revision. thieta added reviewers: steakhal, martong, NoQ. Herald added a subscriber: rnkovacs. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. When doing CTU analysis setup you pre-compile .cpp to .ast and then you run clang

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta added a comment. This still needs tests - but I wanted to get your early input on the approach here and what you all think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128704/new/ https://reviews.llvm.org/D128704

[PATCH] D128409: [clang-cl] Add -emit-ast to clang-cl driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3f0578dd87ee: [clang-cl] Add -emit-ast to clang-cl driver (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta updated this revision to Diff 440558. thieta added a comment. Add test. Just repurpose the same test we already have but add a step to generate ast first and then pushing that through extdef-mapping. It should always produce the same result. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta added inline comments. Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:122 + + CompilerInstance CI; + Not sure if I can just create a compilerinstance here and if I should feed it anymore data then I already do. Comm

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta added inline comments. Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:136 + FileManager fm(CI.getFileSystemOpts()); + SmallString<128> absPath(astPath); + fm.makeAbsolutePath(absPath); thieta wrote: > Pretty sure 128 is wrong here -

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta updated this revision to Diff 441279. thieta added a comment. Clean-ups and error handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128704/new/ https://reviews.llvm.org/D128704 Files: clang/test/Analysis/func-mapping-test.cpp clan

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta updated this revision to Diff 441930. thieta marked 6 inline comments as done. thieta added a comment. Addressed review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128704/new/ https://reviews.llvm.org/D128704 Files: clang/docs

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta marked an inline comment as done. thieta added a comment. Thanks for the review! I uploaded a new version addressing all (I think) of your feedback and added a release note. The help text is a bit weird since it's using a commonoptionsparser we can't really change the text to add `` as a

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta added a comment. Ran some internal benchmarks on 1570 files (C and C++ mixed but much more C++ than C): Running clang-extdef-mapping on the source files took: 268s Running clang-extdef-mapping on the AST: 102s That's quite a large speed up if you already need to generate the AST files.

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta updated this revision to Diff 442211. thieta marked 3 inline comments as done. thieta added a comment. Uppercase all variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128704/new/ https://reviews.llvm.org/D128704 Files: clang/docs/Re

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ff553979e8: [clang-extdef-mapping] Directly process .ast files (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC

thieta added a comment. Isn't it better to silence this warning with a pragma instead of disabling it for the whole file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129152/new/ https://reviews.llvm.org/D129152 _

[PATCH] D129152: [Clang][unittests] Silence trucation warning with MSVC

thieta accepted this revision. thieta added a comment. Thanks for switching to pragma! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129152/new/ https://reviews.llvm.org/D129152 ___ cfe-commits mailing l

[PATCH] D128704: [clang-extdef-mapping] Directly process .ast files

thieta added inline comments. Comment at: clang/tools/clang-extdef-mapping/ClangExtDefMapGen.cpp:42 + : Ctx(Context), SM(Context.getSourceManager()) { +CurrentFileName = astFilePath.str(); + } steakhal wrote: > Why is this not initialized in the //initi

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

This revision was automatically updated to reflect the committed changes. Closed by commit rG67d9276b1602: [clang-cl] Ignore /Wv and /Wv:17 flags (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.or

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta created this revision. thieta added reviewers: mehdi_amini, jyknight, jhenderson, hans, tstellar, cor3ntin, MaskRay. Herald added subscribers: ayermolo, StephenFan, mgorny. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added a proj

[PATCH] D129446: [clang][driver] Find Apple default SDK path

thieta added a comment. Ping - any thoughts on this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129446/new/ https://reviews.llvm.org/D129446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684330 , @mehdi_amini wrote: > What does it mean exactly? We can't use **anything** C++17 without writing it > in the coding standards? > I'm not sure it'll be manageable: how do you see this playing out? Probably po

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 448261. thieta added a comment. Address some old comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.txt

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684360 , @barannikov88 wrote: > There are a few places (primarily in ADT and Support) that check __cplusplus > > 201402. Do they need to be cleaned up? Sounds good - but maybe that can be addressed in a separate diff

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684334 , @ChuanqiXu wrote: > So it is free that developers want to use some C++17 features in a small > amount of code, right? As soon as this land C++ 17 should be free to use everywhere yeah! Repository: rG LLVM

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 448262. thieta added a comment. Fixed unintended indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files: bolt/runtime/CMakeLists.txt clang/CMakeLists.t

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686397 , @thakis wrote: > It'd be nice if this was landed opt-in behind some cmake variable at first, > so that folks could try it out on their bots and see how well things work. You can already test this with `-DCMAK

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3684399 , @h-vetinari wrote: > It may be worth calling out that this is about C++17 core language and not > the standard library? > > libstdcxx only finished C++17 support in GCC 12, and libcxx is still missing > vari

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686718 , @thieta wrote: > In D130689#3684399 , @h-vetinari > wrote: > >> It may be worth calling out that this is about C++17 core language and not >> the standard library? >>

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3686723 , @h-vetinari wrote: > I don't think the standard library can be called a vendor-specific extension, > and so I think this still could/should be made clearer (even though the > status links below would show up

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3689157 , @thakis wrote: > Is it expected and intentional that this increases the mac deployment target > to 10.12? I wasn't aware of that - but I think it's expected since the check in RWMutex checks for the C++ stan

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3690274 , @nikic wrote: > Given > https://github.com/llvm/llvm-project/blob/2bb7c54621f31a957302a4deb3d25b752acb07bd/llvm/include/llvm/Support/RWMutex.h#L22-L27, > it seems like this is supposed to be supported. This i

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. @nikic @thakis I fixed this issue in https://reviews.llvm.org/D131063 and it can be built with CXX_STANDARD=17 and OSX_DEPLOYMENT_TARGET=10.11. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. All right! Last call - I am going fix the spelling error and merge this tomorrow EU time unless someone objects. Thanks for all reviews so far! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta updated this revision to Diff 450364. thieta added a comment. Fixed spelling error and added links to C++ standard libraries Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/ https://reviews.llvm.org/D130689 Files: bolt/runtime/CM

[PATCH] D130689: [LLVM] Update C++ standard to 17

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1356504e63a: [LLVM] Update C++ standard to 17 (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705131 , @royjacobson wrote: > This seems to have been more disruptive than expected, since an existing > CMakeCache.txt can make LLVM compile in previous C++14 configuration. This > seems to make some of the bots fa

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705236 , @royjacobson wrote: > This affects people on their work branches as well, and it's not obvious that > it's a configuration error and not a broken master. > > The CMake approach sounds cleaner to me, but I don

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705474 , @dyung wrote: > We are seeing an additional failure on an internal linux bot due to the > change to using C++17 by default when using GNU ld: > ... > Switching between BFD ld and gold still fails (although gol

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3705579 , @Jake-Egan wrote: > There is a failure on the AIX bot also: > ... > https://lab.llvm.org/buildbot/#/builders/214/builds/2707/steps/5/logs/stdio Filed an issue here: https://github.com/llvm/llvm-project/issues/

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706199 , @cor3ntin wrote: > Trying to read the logs,, notably > `C:\PROGRA~2\MIB055~1\2019\PROFES~1\VC\Tools\MSVC\1429~1.301\bin\Hostx64\x64\cl.exe > `, it would seem that this particular bot is running a version much

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706263 , @aaron.ballman wrote: > > Something odd is going on here and we might want to consider a revert of this > patch until we resolve it. When I do a git pull and cmake files change, > Visual Studio's built-i

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706336 , @aaron.ballman wrote: > That's the only reason this hasn't been reverted already. Landing sweeping > changes on a weekend is a good way to reduce the pain, but we really need to > be sure someone watches the

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3706424 , @aaron.ballman wrote: > +1, thank you for thinking about how we can improve this process in the > future! Given that C++17 adoption across compilers has been far better than > C++20, I suspect the next time

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) glandium wrote: > You didn't update l

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/cmake/modules/CheckCompilerVersion.cmake:16 # _MSC_VER == 1927 MSVC++ 14.27 Visual Studio 2019 Version 16.7 -set(MSVC_MIN 19.20) +set(MSVC_MIN 19.27) set(MSVC_SOFT_ERROR 19.27) glandium wrote: > thieta wrote: > > g

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. In D130689#3709742 , @aaron.ballman wrote: > One thing I think would be a definite improvement is to have done an RFC on > Discourse for these changes so that downstreams have a chance to weigh in on > the impact. The patch was

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. I think a week or two of moratorium would be good for sure. I think we can table this discussion for now and I will write a RFC post in discourse when I have time and we can discuss the details there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added a comment. Hi - I tried to incorporate all the feedback here and added a post to discourse suggesting tweaks to the developer policy - please have a look and review it: https://discourse.llvm.org/t/rfc-updates-to-developer-policy-around-c-standards-bump/64383 Repository: rG LLVM

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta created this revision. thieta added reviewers: hans, mstorsjo, rnk. Herald added a project: All. thieta requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. MSVC supports passing /Wv and /Wv:17 to ignore w

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta updated this revision to Diff 417533. thieta added a comment. Added back removed blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 Files: clang/include/clang/Driver/Options.td clang/te

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta added inline comments. Comment at: clang/include/clang/Driver/Options.td:2496 Group, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>; -def fopenmp_assume_no_thread_state : Flag<["-"], "fopenmp-assume-no-thread-state">, Group, - Flags<[CC1Option, NoArgumentUnused, He

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta updated this revision to Diff 417537. thieta added a comment. Split whitespace to it's own commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 Files: clang/include/clang/Driver/Options.td cl

[PATCH] D122298: [clang-cl] Ignore /Wv and /Wv:17 flags

thieta added a comment. Pushed the whitespace fix as a NFC here: https://github.com/llvm/llvm-project/commit/09c0685a043dd4028545c134b562c2605e294855 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122298/new/ https://reviews.llvm.org/D122298 _

[PATCH] D129446: [clang][driver] Find Apple default SDK path

thieta created this revision. thieta added reviewers: egorzhdan, t.p.northover, dexonsmith, ldionne. Herald added a project: All. thieta requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. Currently if you download clang and install it on macOS it

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta created this revision. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have autogenerated pragma regions in our code which where awkwardly broken up like this: #pragma region foo(bar : hello)

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta updated this revision to Diff 430882. thieta added a comment. Added additional tests to check other pragma statements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125961/new/ https://reviews.llvm.org/D125961 Files: clang/lib/Format/Forma

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta added a comment. In D125961#3526347 , @wanders wrote: > There are other pragmas which include colon. How do they fare? > > Example > https://docs.microsoft.com/en-us/cpp/preprocessor/warning?view=msvc-170 > > #pragma warning( disable : 4507 34;

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta added a comment. In D125961#3527447 , @curdeius wrote: > Thanks for the patch! > Could you please add a unit test in unittest/Format/FormatTest.cpp instead of > in lit-based test/? > Is there a bug report that your patch fixes? Sure - I didn't kn

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta updated this revision to Diff 430953. thieta added a comment. Switched to unit test over lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125961/new/ https://reviews.llvm.org/D125961 Files: clang/lib/Format/FormatToken.h clang/lib

[PATCH] D125961: [clang-format] Don't break lines after pragma region

thieta updated this revision to Diff 430954. thieta added a comment. Removed comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125961/new/ https://reviews.llvm.org/D125961 Files: clang/lib/Format/FormatToken.h clang/lib/Format/TokenAnnotat

[PATCH] D125961: [clang-format] Don't break lines after pragma region

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG749fb33e82ff: [clang-format] Don't break lines after pragma region (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

thieta created this revision. thieta added reviewers: MyDeveloperDay, curdeius, owenpan. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In our code-base we auto-generate pragma regions the regions look l

[PATCH] D136337: [clang-format] Discard pre-processor statements in parseBracedList()

thieta created this revision. thieta added reviewers: MyDeveloperDay, curdeius, owenpan. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We had some code that looked like this: int foo() { #pragm

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

thieta updated this revision to Diff 470092. thieta added a comment. Added TokenAnnotatorTest and removed reduntant FormatTests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136336/new/ https://reviews.llvm.org/D136336 Files: clang/lib/Format/To

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

thieta added a comment. In D136336#3877238 , @owenpan wrote: > Can you add a test to `TokenAnnotatorTest.cpp`? Thanks for the review. Fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136336/new/ ht

[PATCH] D136337: [clang-format] Discard pre-processor statements in parseBracedList()

thieta added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136337/new/ https://reviews.llvm.org/D136337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

thieta updated this revision to Diff 470380. thieta added a comment. git clang-format removed accidental include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136336/new/ https://reviews.llvm.org/D136336 Files: clang/lib/Format/TokenAnnotator.cp

[PATCH] D136337: [clang-format] Discard pre-processor statements in parseBracedList()

thieta abandoned this revision. thieta added a comment. In D136337#3881476 , @owenpan wrote: > Can you create an issue on GitHub and include the details on how to reproduce > the problem using the latest clang-format? Ah I re-tested this with main and i

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd1d93db7106: [clang-format] Mark pragma region lines as StringLiterals (authored by thieta). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thieta added a comment. We have tooling that uses this command line from the PDB. I think the conservative approach is to emit the command line by default since this is how MSVC behaves. I don't mind this flag now that I know about it, but I think we should keep the default to what MSVC does fo

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thieta added a comment. Also this should have a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

thieta added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1345 while (CurrentToken) { -if (IsMark || CurrentToken->Previous->is(TT_BinaryOperator)) +if (IsMarkOrRegion || CurrentToken->Previous->is(TT_BinaryOperator)) { Curren

[PATCH] D126903: [clang] Add support for __builtin_memset_inline

thieta added a comment. We have been building a two stage clang and our internal projects with this version of rpmalloc and clang 15.x a while now and I haven't see the issue you see @aganea. I don't think this patch is the problem as @efriedma suggested, could be in rpmalloc but since I have u

[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

thieta added a comment. I am fine with this plan as well. And I am willing to chip in and try to fix the issues with the current implementation since we actually use the feature. @thakis do you mind explaining the issues you see and how to replicate them and I can have a look. Repository: r

[PATCH] D130689: [LLVM] Update C++ standard to 17

thieta added inline comments. Comment at: llvm/docs/ReleaseNotes.rst:57 + +* GCC >= 7.1 +* Clang >= 5.0 xbolva00 wrote: > Do we have bots which uses last supported compiler versions? GCC 7.1, Clang > 5.0 and MSVC 16.7. > > It is bad to promise something and the

[PATCH] D127293: [clang-tidy] Ignore other members in a union if any member of it is initialized in cppcoreguidelines-pro-type-member-init

thieta added a comment. Hi @Sockke - this seems to be ready to land. Is there something holding it back? We ran into the same issue recently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127293/new/ https://reviews.llvm.org/D127293 ___ cfe-

[PATCH] D132486: Revert "libclang.so: Make SONAME the same as LLVM version"

thieta created this revision. Herald added subscribers: fedor.sergeev, mgorny. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This reverts commit bc39d7bdd4977a953b2e102f8f7eb479ad78984e

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thieta updated this revision to Diff 455087. thieta added a comment. Updated the option to default to ON - meaning we keep the current behavior found in main. This rationel for this is explained in my post here: https://discourse.llvm.org/t/rationale-for-removing-versioned-libclang-middle-ground

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thieta updated this revision to Diff 455088. thieta added a comment. Fixed variable name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132486/new/ https://reviews.llvm.org/D132486 Files: clang/CMakeLists.txt clang/docs/ReleaseNotes.rst clang

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

thieta added a comment. @jrtc27 What do you think about this patch with the default flipped? I think this is how it should land personally as discussed on discourse. I have been trying to listen in how people want to handle this and I hope this is a good middle ground that we can agree on for 1

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0f28d4856630: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION (authored by h-vetinari, committed by thiet

  1   2   >