[PATCH] D154761: [clang][Interp] Diagnose callsite for implicit functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't have any code to point at here, so the diag

[PATCH] D154778: [clang] Fix __is_trivially_equality_comparable for classes which contain arrays of non-trivially equality comparable types

tbaeder added inline comments. Comment at: clang/lib/AST/Type.cpp:2676 + if (Type->isArrayType()) +Type = Type->getBaseElementTypeUnsafe()->getCanonicalTypeUnqualified(); + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D154758: [clang][Interp] Emit correct diagnostic for uninitialized reads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc54ff51be9c1: [clang][Interp] Emit correct diagnostic for uninitialized reads (authored by tbaeder). Changed prior to commit: https://reviews.llvm

[PATCH] D154795: [clang][Interp] Check pointers for live-ness when returning them

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We might be trying to return a pointer or reference

[PATCH] D152132: [clang][Inter] Fix lifetime diagnostics for dead records

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152132/new/ https://reviews.llvm.org/D152132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. One problem this does not fix (but rather introduce) is that the `InterpState` will also free initmaps of global variables which haven't been fully initialized. When the initialization fails midway throught, the `InterpState` will free the `InitMap`, leaving the global

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

tbaeder added a comment. > Maybe you can show an example how this might look like in practice? AFAIU, the real-world case is more a C "class" struct with a couple of function pointers (a vtable), which might be different depending on circumstances. So, the problem with this (type of) analysis i

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2436 +CF.getVarDecl()->getLocation()); + break; +} tbaeder wrote: > aaronpuchert wrote: > > aaronpuchert wrote: > > > tbaeder wrote

[PATCH] D154928: [clang][Interp] Call dtor or Floating values

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The APFloat might heap-allocate some memory, so we n

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder abandoned this revision. tbaeder added a comment. I'm gonna close this, since the new approach is too different. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 ___ cfe-commits mailing list c

[PATCH] D149013: [clang][Interp] Check pointers when accessing base class

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149013/new/ https://reviews.llvm.org/D149013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements `__builtin_bit_cast()`. The new opcod

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16999-17000 + + if (CheckOnly) +return true; + aaron.ballman wrote: > E, this seems like a pretty big surprise because evaluating that char > range can fail. This means: > ``` > c

[PATCH] D155165: [clang][Interp] Fully serialize Floatings to bytes

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit is a bit ugly at the moment since I'm gath

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:17059 +// the message is grammatically valid without evaluating it. +if (!Failed && AssertMessage && !!Cond) { + std::string Str; Should work, shouldn't it? Repository: rG

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D154475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. When passing a different prefix via `-verify=foo`, the error messages now say "error: 'foo-error' diagnostics seen but not expected", etc. I'm often working in test files where two different prefixes are used and I'm always confused about which one of the two the error

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. In D154688#4498398 , @aaron.ballman wrote: > In D154688#4497967 , @tbaeder wrote: > >> When passing a different prefix via `-verify=foo`, the error messages now >> say "error: 'foo-error

[PATCH] D155270: [clang][Interp] Basic support for bit fields

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. One existing problem is that we can't do much with the

[PATCH] D153616: [clang][Interp] Create a new local variable in visitLambdaExpr()

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153616/new/ https://reviews.llvm.org/D153616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

tbaeder added a comment. Tests will come in a later commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155367/new/ https://reviews.llvm.org/D155367 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D155368: [clang][Interp] __builtin_copysign

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a way to pop arguments based on the call expressio

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Function.h:180 +// FIXME: Is there a better way to get this information? +if (getName() == "__builtin_isnan") + return true; cor3ntin wrote: > You can compare getBuiltinID(), which is be

[PATCH] D155371: [clang][Interp] Implement __builtin_isinf

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder updated this revision to Diff 540692. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155369/new/ https://reviews.llvm.org/D155369 Files: clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Function.h clang/lib/AST/Interp/Interp.cpp clang/lib/AST/Interp/Interp.h clang/

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Function.h:180 +// FIXME: Is there a better way to get this information? +if (getName() == "__builtin_isnan") + return true; cor3ntin wrote: > t

[PATCH] D155371: [clang][Interp] Implement __builtin_isinf

tbaeder updated this revision to Diff 540693. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155371/new/ https://reviews.llvm.org/D155371 Files: clang/lib/AST/Interp/Floating.h clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST

[PATCH] D155372: [clang][Interp] Implement __builtin_isfinite

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155372: [clang][Interp] Implement __builtin_isfinite

tbaeder updated this revision to Diff 540699. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155372/new/ https://reviews.llvm.org/D155372 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/test/AST/Interp/builtin-functions.cpp

[PATCH] D155374: [clang][Interp] Implement __builtin_isnormal

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155369: [clang][Interp] Implement __builtin_isnan()

tbaeder updated this revision to Diff 540760. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155369/new/ https://reviews.llvm.org/D155369 Files: clang/lib/AST/Interp/Function.cpp clang/lib/AST/Interp/Function.h clang/lib/AST/Interp/Interp.cp

[PATCH] D155393: [clang][Interp] Implement __builtin_isfpclass

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155394: [clang][Interp] Implement __builtin_fpclassify

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

tbaeder updated this revision to Diff 540774. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155367/new/ https://reviews.llvm.org/D155367 Files: clang/lib/AST/Interp/InterpBuiltin.cpp Index: clang/lib/AST/Interp/InterpBuiltin.cpp ===

[PATCH] D155400: [clang][Interp] Implement __builtin_fabs()

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155401: [clang][Interp] Implement __builtin_fmax

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:119 +static bool interp__builtin_inf(InterpState &S, CodePtr OpPC, +const InterpFrame *Frame, const Function *F) { cor3ntin wrote: > why does that

[PATCH] D155410: [clang][Interp] Fix comparing nan/inf floating point values

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155430: [clang][Interp] Implement __arithmethic_fence for floating types

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D155270: [clang][Interp] Basic support for bit fields

tbaeder updated this revision to Diff 540927. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155270/new/ https://reviews.llvm.org/D155270 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Rec

[PATCH] D154761: [clang][Interp] Diagnose callsite for implicit functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6afacc0347c: [clang][Interp] Diagnose callsite for implicit functions (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152246/new/ https://reviews.llvm.org/D152246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2436 +CF.getVarDecl()->getLocation()); + break; +} tbaeder wrote: > tbaeder wrote: > > aaronpuchert wrote: > > > aaronpuchert wrote

[PATCH] D158702: [clang][Interp] Check pointer inc/dec ops for initialization

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9512 uint64_t TSize = Info.Ctx.getTypeSizeInChars(T).getQuantity(); +if (TSize == 0) + return false; shafik wrote: > I think we should issue a diagnostic, we don't have any in

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

tbaeder added a comment. In D158502#4616174 , @cor3ntin wrote: > FYI there are build failures. you probably need to rebase (visitAPValue does > not seem to actually exist) This depends on the `__builtin_offsetof()` patch. Repository: rG LLVM Github

[PATCH] D158516: [clang][Interp] Only lazily visit constant globals

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158516/new/ https://reviews.llvm.org/D158516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158595: [clang][Interp] Allow zero-init of primitives with an empty init list

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158595/new/ https://reviews.llvm.org/D158595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158702: [clang][Interp] Check pointer inc/dec ops for initialization

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158702/new/ https://reviews.llvm.org/D158702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2113 + +bool CFGBuilder::hasTrivialDestructor(VarDecl *VD) const { // Check for const references bound to temporary. Set type to pointee. steakhal w

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder updated this revision to Diff 555251. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp clang/lib/Analysis/PathDiagnostic.

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder added a comment. Not sure I have enough CFG knowledge. Do I just need to create another noreturn block for the cleanup function? This is the CFG I get when both the cleanup function and the destructor are noreturn: int main() [B4 (ENTRY)] Succs (1): B3 [B1] 1: CFGS

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:1901-1902 appendLifetimeEnds(Block, VD, S); -if (BuildOpts.AddImplicitDtors) +if (BuildOpts.AddImplicitDtors && !hasTrivialDestructor(VD)) appendAutomaticObjDtor(Block, VD, S); +if (Ha

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder updated this revision to Diff 555403. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp clang/lib/Analysis/PathDiagnostic.cpp clang/lib/StaticAnalyzer/Core/ExprEn

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder marked an inline comment as done. tbaeder added a comment. @steakhal Double lifetime ends should be fixed now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 ___ cfe-commits mailing list cfe

[PATCH] D157072: [clang][ExprConst] Check float operation input for signaling NaNs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157072/new/ https://reviews.llvm.org/D157072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158361: [clang][Sema] Fix a copy/paste bug in ~Sema()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG84643bfa8723: [clang][Sema] Fix a copy/paste bug in ~Sema() (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

tbaeder added a comment. I thought this review wasn't clear at all on what's supposed to happen but since https://reviews.llvm.org/D157072 is going nowhere, I'll just push this one in the next few days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D149133: [clang][Interp] BaseToDerived casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12a789710e2b: [clang][Interp] BaseToDerived casts (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D149133?vs=516701&id=55

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D149149: [clang][Interp] Check one-past-the-end pointers in GetPtrField

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa13f036949b0: [clang][Interp] Check one-past-the-end pointers in GetPtrField (authored by tbaeder). Changed prior to commit: https://reviews.llvm.

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

tbaeder closed this revision. tbaeder added a comment. This landed as 673ef8ceaece6c9a7194474ef7d97b3b240c0dc5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155568/new/ https://

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d79f985b53e: [clang][Interp] Implement zero-init of record types (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D154189

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadb1fb40e84d: [clang][Interp] Handle mixed floating/integral compound assign operators (authored by tbaeder). Changed prior to commit: https://rev

[PATCH] D157619: [clang][Interp] Reject calling virtual constexpr functions in pre-c++20

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5704dde30735: [clang][Interp] Reject calling virtual constexpr functions in pre-c++20 (authored by tbaeder). Repository: rG LLVM Github Monorepo

[PATCH] D156042: [clang][Interp] Implement __builtin_strlen

tbaeder closed this revision. tbaeder added a comment. This has been pushed already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156042/new/ https://reviews.llvm.org/D156042 ___ cfe-commits mailing lis

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder abandoned this revision. tbaeder added a comment. This was pushed as part of the initializer rework. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

tbaeder added a comment. I do in https://reviews.llvm.org/D156045, but that depends on other commits (not sure which exactly right now though). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155627/new/ https://reviews.llvm.org/D155627 ___ cf

[PATCH] D152246: [clang][ThreadSafety] Analyze known function pointer values

tbaeder added a comment. @aaronpuchert Do you think warning on assignment of function pointers with mismatched attributes is would be a viable way forward? This is what https://github.com/elmarco/clang/commit/bac94282a5c8e3b0410ee8c0522fbdb872ade00c tries to implement IIUC. CHANGES SINCE LAST

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb93d2d37e709: [clang][Interp] Handle SourceLocExprs (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e5809e7e7bc: [clang][Interp] Enable existing source_location tests (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D156047: [clang][Interp] Handle CXXParenListInitExprs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92ac46e703cf: [clang][Interp] Handle CXXParenListInitExprs (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156047?vs=544

[PATCH] D138270: [clang][Sema] Skip checking int expressions for overflow in constexpr functions

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm not 100% sure if this is crazy or not, but it doesn't even seem to break any existing

[PATCH] D138270: [clang][Sema] Skip checking int expressions for overflow in constexpr functions

tbaeder updated this revision to Diff 476391. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138270/new/ https://reviews.llvm.org/D138270 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaChecking.cpp clang/unittests/Support/TimeProfilerTest.cpp I

[PATCH] D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This shows up when the interpretation is interrupte

[PATCH] D137392: [clang][Interp] Explicitly handle RVO Pointer

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137392/new/ https://reviews.llvm.org/D137392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D136815: [clang][Interp] Unify visiting variable declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136815/new/ https://reviews.llvm.org/D136815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136920: [clang][Interp] Array initialization via CXXConstructExpr

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136920/new/ https://reviews.llvm.org/D136920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137232/new/ https://reviews.llvm.org/D137232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136457: [clang][Interp] Fix discarding non-primitive function call return values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136457/new/ https://reviews.llvm.org/D136457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136694/new/ https://reviews.llvm.org/D136694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D137235: [clang][Interp] Fix ImplicitValueInitExprs for pointer types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137235/new/ https://reviews.llvm.org/D137235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `MaybeTypeCast` here is not a variable, it's an enum member with value 1. I'm just not sur

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:749-751 + const Descriptor::MetadataSize MDSize{sizeof(InlineDescriptor)}; + Descriptor *D = + P.createDescriptor(Src, Ty, MDSize, IsConst, Src.is(

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

tbaeder updated this revision to Diff 476452. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138289/new/ https://reviews.llvm.org/D138289 Files: clang/lib/Parse/ParseExpr.cpp Index: clang/lib/Parse/ParseExpr.cpp === --- c

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder updated this revision to Diff 476660. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137488/new/ https://reviews.llvm.org/D137488 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AS

[PATCH] D137488: [clang][Interp] Array initialization via string literal

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1098-1099 + +unsigned N = SL->getLength(); +for (size_t I = 0; I != NumElems; ++I) { + uint32_t CodePoint = I < N ? SL->getCodeUnit(I) : 0; tahonermann wrote: > tahon

[PATCH] D137826: [clang] Allow comparing pointers to string literals

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12951-12954 + // ObjC's @encode() + if (isa(E->getLHS()->IgnoreParenImpCasts()) || + isa(E->getRHS()->IgnoreParenImpCasts())) return Error(E); tahonermann wrote:

[PATCH] D138289: [clang][Parse] Remove constant expression from if condition

tbaeder added a comment. Yeah, just removing the `MaybeTypeCast` worked, but switching to `isTypeCast` doens't. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138289/new/ https://reviews.llvm.org/D138289 ___ cfe-commits mailing list cfe-commi

<    9   10   11   12   13   14   15   16   17   18   >