[PATCH] D155394: [clang][Interp] Implement __builtin_fpclassify

tbaeder closed this revision. tbaeder added a comment. Dang, forgot to add the link to the commit message. This has been closed via https://github.com/llvm/llvm-project/commit/6ba4b213346fad36634a5571feda4f4481097c3a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155394/new/ https://rev

[PATCH] D155400: [clang][Interp] Implement __builtin_fabs()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1684406e63b7: [clang][Interp] Implement __builtin_fabs() (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155400?vs=54078

[PATCH] D155270: [clang][Interp] Basic support for bit fields

tbaeder added a comment. In D155270#4550466 , @aaron.ballman wrote: > Precommit CI is currently crashing on the newly introduced test case. It's missing https://reviews.llvm.org/D155548 :) That's of course just a workaround. At the beginning of the `ev

[PATCH] D155401: [clang][Interp] Implement __builtin_fmax

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89e44e33edec: [clang][Interp] Implement __builtin_fmax (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder updated this revision to Diff 546090. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/c.c Index: clang/test/AST/Interp/c.c ==

[PATCH] D155393: [clang][Interp] Implement __builtin_isfpclass

tbaeder closed this revision. tbaeder marked an inline comment as done. tbaeder added a comment. Also forgot the link in the commit message here. This is closed by https://github.com/llvm/llvm-project/commit/6ba4b213346fad36634a5571feda4f4481097c3a Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; probinson wrote: > Would you mind changing this cast from

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2172-2173 + // Lazily visit global declarations we haven't seen yet. + // This happens in C. + if (const auto *VD = dyn_cast(D); aaron.ballman wrote: > Do we want to assert/l

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder updated this revision to Diff 546872. tbaeder added a comment. 1. Use a `shared_ptr` for the initmaps. 2. However, we allocate them into the `Block`, therefore can't forget to call the Block's dtor. 3. To distinguish between Blocks we've already deallocated (via a `destroy` op), add an

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder updated this revision to Diff 546882. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/c.c Index: clang/test/AST/Interp/c.c ==

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:503 + // If during the evaluation of an expression, the result is not + // mathematically defined [...], the behavior is undefined. + // FIXME: C++ rules require us to not conform to IEEE 754 here.

[PATCH] D157072: [clang][ExprConst] Check float operation input for signaling NaNs

tbaeder created this revision. tbaeder added reviewers: jcranmer-intel, clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Split out from https://reviews.llvm.org/D156506. Before adding this behavio

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin, hazohelet. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo http

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

tbaeder updated this revision to Diff 547145. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157074/new/ https://reviews.llvm.org/D157074 Files: clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Interp.h clang/test/Misc/constexpr-source-ranges.cpp Index: clang/test/Misc/constexp

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2835 if (RHS == 0) { - Info.FFDiag(E, diag::note_expr_divide_by_zero); + Info.FFDiag(E, diag::note_expr_divide_by_zero) << RHSRange; return fa

[PATCH] D154951: [clang][Interp] __builtin_bit_cast, Take 2

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBitcast.cpp:71 +/// All offsets are in bytes. +struct ByteTracker { + std::vector Initialized; aaron.ballman wrote: > Don't we need to track this at the *bit* level instead of the *byte* level

[PATCH] D157174: [clang][Interp] Convert logical binop operands to bool

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move the logic for this into `visitBool`, where it bel

[PATCH] D157174: [clang][Interp] Convert logical binop operands to bool

tbaeder updated this revision to Diff 547495. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157174/new/ https://reviews.llvm.org/D157174 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/c.c Index: clang/test/AST/Interp/c.c ===

[PATCH] D157200: [clang][Interp] Visit Logical-not operand as bool

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `invBool` op here expects a bool operand, but in C

[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

tbaeder added a comment. You're missing tests. Comment at: clang/lib/Sema/SemaExpr.cpp:16696-16697 + + IdentifierInfo *II = RD->getIdentifier(); + if (II == OC.U.IdentInfo && OC.isQualifier) +continue; Repository: rG LLVM Github Monorepo

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

tbaeder added a comment. The fuzzer timeouts fail all the time; I usually just assume it's unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 ___ cfe-co

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/44176 Repository: rG LLVM Github Mono

[PATCH] D157195: [Clang] Fix the do while statement disappearing in AST when an error occurs in the conditional expression of the do while statement

tbaeder added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1897-1898 if (Cond.isUsable()) -Cond = Actions.CorrectDelayedTyposInExpr(Cond); +Cond = Actions.CorrectDelayedTyposInExpr(Cond, /*InitDecl*/ nullptr, +

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

tbaeder updated this revision to Diff 547660. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157074/new/ https://reviews.llvm.org/D157074 Files: clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Interp.h clang/test/Misc/constexpr-source-ra

[PATCH] D157174: [clang][Interp] Convert logical binop operands to bool

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:531-534 + // For C, cast back to integer type. + assert(T); + if (T != PT_Bool) +return this->emitCast(PT_Bool, *T, E); aaron.ballman wrote: > This is casting to boolean ty

[PATCH] D157296: [AST][Coroutine] Fix CoyieldExpr missing end loc

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:321 - return S.BuildCallExpr(nullptr, Result.get(), Loc, Args, Loc, nullptr); + auto EndLoc = Args.empty() ? Loc : Args.back()->getBeginLoc(); + return S.BuildCallExpr(nullptr, Result.get(), Loc, Arg

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder created this revision. tbaeder added reviewers: aaronpuchert, NoQ, clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This might be a little light on the testing side. Repository: rG LLVM

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:530-535 if (S.checkingForUndefinedBehavior()) { SmallString<32> Trunc; APResult.trunc(Result.bitWidth()).toString(Trunc, 10); auto Loc = E->getExprLoc(); -S.report(Loc, diag::warn_integ

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG74c141a467ca: [clang][ExprConst] Add RHS source range to div by zero diags (authored by tbaeder). Changed prior to commit: https://reviews.llvm.or

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder updated this revision to Diff 548520. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156604/new/ https://reviews.llvm.org/D156604 Files: clang/lib/AST/ExprConstant.cpp clang/lib/AST/Interp/Frame.h clang/lib/AST/Interp/InterpFrame.cpp clang/lib/AST/Interp/InterpFrame.h cl

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder added a comment. In D156604#4572018 , @hazohelet wrote: > We need some tests for dtors because they are handled differently from other > functions. > I think the current ExprConstant part would not cover the explicitly-called > dtors because the

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder updated this revision to Diff 548522. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156027/new/ https://reviews.llvm.org/D156027 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D156027: [clang][Interp] Rework how initializers work

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:545-547 + // TODO(perf): For int and bool types, we can probably just skip this + // since we memset our Block*s to 0 and so we have the desired value + // without this. ---

[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

tbaeder added a comment. While both of those suggestions are probably improvements (I haven't checked), they also seem out of scope for this patch. This is just adding source ranges. We can improve them later (and add better tests for them at that point). CHANGES SINCE LAST ACTION https://re

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155270: [clang][Interp] Basic support for bit fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8065b1cc133c: [clang][Interp] Basic support for bit fields (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155270?vs=540

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Add a new `emitPrimCast` helper function and us

[PATCH] D149013: [clang][Interp] Check pointers when accessing base class

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149013/new/ https://reviews.llvm.org/D149013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

tbaeder updated this revision to Diff 548985. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157596/new/ https://reviews.llvm.org/D157596 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/floats.cpp Index: clang/test/AST/In

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

tbaeder added a comment. Generally LGTM, but the `erase` call could do with a comment before. And I'll let someone with more concepts experience handle whether this should be accepted or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157526/ne

[PATCH] D157619: [clang][Interp] Reject calling virtual constexpr functions in pre-c++20

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Create a new `getOrCreateFunction()` in `Context`, so

[PATCH] D156045: [clang][Interp] Enable existing source_location tests

tbaeder added a comment. @hazohelet Thanks for noticing. Should be fixed via https://github.com/llvm/llvm-project/commit/f8074942c5a6f266abb1c4d1465a4d8115b22d43. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156045/new/ https://reviews.llvm.org/D

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

tbaeder updated this revision to Diff 556339. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder updated this revision to Diff 556399. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h clang/lib/Analysis/ThreadSafety.cpp clang/lib/Analysis/ThreadSafetyCommon.cpp

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG87461d669684: [clang][Interp] Implement __builtin_offsetof (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156400?vs=556

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b5fe9c42d94: [clang][Interp] Check floating results for NaNs (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156506?vs=

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ https://reviews.llvm.org/D156794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157252/new/ https://reviews.llvm.org/D157252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158516: [clang][Interp] Only lazily visit constant globals

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158516/new/ https://reviews.llvm.org/D158516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158595: [clang][Interp] Allow zero-init of primitives with an empty init list

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158595/new/ https://reviews.llvm.org/D158595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

tbaeder updated this revision to Diff 556474. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158502/new/ https://reviews.llvm.org/D158502 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp =

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder updated this revision to Diff 556535. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h clang/lib/Analysis/ThreadSafety.cpp c

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

tbaeder added a comment. In D158472#4605228 , @hazohelet wrote: > This breaks the one-note-for-one-overload-candidate rule of overload > resolution failure diagnostics > (https://github.com/llvm/llvm-project/blob/ff08c8e57e39d7970b65637595cdc221901f4ed1

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG293ae0b4b45f: [clang][Interp] Actually consider ConstantExpr result (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

tbaeder added a comment. In D155572#4542484 , @aaron.ballman wrote: > In D155572#4541403 , @tbaeder wrote: > >> In D155572#4539457 , >> @aaron.ballman wrote: >> >>> Is t

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

tbaeder added a comment. In D155572#4645997 , @aaron.ballman wrote: > Hmmm, I think the answer is "no"... and "maybe." `_Complex` can only be > followed by `float`, `double`, or `long double` specifically per the C > standard. However, we also support

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

tbaeder updated this revision to Diff 556825. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155572/new/ https://reviews.llvm.org/D155572 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/Interp/complex.cpp Index: clang/test/AST/I

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d73cca1864b: [clang][Interp] Lazily visit unknown global declarations (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156794/new/ http

[PATCH] D157174: [clang][Interp] Convert logical binop operands to bool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa259005a215d: [clang][Interp] Convert logical binop operands to bool (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D157

[PATCH] D157200: [clang][Interp] Visit Logical-not operand as bool

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd2f2c166203: [clang][Interp] Visit Logical-not operand as bool (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D157200?v

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder updated this revision to Diff 556836. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp clang/lib/Analysis/PathDiagnostic.

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder added inline comments. Comment at: clang/test/Analysis/scopes-cfg-output.cpp:1472 +// CHECK-NEXT:2: (CXXConstructExpr, [B1.3], F) +// CHECK-NEXT:3: F f __attribute__((cleanup(cleanup_F))); +// CHECK-NEXT:4: CleanupFunction (cleanup_F) aaronpu

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder updated this revision to Diff 556838. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyCommon.h clang/lib/Analysis/ThreadSafety.cpp clang/lib/Analysis/ThreadSafetyCommon.cpp

[PATCH] D158702: [clang][Interp] Check pointer inc/dec ops for initialization

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG177f9ab2fbd8: [clang][Interp] Check pointer inc/dec ops for initialization (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D156509: [clang][Interp] Diagnose unknown parameter values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23c39f9a9e14: [clang][Interp] Diagnose unknown parameter values (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D156509?v

[PATCH] D156511: [clang][Interp] Diagnose more unkonwn DeclRefExprs

tbaeder closed this revision. tbaeder added a comment. Looks like I squashed this into https://reviews.llvm.org/D156509 for some reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156511/new/ https://reviews.llvm.org/D156511 __

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157252/new/ https://reviews.llvm.org/D157252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158516: [clang][Interp] Only lazily visit constant globals

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158516/new/ https://reviews.llvm.org/D158516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158595: [clang][Interp] Allow zero-init of primitives with an empty init list

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG52a55a717838: [clang][Interp] Allow zero-init of primitives with an empty init list (authored by tbaeder). Repository: rG LLVM Github Monorepo CH

[PATCH] D154290: [WIP][Clang] Implement P2741R3 - user-generated static_assert messages

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:16384 + Expr *SizeExpression, + Expr *PtrExpression, ASTContext &Ctx, + EvalResult &Status)

[PATCH] D153693: [clang][Interp] Handle InitListExprs of composite type

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153693/new/ https://reviews.llvm.org/D153693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153695: [clang][Interp] Fix passing parameters of composite type

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.h:71 - /// Parameter indices. - llvm::DenseMap Params; + /// Parameter indices. > + llvm::DenseMap Params; shafik wrote: > I don't unde

[PATCH] D154474: [clang][Interp] Fix ignoring Integral- and IntegralToBoolean casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a subscriber: inglorion. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder added a comment. This is split out from https://reviews.llvm.org/D149828, but I think that other one had problems (which made me write this version). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D15447

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder added a comment. The changes in https://reviews.llvm.org/D149828 missed one case, the `(E->getStorageDuration() == SD_Static) && SubExprT` one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D154475 ___

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153001: [clang][ThreadSafety] Add __builtin_instance_member (WIP)

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153001/new/ https://reviews.llvm.org/D153001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, cor3ntin, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. InitMaps are created for primitive arrays when the fir

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154189/new/ https://reviews.llvm.org/D154189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153653/new/ https://reviews.llvm.org/D153653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

tbaeder added a comment. @cjdb LGTY? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153359/new/ https://reviews.llvm.org/D153359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder created this revision. tbaeder added a reviewer: clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154688 Files: clang/lib

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder updated this revision to Diff 538058. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154688/new/ https://reviews.llvm.org/D154688 Files: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp clang/test/Frontend/verify-any-file.c clang/test/Frontend/verify-fatal.c clang/test/Fron

[PATCH] D154290: [WIP][Clang] Implement P2741R3 - user-generated static_assert messages

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16893 + + if (const StringLiteral *SL = dyn_cast(Message); + SL && SL->getCharByteWidth() == 1) { Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16898 + } + + QualTy

[PATCH] D154758: [clang][Interp] Emit correct diagnostic for uninitialized reads

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a long standing diagnostic difference betwe

[PATCH] D154758: [clang][Interp] Emit correct diagnostic for uninitialized reads

tbaeder updated this revision to Diff 538325. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154758/new/ https://reviews.llvm.org/D154758 Files: clang/lib/AST/Interp/Interp.cpp clang/test/AST/Interp/constexpr-nqueens.cpp clang/test/AST/Interp/cxx20.cpp clang/test/AST/Interp/litera

<    8   9   10   11   12   13   14   15   16   17   >