[PATCH] D131155: [clang] Expand array expressions if the filler expression's filler is element dependent

tbaeder updated this revision to Diff 449932. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131155/new/ https://reviews.llvm.org/D131155 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constexpr-array-init.cpp Index: clang/test/SemaCXX/constexpr-array-init.cpp

[PATCH] D131070: [clang][sema] Fix collectConjunctionTerms()

tbaeder added a comment. FWIW I switched it around so _this_ patch is now good as-is while https://reviews.llvm.org/D130894 now depends on this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131070/new/ https://reviews.llvm.org/D131070 _

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder updated this revision to Diff 449942. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.

[PATCH] D131070: [clang][sema] Fix collectConjunctionTerms()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b74074731ee: [clang][sema] Fix collectConjunctionTerms() (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D131070?vs=4499

[PATCH] D131155: [clang] Expand array expressions if the filler expression's filler is element dependent

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1942855c431: [clang] Consider array filler in MaybeElementDependentArrayfiller() (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D131155?vs=449932&id=450230#toc Repository:

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder added a comment. For the record, the output now looks something like this: test.cpp:24:1: error: static assertion failed due to requirement 'c != c' static_assert(c != c); ^ ~~ test.cpp:24:17: note: expression evaluates to '('0' != '0')' static_assert(c != c);

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder added a comment. I don't know much about fixit hints, would they be appropriate to display it below the line itself, e.g. test.cpp:24:17: note: expression evaluates to static_assert(c != c); '0' != '0' ~~^~~~ Or would it be even better to just inline th

[PATCH] D131314: [clang] format string checks for `InitListExpr`

tbaeder added a comment. Not a formal review of course, but for the diagnostics, I'm missing something that tells the user what the format string ended up looking like; in your example, the output never mentions that it checked "%s%d". Comment at: clang/lib/Sema/SemaChecking.

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder added a comment. I don't really want to bike-shed about the presentation for too long... I'm fine with just removing the parens, since we present it like that in the error message as well anyway: ./assert.cpp:6:1: error: static assertion failed due to requirement ''c' == 'a'' stati

[PATCH] D130894: [clang] Print more information about failed static assertions

tbaeder updated this revision to Diff 451143. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130894/new/ https://reviews.llvm.org/D130894 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDeclCXX.

[PATCH] D131423: [clang] fix frontend crash when evaluating type trait

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5445 + } +} + This function copies the two conditions for the if-statements from `evaluateTypeTrait()`. Is just doing it in `evaluateTypeTrait()` too late? Duplicating that seems bad.

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder marked 3 inline comments as done. tbaeder added a comment. In D120244#3368216 , @aaron.ballman wrote: > Precommit CI is failing: > > Failed Tests (1): > > Clang :: Headers/stdbool.c Heh, I guess I need to make a habit of running the tests also

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 414005. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https://reviews.llvm.org/D120244 Files: clang/docs/ReleaseNotes.rst clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Headers/stdbool.h clang/test/Headers/stdbool.c clang/t

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tbaeder added a comment. Hey @dblaikie, seems like this has never been pushed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511 ___ cfe-commits mailing list cfe-

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5ccd6680198: [clang][sema] Enable first-class bool support for C2x (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https:/

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Parse/ParseCXXInlineMethods.cpp:745 - ParseGNUAttributeArgs(&LA.AttrName, LA.AttrNameLoc, Attrs, &endLoc, + ParseGNUAttributeArgs(&LA.AttrName, LA.AttrNameLoc, Attrs, nullpt

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder marked 7 inline comments as done. tbaeder added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:1105 void clearListOnly() { ParsedAttributesView::clearListOnly(); Range = SourceRange(); aaron.ballman wrote: > erichkeane wro

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 415729. tbaeder marked an inline comment as done. tbaeder added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Remove `ParsedAttributesViewWithRange` and address other review comments. CHANGES SINCE LAST ACTION https://

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 415757. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/ParsedAttr.h clang/include/clang/Sema/Se

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 417235. tbaeder marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:2516-2521 + void takeAttributes(ParsedAttributes &attrs) { Attrs.takeAllFrom(attrs); -if (!lastLoc.isInvalid()) - SetRangeEnd(lastLoc); +if (attrs.Range.getEnd().isValid()) +

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/include/clang/Sema/DeclSpec.h:2516-2521 + void takeAttributes(ParsedAttributes &attrs) { Attrs.takeAllFrom(attrs); -if (!lastLoc.isInvalid()) - SetRangeEnd(lastLoc); +i

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/include/clang/Sema/ParsedAttr.h:813 void takeAllFrom(AttributePool &pool) { takePool(pool); pool.Attrs.clear(); erichkeane wrote: > so: `assert(&pool != this &

[PATCH] D121201: [clang] Merge the SourceRange into ParsedAttributes

tbaeder updated this revision to Diff 417509. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121201/new/ https://reviews.llvm.org/D121201 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/include/clang/Sema/ParsedAttr.h clang/include/clang/Sema/Se

[PATCH] D122659: [clang][preprocessor] Allow calling DumpToken() on annotation tokens

This revision was automatically updated to reflect the committed changes. Closed by commit rG0eb5891adcb8: [clang][preprocessor] Allow calling DumpToken() on annotation tokens (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12265

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:24 +char g = u8'\x80'; // expected-warning {{implicit conversion from 'int' to 'char' changes value from 128 to -128}} #endif aa

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder updated this revision to Diff 422402. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119221/new/ https://reviews.llvm.org/D119221 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Lex

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33ec65305525: [clang][lexer] Allow u8 character literal prefixes in C2x (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5787a0c6cc4: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder added a comment. In D117888#3290628 , @sbc100 wrote: > Great! Thanks for working on this.I'm curious what toolchain you are > working that uses GNU libstdc++? I'm looking at libstdc++ enablement in a wasm/emscripten toolchain, so nothing

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement N2418 for C2x. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D119221 Files: cla

[PATCH] D119224: [clang][tests] Add a testcase for C++ DR2406

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DR2406 is in "unknown" state according to https://clang.llvm.org/cxx_dr_status.html. The described defects do

[PATCH] D119230: [clang] Add test for C++ DR2390

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DR2390 clarifies that the argument to `__has_cpp_attribute()` needs to be macro-expanded. Clang already supports

[PATCH] D119224: [clang][tests] Add a testcase for C++ DR2406

This revision was automatically updated to reflect the committed changes. Closed by commit rGce07de234b77: [clang][tests] Add test for C++ DR2406 (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119224/new/ https://reviews.llvm.o

[PATCH] D119230: [clang] Add test for C++ DR2390

This revision was automatically updated to reflect the committed changes. Closed by commit rGef2c8274dfa2: [clang] Add test for C++ DR2390 (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119230/new/ https://reviews.llvm.org/D119

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

tbaeder closed this revision. tbaeder added a comment. I screwed up using the right Differential Revision link, but this landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ https://reviews.llvm.org/D117888 ___

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes the crash from https://github.com/llvm/llvm-project/issues/53742 `CXXNewExpr::getArraySize()`

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 407785. tbaeder added a comment. This is a pretty big gotcha at best and I feel like `getArraySize()` should return `None` in that case instead... thoughts? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 407885. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/Sema/TreeTransform.h clang/te

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2135 std::string TypeS; - if (Optional Size = E->getArraySize()) { + if (E->isArray()) { llvm::raw_string_ostream s(TypeS); I changed this just for clarity, not doing it did not ca

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 407912. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/Sema/TreeTransform.h clang/te

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder marked 3 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/StmtPrinter.cpp:2135 std::string TypeS; - if (Optional Size = E->getArraySize()) { + if (E->isArray()) { llvm::raw_string_ostream s(TypeS); aaron.ballman

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder marked an inline comment as done. tbaeder added a comment. In D119525#3314383 , @aaron.ballman wrote: > Can you also add a release note for the change? Would this go in the "libclang" section in `clang/docs/ReleaseNotes.rst`? Or somewhere else?

[PATCH] D119221: [clang][lexer] Allow u8 character literal prefixes in C2x

tbaeder updated this revision to Diff 408341. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119221/new/ https://reviews.llvm.org/D119221 Files: clang/lib/Lex/Lexer.cpp clang/lib/Sema/SemaExpr.cpp clang/test/Lexer/utf8-char-literal.cpp Index: clang/test/Lexer/utf8-char-literal.cpp

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder updated this revision to Diff 409173. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119525/new/ https://reviews.llvm.org/D119525 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprConstant.cpp clang/lib/AST/StmtPrinter.cpp clang/lib/S

[PATCH] D119525: [clang] Fix crash when array size is missing in initializer

tbaeder added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 +-- +- ``CXXNewExpr::getArraySize()`` previously returned a ``llvm::Optional`` + wrapping a ``nullptr`` when the ``CXXNewExpr`` did not have an array aaron.ballman wrote: >

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. UTF8 char literals are always unsigned. Fixes https://github.com/llvm/

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 427267. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.cpp Index: clang/test/Lexer/u

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 427283. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.cpp Index: clang/test/Lexer/utf8-char-lit

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 427289. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.cpp Index: clang/test/Lexer/utf8-char-lit

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 427614. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.c

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:39 +# if defined(CHAR8_T) +#if u8'\xff' == '\xff' // expected-warning {{right side of operator converted from negative value to unsigned}} +# error Something's not right.

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 427989. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.c

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder marked 4 inline comments as done. tbaeder added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:37-47 +#if __cplusplus == 201703L +# if defined(CHAR8_T) +#if u8'\xff' == '\xff' // expected-warning {{right side of operator converted from negative

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 428303. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.c

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:54-56 +# if !(u8'\xff' == 0xff) +#error u8 char literal is not unsigned +# endif tahonermann wrote: > The C++ case looks good now, but the condition doesn't look right for the

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder updated this revision to Diff 428861. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124996/new/ https://reviews.llvm.org/D124996 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/PPExpressions.cpp clang/test/Lexer/utf8-char-literal.c

[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb91073db6ac3: [clang][preprocessor] Fix unsigned-ness of utf8 char literals (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D125860: [clang] Only use major version in resource dir

tbaeder created this revision. tbaeder added a reviewer: tstellar. Herald added a subscriber: mgorny. Herald added a reviewer: bollu. Herald added a project: All. tbaeder requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, Sanitizers, cfe-commit

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder created this revision. tbaeder added reviewers: tstellar, phosek. Herald added a project: All. tbaeder requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This makes it possible to use the newest gcc-toolset/devtoolset on RHEL.

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 430572. Herald added a subscriber: ormris. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittests/Driv

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 430597. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittes

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8717b492dfcd: [clang][driver] Dynamically select gcc-toolset/devtoolset version (authored by tbaeder). Changed prior to commit: https://reviews.ll

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder updated this revision to Diff 431609. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125862/new/ https://reviews.llvm.org/D125862 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/unittests/Driver/ToolChainTest.cpp Index: clang/unittests/Driver/ToolChainTest.cpp ==

[PATCH] D125862: [clang][driver] Add gcc-toolset/devtoolset 12 to prefixes

tbaeder added a comment. In D125862#3532630 , @MaskRay wrote: >> Harbormaster completed remote builds in `B165047: Diff 430277.` > > You can get Windows bot results in the link. Hm, the windows pre-merge checks don't fail. Just the buildbots. I wonder if

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder updated this revision to Diff 557773. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 Files: clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Descriptor.h clang/lib/AST/Interp/EvalEmitter.cpp clang/lib/AST/Interp/EvalEmit

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.h:203 +public: /// Initializes the map with no fields set. aaron.ballman wrote: > This interface is now more confusing as to how to use because it now has a > public non-default cons

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

This revision was automatically updated to reflect the committed changes. Closed by commit rG311f725d9a6f: [clang][Interp] Create only globals when initializing a global variable (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder updated this revision to Diff 557801. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 Files: clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Descriptor.h clang/lib/AST/Interp/EvalEmitter.cpp clang/lib/AST/Interp/EvalEmit

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.h:207 /// Initializes the map with no fields set. InitMap(unsigned N); aaron.ballman wrote: > Now that this is public, can we make it `exp

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder added inline comments. Comment at: clang/test/Sema/builtin-memcpy.c:4-8 +int b() { + struct { } a[10]; + __builtin_memcpy(&a[2], a, 2); // expected-warning {{buffer has size 0, but size argument is 2}} + return 0; +} aaron.ballman wrote: > The on

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

tbaeder updated this revision to Diff 557826. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157252/new/ https://reviews.llvm.org/D157252 Files: clang/lib/AST/ExprConstant.cpp clang/test/Sema/builtin-memcpy.c Index: clang/test/Sema/builtin-memcpy.c ==

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3671a69470f3: [clang][Interp] Call destructors of local variables (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaaaece65a80f: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc. (authored by tbaeder). Changed prior to commit: https://reviews.llvm.or

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84846/new/ https://reviews.llvm.org/D84846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93375: [clang][driver] Add -ansi option to CompileOnly group

tbaeder created this revision. tbaeder added a reviewer: dang. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -ansi is documented as being the "same as -std=c89", but there are differences when passing it to a link: clang -c te

[PATCH] D90457: [clang][driver] Set LTO mode based on input files

tbaeder added a comment. In D90457#2390519 , @MaskRay wrote: > Is the motivation just to avoid -flto or -flto=lto at link time? Essentially, yes. Lots of projects seem to depend on this behavior of GCC. I.e. the pass -flto when compiling but not when lin

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder added a comment. In D84846#2396303 , @MaskRay wrote: > https://fedoraproject.org/wiki/Toolchain/Watermark Seems that > `.gnu.build.attributes` is used with a GCC plugin (annobin?). The feature on > its own is probably not that useful. `.gnu.linko

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

tbaeder created this revision. tbaeder added a reviewer: serge-sans-paille. Herald added subscribers: cfe-commits, pengfei, kristof.beyls, inglorion, mgorny. Herald added a project: clang. tbaeder requested review of this revision. I tried doing a stage3 build on SystemZ/s390 but ran into the unf

[PATCH] D90457: [clang][driver] Set LTO mode based on input files

tbaeder created this revision. tbaeder added reviewers: tstellar, sfantao, tejohnson. Herald added subscribers: cfe-commits, steven_wu, hiraditya, inglorion, mgorny. Herald added a project: clang. tbaeder requested review of this revision. After setting the LTO mode from the -flto option, look at

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder created this revision. tbaeder added a reviewer: tejohnson. Herald added subscribers: dang, inglorion. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current behavior was introduced in https://github.com/llvm/llvm-proj

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder updated this revision to Diff 345763. tbaeder added a comment. On second thought, rather only handle `=auto` and `=jobserver` and don't warn. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.t

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder updated this revision to Diff 346058. Herald added subscribers: steven_wu, hiraditya. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/lib/Frontend/Compi

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder updated this revision to Diff 346634. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/lto.c Index:

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder updated this revision to Diff 346635. tbaeder added a comment. Thanks for the feedback, I think this should work better. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder updated this revision to Diff 346737. tbaeder added a comment. Use `hasFlag()` instead of `hasArg()` in Driver.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

This revision was automatically updated to reflect the committed changes. Closed by commit rG95423c7c990d: [clang][driver] Treat -flto=[auto,jobserver] as -flto (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https:/

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, rsmith, rjmccall, rtrieu. Herald added subscribers: lxfind, jdoerfert. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, when trying to access a member of a n

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319671. tbaeder added a comment. Forgot clang-format of course, sorry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaExprMember.cpp clang/test/CX

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319780. tbaeder added a comment. Answered one of my questions by adding a new function directly to `Sema`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/include/clang/Sema/Sema.h clang/lib

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319820. tbaeder added a comment. Fixed the Lambda oddity as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaExpr.

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder created this revision. tbaeder added reviewers: Hahnfeld, phosek, yaxunl, rsmith. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since ToolChain::GetCXXStdlibType() is a simple getter that might emit the "invalid library n

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder updated this revision to Diff 321022. tbaeder added a comment. Noticed similar/worse behavior for -rtlib. Expanded the patch to that and -unwindlib as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 Files: clang/lib/Driver/ToolC

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder added a comment. In D95915#2539483 , @jdoerfert wrote: > Also, now you don't warn for different missing runtimes, which seems odd. What do you mean? Is the value returned from `GetRuntimeLibType()` ever going to change? CHANGES SINCE LAST ACTIO

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder added a comment. In D95915#2541129 , @Hahnfeld wrote: > My proposal would be to cache the return value of the three routines in > `ToolChain`. This has the advantage that the values get parsed only once and > there is at most one warning. I don't

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder updated this revision to Diff 321349. tbaeder added a comment. Here a version without the local static bools. If this is good to go, I can add some tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 Files: clang/include/clang/Driv

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

tbaeder created this revision. tbaeder added reviewers: rsmith, EricWF, ldionne, tstellar, hfinkel. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Hi, currently the following fails: clang++ -stdlib=libc++ -static ./test.cpp be

[PATCH] D96070: [clang] [driver] Enable static linking to libc++

tbaeder added a comment. In D96070#2543172 , @mstorsjo wrote: > In particular, if libcxx is built with `LIBCXX_ENABLE_STATIC_ABI_LIBRARY` > enabled, the libcxxabi static library is merged into libc++.a, making static > linking work just fine. I can't te

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder updated this revision to Diff 322082. tbaeder added a comment. Switched to `llvm::Optional` and added some tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver/ToolChain

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder added a comment. Any update on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

<    1   2   3   4   5   6   7   8   9   10   >